151740 2015-12-01 23:28:26 -0800 Update JSC feature list for rest parameters and generators 2015-12-07 15:16:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam commit-queue keith_miller mark.lam msaboff oldest_to_newest 1145528 0 saam 2015-12-01 23:28:26 -0800 ... 1147005 1 266812 saam 2015-12-07 14:07:06 -0800 Created attachment 266812 patch 1147007 2 266812 joepeck 2015-12-07 14:12:48 -0800 Comment on attachment 266812 patch View in context: https://bugs.webkit.org/attachment.cgi?id=266812&action=review r=me > Source/JavaScriptCore/features.json:132 > "status": "In Development", > - "enabled-by-default": false > + "enabled-by-default": true Should this be "Done" or is it still in development? > Source/JavaScriptCore/features.json:230 > + "name": "Rest Parameter", Should this be plural? Sometimes it is and isn't, but I think most of the time I've seen it pluralized. 1147022 3 266812 saam 2015-12-07 14:39:48 -0800 Comment on attachment 266812 patch View in context: https://bugs.webkit.org/attachment.cgi?id=266812&action=review >> Source/JavaScriptCore/features.json:132 >> + "enabled-by-default": true > > Should this be "Done" or is it still in development? It's still under active development but it also works. I think In Development is an okay name. >> Source/JavaScriptCore/features.json:230 >> + "name": "Rest Parameter", > > Should this be plural? Sometimes it is and isn't, but I think most of the time I've seen it pluralized. I've seen it both ways too. It doesn't help that the title of of this page on MDN is "rest parameters" and the first sentence starts with "the rest parameter" (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/rest_parameters). I think singular is more correct because it is a single parameter that gathers an array of the rest of the arguments. 1147037 4 266812 commit-queue 2015-12-07 15:16:12 -0800 Comment on attachment 266812 patch Clearing flags on attachment: 266812 Committed r193659: <http://trac.webkit.org/changeset/193659> 1147038 5 commit-queue 2015-12-07 15:16:16 -0800 All reviewed patches have been landed. Closing bug. 266812 2015-12-07 14:07:06 -0800 2015-12-07 15:16:12 -0800 patch b-backup.diff text/plain 2387 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkzNjQ4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDE1LTEyLTA3ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFVwZGF0ZSBKU0MgZmVhdHVyZSBsaXN0IGZvciByZXN0IHBhcmFtZXRlcnMgYW5kIGdlbmVyYXRv cnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTc0 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmVh dHVyZXMuanNvbjoKKwogMjAxNS0xMi0wNyAgQWxiZXJ0byBHYXJjaWEgIDxiZXJ0b0BpZ2FsaWEu Y29tPgogCiAgICAgICAgIENyYXNoZXMgb24gUFBDNjQgZHVlIHRvIG1wcm90ZWN0KCkgb24gYWRk cmVzcyBub3QgYWxpZ25lZCB0byB0aGUgcGFnZSBzaXplCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZmVhdHVyZXMuanNvbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZmVhdHVyZXMuanNvbgkocmV2aXNpb24gMTkzNjQ3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2ZlYXR1cmVzLmpzb24JKHdvcmtpbmcgY29weSkKQEAgLTEyOSwxMiArMTI5LDEzIEBACiAgICAg ICAgICJuYW1lIjogIkdlbmVyYXRvcnMiLAogICAgICAgICAic3RhdHVzIjogewogICAgICAgICAg ICAgInN0YXR1cyI6ICJJbiBEZXZlbG9wbWVudCIsCi0gICAgICAgICAgICAiZW5hYmxlZC1ieS1k ZWZhdWx0IjogZmFsc2UKKyAgICAgICAgICAgICJlbmFibGVkLWJ5LWRlZmF1bHQiOiB0cnVlCiAg ICAgICAgIH0sCiAgICAgICAgICJ1cmwiOiAiaHR0cDovL3d3dy5lY21hLWludGVybmF0aW9uYWwu b3JnL2VjbWEtMjYyLzYuMC9pbmRleC5odG1sI3NlYy1nZW5lcmF0b3Itb2JqZWN0cyIsCiAgICAg ICAgICJzcGVjaWZpY2F0aW9uIjogIkVTNiIsCiAgICAgICAgICJkZXNjcmlwdGlvbiI6ICJBbiBp dGVyYXRpdmUgZnVuY3Rpb24gb2JqZWN0IHRoYXQgaXMgaW50ZXJydXB0YWJsZSBhbmQgcmVzdW1h YmxlLiIsCiAgICAgICAgICJ3ZWJraXQtdXJsIjogImh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTAyOTAiLAorICAgICAgICAiZG9jdW1lbnRhdGlvbi11cmwiOiAiaHR0 cHM6Ly9oYWNrcy5tb3ppbGxhLm9yZy8yMDE1LzA1L2VzNi1pbi1kZXB0aC1nZW5lcmF0b3JzLyIs CiAgICAgICAgICJjb250YWN0IjogewogICAgICAgICAgICAgIm5hbWUiOiAiWXVzdWtlIFN1enVr aSIsCiAgICAgICAgICAgICAidHdpdHRlciI6ICJAQ29uc3RlbGxhdGlvbiIsCkBAIC0yMjYsNiAr MjI3LDIyIEBACiAgICAgICAgICJzcGVjaWZpY2F0aW9uIjogIkVTNiIKICAgICB9LAogICAgIHsK KyAgICAgICAgIm5hbWUiOiAiUmVzdCBQYXJhbWV0ZXIiLAorICAgICAgICAic3RhdHVzIjogewor ICAgICAgICAgICAgInN0YXR1cyI6ICJEb25lIiwKKyAgICAgICAgICAgICJlbmFibGVkLWJ5LWRl ZmF1bHQiOiB0cnVlCisgICAgICAgIH0sCisgICAgICAgICJ1cmwiOiAiaHR0cDovL3d3dy5lY21h LWludGVybmF0aW9uYWwub3JnL2VjbWEtMjYyLzYuMC8jc2VjLWZ1bmN0aW9uLWRlZmluaXRpb25z IiwKKyAgICAgICAgImRvY3VtZW50YXRpb24tdXJsIjogImh0dHBzOi8vZGV2ZWxvcGVyLm1vemls bGEub3JnL2VuLVVTL2RvY3MvV2ViL0phdmFTY3JpcHQvUmVmZXJlbmNlL0Z1bmN0aW9ucy9yZXN0 X3BhcmFtZXRlcnMiLAorICAgICAgICAiZGVzY3JpcHRpb24iOiAiUmVzdCBwYXJhbWV0ZXJzIGFs bG93IHlvdSB0byBjb2xsZWN0IHRoZSBhcmd1bWVudHMsIG9yIHRoZSBhcmd1bWVudHMgYWZ0ZXIg c29tZSBvZmZzZXQsIG9mIGEgZnVuY3Rpb24gaW50byBhIEpTIGFycmF5LiIsCisgICAgICAgICJz cGVjaWZpY2F0aW9uIjogIkVTNiIsCisgICAgICAgICJjb250YWN0IjogeworICAgICAgICAgICAg Im5hbWUiOiAiU2FhbSBCYXJhdGkiLAorICAgICAgICAgICAgImVtYWlsIjogInNiYXJhdGlAYXBw bGUuY29tIiwKKyAgICAgICAgICAgICJ0d2l0dGVyIjogIkBzYWFtYmFyYXRpIgorICAgICAgICB9 CisgICAgfSwKKyAgICB7CiAgICAgICAgICJuYW1lIjogIlNldCBEYXRhIFN0cnVjdHVyZSIsCiAg ICAgICAgICJzdGF0dXMiOiB7CiAgICAgICAgICAgICAic3RhdHVzIjogIkRvbmUiLAo=