151733 2015-12-01 17:21:46 -0800 Teach DFG that ArithSub can now clobber the heap (and other things). 2015-12-02 12:11:40 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam benjamin fpizlo ggaren keith_miller msaboff saam oldest_to_newest 1145474 0 mark.lam 2015-12-01 17:21:46 -0800 Now that ArithSub can handle UntypedUse operands, we need to update the DFG's expectation of this node's properties. 1145487 1 266418 mark.lam 2015-12-01 17:38:12 -0800 Created attachment 266418 proposed patch. 1145618 2 266418 ggaren 2015-12-02 10:54:30 -0800 Comment on attachment 266418 proposed patch. r=me 1145636 3 mark.lam 2015-12-02 11:16:47 -0800 Thanks for the review. Landed in r192949: <http://trac.webkit.org/r192949>. 1145653 4 266418 fpizlo 2015-12-02 12:02:16 -0800 Comment on attachment 266418 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=266418&action=review > Source/JavaScriptCore/dfg/DFGClobberize.h:262 > +#if USE(JSVALUE64) Please remove this, it's not needed. 1145657 5 mark.lam 2015-12-02 12:11:40 -0800 (In reply to comment #4) > > Source/JavaScriptCore/dfg/DFGClobberize.h:262 > > +#if USE(JSVALUE64) > > Please remove this, it's not needed. Thanks. Removed in r192952: <http://trac.webkit.org/r192952>. 266418 2015-12-01 17:38:12 -0800 2015-12-02 10:54:30 -0800 proposed patch. bug-151733.patch text/plain 4452 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkyOTMzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE1LTEyLTAxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBU ZWFjaCBERkcgdGhhdCBBcml0aFN1YiBjYW4gbm93IGNsb2JiZXIgdGhlIGhlYXAgKGFuZCBvdGhl ciB0aGluZ3MpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTUxNzMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBkZmcvREZHQWJzdHJhY3RJbnRlcnByZXRlcklubGluZXMuaDoKKyAgICAgICAgKEpTQzo6 REZHOjpBYnN0cmFjdEludGVycHJldGVyPEFic3RyYWN0U3RhdGVUeXBlPjo6ZXhlY3V0ZUVmZmVj dHMpOgorICAgICAgICAqIGRmZy9ERkdDbG9iYmVyaXplLmg6CisgICAgICAgIChKU0M6OkRGRzo6 Y2xvYmJlcml6ZSk6CisgICAgICAgICogZGZnL0RGR1ByZWRpY3Rpb25Qcm9wYWdhdGlvblBoYXNl LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpQcmVkaWN0aW9uUHJvcGFnYXRpb25QaGFzZTo6cHJv cGFnYXRlKToKKwogMjAxNS0xMi0wMSAgQ2FpdGxpbiBQb3R0ZXIgIDxjYWl0cG90dGVyODhAZ21h aWwuY29tPgogCiAgICAgICAgIFtKU0NdIHN1cHBvcnQgQ292ZXJJbml0aWFsaXplZE5hbWUgaW4g bmVzdGVkIEFzc2lnbm1lbnRQYXR0ZXJucwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdBYnN0cmFjdEludGVycHJldGVySW5saW5lcy5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RJbnRlcnByZXRlcklubGluZXMuaAkocmV2aXNp b24gMTkyOTEyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdEludGVy cHJldGVySW5saW5lcy5oCSh3b3JraW5nIGNvcHkpCkBAIC01MjgsNyArNTI4LDggQEAgYm9vbCBB YnN0cmFjdEludGVycHJldGVyPEFic3RyYWN0U3RhdGVUeQogICAgICAgICAgICAgICAgICAgICBm b3JOb2RlKG5vZGUtPmNoaWxkMSgpKS5tX3R5cGUsIGZvck5vZGUobm9kZS0+Y2hpbGQyKCkpLm1f dHlwZSkpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgVW50eXBlZFVzZToKLSAg ICAgICAgICAgIGZvck5vZGUobm9kZSkuc2V0VHlwZShtX2dyYXBoLCBTcGVjSGVhcFRvcCk7Cisg ICAgICAgICAgICBjbG9iYmVyV29ybGQobm9kZS0+b3JpZ2luLnNlbWFudGljLCBjbG9iYmVyTGlt aXQpOworICAgICAgICAgICAgZm9yTm9kZShub2RlKS5zZXRUeXBlKG1fZ3JhcGgsIFNwZWNCeXRl Y29kZU51bWJlcik7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgZGVmYXVsdDoKICAgICAg ICAgICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR0Nsb2JiZXJpemUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR0Nsb2JiZXJpemUuaAkocmV2aXNpb24gMTkyOTEyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDbG9iYmVyaXplLmgJKHdvcmtpbmcgY29weSkKQEAgLTI0 Nyw3ICsyNDcsNiBAQCB2b2lkIGNsb2JiZXJpemUoR3JhcGgmIGdyYXBoLCBOb2RlKiBub2RlCiAg ICAgfQogCiAgICAgY2FzZSBBcml0aEFkZDoKLSAgICBjYXNlIEFyaXRoU3ViOgogICAgIGNhc2Ug QXJpdGhOZWdhdGU6CiAgICAgY2FzZSBBcml0aE11bDoKICAgICBjYXNlIEFyaXRoRGl2OgpAQCAt MjU3LDYgKzI1NiwyMyBAQCB2b2lkIGNsb2JiZXJpemUoR3JhcGgmIGdyYXBoLCBOb2RlKiBub2Rl CiAgICAgICAgIGRlZihQdXJlVmFsdWUobm9kZSwgbm9kZS0+YXJpdGhNb2RlKCkpKTsKICAgICAg ICAgcmV0dXJuOwogCisgICAgY2FzZSBBcml0aFN1YjoKKyAgICAgICAgc3dpdGNoIChub2RlLT5i aW5hcnlVc2VLaW5kKCkpIHsKKyAgICAgICAgY2FzZSBJbnQzMlVzZToKKyNpZiBVU0UoSlNWQUxV RTY0KQorICAgICAgICBjYXNlIEludDUyUmVwVXNlOgorI2VuZGlmCisgICAgICAgIGNhc2UgRG91 YmxlUmVwVXNlOgorICAgICAgICAgICAgZGVmKFB1cmVWYWx1ZShub2RlLCBub2RlLT5hcml0aE1v ZGUoKSkpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICBjYXNlIFVudHlwZWRVc2U6Cisg ICAgICAgICAgICByZWFkKFdvcmxkKTsKKyAgICAgICAgICAgIHdyaXRlKEhlYXApOworICAgICAg ICAgICAgcmV0dXJuOworICAgICAgICBkZWZhdWx0OgorICAgICAgICAgICAgREZHX0NSQVNIKGdy YXBoLCBub2RlLCAiQmFkIHVzZSBraW5kIik7CisgICAgICAgIH0KKwogICAgIGNhc2UgQXJpdGhS b3VuZDoKICAgICAgICAgZGVmKFB1cmVWYWx1ZShub2RlLCBzdGF0aWNfY2FzdDx1aW50cHRyX3Q+ KG5vZGUtPmFyaXRoUm91bmRpbmdNb2RlKCkpKSk7CiAgICAgICAgIHJldHVybjsKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUHJlZGljdGlvblByb3BhZ2F0aW9uUGhhc2UuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUHJlZGljdGlvblBy b3BhZ2F0aW9uUGhhc2UuY3BwCShyZXZpc2lvbiAxOTI5MTIpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR1ByZWRpY3Rpb25Qcm9wYWdhdGlvblBoYXNlLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMjY5LDggKzI2OSw3IEBAIHByaXZhdGU6CiAgICAgICAgICAgICBicmVhazsKICAgICAg ICAgfQogCi0gICAgICAgIGNhc2UgQXJpdGhBZGQ6Ci0gICAgICAgIGNhc2UgQXJpdGhTdWI6IHsK KyAgICAgICAgY2FzZSBBcml0aEFkZDogewogICAgICAgICAgICAgU3BlY3VsYXRlZFR5cGUgbGVm dCA9IG5vZGUtPmNoaWxkMSgpLT5wcmVkaWN0aW9uKCk7CiAgICAgICAgICAgICBTcGVjdWxhdGVk VHlwZSByaWdodCA9IG5vZGUtPmNoaWxkMigpLT5wcmVkaWN0aW9uKCk7CiAgICAgICAgICAgICAK QEAgLTI4NSw2ICsyODQsMjUgQEAgcHJpdmF0ZToKICAgICAgICAgICAgIGJyZWFrOwogICAgICAg ICB9CiAgICAgICAgICAgICAKKyAgICAgICAgY2FzZSBBcml0aFN1YjogeworICAgICAgICAgICAg U3BlY3VsYXRlZFR5cGUgbGVmdCA9IG5vZGUtPmNoaWxkMSgpLT5wcmVkaWN0aW9uKCk7CisgICAg ICAgICAgICBTcGVjdWxhdGVkVHlwZSByaWdodCA9IG5vZGUtPmNoaWxkMigpLT5wcmVkaWN0aW9u KCk7CisKKyAgICAgICAgICAgIGlmIChsZWZ0ICYmIHJpZ2h0KSB7CisgICAgICAgICAgICAgICAg aWYgKGlzRnVsbE51bWJlck9yQm9vbGVhblNwZWN1bGF0aW9uRXhwZWN0aW5nRGVmaW5lZChsZWZ0 KQorICAgICAgICAgICAgICAgICAgICAmJiBpc0Z1bGxOdW1iZXJPckJvb2xlYW5TcGVjdWxhdGlv bkV4cGVjdGluZ0RlZmluZWQocmlnaHQpKSB7CisgICAgICAgICAgICAgICAgICAgIGlmIChtX2dy YXBoLmFkZFNwZWN1bGF0aW9uTW9kZShub2RlLCBtX3Bhc3MpICE9IERvbnRTcGVjdWxhdGVJbnQz MikKKyAgICAgICAgICAgICAgICAgICAgICAgIGNoYW5nZWQgfD0gbWVyZ2VQcmVkaWN0aW9uKFNw ZWNJbnQzMik7CisgICAgICAgICAgICAgICAgICAgIGVsc2UgaWYgKG1fZ3JhcGguYWRkU2hvdWxk U3BlY3VsYXRlTWFjaGluZUludChub2RlKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIGNoYW5n ZWQgfD0gbWVyZ2VQcmVkaWN0aW9uKFNwZWNJbnQ1Mik7CisgICAgICAgICAgICAgICAgICAgIGVs c2UKKyAgICAgICAgICAgICAgICAgICAgICAgIGNoYW5nZWQgfD0gbWVyZ2VQcmVkaWN0aW9uKHNw ZWN1bGF0ZWREb3VibGVUeXBlRm9yUHJlZGljdGlvbnMobGVmdCwgcmlnaHQpKTsKKyAgICAgICAg ICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgICAgICAgICAgY2hhbmdlZCB8PSBtZXJnZVByZWRp Y3Rpb24oU3BlY0ludDMyIHwgU3BlY0J5dGVjb2RlRG91YmxlKTsKKyAgICAgICAgICAgIH0KKyAg ICAgICAgICAgIGJyZWFrOworICAgICAgICB9CisKICAgICAgICAgY2FzZSBBcml0aE5lZ2F0ZToK ICAgICAgICAgICAgIGlmIChub2RlLT5jaGlsZDEoKS0+cHJlZGljdGlvbigpKSB7CiAgICAgICAg ICAgICAgICAgaWYgKG1fZ3JhcGgubmVnYXRlU2hvdWxkU3BlY3VsYXRlSW50MzIobm9kZSwgbV9w YXNzKSkK