151722 2015-12-01 14:26:52 -0800 Web Inspector: Timestamp in Tooltip of Event Markers is incorrect 2015-12-01 15:46:50 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1145397 0 joepeck 2015-12-01 14:26:52 -0800 * SUMMARY Timestamp in Tooltip of Event Markers is incorrect. Works on the first load, but later loads the timestamp appears wrong. It looks relative to the original first load instead of the active recording. * STEPS TO REPRODUCE 1. Inspect this page 2. Show Timelines Tab 3. Reload 4. Wait a minute 5. Reload again 6. Hover "Load" event marker => Tooltip says "1min..." instead of matching the time in the dashboard * NOTES - Same for console.timeStamp() 1145398 1 webkit-bug-importer 2015-12-01 14:27:06 -0800 <rdar://problem/23712906> 1145400 2 266394 joepeck 2015-12-01 14:29:19 -0800 Created attachment 266394 [PATCH] Proposed Fix 1145429 3 266394 commit-queue 2015-12-01 15:46:46 -0800 Comment on attachment 266394 [PATCH] Proposed Fix Clearing flags on attachment: 266394 Committed r192921: <http://trac.webkit.org/changeset/192921> 1145430 4 commit-queue 2015-12-01 15:46:50 -0800 All reviewed patches have been landed. Closing bug. 266394 2015-12-01 14:29:19 -0800 2015-12-01 15:46:46 -0800 [PATCH] Proposed Fix tooltip.patch text/plain 2904 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGNhNWIzZWEuLjIxNjY5YmQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE1LTEyLTAxICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZXN0 YW1wIGluIFRvb2x0aXAgb2YgRXZlbnQgTWFya2VycyBpcyBpbmNvcnJlY3QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTcyMgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3 cy9UaW1lbGluZVJ1bGVyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUnVsZXIu cHJvdG90eXBlLmFkZE1hcmtlcik6CisgICAgICAgIENvbnZlcnQgdGhlIG1hcmtlcidzIHRpbWUs IHRvIGJlIHJlbGF0aXZlIHRvIHRoZSBzdGFydCBvZiB0aGUgcmVjb3JkaW5nLgorCisyMDE1LTEy LTAxICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgVW5y ZXZpZXdlZCBjb21tb24gdHlwbyBmaXggIm9jY3VyYW5jZSIgPT4gIm9jY3VycmVuY2UiLgogCiAg ICAgICAgICogU2NyaXB0cy9jb21iaW5lLXJlc291cmNlcy5wbDoKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUnVsZXIuanMgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJ1bGVyLmpz CmluZGV4IDRlZGZmOGQuLjY2ZDcwZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUnVsZXIuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSdWxlci5qcwpAQCAtMzAwLDIx ICszMDAsMjIgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUnVsZXIgPSBjbGFzcyBUaW1lbGluZVJ1 bGVyIGV4dGVuZHMgV2ViSW5zcGVjdG9yLlZpZXcKIAogICAgICAgICBtYXJrZXIuYWRkRXZlbnRM aXN0ZW5lcihXZWJJbnNwZWN0b3IuVGltZWxpbmVNYXJrZXIuRXZlbnQuVGltZUNoYW5nZWQsIHRo aXMuX3RpbWVsaW5lTWFya2VyVGltZUNoYW5nZWQsIHRoaXMpOwogCi0gICAgICAgIHZhciBtYXJr ZXJFbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CisgICAgICAgIGxldCBt YXJrZXJUaW1lID0gbWFya2VyLnRpbWUgLSB0aGlzLl9zdGFydFRpbWU7CisgICAgICAgIGxldCBt YXJrZXJFbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CiAgICAgICAgIG1h cmtlckVsZW1lbnQuY2xhc3NMaXN0LmFkZChtYXJrZXIudHlwZSwgIm1hcmtlciIpOwogCiAgICAg ICAgIHN3aXRjaCAobWFya2VyLnR5cGUpIHsKICAgICAgICAgY2FzZSBXZWJJbnNwZWN0b3IuVGlt ZWxpbmVNYXJrZXIuVHlwZS5Mb2FkRXZlbnQ6Ci0gICAgICAgICAgICBtYXJrZXJFbGVtZW50LnRp dGxlID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJMb2FkIFx1MjAxNCAlcyIpLmZvcm1hdChOdW1i ZXIuc2Vjb25kc1RvU3RyaW5nKG1hcmtlci50aW1lKSk7CisgICAgICAgICAgICBtYXJrZXJFbGVt ZW50LnRpdGxlID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJMb2FkIFx1MjAxNCAlcyIpLmZvcm1h dChOdW1iZXIuc2Vjb25kc1RvU3RyaW5nKG1hcmtlclRpbWUpKTsKICAgICAgICAgICAgIGJyZWFr OwogICAgICAgICBjYXNlIFdlYkluc3BlY3Rvci5UaW1lbGluZU1hcmtlci5UeXBlLkRPTUNvbnRl bnRFdmVudDoKLSAgICAgICAgICAgIG1hcmtlckVsZW1lbnQudGl0bGUgPSBXZWJJbnNwZWN0b3Iu VUlTdHJpbmcoIkRPTUNvbnRlbnRMb2FkZWQgXHUyMDE0ICVzIikuZm9ybWF0KE51bWJlci5zZWNv bmRzVG9TdHJpbmcobWFya2VyLnRpbWUpKTsKKyAgICAgICAgICAgIG1hcmtlckVsZW1lbnQudGl0 bGUgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkRPTUNvbnRlbnRMb2FkZWQgXHUyMDE0ICVzIiku Zm9ybWF0KE51bWJlci5zZWNvbmRzVG9TdHJpbmcobWFya2VyVGltZSkpOwogICAgICAgICAgICAg YnJlYWs7CiAgICAgICAgIGNhc2UgV2ViSW5zcGVjdG9yLlRpbWVsaW5lTWFya2VyLlR5cGUuVGlt ZVN0YW1wOgogICAgICAgICAgICAgaWYgKG1hcmtlci5kZXRhaWxzKQotICAgICAgICAgICAgICAg IG1hcmtlckVsZW1lbnQudGl0bGUgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIiVzIFx1MjAxNCAl cyIpLmZvcm1hdChtYXJrZXIuZGV0YWlscywgTnVtYmVyLnNlY29uZHNUb1N0cmluZyhtYXJrZXIu dGltZSkpOworICAgICAgICAgICAgICAgIG1hcmtlckVsZW1lbnQudGl0bGUgPSBXZWJJbnNwZWN0 b3IuVUlTdHJpbmcoIiVzIFx1MjAxNCAlcyIpLmZvcm1hdChtYXJrZXIuZGV0YWlscywgTnVtYmVy LnNlY29uZHNUb1N0cmluZyhtYXJrZXJUaW1lKSk7CiAgICAgICAgICAgICBlbHNlCi0gICAgICAg ICAgICAgICAgbWFya2VyRWxlbWVudC50aXRsZSA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiVGlt ZXN0YW1wIFx1MjAxNCAlcyIpLmZvcm1hdChOdW1iZXIuc2Vjb25kc1RvU3RyaW5nKG1hcmtlci50 aW1lKSk7CisgICAgICAgICAgICAgICAgbWFya2VyRWxlbWVudC50aXRsZSA9IFdlYkluc3BlY3Rv ci5VSVN0cmluZygiVGltZXN0YW1wIFx1MjAxNCAlcyIpLmZvcm1hdChOdW1iZXIuc2Vjb25kc1Rv U3RyaW5nKG1hcmtlclRpbWUpKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAK