151711 2015-12-01 11:17:10 -0800 Web Inspector: Broken Inspector when resources are minified 2015-12-01 13:12:17 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1145292 0 joepeck 2015-12-01 11:17:10 -0800 * SUMMARY Broken Inspector when resources are minified. * ERRORS: Main.js:8903:11: CONSOLE ERROR ReferenceError: Can't find variable: CodeMirror Main.html:38:28: CONSOLE ERROR TypeError: WebInspector.loaded is not a function. (In 'WebInspector.loaded()', 'WebInspector.loaded' is undefined) * NOTES The minified html shows Main.js first in the list above its dependencies: > <script src="Main.js"></script> > <script src="CodeMirror.js"></script> > <script src="Esprima.js"></script> > <script src="ESLint.js"></script> 1145294 1 joepeck 2015-12-01 11:19:36 -0800 <rdar://problem/23692010> 1145297 2 266369 joepeck 2015-12-01 11:21:18 -0800 Created attachment 266369 [PATCH] Proposed Fix 1145347 3 joepeck 2015-12-01 13:12:17 -0800 <https://trac.webkit.org/changeset/192902> 266369 2015-12-01 11:21:18 -0800 2015-12-01 13:12:07 -0800 [PATCH] Proposed Fix ordering.patch text/plain 7516 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDU1M2ZkNGEuLjI4ZjM0NjcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTEyLTAxICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQnJva2Vu IEluc3BlY3RvciB3aGVuIHJlc291cmNlcyBhcmUgbWluaWZpZWQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTcxMQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9jb21iaW5lLXJlc291cmNl cy5wbDoKKyAgICAgICAgKGNvbmNhdGVuYXRlRmlsZXMpOgorICAgICAgICBQcm92aWRlIGEgd2F5 IHRvIGp1c3Qgc3RyaXAgcmVzb3VyY2VzIG1hdGNoZXMgYSBwYXR0ZXJuLgorCisgICAgICAgICog U2NyaXB0cy9jb3B5LXVzZXItaW50ZXJmYWNlLXJlc291cmNlcy5wbDoKKyAgICAgICAgU3RyaXAg IkRlYnVnLyIgcmVzb3VyY2VzIGJlZm9yZSBjb21iaW5pbmcgLyBtaW5pZnlpbmcgb3RoZXJzLgor CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9WaWV3LmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLlZpZXcucHJvdG90eXBlLm1ha2VSb290Vmlldyk6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuVmlldy5wcm90b3R5cGUuZGlkRGV0YWNoKToKKyAgICAgICAgQWRkcmVzcyB3YXJuaW5ncyBm cm9tIHRoZSBjb25zb2xlLmFzc2VydCBzdHJpcHBpbmcgcGhhc2UKKyAgICAgICAgZm9yIGNvbnNv bGUuYXNzZXJ0IHN0YXRlbWVudHMgbGFja2luZyBhIHRyYWlsaW5nIHNlbWljb2xvbi4KKwogMjAx NS0xMS0zMCAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5z cGVjdG9yOiBzaG93IHNvbWV0aGluZyB1c2VmdWwgd2hlbiB0aGUgaW5zcGVjdG9yIGZyb250ZW5k IGZhaWxzIHRvIGxvYWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9TY3JpcHRz L2NvbWJpbmUtcmVzb3VyY2VzLnBsIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1NjcmlwdHMvY29t YmluZS1yZXNvdXJjZXMucGwKaW5kZXggMDc4NGQ0NS4uZWJkY2Y0OCAxMDA3NTUKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1NjcmlwdHMvY29tYmluZS1yZXNvdXJjZXMucGwKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1NjcmlwdHMvY29tYmluZS1yZXNvdXJjZXMucGwKQEAgLTM1LDYg KzM1LDcgQEAgb3VyICRvdXRwdXRTdHlsZXNoZWV0TmFtZTsKIG91ciAkZGVyaXZlZFNvdXJjZXNE aXJlY3Rvcnk7CiBvdXIgJGh0bWxEaXJlY3Rvcnk7CiBvdXIgJGh0bWxGaWxlOworb3VyICRzdHJp cDsKIAogR2V0T3B0aW9ucygnb3V0cHV0LWRpcj1zJyA9PiBcJG91dHB1dERpcmVjdG9yeSwKICAg ICAgICAgICAgJ291dHB1dC1zY3JpcHQtbmFtZT1zJyA9PiBcJG91dHB1dFNjcmlwdE5hbWUsCkBA IC00MiwxMCArNDMsMTEgQEAgR2V0T3B0aW9ucygnb3V0cHV0LWRpcj1zJyA9PiBcJG91dHB1dERp cmVjdG9yeSwKICAgICAgICAgICAgJ2Rlcml2ZWQtc291cmNlcy1kaXI9cycgPT4gXCRkZXJpdmVk U291cmNlc0RpcmVjdG9yeSwKICAgICAgICAgICAgJ2lucHV0LWRpcj1zJyA9PiBcJGlucHV0RGly ZWN0b3J5LAogICAgICAgICAgICAnaW5wdXQtaHRtbC1kaXI9cycgPT4gXCRodG1sRGlyZWN0b3J5 LAotICAgICAgICAgICAnaW5wdXQtaHRtbD1zJyA9PiBcJGh0bWxGaWxlKTsKKyAgICAgICAgICAg J2lucHV0LWh0bWw9cycgPT4gXCRodG1sRmlsZSwKKyAgICAgICAgICAgJ3N0cmlwJyA9PiBcJHN0 cmlwKTsKIAotdW5sZXNzIChkZWZpbmVkICRodG1sRmlsZSBhbmQgZGVmaW5lZCAkZGVyaXZlZFNv dXJjZXNEaXJlY3RvcnkgYW5kIGRlZmluZWQgJG91dHB1dERpcmVjdG9yeSBhbmQgKGRlZmluZWQg JG91dHB1dFNjcmlwdE5hbWUgb3IgZGVmaW5lZCAkb3V0cHV0U3R5bGVzaGVldE5hbWUpKSB7Ci0g ICAgcHJpbnQgIlVzYWdlOiAkMCAtLWlucHV0LWh0bWwgPHBhdGg+IC0tZGVyaXZlZC1zb3VyY2Vz LWRpciA8cGF0aD4gLS1vdXRwdXQtZGlyIDxwYXRoPiBbLS1vdXRwdXQtc2NyaXB0LW5hbWUgPG5h bWU+XSBbLS1vdXRwdXQtc3R5bGUtbmFtZSA8bmFtZT5dXG4iOwordW5sZXNzIChkZWZpbmVkICRo dG1sRmlsZSBhbmQgZGVmaW5lZCAkZGVyaXZlZFNvdXJjZXNEaXJlY3RvcnkgYW5kIGRlZmluZWQg JG91dHB1dERpcmVjdG9yeSBhbmQgKGRlZmluZWQgJHN0cmlwIG9yIGRlZmluZWQgJG91dHB1dFNj cmlwdE5hbWUgb3IgZGVmaW5lZCAkb3V0cHV0U3R5bGVzaGVldE5hbWUpKSB7CisgICAgcHJpbnQg IlVzYWdlOiAkMCAtLWlucHV0LWh0bWwgPHBhdGg+IC0tZGVyaXZlZC1zb3VyY2VzLWRpciA8cGF0 aD4gLS1vdXRwdXQtZGlyIDxwYXRoPiBbLS1vdXRwdXQtc2NyaXB0LW5hbWUgPG5hbWU+XSBbLS1v dXRwdXQtc3R5bGUtbmFtZSA8bmFtZT5dIFstLXN0cmlwXVxuIjsKICAgICBleGl0OwogfQogCkBA IC03Niw3ICs3OCw2IEBAIHN1YiBjb25jYXRlbmF0ZUZpbGVzKCQkJCkKIAogICAgIHdoaWxlICgk aGVhZENvbnRlbnRzID1+IG0vJHRhZ0V4cHJlc3Npb24vZ2kpIHsKICAgICAgICAgbG9jYWwgJC87 Ci0gICAgICAgIG5leHQgaWYgJDEgPX4gL15EZWJ1Z1wvLzsKICAgICAgICAgb3BlbiBJTiwgIiRo dG1sRGlyZWN0b3J5LyQxIiBvciBvcGVuIElOLCAiJGRlcml2ZWRTb3VyY2VzRGlyZWN0b3J5LyQx IiBvciBkaWUgIkNhbid0IG9wZW4gJGh0bWxEaXJlY3RvcnkvJDE6ICQhIjsKICAgICAgICAgcHJp bnQgT1VUICJcbiIgaWYgJGZpbGVDb3VudCsrOwogICAgICAgICBwcmludCBPVVQgIi8qICQxICov XG5cbiI7CkBAIC04OSwxMiArOTAsMTcgQEAgc3ViIGNvbmNhdGVuYXRlRmlsZXMoJCQkKQogICAg ICMgRG9uJ3QgdXNlIFxzIHNvIHdlIGNhbiBjb250cm9sIHRoZSBuZXdsaW5lcyB3ZSBjb25zdW1l LgogICAgIG15ICRyZXBsYWNlbWVudEV4cHJlc3Npb24gPSAiKFtcdCBdKikiIC4gJHRhZ0V4cHJl c3Npb24gLiAiW1x0IF0qXG4rIjsKIAotICAgICMgUmVwbGFjZSB0aGUgZmlyc3Qgb2NjdXJhbmNl IHdpdGggYSB0b2tlbiBzbyB3ZSBjYW4gaW5qZWN0IHRoZSBjb25jYXRlbmF0ZWQgdGFnIGluIHRo ZSBzYW1lIHBsYWNlCi0gICAgIyBhcyB0aGUgZmlyc3QgZmlsZSB0aGF0IGdvdCBjb25zb2xpZGF0 ZWQuIFRoaXMgbWFrZXMgc3VyZSB3ZSBwcmVzZXJ2ZSBzb21lIG9yZGVyIGlmIHRoZXJlIGFyZSBv dGhlcgotICAgICMgaXRlbXMgaW4gdGhlIGhlYWQgdGhhdCB3ZSBkaWRuJ3QgY29uc29saWRhdGUu Ci0gICAgJGhlYWRDb250ZW50cyA9fiBzLyRyZXBsYWNlbWVudEV4cHJlc3Npb24vJDElQ09OQ0FU RU5BVEVEJVxuL2k7Ci0gICAgJGhlYWRDb250ZW50cyA9fiBzLyRyZXBsYWNlbWVudEV4cHJlc3Np b24vL2dpOwotICAgICRoZWFkQ29udGVudHMgPX4gcy8lQ09OQ0FURU5BVEVEJS8kY29uY2F0ZW5h dGVkVGFnLzsKKyAgICBpZiAoZGVmaW5lZCAkc3RyaXApIHsKKyAgICAgICAgIyBKdXN0IHN0cmlw IGFsbCBvY2N1cmFuY2VzIG9mIHRoZSBwYXR0ZXJuLgorICAgICAgICAkaGVhZENvbnRlbnRzID1+ IHMvJHJlcGxhY2VtZW50RXhwcmVzc2lvbi8vZ2k7CisgICAgfSBlbHNlIHsKKyAgICAgICAgIyBS ZXBsYWNlIHRoZSBmaXJzdCBvY2N1cmFuY2Ugd2l0aCBhIHRva2VuIHNvIHdlIGNhbiBpbmplY3Qg dGhlIGNvbmNhdGVuYXRlZCB0YWcgaW4gdGhlIHNhbWUgcGxhY2UKKyAgICAgICAgIyBhcyB0aGUg Zmlyc3QgZmlsZSB0aGF0IGdvdCBjb25zb2xpZGF0ZWQuIFRoaXMgbWFrZXMgc3VyZSB3ZSBwcmVz ZXJ2ZSBzb21lIG9yZGVyIGlmIHRoZXJlIGFyZSBvdGhlcgorICAgICAgICAjIGl0ZW1zIGluIHRo ZSBoZWFkIHRoYXQgd2UgZGlkbid0IGNvbnNvbGlkYXRlLgorICAgICAgICAkaGVhZENvbnRlbnRz ID1+IHMvJHJlcGxhY2VtZW50RXhwcmVzc2lvbi8kMSVDT05DQVRFTkFURUQlXG4vaTsKKyAgICAg ICAgJGhlYWRDb250ZW50cyA9fiBzLyRyZXBsYWNlbWVudEV4cHJlc3Npb24vL2dpOworICAgICAg ICAkaGVhZENvbnRlbnRzID1+IHMvJUNPTkNBVEVOQVRFRCUvJGNvbmNhdGVuYXRlZFRhZy87Cisg ICAgfQogfQogCiBteSAkaW5wdXREaXJlY3RvcnlQYXR0ZXJuID0gIig/IUV4dGVybmFsXC8pW15c Il0qIjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9TY3JpcHRzL2NvcHktdXNl ci1pbnRlcmZhY2UtcmVzb3VyY2VzLnBsIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1NjcmlwdHMv Y29weS11c2VyLWludGVyZmFjZS1yZXNvdXJjZXMucGwKaW5kZXggNzJjMTZlNy4uNjMyNDg2MSAx MDA3NTUKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1NjcmlwdHMvY29weS11c2VyLWludGVy ZmFjZS1yZXNvdXJjZXMucGwKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1NjcmlwdHMvY29w eS11c2VyLWludGVyZmFjZS1yZXNvdXJjZXMucGwKQEAgLTE0OCwxMSArMTQ4LDE0IEBAIG15ICRz aG91bGRDb21iaW5lVGVzdCA9IGRlZmluZWQgJEVOVnsnQ09NQklORV9URVNUX1JFU09VUkNFUyd9 ICYmICgkRU5WeydDT01CSU5FCiBteSAkY29tYmluZVJlc291cmNlc0NtZCA9IEZpbGU6OlNwZWMt PmNhdGZpbGUoJHNjcmlwdHNSb290LCAnY29tYmluZS1yZXNvdXJjZXMucGwnKTsKIAogaWYgKCRz aG91bGRDb21iaW5lTWFpbikgeworICAgICMgUmVtb3ZlIERlYnVnIEphdmFTY3JpcHQgYW5kIENT UyBmaWxlcyBpbiBQcm9kdWN0aW9uIGJ1aWxkcy4KKyAgICBzeXN0ZW0oJGNvbWJpbmVSZXNvdXJj ZXNDbWQsICctLWlucHV0LWRpcicsICdEZWJ1ZycsICctLWlucHV0LWh0bWwnLCBGaWxlOjpTcGVj LT5jYXRmaWxlKCR1aVJvb3QsICdNYWluLmh0bWwnKSwgJy0taW5wdXQtaHRtbC1kaXInLCAkdWlS b290LCAnLS1kZXJpdmVkLXNvdXJjZXMtZGlyJywgJGRlcml2ZWRTb3VyY2VzRGlyLCAnLS1vdXRw dXQtZGlyJywgJGRlcml2ZWRTb3VyY2VzRGlyLCAnLS1vdXRwdXQtc2NyaXB0LW5hbWUnLCAnRGVi dWcuanMnLCAnLS1vdXRwdXQtc3R5bGUtbmFtZScsICdEZWJ1Zy5jc3MnLCAnLS1zdHJpcCcpOwor CiAgICAgIyBDb21iaW5lIHRoZSBKYXZhU2NyaXB0IGFuZCBDU1MgZmlsZXMgaW4gUHJvZHVjdGlv biBidWlsZHMgaW50byBzaW5nbGUgZmlsZXMgKE1haW4uanMgYW5kIE1haW4uY3NzKS4KLSAgICBz eXN0ZW0oJGNvbWJpbmVSZXNvdXJjZXNDbWQsICctLWlucHV0LWh0bWwnLCBGaWxlOjpTcGVjLT5j YXRmaWxlKCR1aVJvb3QsICdNYWluLmh0bWwnKSwgJy0tZGVyaXZlZC1zb3VyY2VzLWRpcicsICRk ZXJpdmVkU291cmNlc0RpciwgJy0tb3V0cHV0LWRpcicsICRkZXJpdmVkU291cmNlc0RpciwgJy0t b3V0cHV0LXNjcmlwdC1uYW1lJywgJ01haW4uanMnLCAnLS1vdXRwdXQtc3R5bGUtbmFtZScsICdN YWluLmNzcycpOwotCi0gICAgIyBDb21iaW5lIHRoZSBDb2RlTWlycm9yIEphdmFTY3JpcHQgYW5k IENTUyBmaWxlcyBpbiBQcm9kdWN0aW9uIGJ1aWxkcyBpbnRvIHNpbmdsZSBmaWxlcyAoQ29kZU1p cnJvci5qcyBhbmQgQ29kZU1pcnJvci5jc3MpLgogICAgIG15ICRkZXJpdmVkU291cmNlc01haW5I VE1MID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZSgkZGVyaXZlZFNvdXJjZXNEaXIsICdNYWluLmh0bWwn KTsKKyAgICBzeXN0ZW0oJGNvbWJpbmVSZXNvdXJjZXNDbWQsICctLWlucHV0LWh0bWwnLCAkZGVy aXZlZFNvdXJjZXNNYWluSFRNTCwgJy0taW5wdXQtaHRtbC1kaXInLCAkdWlSb290LCAnLS1kZXJp dmVkLXNvdXJjZXMtZGlyJywgJGRlcml2ZWRTb3VyY2VzRGlyLCAnLS1vdXRwdXQtZGlyJywgJGRl cml2ZWRTb3VyY2VzRGlyLCAnLS1vdXRwdXQtc2NyaXB0LW5hbWUnLCAnTWFpbi5qcycsICctLW91 dHB1dC1zdHlsZS1uYW1lJywgJ01haW4uY3NzJyk7CisKKyAgICAjIENvbWJpbmUgdGhlIENvZGVN aXJyb3IgSmF2YVNjcmlwdCBhbmQgQ1NTIGZpbGVzIGluIFByb2R1Y3Rpb24gYnVpbGRzIGludG8g c2luZ2xlIGZpbGVzIChDb2RlTWlycm9yLmpzIGFuZCBDb2RlTWlycm9yLmNzcykuCiAgICAgc3lz dGVtKCRjb21iaW5lUmVzb3VyY2VzQ21kLCAnLS1pbnB1dC1kaXInLCAnRXh0ZXJuYWwvQ29kZU1p cnJvcicsICctLWlucHV0LWh0bWwnLCAkZGVyaXZlZFNvdXJjZXNNYWluSFRNTCwgJy0taW5wdXQt aHRtbC1kaXInLCAkdWlSb290LCAnLS1kZXJpdmVkLXNvdXJjZXMtZGlyJywgJGRlcml2ZWRTb3Vy Y2VzRGlyLCAnLS1vdXRwdXQtZGlyJywgJGRlcml2ZWRTb3VyY2VzRGlyLCAnLS1vdXRwdXQtc2Ny aXB0LW5hbWUnLCAnQ29kZU1pcnJvci5qcycsICctLW91dHB1dC1zdHlsZS1uYW1lJywgJ0NvZGVN aXJyb3IuY3NzJyk7CiAKICAgICAjIENvbWJpbmUgdGhlIEVzcHJpbWEgSmF2YVNjcmlwdCBmaWxl cyBpbiBQcm9kdWN0aW9uIGJ1aWxkcyBpbnRvIGEgc2luZ2xlIGZpbGUgKEVzcHJpbWEuanMpLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVmll dy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1ZpZXcuanMK aW5kZXggYjMxNDAzMi4uM2MwNTVlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvVmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9WaWV3LmpzCkBAIC02Miw3ICs2Miw3IEBAIFdlYkluc3BlY3Rv ci5WaWV3ID0gY2xhc3MgVmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKICAgICBtYWtl Um9vdFZpZXcoKQogICAgIHsKICAgICAgICAgY29uc29sZS5hc3NlcnQoIVdlYkluc3BlY3Rvci5W aWV3Ll9yb290VmlldywgIlJvb3QgdmlldyBhbHJlYWR5IGV4aXN0cy4iKTsKLSAgICAgICAgY29u c29sZS5hc3NlcnQoIXRoaXMuX3BhcmVudFZpZXcsICJSb290IHZpZXcgY2Fubm90IGJlIGEgc3Vi dmlldy4iKQorICAgICAgICBjb25zb2xlLmFzc2VydCghdGhpcy5fcGFyZW50VmlldywgIlJvb3Qg dmlldyBjYW5ub3QgYmUgYSBzdWJ2aWV3LiIpOwogICAgICAgICBpZiAoV2ViSW5zcGVjdG9yLlZp ZXcuX3Jvb3RWaWV3KQogICAgICAgICAgICAgcmV0dXJuOwogCkBAIC0xNTQsNyArMTU0LDcgQEAg V2ViSW5zcGVjdG9yLlZpZXcgPSBjbGFzcyBWaWV3IGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVj dAogCiAgICAgZGlkRGV0YWNoKCkKICAgICB7Ci0gICAgICAgIGNvbnNvbGUuYXNzZXJ0KHRoaXMu X3BhcmVudFZpZXcsICJEZXRhY2hlZCB2aWV3IGhhcyBubyBwYXJlbnQuIikKKyAgICAgICAgY29u c29sZS5hc3NlcnQodGhpcy5fcGFyZW50VmlldywgIkRldGFjaGVkIHZpZXcgaGFzIG5vIHBhcmVu dC4iKTsKICAgICAgICAgdGhpcy5fcGFyZW50VmlldyA9IG51bGw7CiAgICAgfQogCg==