151699 2015-12-01 01:33:04 -0800 REGRESSION(r192834): [GTK] Test /webkit2/WebKitWebView/editor-state/typing-attributes times out after r192834 2015-12-01 09:40:50 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned andersca bugs-noreply thorton oldest_to_newest 1145194 0 cgarcia 2015-12-01 01:33:04 -0800 We are no longer notified of the editor state change from WebPage::didChangeSelection(), the non mac code was removed in r192834. 1145197 1 266347 cgarcia 2015-12-01 01:35:35 -0800 Created attachment 266347 Patch The fix is pretty obvious, but I'm assuming it was removed by mistake, so better get a review to be sure. 1145246 2 cgarcia 2015-12-01 09:40:50 -0800 Committed r192888: <http://trac.webkit.org/changeset/192888> 266347 2015-12-01 01:35:35 -0800 2015-12-01 08:29:52 -0800 Patch wk2-editor-state-change.diff text/plain 1614 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhMzE4M2UxLi5mNWViZTE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTUtMTItMDEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFJFR1JFU1NJT04ocjE5MjgzNCk6IFtHVEtdIFRlc3QgL3dlYmtpdDIvV2Vi S2l0V2ViVmlldy9lZGl0b3Itc3RhdGUvdHlwaW5nLWF0dHJpYnV0ZXMgdGltZXMgb3V0IGFmdGVy IHIxOTI4MzQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE1MTY5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEluIHIxOTI4MzQgdGhlIGNvZGUgdG8gc2VuZCBFZGl0b3JTdGF0ZUNoYW5nZWQgbWVzc2FnZSB0 byB0aGUgVUkKKyAgICAgICAgcHJvY2VzcyBmcm9tIFdlYlBhZ2U6OmRpZENoYW5nZVNlbGVjdGlv biB3YXMgcmVtb3ZlZCBmb3Igbm9uLW1hYworICAgICAgICBwb3J0cy4KKworICAgICAgICAqIFdl YlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6 ZGlkQ2hhbmdlU2VsZWN0aW9uKTogU2VuZCBFZGl0b3JTdGF0ZUNoYW5nZWQKKyAgICAgICAgbWVz c2FnZSB0byB0aGUgVUkgcHJvY2VzcyBhbHNvIGZvciBub24tbWFjIHBvcnRzLCBhcyBiZWZvcmUg cjE5MjgzNC4KKworMjAxNS0xMi0wMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKICAgICAgICAgVW5yZXZpZXdlZC4gQWRkIG1pc3NpbmcgaW5zcGVjdG9yIGZp bGVzIHRvIHRoZSBHVEsrIGJ1aWxkLgogCiAgICAgICAgICogUGxhdGZvcm1HVEsuY21ha2U6IEFk ZCBhbHNvIERlYnVnIGNzcyBmaWxlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9XZWJQYWdlLmNwcAppbmRleCAyMjBjNjc1Li40NzM3NWE1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCkBAIC00NDgwLDYgKzQ0ODAsOCBA QCB2b2lkIFdlYlBhZ2U6OmRpZENoYW5nZVNlbGVjdGlvbigpCiAgICAgICAgIHNlbmQoTWVzc2Fn ZXM6OldlYlBhZ2VQcm94eTo6Q29tcG9zaXRpb25XYXNDYW5jZWxlZChlZGl0b3JTdGF0ZSkpOwog ICAgIH0gZWxzZQogICAgICAgICBzZW5kKE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OkVkaXRvclN0 YXRlQ2hhbmdlZChlZGl0b3JTdGF0ZSkpOworI2Vsc2UKKyAgICBzZW5kKE1lc3NhZ2VzOjpXZWJQ YWdlUHJveHk6OkVkaXRvclN0YXRlQ2hhbmdlZChlZGl0b3JTdGF0ZSksIHBhZ2VJRCgpLCBJUEM6 OkRpc3BhdGNoTWVzc2FnZUV2ZW5XaGVuV2FpdGluZ0ZvclN5bmNSZXBseSk7CiAjZW5kaWYKIAog I2lmIFBMQVRGT1JNKElPUykK