151689 2015-11-30 17:38:35 -0800 Fix possible crash with animated layers in reflections 2015-11-30 18:47:04 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser dino simon.fraser thorton oldest_to_newest 1145054 0 simon.fraser 2015-11-30 17:38:35 -0800 Fix possible crash with animated layers in reflections 1145055 1 266308 simon.fraser 2015-11-30 17:40:09 -0800 Created attachment 266308 Patch 1145056 2 simon.fraser 2015-11-30 17:40:24 -0800 rdar://problem/23018612 1145062 3 266308 darin 2015-11-30 17:57:09 -0800 Comment on attachment 266308 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266308&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3501 > + clearClonesOwner(m_layerClones.get()); > m_layerClones = nullptr; Since you are using a helper function, why not have it take std::unique_ptr<LayerMap>& and then it can do the nulling out too. 1145083 4 simon.fraser 2015-11-30 18:46:57 -0800 https://trac.webkit.org/changeset/192853 266308 2015-11-30 17:40:09 -0800 2015-11-30 18:47:04 -0800 Patch bug-151689-20151130173947.patch text/plain 3315 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyODA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2RkNTRjYmZlNTMxNzQx YTc1ZDY3ZTRmYzM2M2M2OGI3M2FmNzZmOC4uZWRiMTQ5ZTE0NDNhODIyOWE0NzlkMmRlODM3MDQy MGM4Y2FmYmUyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTExLTMwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBwb3NzaWJs ZSBjcmFzaCB3aXRoIGFuaW1hdGVkIGxheWVycyBpbiByZWZsZWN0aW9ucworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxNjg5CisgICAgICAgIHJkYXI6 Ly9wcm9ibGVtLzIzMDE4NjEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUmVmbGVjdGlvbnMgY3JlYXRlIGFkZGl0aW9uYWwgUGxhdGZvcm1DQUxheWVy cyB3aG9zZSBvd25lciBpcyBzZXQgdG8gdGhlIEdyYXBoaWNzTGF5ZXJDQS4KKyAgICAgICAgVGhv c2UgUGxhdGZvcm1DQUxheWVycyBuZWVkIHRoZWlyIG93bmVyIHBvaW50ZXIgY2xlYXJlZCBvdXQg d2hlbiB0aGUgR3JhcGhpY3NMYXllckNBCisgICAgICAgIGlzIGRlc3Ryb3llZC4KKyAgICAgICAg CisgICAgICAgIFRlc3RlZCBieSBjb21wb3NpdGluZy9yZWZsZWN0aW9ucy9uZXN0ZWQtcmVmbGVj dGlvbi10cmFuc2l0aW9uLmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhL0dy YXBoaWNzTGF5ZXJDQS5jcHA6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhp Y3NMYXllckNBLmg6CisKIDIwMTUtMTEtMzAgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUu Y29tPgogCiAgICAgICAgIE1vZGVybiBJREI6IFJlc29sdmUgZmxha3kgR0MtdnMtd3JhcHBlciBp c3N1ZSB3aXRoIElEQk9wZW5EQlJlcXVlc3QuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmNwcAppbmRleCBhZDc5ZTk1MzU3 NDljYzc4OTNhNWU4N2JmN2RkN2Y2MjBiYTQ0YzExLi41ZTAzY2E2Nzc2MTM1ZDU3NTExNjQ2NWVj NjgyYzVmNmM2ZjhmYTE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jYS9HcmFwaGljc0xheWVyQ0EuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHAKQEAgLTM0ODYsMTMgKzM0ODYsMzMgQEAg dm9pZCBHcmFwaGljc0xheWVyQ0E6OmVuc3VyZUNsb25lTGF5ZXJzKENsb25lSUQgY2xvbmVJRCwg UmVmUHRyPFBsYXRmb3JtQ0FMYXllcj4KICAgICBzaGFwZU1hc2tMYXllciA9IGZpbmRPck1ha2VD bG9uZShjbG9uZUlELCBtX3NoYXBlTWFza0xheWVyLmdldCgpLCBtX3NoYXBlTWFza0xheWVyQ2xv bmVzLmdldCgpLCBjbG9uZUxldmVsKTsKIH0KIAordm9pZCBHcmFwaGljc0xheWVyQ0E6OmNsZWFy Q2xvbmVzT3duZXIoTGF5ZXJNYXAqIGxheWVyTWFwKQoreworICAgIGlmICghbGF5ZXJNYXApCisg ICAgICAgIHJldHVybjsKKworICAgIGZvciAoYXV0byYgbGF5ZXIgOiBsYXllck1hcC0+dmFsdWVz KCkpCisgICAgICAgIGxheWVyLT5zZXRPd25lcihudWxscHRyKTsKK30KKwogdm9pZCBHcmFwaGlj c0xheWVyQ0E6OnJlbW92ZUNsb25lTGF5ZXJzKCkKIHsKKyAgICBjbGVhckNsb25lc093bmVyKG1f bGF5ZXJDbG9uZXMuZ2V0KCkpOwogICAgIG1fbGF5ZXJDbG9uZXMgPSBudWxscHRyOworCisgICAg Y2xlYXJDbG9uZXNPd25lcihtX3N0cnVjdHVyYWxMYXllckNsb25lcy5nZXQoKSk7CiAgICAgbV9z dHJ1Y3R1cmFsTGF5ZXJDbG9uZXMgPSBudWxscHRyOworCisgICAgY2xlYXJDbG9uZXNPd25lciht X2NvbnRlbnRzTGF5ZXJDbG9uZXMuZ2V0KCkpOwogICAgIG1fY29udGVudHNMYXllckNsb25lcyA9 IG51bGxwdHI7CisKKyAgICBjbGVhckNsb25lc093bmVyKG1fY29udGVudHNDbGlwcGluZ0xheWVy Q2xvbmVzLmdldCgpKTsKICAgICBtX2NvbnRlbnRzQ2xpcHBpbmdMYXllckNsb25lcyA9IG51bGxw dHI7CisKKyAgICBjbGVhckNsb25lc093bmVyKG1fY29udGVudHNTaGFwZU1hc2tMYXllckNsb25l cy5nZXQoKSk7CiAgICAgbV9jb250ZW50c1NoYXBlTWFza0xheWVyQ2xvbmVzID0gbnVsbHB0cjsK KworICAgIGNsZWFyQ2xvbmVzT3duZXIobV9zaGFwZU1hc2tMYXllckNsb25lcy5nZXQoKSk7CiAg ICAgbV9zaGFwZU1hc2tMYXllckNsb25lcyA9IG51bGxwdHI7CiB9CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5oIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmgKaW5kZXgg OGVhNDZlYjYzOGZiZmE5ZmNhOTIzOWI5MzI1ZDEyOGU5NmMyMzhhYy4uYTczM2Q4Nzg0MTBmYTU1 YzRhNjc3NTQyZDM1NTVjOTBlNDdjNDMxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmgKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmgKQEAgLTM2NSw2ICszNjUsOCBA QCBwcml2YXRlOgogICAgIHZvaWQgZW5zdXJlQ2xvbmVMYXllcnMoQ2xvbmVJRCwgUmVmUHRyPFBs YXRmb3JtQ0FMYXllcj4mIHByaW1hcnlMYXllciwgUmVmUHRyPFBsYXRmb3JtQ0FMYXllcj4mIHN0 cnVjdHVyYWxMYXllciwKICAgICAgICAgUmVmUHRyPFBsYXRmb3JtQ0FMYXllcj4mIGNvbnRlbnRz TGF5ZXIsIFJlZlB0cjxQbGF0Zm9ybUNBTGF5ZXI+JiBjb250ZW50c0NsaXBwaW5nTGF5ZXIsIFJl ZlB0cjxQbGF0Zm9ybUNBTGF5ZXI+JiBjb250ZW50c1NoYXBlTWFza0xheWVyLCBSZWZQdHI8UGxh dGZvcm1DQUxheWVyPiYgc2hhcGVNYXNrTGF5ZXIsIENsb25lTGV2ZWwpOwogCisgICAgc3RhdGlj IHZvaWQgY2xlYXJDbG9uZXNPd25lcihMYXllck1hcCopOworCiAgICAgYm9vbCBoYXNDbG9uZUxh eWVycygpIGNvbnN0IHsgcmV0dXJuICEhbV9sYXllckNsb25lczsgfQogICAgIHZvaWQgcmVtb3Zl Q2xvbmVMYXllcnMoKTsKICAgICBGbG9hdFBvaW50IHBvc2l0aW9uRm9yQ2xvbmVSb290TGF5ZXIo KSBjb25zdDsK