151670 2015-11-30 12:45:34 -0800 Fix the graphics benchmark complexity bounds adjustment 2015-11-30 15:06:46 -0800 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sabouhallawa sabouhallawa cdumez commit-queue dino rniwa simon.fraser oldest_to_newest 1144885 0 sabouhallawa 2015-11-30 12:45:34 -0800 The test complexity bounds (min-max values) are used to prevent the test FPS from fluctuating. We always make sure the current complexity of the test is within these bounds. These bounds are the min-max values of the test complexity starting from the beginning of the first overshoot till the end of the following undershoot of the FPS. We need also to make sure that the bounds are large enough to allow some flexibility. This is helpful when the difference between the lower and upper bounds is very small. I think it is enough to make sure the lower bound is at least 90% of the upper bound. The bounds are negative in the case of graphics benchmark since the relationship between the test complexity and FPS is reverse proportional. So we need to apply the adjustment to the "absolute" minimum bound which is (min if min < 0) or (max if max < 0). 1144887 1 266261 sabouhallawa 2015-11-30 12:49:03 -0800 Created attachment 266261 Patch 1144968 2 266261 commit-queue 2015-11-30 15:06:43 -0800 Comment on attachment 266261 Patch Clearing flags on attachment: 266261 Committed r192835: <http://trac.webkit.org/changeset/192835> 1144969 3 commit-queue 2015-11-30 15:06:46 -0800 All reviewed patches have been landed. Closing bug. 266261 2015-11-30 12:49:03 -0800 2015-11-30 15:06:43 -0800 Patch bug-151670-20151130124842.patch text/plain 1656 sabouhallawa SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxOTI4MTUpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTExLTMwICBT YWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgRml4 IHRoZSBncmFwaGljcyBiZW5jaG1hcmsgY29tcGxleGl0eSBib3VuZHMgYWRqdXN0bWVudAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxNjcwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIHRo ZSBncmFwaGljcyBiZW5jaG1hcmsgY29tcGxleGl0eSBib3VuZHMgYWRqdXN0bWVudCBpcyBhcHBs aWVkCisgICAgICAgIHRvIHRoZSBhYnNvbHV0ZSBsb3dlciBib3VuZC4KKworICAgICAgICAqIEFu aW1vbWV0ZXIvdGVzdHMvcmVzb3VyY2VzL21hdGguanM6CisgICAgICAgIChQSURDb250cm9sbGVy LnByb3RvdHlwZS5fc2F0dXJhdGUpOgorCiAyMDE1LTExLTIwICBTaW1vbiBGcmFzZXIgIDxzaW1v bi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEFuaW1vbWV0ZXI6IGdyYXBocyBzaG91bGQg bm90IGRvIGludGVycG9sYXRpb24KSW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQW5pbW9tZXRlci90 ZXN0cy9yZXNvdXJjZXMvbWF0aC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBQZXJmb3JtYW5jZVRlc3RzL0Fu aW1vbWV0ZXIvdGVzdHMvcmVzb3VyY2VzL21hdGguanMJKHJldmlzaW9uIDE5MjgwOCkKKysrIFBl cmZvcm1hbmNlVGVzdHMvQW5pbW9tZXRlci90ZXN0cy9yZXNvdXJjZXMvbWF0aC5qcwkod29ya2lu ZyBjb3B5KQpAQCAtMzkxLDkgKzM5MSwxMCBAQCBQSURDb250cm9sbGVyLnByb3RvdHlwZSA9CiAg ICAgICAgICAgICBicmVhazsKICAgICAgICAgCiAgICAgICAgIGNhc2UgUElEQ29udHJvbGxlci5z dGFnZXMuU0FUVVJBVEU6CisgICAgICAgICAgICBjb25zdCBsaW1pdFBlcmNlbnRhZ2UgPSAwLjkw OworICAgICAgICAgICAgdmFyIG1pbiA9IHRoaXMuX21pbiA+IDAgPyBNYXRoLm1pbih0aGlzLl9t aW4sIHRoaXMuX21heCAqIGxpbWl0UGVyY2VudGFnZSkgOiB0aGlzLl9taW47CisgICAgICAgICAg ICB2YXIgbWF4ID0gdGhpcy5fbWF4IDwgMCA/IE1hdGgubWF4KHRoaXMuX21heCwgdGhpcy5fbWlu ICogbGltaXRQZXJjZW50YWdlKSA6IHRoaXMuX21heDsKICAgICAgICAgICAgIHZhciBvdXQgPSB0 aGlzLl9vdXQgKyB1OwotICAgICAgICAgICAgdmFyIG1pbiA9IE1hdGgubWluKHRoaXMuX21pbiwg dGhpcy5fbWF4ICogMC43MCk7Ci0gICAgICAgICAgICB2YXIgbWF4ID0gdGhpcy5fbWF4OwogCiAg ICAgICAgICAgICAvLyBDbGlwIHRoZSBjb250cm9sbGVyIG91dHB1dCB0byB0aGUgbWluLW1heCB2 YWx1ZXMKICAgICAgICAgICAgIG91dCA9IE1hdGgubWF4KE1hdGgubWluKG1heCwgb3V0KSwgbWlu KTsK