151645 2015-11-28 23:10:24 -0800 Modern IDB: Resolve flaky GC-vs-wrapper issue with IDBOpenDBRequest 2015-11-30 10:24:41 -0800 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 149117 150882 1 beidson beidson achristensen alecflett commit-queue jsbell oldest_to_newest 1144679 0 beidson 2015-11-28 23:10:24 -0800 Modern IDB: Resolve flaky GC-vs-wrapper issue with IDBOpenDBRequest IDBRequest::hasPendingActivity() lies for IDBOpenDBRequests that have fired their onUpgradeNeeded event but not yet fired their onSuccess event. GC can happen between, removing the wrapper, and therefore causing onSuccess to never actually fire. 1144686 1 266223 beidson 2015-11-29 09:53:03 -0800 Created attachment 266223 Patch v1 1144807 2 266223 commit-queue 2015-11-30 10:24:37 -0800 Comment on attachment 266223 Patch v1 Clearing flags on attachment: 266223 Committed r192803: <http://trac.webkit.org/changeset/192803> 1144808 3 commit-queue 2015-11-30 10:24:41 -0800 All reviewed patches have been landed. Closing bug. 266223 2015-11-29 09:53:03 -0800 2015-11-30 10:24:37 -0800 Patch v1 patch text/plain 5480 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1M2RjN2IzLi5hMTg5ODdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzEg QEAKKzIwMTUtMTEtMjkgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIE1vZGVybiBJREI6IFJlc29sdmUgZmxha3kgR0MtdnMtd3JhcHBlciBpc3N1ZSB3aXRoIElE Qk9wZW5EQlJlcXVlc3QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTE2NDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBObyBuZXcgdGVzdHMgKFJlc29sdmVzIGZsYWtpbmVzcyB3aXRoIGh1bmRyZWRzIG9m IGV4aXN0aW5nIElEQiB0ZXN0cykuCisKKyAgICAgICAgRG8gdG8gaW1wcm9wZXIgbWFuYWdlbWVu dCBvZiB0aGUgbV9oYXNQZW5kaW5nQWN0aXZpdHkgZmxhZyBvbiBJREJSZXF1ZXN0SW1wbCwKKyAg ICAgICAgdGhlIHJlcXVlc3Qgd3JhcHBlciBmb3IgYW4gSURCT3BlbkRCUmVxdWVzdCBtaWdodCBi ZSBnYXJiYWdlIGNvbGxlY3RlZCBpbiBiZXR3ZWVuIHRoZQorICAgICAgICBvblVwZ3JhZGVOZWVk ZWQgZXZlbnQgYW5kIG9uU3VjY2VzcyBldmVudC4KKyAgICAgICAgCisgICAgICAgIFRoaXMgbWFu aWZlc3RlZCBhcyBmbGFraW5lc3MgaW4gbWFueSB0ZXN0cywgc29tZSBtb3JlIHRoYW4gb3RoZXJz LgorICAgICAgICAKKyAgICAgICAgSSB0cmllZCB0byB3cml0ZSBhIHRhcmdldGVkIDEwMCUgcmVw cm9kdWNpYmxlIGNhc2UgbWFudWFsbHkgZm9yY2luZyBHQywgYnV0IGNvdWxkIG5vdCBnZXQKKyAg ICAgICAgdGhlIHRpbWluZyByaWdodC4KKyAgICAgICAgCisgICAgICAgICogTW9kdWxlcy9pbmRl eGVkZGIvY2xpZW50L0lEQk9wZW5EQlJlcXVlc3RJbXBsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OklEQkNsaWVudDo6SURCT3BlbkRCUmVxdWVzdDo6ZmlyZVN1Y2Nlc3NBZnRlclZlcnNpb25DaGFu Z2VDb21taXQpOgorICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRiL2NsaWVudC9JREJPcGVuREJS ZXF1ZXN0SW1wbC5oOgorICAgICAgICAKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9jbGll bnQvSURCUmVxdWVzdEltcGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCQ2xpZW50OjpJREJS ZXF1ZXN0OjpkaXNwYXRjaEV2ZW50KToKKyAgICAgICAgKFdlYkNvcmU6OklEQkNsaWVudDo6SURC UmVxdWVzdDo6d2lsbEl0ZXJhdGVDdXJzb3IpOgorICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRi L2NsaWVudC9JREJSZXF1ZXN0SW1wbC5oOgorICAgICAgICAoV2ViQ29yZTo6SURCQ2xpZW50OjpJ REJSZXF1ZXN0Ojppc09wZW5EQlJlcXVlc3QpOgorCiAyMDE1LTExLTI3ICBCcmFkeSBFaWRzb24g IDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBNb2Rlcm4gSURCOiBDbGFzcy1pZnkgSURC R2V0UmVzdWx0IG1ha2luZyBpdCBpbXBvc3NpYmxlIHRvIGdldCB0aGUgZGF0YSBtZW1iZXJzIHdy b25nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvY2xpZW50 L0lEQk9wZW5EQlJlcXVlc3RJbXBsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhl ZGRiL2NsaWVudC9JREJPcGVuREJSZXF1ZXN0SW1wbC5jcHAKaW5kZXggMTVhOGNkNy4uYTA5Y2Iy NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvY2xpZW50L0lE Qk9wZW5EQlJlcXVlc3RJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4 ZWRkYi9jbGllbnQvSURCT3BlbkRCUmVxdWVzdEltcGwuY3BwCkBAIC03MSw2ICs3MSw3IEBAIHZv aWQgSURCT3BlbkRCUmVxdWVzdDo6ZmlyZVN1Y2Nlc3NBZnRlclZlcnNpb25DaGFuZ2VDb21taXQo KQogewogICAgIExPRyhJbmRleGVkREIsICJJREJPcGVuREJSZXF1ZXN0OjpmaXJlU3VjY2Vzc0Fm dGVyVmVyc2lvbkNoYW5nZUNvbW1pdCgpIik7CiAKKyAgICBBU1NFUlQoaGFzUGVuZGluZ0FjdGl2 aXR5KCkpOwogICAgIEFTU0VSVChtX3Jlc3VsdCk7CiAgICAgQVNTRVJUKG1fcmVzdWx0LT50eXBl KCkgPT0gSURCQW55OjpUeXBlOjpJREJEYXRhYmFzZSk7CiAgICAgbV90cmFuc2FjdGlvbi0+YWRk UmVxdWVzdCgqdGhpcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4 ZWRkYi9jbGllbnQvSURCT3BlbkRCUmVxdWVzdEltcGwuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvaW5kZXhlZGRiL2NsaWVudC9JREJPcGVuREJSZXF1ZXN0SW1wbC5oCmluZGV4IDAzNjNjYzUu LjgzYTE3NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL2Ns aWVudC9JREJPcGVuREJSZXF1ZXN0SW1wbC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv aW5kZXhlZGRiL2NsaWVudC9JREJPcGVuREJSZXF1ZXN0SW1wbC5oCkBAIC02MSw2ICs2MSw4IEBA IHByaXZhdGU6CiAgICAgdm9pZCBvblVwZ3JhZGVOZWVkZWQoY29uc3QgSURCUmVzdWx0RGF0YSYp OwogICAgIHZvaWQgb25EZWxldGVEYXRhYmFzZVN1Y2Nlc3MoY29uc3QgSURCUmVzdWx0RGF0YSYp OwogCisgICAgdmlydHVhbCBib29sIGlzT3BlbkRCUmVxdWVzdCgpIGNvbnN0IG92ZXJyaWRlIHsg cmV0dXJuIHRydWU7IH0KKwogICAgIElEQkRhdGFiYXNlSWRlbnRpZmllciBtX2RhdGFiYXNlSWRl bnRpZmllcjsKICAgICB1aW50NjRfdCBtX3ZlcnNpb24geyAwIH07CiB9OwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvY2xpZW50L0lEQlJlcXVlc3RJbXBsLmNw cCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL2NsaWVudC9JREJSZXF1ZXN0SW1w bC5jcHAKaW5kZXggYTRmZTYyNi4uZTljNGU3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9pbmRleGVkZGIvY2xpZW50L0lEQlJlcXVlc3RJbXBsLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9jbGllbnQvSURCUmVxdWVzdEltcGwuY3BwCkBAIC0y MzgsNiArMjM4LDggQEAgYm9vbCBJREJSZXF1ZXN0OjpkaXNwYXRjaEV2ZW50KEV2ZW50JiBldmVu dCkKIHsKICAgICBMT0coSW5kZXhlZERCLCAiSURCUmVxdWVzdDo6ZGlzcGF0Y2hFdmVudCAtICVz ICglcCkiLCBldmVudC50eXBlKCkuY2hhcmFjdGVyczgoKSwgdGhpcyk7CiAKKyAgICBBU1NFUlQo bV9oYXNQZW5kaW5nQWN0aXZpdHkpOworCiAgICAgaWYgKGV2ZW50LnR5cGUoKSAhPSBldmVudE5h bWVzKCkuYmxvY2tlZEV2ZW50KQogICAgICAgICBtX3JlYWR5U3RhdGUgPSBJREJSZXF1ZXN0UmVh ZHlTdGF0ZTo6RG9uZTsKIApAQCAtMjQ5LDE2ICsyNTEsMjIgQEAgYm9vbCBJREJSZXF1ZXN0Ojpk aXNwYXRjaEV2ZW50KEV2ZW50JiBldmVudCkKICAgICAgICAgdGFyZ2V0cy5hcHBlbmQobV90cmFu c2FjdGlvbi0+ZGIoKSk7CiAgICAgfQogCisgICAgbV9oYXNQZW5kaW5nQWN0aXZpdHkgPSBmYWxz ZTsKKwogICAgIGJvb2wgZG9udFByZXZlbnREZWZhdWx0OwogICAgIHsKICAgICAgICAgVHJhbnNh Y3Rpb25BY3RpdmF0b3IgYWN0aXZhdG9yKG1fdHJhbnNhY3Rpb24uZ2V0KCkpOwogICAgICAgICBk b250UHJldmVudERlZmF1bHQgPSBJREJFdmVudERpc3BhdGNoZXI6OmRpc3BhdGNoKGV2ZW50LCB0 YXJnZXRzKTsKICAgICB9CiAKLSAgICBpZiAobV90cmFuc2FjdGlvbiAmJiAhbV9wZW5kaW5nQ3Vy c29yKSB7CisgICAgLy8gSURCRXZlbnREaXNwYXRjaGVyOjpkaXNwYXRjaCgpIG1pZ2h0IGhhdmUg c2V0IHRoZSBwZW5kaW5nIGFjdGl2aXR5IGZsYWcgYmFjayB0byB0cnVlLCBzdWdnZXN0aW5nIHRo ZSByZXF1ZXN0IHdpbGwgYmUgcmV1c2VkLgorICAgIC8vIFdlIG1pZ2h0IGFsc28gcmUtdXNlIHRo ZSByZXF1ZXN0IGlmIHRoaXMgZXZlbnQgd2FzIHRoZSB1cGdyYWRlbmVlZGVkIGV2ZW50IGZvciBh biBJREJPcGVuREJSZXF1ZXN0LgorICAgIGlmICghbV9oYXNQZW5kaW5nQWN0aXZpdHkpCisgICAg ICAgIG1faGFzUGVuZGluZ0FjdGl2aXR5ID0gaXNPcGVuREJSZXF1ZXN0KCkgJiYgZXZlbnQudHlw ZSgpID09IGV2ZW50TmFtZXMoKS51cGdyYWRlbmVlZGVkRXZlbnQ7CisKKyAgICAvLyBUaGUgcmVx dWVzdCBzaG91bGQgb25seSByZW1haW4gaW4gdGhlIHRyYW5zYWN0aW9uJ3MgcmVxdWVzdCBsaXN0 IGlmIGl0IHJlcHJlc2VudHMgYSBwZW5kaW5nIGN1cnNvciBvcGVyYXRpb24uCisgICAgaWYgKG1f dHJhbnNhY3Rpb24gJiYgIW1fcGVuZGluZ0N1cnNvcikKICAgICAgICAgbV90cmFuc2FjdGlvbi0+ cmVtb3ZlUmVxdWVzdCgqdGhpcyk7Ci0gICAgICAgIG1faGFzUGVuZGluZ0FjdGl2aXR5ID0gZmFs c2U7Ci0gICAgfQogCiAgICAgcmV0dXJuIGRvbnRQcmV2ZW50RGVmYXVsdDsKIH0KQEAgLTMxNSw2 ICszMjMsNyBAQCB2b2lkIElEQlJlcXVlc3Q6OndpbGxJdGVyYXRlQ3Vyc29yKElEQkN1cnNvciYg Y3Vyc29yKQogICAgIEFTU0VSVCgmY3Vyc29yID09IHJlc3VsdEN1cnNvcigpKTsKIAogICAgIG1f cGVuZGluZ0N1cnNvciA9ICZjdXJzb3I7CisgICAgbV9oYXNQZW5kaW5nQWN0aXZpdHkgPSB0cnVl OwogICAgIG1fcmVzdWx0ID0gbnVsbHB0cjsKICAgICBtX3JlYWR5U3RhdGUgPSBJREJSZXF1ZXN0 UmVhZHlTdGF0ZTo6UGVuZGluZzsKICAgICBtX2RvbUVycm9yID0gbnVsbHB0cjsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL2NsaWVudC9JREJSZXF1ZXN0SW1w bC5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvY2xpZW50L0lEQlJlcXVlc3RJ bXBsLmgKaW5kZXggZDlhYzc1OS4uYTNjNDYwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9pbmRleGVkZGIvY2xpZW50L0lEQlJlcXVlc3RJbXBsLmgKKysrIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvY2xpZW50L0lEQlJlcXVlc3RJbXBsLmgKQEAgLTExMyw2 ICsxMTMsOCBAQCBwcm90ZWN0ZWQ6CiAgICAgdmlydHVhbCB2b2lkIHJlZkV2ZW50VGFyZ2V0KCkg b3ZlcnJpZGUgZmluYWwgeyBSZWZDb3VudGVkPElEQlJlcXVlc3Q+OjpyZWYoKTsgfQogICAgIHZp cnR1YWwgdm9pZCBkZXJlZkV2ZW50VGFyZ2V0KCkgb3ZlcnJpZGUgZmluYWwgeyBSZWZDb3VudGVk PElEQlJlcXVlc3Q+OjpkZXJlZigpOyB9CiAKKyAgICB2aXJ0dWFsIGJvb2wgaXNPcGVuREJSZXF1 ZXN0KCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KKwogICAgIElEQlJlcXVlc3RSZWFkeVN0YXRl IG1fcmVhZHlTdGF0ZSB7IElEQlJlcXVlc3RSZWFkeVN0YXRlOjpQZW5kaW5nIH07CiAgICAgUmVm UHRyPElEQkFueT4gbV9yZXN1bHQ7CiAgICAgUmVmUHRyPElEQlRyYW5zYWN0aW9uPiBtX3RyYW5z YWN0aW9uOwo=