151639 2015-11-27 22:06:10 -0800 Stop unnecessarily copying WKWebViewConfiguration in a few places 2015-11-28 13:30:20 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca commit-queue mitz sam simon.fraser oldest_to_newest 1144632 0 thorton 2015-11-27 22:06:10 -0800 Stop unnecessarily copying WKWebViewConfiguration in a few places 1144633 1 266211 thorton 2015-11-27 22:07:25 -0800 Created attachment 266211 Patch 1144635 2 266211 mitz 2015-11-27 22:47:12 -0800 Comment on attachment 266211 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266211&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h:31 > +#import "WKWebViewConfiguration.h" Is this for the enum below? 1144654 3 thorton 2015-11-28 12:43:30 -0800 (In reply to comment #2) > Comment on attachment 266211 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=266211&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h:31 > > +#import "WKWebViewConfiguration.h" > > Is this for the enum below? Correct. 1144658 4 266211 commit-queue 2015-11-28 13:30:18 -0800 Comment on attachment 266211 Patch Clearing flags on attachment: 266211 Committed r192786: <http://trac.webkit.org/changeset/192786> 1144659 5 commit-queue 2015-11-28 13:30:20 -0800 All reviewed patches have been landed. Closing bug. 266211 2015-11-27 22:07:25 -0800 2015-11-28 13:30:18 -0800 Patch bug-151639-20151127220705.patch text/plain 5827 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNzI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2I5OWY0ODgxOTFjYTIz MDYxZWQyMGQ3OGU4NzEzMzFkNDUxZTQ2MC4uNTUwYzE5MGYzZDk3NmM4N2YwMzZjYzAzMmNhNzY5 M2RjMTIyN2JjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSArMSwzMCBAQAorMjAxNS0xMS0yNyAgVGltIEhv cnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAgICAgICBTdG9wIHVubmVjZXNz YXJpbHkgY29weWluZyBXS1dlYlZpZXdDb25maWd1cmF0aW9uIGluIGEgZmV3IHBsYWNlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxNjM5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL0NvY29hL1dLV2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IGluaXRXaXRoRnJh bWU6Y29uZmlndXJhdGlvbjpdKToKKyAgICAgICAgKC1bV0tXZWJWaWV3IGRlYWxsb2NdKToKKyAg ICAgICAgKC1bV0tXZWJWaWV3IF9jb250ZW50UHJvdmlkZXJSZWdpc3RyeV0pOgorICAgICAgICAo LVtXS1dlYlZpZXcgX3NlbGVjdGlvbkdyYW51bGFyaXR5XSk6CisgICAgICAgICgtW1dLV2ViVmll dyBfc2V0SGFzQ3VzdG9tQ29udGVudFZpZXc6bG9hZGVkTUlNRVR5cGU6XSk6CisgICAgICAgICog VUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdJbnRlcm5hbC5oOgorICAgICAgICAqIFVJUHJv Y2Vzcy9pb3MvUGFnZUNsaWVudEltcGxJT1MubW06CisgICAgICAgIChXZWJLaXQ6OlBhZ2VDbGll bnRJbXBsOjptaW1lVHlwZXNXaXRoQ3VzdG9tQ29udGVudFByb3ZpZGVycyk6CisgICAgICAgICog VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dL Q29udGVudFZpZXcgc2V0dXBJbnRlcmFjdGlvbl0pOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3 IF9zdG9wQXNzaXN0aW5nS2V5Ym9hcmRdKToKKyAgICAgICAgTG9va2luZyBhdCBhbGxvY2F0aW9u IHRyYWNlcyBJIG5vdGljZWQgdGhhdCB3ZSB3ZXJlIG1ha2luZyB3YXkgbW9yZQorICAgICAgICBX S1dlYlZpZXdDb25maWd1cmF0aW9ucyB0aGFuIG1hZGUgc2Vuc2U7IGxvb2tpbmcgYXQgYmFja3Ry YWNlcyBJIGZvdW5kCisgICAgICAgIGEgZmV3IGludGVybmFsIGNhbGxlcnMgb2YgLVtXS1dlYlZp ZXcgY29uZmlndXJhdGlvbl0sIHdoaWNoIGNvcGllcyB0aGUKKyAgICAgICAgY29uZmlndXJhdGlv bi4gVGhlcmUncyBubyByZWFzb24gZm9yIHRoZXNlIGludGVybmFsIGNhbGxlcnMgdG8gbWFrZSAK KyAgICAgICAgc3VjaCBhIGNvcHksIHRob3VnaC4KKworICAgICAgICBJJ20gbm90IGV4YWN0bHkg c3VyZSB3aGF0IHRoZSB1c3VhbCBhcHByb2FjaCBpcyBoZXJlLCBidXQgSSBhZGRlZAorICAgICAg ICBnZXR0ZXJzIHNvIFdLQ29udGVudFZpZXdJbnRlcmFjdGlvbiBhbmQgUGFnZUNsaWVudEltcGxJ T1MgY2FuIGdldCB0bworICAgICAgICB0aGUgdmFsdWVzIHRoZXkncmUgbG9va2luZyBmb3Igd2l0 aG91dCB1c2luZyB0aGUgY29uZmlndXJhdGlvbiBwcm9wZXJ0eS4KKwogPT0gUm9sbGVkIG92ZXIg dG8gQ2hhbmdlTG9nLTIwMTUtMTEtMjEgPT0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KaW5kZXggYzBiZDFjMGQ1N2M3ZDllMzg1Zjc1YzQ4NmJh ZDgwYTNiNzE1ZWEzMi4uZGZmYzVjOWIxYzU3NWVhZmIzNTE1MWExYmY5YjQ3MjVmYWM3OWU0ZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcu bW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0K QEAgLTgwNSw2ICs4MDUsMTYgQEAgc3RhdGljIENHU2l6ZSByb3VuZFNjcm9sbFZpZXdDb250ZW50 U2l6ZShjb25zdCBXZWJLaXQ6OldlYlBhZ2VQcm94eSYgcGFnZSwgQ0dTaXoKICAgICByZXR1cm4g X2N1c3RvbUNvbnRlbnRWaWV3ID8gX2N1c3RvbUNvbnRlbnRWaWV3LmdldCgpIDogX2NvbnRlbnRW aWV3LmdldCgpOwogfQogCistIChXS1dlYlZpZXdDb250ZW50UHJvdmlkZXJSZWdpc3RyeSAqKV9j b250ZW50UHJvdmlkZXJSZWdpc3RyeQoreworICAgIHJldHVybiBbX2NvbmZpZ3VyYXRpb24gX2Nv bnRlbnRQcm92aWRlclJlZ2lzdHJ5XTsKK30KKworLSAoV0tTZWxlY3Rpb25HcmFudWxhcml0eSlf c2VsZWN0aW9uR3JhbnVsYXJpdHkKK3sKKyAgICByZXR1cm4gW19jb25maWd1cmF0aW9uIHNlbGVj dGlvbkdyYW51bGFyaXR5XTsKK30KKwogLSAodm9pZClfc2V0SGFzQ3VzdG9tQ29udGVudFZpZXc6 KEJPT0wpcGFnZUhhc0N1c3RvbUNvbnRlbnRWaWV3IGxvYWRlZE1JTUVUeXBlOihjb25zdCBXVEY6 OlN0cmluZyYpbWltZVR5cGUKIHsKICAgICBpZiAocGFnZUhhc0N1c3RvbUNvbnRlbnRWaWV3KSB7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll d0ludGVybmFsLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll d0ludGVybmFsLmgKaW5kZXggOTUwN2RjOTMzN2Y2MTU0NmE2MzQ5MmNjYmQyODEyNmM0MzM5Njdi My4uYWZhMzk4Y2E3ZGE4MGRjOTdkOTBlYzZiMzI2ZmIyMWVjMzkwMTkxNyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdJbnRlcm5hbC5oCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3SW50ZXJuYWwu aApAQCAtMjgsNiArMjgsNyBAQAogI2lmIFdLX0FQSV9FTkFCTEVECiAKICNpbXBvcnQgIlNhbWVE b2N1bWVudE5hdmlnYXRpb25UeXBlLmgiCisjaW1wb3J0ICJXS1dlYlZpZXdDb25maWd1cmF0aW9u LmgiCiAjaW1wb3J0IDx3dGYvUmVmUHRyLmg+CiAjaW1wb3J0IDx3dGYvUmV0YWluUHRyLmg+CiAK QEAgLTU0LDYgKzU1LDcgQEAgY2xhc3MgV2ViUGFnZVByb3h5Owogc3RydWN0IFByaW50SW5mbzsK IH0KIAorQGNsYXNzIFdLV2ViVmlld0NvbnRlbnRQcm92aWRlclJlZ2lzdHJ5OwogQGNsYXNzIF9X S0ZyYW1lSGFuZGxlOwogCiBAaW50ZXJmYWNlIFdLV2ViVmlldyAoKSBXS19XRUJfVklFV19QUk9U T0NPTFMgewpAQCAtMTA5LDYgKzExMSwxMCBAQCBzdHJ1Y3QgUHJpbnRJbmZvOwogLSAodm9pZClf bmF2aWdhdGlvbkdlc3R1cmVEaWRCZWdpbjsKIC0gKHZvaWQpX25hdmlnYXRpb25HZXN0dXJlRGlk RW5kOwogCitAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIFdLV2ViVmlld0NvbnRlbnRQ cm92aWRlclJlZ2lzdHJ5ICpfY29udGVudFByb3ZpZGVyUmVnaXN0cnk7CisKK0Bwcm9wZXJ0eSAo bm9uYXRvbWljLCByZWFkb25seSkgV0tTZWxlY3Rpb25HcmFudWxhcml0eSBfc2VsZWN0aW9uR3Jh bnVsYXJpdHk7CisKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkgQk9PTCBfYWxsb3dz RG91YmxlVGFwR2VzdHVyZXM7CiBAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIFVJRWRn ZUluc2V0cyBfY29tcHV0ZWRDb250ZW50SW5zZXQ7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvUGFnZUNsaWVudEltcGxJT1MubW0gYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvaW9zL1BhZ2VDbGllbnRJbXBsSU9TLm1tCmluZGV4IDUzZmY1ZjM5ZjYw YjM2MGRhNzMwZDc4ZDAwZjEwNDNkZDcxN2U5ZmMuLjdmYmY1MjdiMmMyMjhmYWMyZTQ0NTdlZTk2 YTY4ZWYwYzlmMDY3ZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3Mv UGFnZUNsaWVudEltcGxJT1MubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9Q YWdlQ2xpZW50SW1wbElPUy5tbQpAQCAtNjgxLDcgKzY4MSw3IEBAIHZvaWQgUGFnZUNsaWVudElt cGw6OmRpZEZpbmlzaERyYXdpbmdQYWdlc1RvUERGKGNvbnN0IElQQzo6RGF0YVJlZmVyZW5jZSYg cGRmRGF0CiAKIFZlY3RvcjxTdHJpbmc+IFBhZ2VDbGllbnRJbXBsOjptaW1lVHlwZXNXaXRoQ3Vz dG9tQ29udGVudFByb3ZpZGVycygpCiB7Ci0gICAgcmV0dXJuIG1fd2ViVmlldy5jb25maWd1cmF0 aW9uLl9jb250ZW50UHJvdmlkZXJSZWdpc3RyeS5fbWltZVR5cGVzV2l0aEN1c3RvbUNvbnRlbnRQ cm92aWRlcnM7CisgICAgcmV0dXJuIG1fd2ViVmlldy5fY29udGVudFByb3ZpZGVyUmVnaXN0cnku X21pbWVUeXBlc1dpdGhDdXN0b21Db250ZW50UHJvdmlkZXJzOwogfQogCiB2b2lkIFBhZ2VDbGll bnRJbXBsOjpuYXZpZ2F0aW9uR2VzdHVyZURpZEJlZ2luKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXgg OWFkMDkxNzEyZjg5YWJkZmYyYjIyODY3MWVmMTQ2OTA4NDk1NDQxOS4uYjFkOTg0MDdmYWU4ZmZi NTIxNGEzM2YyNTgzMjE1NWJkYjFiY2I2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KQEAgLTQ4NCw3ICs0 ODQsNyBAQCBzdGF0aWMgVUlXZWJTZWxlY3Rpb25Nb2RlIHRvVUlXZWJTZWxlY3Rpb25Nb2RlKFdL U2VsZWN0aW9uR3JhbnVsYXJpdHkgZ3JhbnVsYXJpdAogICAgIF9zaG93aW5nVGV4dFN0eWxlT3B0 aW9ucyA9IE5POwogCiAgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIGJlIGNhbGxlZCB3aGVuIHdl IGdldCBub3RpZmllZCB0aGF0IGxvYWRpbmcgaGFzIGNvbXBsZXRlZC4KLSAgICBbc2VsZiB1c2VT ZWxlY3Rpb25Bc3Npc3RhbnRXaXRoTW9kZTp0b1VJV2ViU2VsZWN0aW9uTW9kZShbW193ZWJWaWV3 IGNvbmZpZ3VyYXRpb25dIHNlbGVjdGlvbkdyYW51bGFyaXR5XSldOworICAgIFtzZWxmIHVzZVNl bGVjdGlvbkFzc2lzdGFudFdpdGhNb2RlOnRvVUlXZWJTZWxlY3Rpb25Nb2RlKFtfd2ViVmlldyBf c2VsZWN0aW9uR3JhbnVsYXJpdHldKV07CiAgICAgCiAgICAgX2FjdGlvblNoZWV0QXNzaXN0YW50 ID0gYWRvcHROUyhbW1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQgYWxsb2NdIGluaXRXaXRoVmlldzpz ZWxmXSk7CiAgICAgW19hY3Rpb25TaGVldEFzc2lzdGFudCBzZXREZWxlZ2F0ZTpzZWxmXTsKQEAg LTMxNzksNyArMzE3OSw3IEBAIHN0YXRpYyBVSVRleHRBdXRvY2FwaXRhbGl6YXRpb25UeXBlIHRv VUlUZXh0QXV0b2NhcGl0YWxpemUoV2ViQXV0b2NhcGl0YWxpemVUeXBlCiAKIC0gKHZvaWQpX3N0 b3BBc3Npc3RpbmdLZXlib2FyZAogewotICAgIFtzZWxmIHVzZVNlbGVjdGlvbkFzc2lzdGFudFdp dGhNb2RlOnRvVUlXZWJTZWxlY3Rpb25Nb2RlKFtbX3dlYlZpZXcgY29uZmlndXJhdGlvbl0gc2Vs ZWN0aW9uR3JhbnVsYXJpdHldKV07CisgICAgW3NlbGYgdXNlU2VsZWN0aW9uQXNzaXN0YW50V2l0 aE1vZGU6dG9VSVdlYlNlbGVjdGlvbk1vZGUoW193ZWJWaWV3IF9zZWxlY3Rpb25HcmFudWxhcml0 eV0pXTsKIH0KIAogLSAoY29uc3QgQXNzaXN0ZWROb2RlSW5mb3JtYXRpb24mKWFzc2lzdGVkTm9k ZUluZm9ybWF0aW9uCg==