151623 2015-11-26 06:05:22 -0800 [GTK] Do not use the WebCore garbage collector timer 2015-11-27 00:38:05 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply mrobinson zan oldest_to_newest 1144501 0 cgarcia 2015-11-26 06:05:22 -0800 Now that garbage collector timers have been implemented in JavaScriptCore for glib, we don't need to use another Timer in WebCore. 1144502 1 266183 cgarcia 2015-11-26 06:08:05 -0800 Created attachment 266183 Patch 1144559 2 266183 mrobinson 2015-11-27 00:20:04 -0800 Comment on attachment 266183 Patch Looks like EFL needs this patch as well. 1144560 3 cgarcia 2015-11-27 00:29:08 -0800 Yes, actually, this works for EFL because USE(GLIB) is true for them 1144561 4 mrobinson 2015-11-27 00:30:42 -0800 (In reply to comment #3) > Yes, actually, this works for EFL because USE(GLIB) is true for them Oh, you are right. I had forgotten that. 1144562 5 cgarcia 2015-11-27 00:38:05 -0800 Committed r192775: <http://trac.webkit.org/changeset/192775> 266183 2015-11-26 06:08:05 -0800 2015-11-27 00:20:04 -0800 Patch wcore-gc-timer.diff text/plain 2338 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMzkzZGE3Li5kNjBlZjI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTUtMTEtMjYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIERvIG5vdCB1c2UgdGhlIFdlYkNvcmUgZ2FyYmFnZSBjb2xsZWN0 b3IgdGltZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE1MTYyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE5vdyB0aGF0IGdhcmJhZ2UgY29sbGVjdG9yIHRpbWVycyBoYXZlIGJlZW4gaW1wbGVtZW50ZWQg aW4KKyAgICAgICAgSmF2YVNjcmlwdENvcmUgZm9yIGdsaWIsIHdlIGRvbid0IG5lZWQgdG8gdXNl IGFub3RoZXIgVGltZXIgaW4gV2ViQ29yZS4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0dDQ29u dHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHQ0NvbnRyb2xsZXI6OmdhcmJhZ2VDb2xs ZWN0U29vbik6CisgICAgICAgIChXZWJDb3JlOjpHQ0NvbnRyb2xsZXI6OmdhcmJhZ2VDb2xsZWN0 Tm93SWZOb3REb25lUmVjZW50bHkpOgorCiAyMDE1LTExLTE4ICBBbmR5IEVzdGVzICA8YWVzdGVz QGFwcGxlLmNvbT4KIAogICAgICAgICBbQ29udGVudCBGaWx0ZXJpbmddIENyYXNoIGluIERvY3Vt ZW50TG9hZGVyOjpub3RpZnlGaW5pc2hlZCgpIHdoZW4gYWxsb3dpbmcgYSBtZWRpYSBkb2N1bWVu dCB0byBsb2FkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9HQ0NvbnRy b2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvR0NDb250cm9sbGVyLmNwcApp bmRleCBhM2YwYTg2Li5jNjc5MTdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9HQ0NvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0dD Q29udHJvbGxlci5jcHAKQEAgLTU3LDEyICs1NywxMCBAQCBHQ0NvbnRyb2xsZXI6OkdDQ29udHJv bGxlcigpCiAKIHZvaWQgR0NDb250cm9sbGVyOjpnYXJiYWdlQ29sbGVjdFNvb24oKQogewotICAg IC8vIFdlIG9ubHkgdXNlIHJlcG9ydEFiYW5kb25lZE9iamVjdEdyYXBoIG9uIHN5c3RlbXMgd2l0 aCBDb3JlRm91bmRhdGlvbiAKLSAgICAvLyBzaW5jZSBpdCB1c2VzIGEgcnVuLWxvb3AtYmFzZWQg dGltZXIgdGhhdCBpcyBjdXJyZW50bHkgb25seSBhdmFpbGFibGUgb24KLSAgICAvLyBzeXN0ZW1z IHdpdGggQ29yZUZvdW5kYXRpb24uIElmIGFuZCB3aGVuIHRoZSBub3Rpb24gb2YgYSBydW4gbG9v cCBpcyBwdXNoZWQgCi0gICAgLy8gZG93biBpbnRvIFdURiBzbyB0aGF0IG1vcmUgcGxhdGZvcm1z IGNhbiB0YWtlIGFkdmFudGFnZSBvZiBpdCwgd2Ugd2lsbCBiZSAKLSAgICAvLyBhYmxlIHRvIHVz ZSByZXBvcnRBYmFuZG9uZWRPYmplY3RHcmFwaCBvbiBtb3JlIHBsYXRmb3Jtcy4KLSNpZiBVU0Uo Q0YpCisgICAgLy8gV2Ugb25seSB1c2UgcmVwb3J0QWJhbmRvbmVkT2JqZWN0R3JhcGggZm9yIHN5 c3RlbXMgZm9yIHdoaWNoIHRoZXJlJ3MgYW4gaW1wbGVtZW50YXRpb24KKyAgICAvLyBvZiB0aGUg Z2FyYmFnZSBjb2xsZWN0b3IgdGltZXJzIGluIEphdmFTY3JpcHRDb3JlLiBXZSB3b3VsZG4ndCBu ZWVkIHRoaXMgaWYgSmF2YVNjcmlwdENvcmUKKyAgICAvLyB1c2VkIGEgdGltZXIgaW1wbGVtZW50 YXRpb24gZnJvbSBXVEYgbGlrZSBSdW5Mb29wOjpUaW1lci4KKyNpZiBVU0UoQ0YpIHx8IFVTRShH TElCKQogICAgIEpTTG9ja0hvbGRlciBsb2NrKEpTRE9NV2luZG93Ojpjb21tb25WTSgpKTsKICAg ICBKU0RPTVdpbmRvdzo6Y29tbW9uVk0oKS5oZWFwLnJlcG9ydEFiYW5kb25lZE9iamVjdEdyYXBo KCk7CiAjZWxzZQpAQCAtOTIsNyArOTAsNyBAQCB2b2lkIEdDQ29udHJvbGxlcjo6Z2FyYmFnZUNv bGxlY3ROb3coKQogCiB2b2lkIEdDQ29udHJvbGxlcjo6Z2FyYmFnZUNvbGxlY3ROb3dJZk5vdERv bmVSZWNlbnRseSgpCiB7Ci0jaWYgVVNFKENGKQorI2lmIFVTRShDRikgfHwgVVNFKEdMSUIpCiAg ICAgSlNMb2NrSG9sZGVyIGxvY2soSlNET01XaW5kb3c6OmNvbW1vblZNKCkpOwogICAgIGlmICgh SlNET01XaW5kb3c6OmNvbW1vblZNKCkuaGVhcC5pc0J1c3koKSkKICAgICAgICAgSlNET01XaW5k b3c6OmNvbW1vblZNKCkuaGVhcC5jb2xsZWN0QWxsR2FyYmFnZUlmTm90RG9uZVJlY2VudGx5KCk7 Cg==