151621 2015-11-26 05:45:11 -0800 Use mark pragmas only if it is supported 2015-12-14 04:56:13 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 152248 1 ossy ossy ap benjamin commit-queue fpizlo ggaren keith_miller mark.lam msaboff ossy saam oldest_to_newest 1144496 0 ossy 2015-11-26 05:45:11 -0800 build log: ----------- ../../Source/JavaScriptCore/b3/air/AirIteratedRegisterCoalescing.cpp:687:0: error: ignoring #pragma mark [-Werror=unknown-pragmas] ../../Source/JavaScriptCore/b3/air/AirIteratedRegisterCoalescing.cpp:721:0: error: ignoring #pragma mark [-Werror=unknown-pragmas] mark pragma is an OS X only feature, we shouldn't use them unconditionally. 1144500 1 266182 ossy 2015-11-26 06:01:26 -0800 Created attachment 266182 Patch 1144508 2 266182 mark.lam 2015-11-26 06:45:39 -0800 Comment on attachment 266182 Patch r=me 1144518 3 ap 2015-11-26 07:30:42 -0800 What does Cocoa have to do with pragmas? Is this how we usually conditionalize these? 1144519 4 ossy 2015-11-26 08:14:37 -0800 (In reply to comment #3) > What does Cocoa have to do with pragmas? This pragma is for Xcode, that's why GCC on Linux doesn't know what to with it. http://iosdevelopertips.com/xcode/xcode-and-pragma-mark.html > Is this how we usually conditionalize these? It is the first and only occurence of this pragma in platform independent code. 1144520 5 mark.lam 2015-11-26 08:16:53 -0800 (In reply to comment #3) > What does Cocoa have to do with pragmas? Is this how we usually > conditionalize these? "#if PLATFORM(COCOA)" here is more like a pseudonym for "#if PLATFORM(MAC) || PLATFORM(IOS)". The pragma appears to only be supported by Xcode, and hence maybe by Clang in general? I would have suggested "#if COMPILER(CLANG)" except I'm not sure if Clang on linux also supports this pragma. Ossy, can you try "#if COMPILER(CLANG)" and then building on linux with Clang? 1144526 6 ossy 2015-11-26 08:59:04 -0800 (In reply to comment #5) > (In reply to comment #3) > > What does Cocoa have to do with pragmas? Is this how we usually > > conditionalize these? > > "#if PLATFORM(COCOA)" here is more like a pseudonym for "#if PLATFORM(MAC) > || PLATFORM(IOS)". The pragma appears to only be supported by Xcode, and > hence maybe by Clang in general? I would have suggested "#if > COMPILER(CLANG)" except I'm not sure if Clang on linux also supports this > pragma. > > Ossy, can you try "#if COMPILER(CLANG)" and then building on linux with > Clang? Using COMPILER(CLANG) instead of PLATFORM(COCOA) would be very confusing. As far as I know "#pragma mark" is useful for only Xcode users which is same as PLATFORM(COCOA) ( == #if PLATFORM(MAC) || PLATFORM(IOS) ). I checked, Clang simply ignores this pragma on Linux too since an Apple employee hacked it into Clang - https://github.com/llvm-mirror/clang/commit/2243449253475574fc6f14986ff8f7fce5d46799 . Not to mention that pragmas are compiler directives originally, but Apple uses it for other purposes ... 1144578 7 266182 commit-queue 2015-11-27 05:02:04 -0800 Comment on attachment 266182 Patch Clearing flags on attachment: 266182 Committed r192778: <http://trac.webkit.org/changeset/192778> 1144579 8 commit-queue 2015-11-27 05:02:09 -0800 All reviewed patches have been landed. Closing bug. 1144608 9 ap 2015-11-27 14:03:29 -0800 A less misleading way to deal with this is to use #if 0 and #endif around the pragma. Alternatively, this style of comment is also recognized by Xcode: "// MARK: ..." The downside is that "MARK: " is also displayed in Xcode's function name menu then. 266182 2015-11-26 06:01:26 -0800 2015-11-27 05:02:04 -0800 Patch bug-151621-20151126150108.patch text/plain 1550 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 NDRkNzZiNzBkZjdhNGIyN2Q0YmI4OTVhYTg1ZTM5NWE5MWE3MDNlLi42MDU5MmZjOWE5NzJmMmRj MjQzMTdhMDI0MjMwNzZlMjM1OTM5ZDBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNS0xMS0yNiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIFVzZSBtYXJrIHByYWdtYXMgb25seSBpZiBpdCBpcyBzdXBwb3J0ZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTYyMQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYjMvYWly L0Fpckl0ZXJhdGVkUmVnaXN0ZXJDb2FsZXNjaW5nLmNwcDoKKwogMjAxNS0xMS0yNCAgQ2FpdGxp biBQb3R0ZXIgIDxjYWl0cEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtKU0NdIHN1cHBvcnQgQ29t cHV0ZWQgUHJvcGVydHkgTmFtZXMgaW4gZGVzdHJ1Y3R1cmluZyBQYXR0ZXJucwpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL2Fpci9BaXJJdGVyYXRlZFJlZ2lzdGVyQ29hbGVz Y2luZy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fpckl0ZXJhdGVkUmVnaXN0 ZXJDb2FsZXNjaW5nLmNwcAppbmRleCA4ZWY4ZDE3NWE5MGI4NjYyNWE1ZmY1OWRhMTRlN2MyZTFh NzI4MWY2Li4xY2QwODY5NGQ3MDk4YzM5MDA4MmUwNDAzYWVkNmM2MGYyYjk1MTg3IDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fpckl0ZXJhdGVkUmVnaXN0ZXJDb2Fs ZXNjaW5nLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fpckl0ZXJhdGVk UmVnaXN0ZXJDb2FsZXNjaW5nLmNwcApAQCAtNjg0LDcgKzY4NCw5IEBAIHByaXZhdGU6CiAgICAg ICAgICAgICBtX2NvbG9yZWRUbXAuY2xlYXIoKTsKICAgICB9CiAKKyNpZiBQTEFURk9STShDT0NP QSkKICNwcmFnbWEgbWFyayAtIERlYnVnZ2luZyBoZWxwZXJzLgorI2VuZGlmCiAKICAgICB2b2lk IGR1bXBJbnRlcmZlcmVuY2VHcmFwaEluRG90KFByaW50U3RyZWFtJiBvdXQpCiAgICAgewpAQCAt NzE4LDcgKzcyMCw5IEBAIHByaXZhdGU6CiAgICAgICAgICAgICBvdXQucHJpbnQoIiAgICAiLCB0 bXAsICJcbiIpOwogICAgIH0KIAorI2lmIFBMQVRGT1JNKENPQ09BKQogI3ByYWdtYSBtYXJrIC0K KyNlbmRpZgogCiAgICAgLy8gSW50ZXJmZXJlbmNlIGVkZ2VzIGFyZSBub3QgZGlyZWN0ZWQuIEFu IGVkZ2UgYmV0d2VlbiBhbnkgdHdvIFRtcHMgaXMgcmVwcmVzZW50ZWQKICAgICAvLyBieSB0aGUg Y29uY2F0ZW5hdGVkIHZhbHVlcyBvZiB0aGUgc21hbGxlc3QgVG1wIGZvbGxvd2VkIGJ5IHRoZSBi aWdnZXIgVG1wLgo=