151616 2015-11-26 04:15:45 -0800 Fix the !ENABLE(DFG_JIT) build after r192699 2015-11-30 22:59:02 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED P1 Critical --- 150762 1 ossy ossy commit-queue fpizlo ggaren keith_miller mark.lam msaboff saam oldest_to_newest 1144484 0 ossy 2015-11-26 04:15:45 -0800 build error log: ----------------- ../../Source/JavaScriptCore/assembler/MacroAssembler.h: In member function 'void JSC::MacroAssembler::moveDoubleConditionallyTest32(JSC::MacroAssemblerX86Common::ResultCondition, TestType, MaskType, JSC::AbstractMacroAssembler<JSC::X86Assembler, JSC::MacroAssemblerX86Common>::FPRegisterID, JSC::AbstractMacroAssembler<JSC::X86Assembler, JSC::MacroAssemblerX86Common>::FPRegisterID)': ../../Source/JavaScriptCore/assembler/MacroAssembler.h:1323:30: error: there are no arguments to 'isInvertible' that depend on a template parameter, so a declaration of 'isInvertible' must be available [-fpermissive] ../../Source/JavaScriptCore/assembler/MacroAssembler.h:1323:30: note: (if you use '-fpermissive', G++ will accept your code, but allowing the use of an undeclared name is deprecated) ../../Source/JavaScriptCore/assembler/MacroAssembler.h:1324:54: error: no matching function for call to 'JSC::MacroAssembler::invert(JSC::MacroAssemblerX86Common::ResultCondition&)' The problem is that isInvertible() is defined inside ENABLE(DFG_JIT) guards, but used without guard: - http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/assembler/MacroAssembler.h?rev=192699#L175 - http://trac.webkit.org/changeset/192699/trunk/Source/JavaScriptCore/assembler/MacroAssembler.h But the new moveDoubleConditionally*() functions are used only in B3 JIT, let's guard them. 1144485 1 266176 ossy 2015-11-26 04:16:59 -0800 Created attachment 266176 Patch 1145150 2 266176 commit-queue 2015-11-30 22:58:57 -0800 Comment on attachment 266176 Patch Clearing flags on attachment: 266176 Committed r192862: <http://trac.webkit.org/changeset/192862> 1145151 3 commit-queue 2015-11-30 22:59:02 -0800 All reviewed patches have been landed. Closing bug. 266176 2015-11-26 04:16:59 -0800 2015-11-30 22:58:57 -0800 Patch bug-151616-20151126131641.patch text/plain 1417 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 NDRkNzZiNzBkZjdhNGIyN2Q0YmI4OTVhYTg1ZTM5NWE5MWE3MDNlLi4yNzI3YTNlMjhlZTJhOWI5 ZjQ4ZGFhMDYzNWY5MWU1ZjdhZjZkZGQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNS0xMS0yNiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIEZpeCB0aGUgIUVOQUJMRShERkdfSklUKSBidWlsZCBhZnRlciByMTky Njk5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE2 MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFz c2VtYmxlci9NYWNyb0Fzc2VtYmxlci5oOgorCiAyMDE1LTExLTI0ICBDYWl0bGluIFBvdHRlciAg PGNhaXRwQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0pTQ10gc3VwcG9ydCBDb21wdXRlZCBQcm9w ZXJ0eSBOYW1lcyBpbiBkZXN0cnVjdHVyaW5nIFBhdHRlcm5zCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyLmggYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyLmgKaW5kZXggZDZiYTBmYzQyYTk4YTA1 NmY5NDQ4Y2Y0MTdiZmIzZDUxODM2MGRjOS4uZjczNDNmZjE0ODUzNTJiN2U5MjkwMWE4NzEyMThh ODc4ZWRkMmIyNyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N YWNyb0Fzc2VtYmxlci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFj cm9Bc3NlbWJsZXIuaApAQCAtMTMwMSw2ICsxMzAxLDcgQEAgcHVibGljOgogCiAjZW5kaWYgLy8g IUNQVShYODZfNjQpCiAKKyNpZiBFTkFCTEUoQjNfSklUKQogICAgIHRlbXBsYXRlPHR5cGVuYW1l IExlZnRUeXBlLCB0eXBlbmFtZSBSaWdodFR5cGU+CiAgICAgdm9pZCBtb3ZlRG91YmxlQ29uZGl0 aW9uYWxseTMyKFJlbGF0aW9uYWxDb25kaXRpb24gY29uZCwgTGVmdFR5cGUgbGVmdCwgUmlnaHRU eXBlIHJpZ2h0LCBGUFJlZ2lzdGVySUQgc3JjLCBGUFJlZ2lzdGVySUQgZGVzdCkKICAgICB7CkBA IC0xMzU1LDYgKzEzNTYsNyBAQCBwdWJsaWM6CiAgICAgICAgIG1vdmVEb3VibGUoc3JjLCBkZXN0 KTsKICAgICAgICAgZmFsc2VDYXNlLmxpbmsodGhpcyk7CiAgICAgfQorI2VuZGlmCiAKICAgICB2 b2lkIGxlYShBZGRyZXNzIGFkZHJlc3MsIFJlZ2lzdGVySUQgZGVzdCkKICAgICB7Cg==