151577 2015-11-23 17:13:05 -0800 Web Inspector: Cmd-1 to Cmd-9 shortcuts should select tabs by ordinal 2015-12-01 11:51:31 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1144248 0 bburg 2015-11-23 17:13:05 -0800 This would be cool, and match other tab contexts in browsers. 1144249 1 webkit-bug-importer 2015-11-23 17:13:17 -0800 <rdar://problem/23652019> 1144263 2 266108 bburg 2015-11-23 20:03:20 -0800 Created attachment 266108 Proposed Fix 1144357 3 266108 commit-queue 2015-11-24 10:22:11 -0800 Comment on attachment 266108 Proposed Fix Clearing flags on attachment: 266108 Committed r192764: <http://trac.webkit.org/changeset/192764> 1144358 4 commit-queue 2015-11-24 10:22:14 -0800 All reviewed patches have been landed. Closing bug. 1145316 5 266108 joepeck 2015-12-01 11:51:31 -0800 Comment on attachment 266108 Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=266108&action=review > Source/WebInspectorUI/UserInterface/Base/Main.js:1860 > + event.preventDefault(); Is this needed? I think the KeyboardShortcut implicitly prevents defaults by default. 266108 2015-11-23 20:03:20 -0800 2015-11-24 10:22:11 -0800 Proposed Fix bug-151577-20151123200304.patch text/plain 2657 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNzU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAx NTk1MDVkYThlOGFlZDMxY2YxNjE1MDE5NGJkOWIwMDliYTQ4MzJiLi5jMjU4YzNmY2FiNTJhMDAy MmI0ZTlkMGQ0MzkzZDZhYTFmNTExNzE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNyBAQAogMjAxNS0xMS0yMyAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBDbWQtMSB0byBDbWQtOSBzaG9ydGN1dHMgc2hvdWxkIHNl bGVjdCB0YWJzIGJ5IG9yZGluYWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1MTU3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoZSBzaG9ydGN1dHMgb25seSB3b3JrIGlmIGEgdGFiIGF0IHRoZSBzcGVj aWZpZWQgb3JkaW5hbCBleGlzdHMuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvTWFp bi5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5jb250ZW50TG9hZGVkKToKKworMjAxNS0xMS0y MyAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9y OiBBZGQgYSBrZXlib2FyZCBzaG9ydGN1dCB0byByZXN0b3JlIHRoZSBkZWZhdWx0IHpvb20gbGV2 ZWwKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTIz NwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNl L01haW4uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4u anMKaW5kZXggMmM4ZTY5MjY5NTRjMTVkM2RlYzI3NzY2MzE4ZDVkZmI0YmZlNDgyOC4uMzJkMmEz MGVjNmQ2NjBjYzVhNTQxYTZlOTUwNTUxZWNiMzllNmE4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwpAQCAtMjUxLDYgKzI1MSw4IEBA IFdlYkluc3BlY3Rvci5jb250ZW50TG9hZGVkID0gZnVuY3Rpb24oKQogICAgIHRoaXMuX2RlY3Jl YXNlWm9vbUtleWJvYXJkU2hvcnRjdXQgPSBuZXcgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRj dXQoV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuQ29tbWFuZE9yQ29udHJv bCwgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuS2V5Lk1pbnVzLCB0aGlzLl9kZWNyZWFz ZVpvb20uYmluZCh0aGlzKSk7CiAgICAgdGhpcy5fcmVzZXRab29tS2V5Ym9hcmRTaG9ydGN1dCA9 IG5ldyBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRT aG9ydGN1dC5Nb2RpZmllci5Db21tYW5kT3JDb250cm9sLCAiMCIsIHRoaXMuX3Jlc2V0Wm9vbS5i aW5kKHRoaXMpKTsKIAorICAgIHRoaXMuX3Nob3dUYWJBdEluZGV4S2V5Ym9hcmRTaG9ydGN1dHMg PSBbMSwgMiwgMywgNCwgNSwgNiwgNywgOCwgOV0ubWFwKChpKSA9PiBuZXcgV2ViSW5zcGVjdG9y LktleWJvYXJkU2hvcnRjdXQoV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIu Q29tbWFuZE9yQ29udHJvbCwgYCR7aX1gLCB0aGlzLl9zaG93VGFiQXRJbmRleC5iaW5kKHRoaXMs IGkpKSk7CisKICAgICB0aGlzLnRhYkJyb3dzZXIgPSBuZXcgV2ViSW5zcGVjdG9yLlRhYkJyb3dz ZXIoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRhYi1icm93c2VyIiksIHRoaXMudGFiQmFyLCB0 aGlzLm5hdmlnYXRpb25TaWRlYmFyLCB0aGlzLmRldGFpbHNTaWRlYmFyKTsKICAgICB0aGlzLnRh YkJyb3dzZXIuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuVGFiQnJvd3Nlci5FdmVudC5T ZWxlY3RlZFRhYkNvbnRlbnRWaWV3RGlkQ2hhbmdlLCB0aGlzLl90YWJCcm93c2VyU2VsZWN0ZWRU YWJDb250ZW50Vmlld0RpZENoYW5nZSwgdGhpcyk7CiAKQEAgLTE4NTEsNiArMTg1MywxMyBAQCBX ZWJJbnNwZWN0b3IuX3Jlc2V0Wm9vbSA9IGZ1bmN0aW9uKGV2ZW50KSB7CiAgICAgZXZlbnQucHJl dmVudERlZmF1bHQoKTsKIH07CiAKK1dlYkluc3BlY3Rvci5fc2hvd1RhYkF0SW5kZXggPSBmdW5j dGlvbihpLCBldmVudCkgeworICAgIGlmIChpIDw9IFdlYkluc3BlY3Rvci50YWJCYXIudGFiQmFy SXRlbXMubGVuZ3RoKQorICAgICAgICBXZWJJbnNwZWN0b3IudGFiQmFyLnNlbGVjdGVkVGFiQmFy SXRlbSA9IGkgLSAxOworCisgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKK30KKwogV2ViSW5z cGVjdG9yLmVsZW1lbnREcmFnU3RhcnQgPSBmdW5jdGlvbihlbGVtZW50LCBkaXZpZGVyRHJhZywg ZWxlbWVudERyYWdFbmQsIGV2ZW50LCBjdXJzb3IsIGV2ZW50VGFyZ2V0KQogewogICAgIGlmIChX ZWJJbnNwZWN0b3IuX2VsZW1lbnREcmFnZ2luZ0V2ZW50TGlzdGVuZXIgfHwgV2ViSW5zcGVjdG9y Ll9lbGVtZW50RW5kRHJhZ2dpbmdFdmVudExpc3RlbmVyKQo=