151572 2015-11-23 14:01:07 -0800 Web Inspector: use Cmd-Option-L and Cmd-Option-R for toggling navigation and details sidebars 2015-11-28 15:23:39 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 151237 1 bburg bburg bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1144218 0 bburg 2015-11-23 14:01:07 -0800 We currently use Cmd-0 and Cmd-Option-0, but these don't match Safari's shortcuts and conflict with Cmd-0 as "Reset Page Zoom". 1144219 1 webkit-bug-importer 2015-11-23 14:01:20 -0800 <rdar://problem/23650902> 1144220 2 266098 bburg 2015-11-23 14:03:56 -0800 Created attachment 266098 Proposed Fix 1144254 3 266098 commit-queue 2015-11-23 18:43:44 -0800 Comment on attachment 266098 Proposed Fix Clearing flags on attachment: 266098 Committed r192755: <http://trac.webkit.org/changeset/192755> 1144255 4 commit-queue 2015-11-23 18:43:47 -0800 All reviewed patches have been landed. Closing bug. 1144624 5 nvasilyev 2015-11-27 20:33:22 -0800 Command-Option-R toggles responsive design mode in Safari. Now, pressing Command-Option-R once enters responsive design mode. Pressing it again, toggles the right sidebar. https://cloudup.com/c-qJT91xLhK 1144663 6 bburg 2015-11-28 15:23:39 -0800 (In reply to comment #5) > Command-Option-R toggles responsive design mode in Safari. > Now, pressing Command-Option-R once enters responsive design mode. > Pressing it again, toggles the right sidebar. > https://cloudup.com/c-qJT91xLhK This looks like a focus bug. It doesn't reproduce when Inspector has its own window. When inspector is docked and the main page focused, the shortcut opens RDM and focuses the Web Inspector. It should keep focus when changing into or out of RDM. Can you file a radar about this? It isn't clear whether it's a WebKit or Safari bug. 266098 2015-11-23 14:03:56 -0800 2015-11-23 18:43:44 -0800 Proposed Fix bug-151572-20151123140340.patch text/plain 3033 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBi NDZhYTJjMjMyMzFhZDI2Nzc0NWQ0MWY2NzUwYmIwOWNhZjM4ZjlhLi4zYzEwODNlMTA2ODJjZDlm OGUxOTA4ZTRiOGI1MzBmODU5ZjhhODY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOCBAQAogMjAxNS0xMS0yMyAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAor ICAgICAgICBXZWIgSW5zcGVjdG9yOiB1c2UgQ21kLU9wdGlvbi1MIGFuZCBDbWQtT3B0aW9uLVIg Zm9yIHRvZ2dsaW5nIG5hdmlnYXRpb24gYW5kIGRldGFpbHMgc2lkZWJhcnMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTU3MgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBwcmV2aW91cyBzaG9ydGN1 dHMgd2VyZSBDbWQtMCBhbmQgQ21kLU9wdGlvbi0wLCBidXQgdGhlc2UgZGlkbid0IG1hdGNoIFNh ZmFyaSdzCisgICAgICAgIHNpZGViYXIgc2hvcnRjdXRzIGFuZCBjb25mbGljdCB3aXRoIENtZC0w IGFzIHRoZSBjcm9zcy1icm93c2VyIHdheSB0byByZXNldCBwYWdlIHpvb20uCisKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5jb250 ZW50TG9hZGVkKToKKworMjAxNS0xMS0yMyAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4K KwogICAgICAgICBXZWIgSW5zcGVjdG9yOiB3aGVuIGluc3BlY3RpbmcgdGhlIGluc3BlY3Rvciwg YWRkIHRoZSBpbnNwZWN0aW9uIGxldmVsIHRvIHRoZSB0aXRsZSBiYXIKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTU1NQogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKaW5kZXggMGY4YWU3YTZi MWNjNzBmM2M1ODcxOGVlZTk2MjA4NDM5ODNiZDMwMi4uN2U4NTczOTgwYWFhMDM3YWVhM2Y3NDUy M2M5MDRmODFlN2E3MmU3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvQmFzZS9NYWluLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0Jhc2UvTWFpbi5qcwpAQCAtMjQ0LDggKzI0NCw4IEBAIFdlYkluc3BlY3Rvci5jb250 ZW50TG9hZGVkID0gZnVuY3Rpb24oKQogICAgIHRoaXMuX3NhdmVLZXlib2FyZFNob3J0Y3V0ID0g bmV3IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0KFdlYkluc3BlY3Rvci5LZXlib2FyZFNo b3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmRPckNvbnRyb2wsICJTIiwgdGhpcy5fc2F2ZS5iaW5kKHRo aXMpKTsKICAgICB0aGlzLl9zYXZlQXNLZXlib2FyZFNob3J0Y3V0ID0gbmV3IFdlYkluc3BlY3Rv ci5LZXlib2FyZFNob3J0Y3V0KFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVy LlNoaWZ0IHwgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuQ29tbWFuZE9y Q29udHJvbCwgIlMiLCB0aGlzLl9zYXZlQXMuYmluZCh0aGlzKSk7CiAKLSAgICB0aGlzLm5hdmln YXRpb25TaWRlYmFyS2V5Ym9hcmRTaG9ydGN1dCA9IG5ldyBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRT aG9ydGN1dChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5Db21tYW5kT3JD b250cm9sLCAiMCIsIHRoaXMudG9nZ2xlTmF2aWdhdGlvblNpZGViYXIuYmluZCh0aGlzKSk7Ci0g ICAgdGhpcy5kZXRhaWxzU2lkZWJhcktleWJvYXJkU2hvcnRjdXQgPSBuZXcgV2ViSW5zcGVjdG9y LktleWJvYXJkU2hvcnRjdXQoV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIu Q29tbWFuZE9yQ29udHJvbCB8IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVy Lk9wdGlvbiwgIjAiLCB0aGlzLnRvZ2dsZURldGFpbHNTaWRlYmFyLmJpbmQodGhpcykpOworICAg IHRoaXMubmF2aWdhdGlvblNpZGViYXJLZXlib2FyZFNob3J0Y3V0ID0gbmV3IFdlYkluc3BlY3Rv ci5LZXlib2FyZFNob3J0Y3V0KFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVy LkNvbW1hbmRPckNvbnRyb2wgfCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmll ci5PcHRpb24sICJMIiwgdGhpcy50b2dnbGVOYXZpZ2F0aW9uU2lkZWJhci5iaW5kKHRoaXMpKTsK KyAgICB0aGlzLmRldGFpbHNTaWRlYmFyS2V5Ym9hcmRTaG9ydGN1dCA9IG5ldyBXZWJJbnNwZWN0 b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmll ci5Db21tYW5kT3JDb250cm9sIHwgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZp ZXIuT3B0aW9uLCAiUiIsIHRoaXMudG9nZ2xlRGV0YWlsc1NpZGViYXIuYmluZCh0aGlzKSk7CiAK ICAgICB0aGlzLl9pbmNyZWFzZVpvb21LZXlib2FyZFNob3J0Y3V0ID0gbmV3IFdlYkluc3BlY3Rv ci5LZXlib2FyZFNob3J0Y3V0KFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVy LkNvbW1hbmRPckNvbnRyb2wsIFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0LktleS5QbHVz LCB0aGlzLl9pbmNyZWFzZVpvb20uYmluZCh0aGlzKSk7CiAgICAgdGhpcy5fZGVjcmVhc2Vab29t S2V5Ym9hcmRTaG9ydGN1dCA9IG5ldyBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJ bnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5Db21tYW5kT3JDb250cm9sLCBXZWJJ bnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5LZXkuTWludXMsIHRoaXMuX2RlY3JlYXNlWm9vbS5i aW5kKHRoaXMpKTsK