151567 2015-11-23 09:03:13 -0800 REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button 2015-12-07 02:47:49 -0800 1 1 1 Unclassified WebKit WebKit EFL WebKit Local Build All Linux RESOLVED FIXED P2 Normal --- 1 rhodovan.u-szeged gyuyoung.kim bburg commit-queue gyuyoung gyuyoung.kim hs85.jeong lucas.de.marchi ossy ryuan.choi oldest_to_newest 1144186 0 rhodovan.u-szeged 2015-11-23 09:03:13 -0800 Open www.google.com with MiniBrowser (debug or release) and try to close it with the close-window button in the corner. With an EFL build nothing happens for me (i.e. the window does not close). Could somebody test it with another port too? 1144232 1 bburg 2015-11-23 15:15:14 -0800 This does not seem to reproduce on Mac. Changing platform to EFL for now. 1144271 2 gyuyoung.kim 2015-11-23 21:07:57 -0800 This bug looks a regression. 1144283 3 266120 gyuyoung.kim 2015-11-23 22:19:34 -0800 Created attachment 266120 Patch 1144284 4 266120 hs85.jeong 2015-11-23 22:30:55 -0800 Comment on attachment 266120 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266120&action=review > Tools/MiniBrowser/efl/main.c:2040 > + window_close(window_find_with_elm_window(elm_window)); If we don't use the parameters (user_data, event_info), how about removing them? 1144286 5 266121 gyuyoung.kim 2015-11-23 22:34:38 -0800 Created attachment 266121 Patch 1144287 6 266120 gyuyoung.kim 2015-11-23 22:35:40 -0800 Comment on attachment 266120 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266120&action=review >> Tools/MiniBrowser/efl/main.c:2040 >> + window_close(window_find_with_elm_window(elm_window)); > > If we don't use the parameters (user_data, event_info), how about removing them? It is not huge related with this fix though, let's remove unused parameters as well. 1144297 7 266124 gyuyoung.kim 2015-11-23 22:52:16 -0800 Created attachment 266124 Patch 1144300 8 gyuyoung.kim 2015-11-23 23:08:17 -0800 (In reply to comment #4) > Comment on attachment 266120 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=266120&action=review > > > Tools/MiniBrowser/efl/main.c:2040 > > + window_close(window_find_with_elm_window(elm_window)); > > If we don't use the parameters (user_data, event_info), how about removing > them? EFL MiniBrowser is C, not C++. So we can't omit parameter. http://stackoverflow.com/questions/8776810/parameter-name-omitted-c-vs-c 1144306 9 hs85.jeong 2015-11-23 23:13:43 -0800 (In reply to comment #8) > (In reply to comment #4) > > Comment on attachment 266120 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=266120&action=review > > > > > Tools/MiniBrowser/efl/main.c:2040 > > > + window_close(window_find_with_elm_window(elm_window)); > > > > If we don't use the parameters (user_data, event_info), how about removing > > them? > > EFL MiniBrowser is C, not C++. So we can't omit parameter. > > http://stackoverflow.com/questions/8776810/parameter-name-omitted-c-vs-c Okay,, I just worry about some warning occur case like as c++. Thanks for the information. 1144383 10 266124 commit-queue 2015-11-24 16:20:51 -0800 Comment on attachment 266124 Patch Clearing flags on attachment: 266124 Committed r192767: <http://trac.webkit.org/changeset/192767> 1144384 11 commit-queue 2015-11-24 16:20:56 -0800 All reviewed patches have been landed. Closing bug. 1146802 12 ryuan.choi 2015-12-07 02:47:49 -0800 (In reply to comment #11) > All reviewed patches have been landed. Closing bug. Sorry for the late answer. I made a Bug 151934 to fix this regression. 266120 2015-11-23 22:19:34 -0800 2015-11-23 22:34:32 -0800 Patch bug-151567-20151124151918.patch text/plain 1376 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNzU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzVmOWY0NmNkYjYxNTI3YzY2ZWY4ZmQxMjk4NGZlMDRj ZjQwYWU4Yi4uZTYzNDRlZjJkYWZiMjk2MTY5NmI1ZDRkNWNlZDFjYzZjN2FiNjRiMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE1LTExLTIzICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSRUdSRVNTSU9OKHIxOTIwNTMpOiBNaW5pQnJvd3NlciBkb2Vzbid0IGV4aXQg d2hlbiBjbGlja2luZyBvbiB0aGUgY2xvc2Utd2luZG93IGJ1dHRvbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxNTY3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9lZmwvbWFpbi5j OiBDYWxsIHdpbmRvd19jbG9zZSgpIGluc3RlYWQgb2YgZXdrX3ZpZXdfdHJ5X2Nsb3NlKCkuCisg ICAgICAgIChvbl93aW5kb3dfZGVsZXRpb24pOgorCiAyMDE1LTExLTIzICBBbGV4IENocmlzdGVu c2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IGNyYXNoIGluIH5X ZWJQcm9jZXNzUG9vbCB3aGVuIHVzaW5nIEdlb2xvY2F0aW9uIHdpdGggdXNlTmV0d29ya1Byb2Nl c3M9dHJ1ZQpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYyBiL1Rvb2xz L01pbmlCcm93c2VyL2VmbC9tYWluLmMKaW5kZXggMTYwMzFkNDZmYzc3M2U0ODgxMTU4ZTlkNDQy MDRhYTNhNDJmMjZiNy4uN2ZhNDVlMmVhOWY4Zjk2ZTMyYTc1YTEwZGMzYmU2MTM3ODAwMzdjYiAx MDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYworKysgYi9Ub29scy9NaW5p QnJvd3Nlci9lZmwvbWFpbi5jCkBAIC0yMDM3LDggKzIwMzcsNyBAQCBvbl9ob21lX2J1dHRvbl9j bGlja2VkKHZvaWQgKnVzZXJfZGF0YSwgRXZhc19PYmplY3QgKmhvbWVfYnV0dG9uLCB2b2lkICpl dmVudF9pbgogc3RhdGljIHZvaWQKIG9uX3dpbmRvd19kZWxldGlvbih2b2lkICp1c2VyX2RhdGEs IEV2YXNfT2JqZWN0ICplbG1fd2luZG93LCB2b2lkICpldmVudF9pbmZvKQogewotICAgIEJyb3dz ZXJfV2luZG93ICp3aW5kb3cgPSAoQnJvd3Nlcl9XaW5kb3cgKil1c2VyX2RhdGE7Ci0gICAgZXdr X3ZpZXdfdHJ5X2Nsb3NlKHdpbmRvdy0+ZXdrX3ZpZXcpOworICAgIHdpbmRvd19jbG9zZSh3aW5k b3dfZmluZF93aXRoX2VsbV93aW5kb3coZWxtX3dpbmRvdykpOwogfQogCiBzdGF0aWMgRXZhc19P YmplY3QgKgo= 266121 2015-11-23 22:34:38 -0800 2015-11-23 22:52:09 -0800 Patch bug-151567-20151124153422.patch text/plain 1441 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNzU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzVmOWY0NmNkYjYxNTI3YzY2ZWY4ZmQxMjk4NGZlMDRj ZjQwYWU4Yi4uZTYzNDRlZjJkYWZiMjk2MTY5NmI1ZDRkNWNlZDFjYzZjN2FiNjRiMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE1LTExLTIzICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSRUdSRVNTSU9OKHIxOTIwNTMpOiBNaW5pQnJvd3NlciBkb2Vzbid0IGV4aXQg d2hlbiBjbGlja2luZyBvbiB0aGUgY2xvc2Utd2luZG93IGJ1dHRvbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxNTY3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9lZmwvbWFpbi5j OiBDYWxsIHdpbmRvd19jbG9zZSgpIGluc3RlYWQgb2YgZXdrX3ZpZXdfdHJ5X2Nsb3NlKCkuCisg ICAgICAgIChvbl93aW5kb3dfZGVsZXRpb24pOgorCiAyMDE1LTExLTIzICBBbGV4IENocmlzdGVu c2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IGNyYXNoIGluIH5X ZWJQcm9jZXNzUG9vbCB3aGVuIHVzaW5nIEdlb2xvY2F0aW9uIHdpdGggdXNlTmV0d29ya1Byb2Nl c3M9dHJ1ZQpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYyBiL1Rvb2xz L01pbmlCcm93c2VyL2VmbC9tYWluLmMKaW5kZXggMTYwMzFkNDZmYzc3M2U0ODgxMTU4ZTlkNDQy MDRhYTNhNDJmMjZiNy4uM2ExOTBiNGFiNTM4MzRkNjExN2ZjYTgwZWY1YjBmZGNlYzVmOTQ4MyAx MDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYworKysgYi9Ub29scy9NaW5p QnJvd3Nlci9lZmwvbWFpbi5jCkBAIC0yMDM1LDEwICsyMDM1LDkgQEAgb25faG9tZV9idXR0b25f Y2xpY2tlZCh2b2lkICp1c2VyX2RhdGEsIEV2YXNfT2JqZWN0ICpob21lX2J1dHRvbiwgdm9pZCAq ZXZlbnRfaW4KIH0KIAogc3RhdGljIHZvaWQKLW9uX3dpbmRvd19kZWxldGlvbih2b2lkICp1c2Vy X2RhdGEsIEV2YXNfT2JqZWN0ICplbG1fd2luZG93LCB2b2lkICpldmVudF9pbmZvKQorb25fd2lu ZG93X2RlbGV0aW9uKHZvaWQqLCBFdmFzX09iamVjdCAqZWxtX3dpbmRvdywgdm9pZCopCiB7Ci0g ICAgQnJvd3Nlcl9XaW5kb3cgKndpbmRvdyA9IChCcm93c2VyX1dpbmRvdyAqKXVzZXJfZGF0YTsK LSAgICBld2tfdmlld190cnlfY2xvc2Uod2luZG93LT5ld2tfdmlldyk7CisgICAgd2luZG93X2Ns b3NlKHdpbmRvd19maW5kX3dpdGhfZWxtX3dpbmRvdyhlbG1fd2luZG93KSk7CiB9CiAKIHN0YXRp YyBFdmFzX09iamVjdCAqCg== 266124 2015-11-23 22:52:16 -0800 2015-11-24 16:20:51 -0800 Patch bug-151567-20151124155200.patch text/plain 1376 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNzU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzVmOWY0NmNkYjYxNTI3YzY2ZWY4ZmQxMjk4NGZlMDRj ZjQwYWU4Yi4uZTYzNDRlZjJkYWZiMjk2MTY5NmI1ZDRkNWNlZDFjYzZjN2FiNjRiMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE1LTExLTIzICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSRUdSRVNTSU9OKHIxOTIwNTMpOiBNaW5pQnJvd3NlciBkb2Vzbid0IGV4aXQg d2hlbiBjbGlja2luZyBvbiB0aGUgY2xvc2Utd2luZG93IGJ1dHRvbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxNTY3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9lZmwvbWFpbi5j OiBDYWxsIHdpbmRvd19jbG9zZSgpIGluc3RlYWQgb2YgZXdrX3ZpZXdfdHJ5X2Nsb3NlKCkuCisg ICAgICAgIChvbl93aW5kb3dfZGVsZXRpb24pOgorCiAyMDE1LTExLTIzICBBbGV4IENocmlzdGVu c2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IGNyYXNoIGluIH5X ZWJQcm9jZXNzUG9vbCB3aGVuIHVzaW5nIEdlb2xvY2F0aW9uIHdpdGggdXNlTmV0d29ya1Byb2Nl c3M9dHJ1ZQpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYyBiL1Rvb2xz L01pbmlCcm93c2VyL2VmbC9tYWluLmMKaW5kZXggMTYwMzFkNDZmYzc3M2U0ODgxMTU4ZTlkNDQy MDRhYTNhNDJmMjZiNy4uN2ZhNDVlMmVhOWY4Zjk2ZTMyYTc1YTEwZGMzYmU2MTM3ODAwMzdjYiAx MDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYworKysgYi9Ub29scy9NaW5p QnJvd3Nlci9lZmwvbWFpbi5jCkBAIC0yMDM3LDggKzIwMzcsNyBAQCBvbl9ob21lX2J1dHRvbl9j bGlja2VkKHZvaWQgKnVzZXJfZGF0YSwgRXZhc19PYmplY3QgKmhvbWVfYnV0dG9uLCB2b2lkICpl dmVudF9pbgogc3RhdGljIHZvaWQKIG9uX3dpbmRvd19kZWxldGlvbih2b2lkICp1c2VyX2RhdGEs IEV2YXNfT2JqZWN0ICplbG1fd2luZG93LCB2b2lkICpldmVudF9pbmZvKQogewotICAgIEJyb3dz ZXJfV2luZG93ICp3aW5kb3cgPSAoQnJvd3Nlcl9XaW5kb3cgKil1c2VyX2RhdGE7Ci0gICAgZXdr X3ZpZXdfdHJ5X2Nsb3NlKHdpbmRvdy0+ZXdrX3ZpZXcpOworICAgIHdpbmRvd19jbG9zZSh3aW5k b3dfZmluZF93aXRoX2VsbV93aW5kb3coZWxtX3dpbmRvdykpOwogfQogCiBzdGF0aWMgRXZhc19P YmplY3QgKgo=