<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>151559</bug_id>
          
          <creation_ts>2015-11-23 02:41:01 -0800</creation_ts>
          <short_desc>[CMake] Do not use LLVM static libraries for FTL JIT</short_desc>
          <delta_ts>2016-01-26 07:04:47 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P3</priority>
          <bug_severity>Blocker</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>153484</dependson>
          <blocked>143605</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Guilaume Ayoub">guillaume.webkit</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>achristensen</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>fpizlo</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>jeremyhu</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>mrobinson</cc>
    
    <cc>ossy</cc>
    
    <cc>tpopela</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1144146</commentid>
    <comment_count>0</comment_count>
    <who name="Guilaume Ayoub">guillaume.webkit</who>
    <bug_when>2015-11-23 02:41:01 -0800</bug_when>
    <thetext>When I&apos;m trying to compile WebkitGTK 2.11.2, I get:

&gt; No rule to make target &apos;/usr/lib64/libLLVMSupport.a&apos;, needed by &apos;DerivedSources/JavaScriptCore/WebKitLLVMLibraryToken.h&apos;.

I can build WebkitGTK 2.11.1 successfully with the same configuration flags.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1144179</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2015-11-23 07:28:18 -0800</bug_when>
    <thetext>It&apos;s because we turned on FTL JIT. You need to either install LLVM on your system, including LLVM static libraries (the llvm-static package on Fedora), or run cmake with -DENABLE_FTL_JIT=OFF.

But this is also a bug in our CMake build system. You should have gotten a nice error message when running CMake. Currently our build system is smart enough to check that you have LLVM itself installed, but we additionally depend on those static libraries, and while we check for those separately, we don&apos;t error out properly if they&apos;re missing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1144188</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2015-11-23 10:22:04 -0800</bug_when>
    <thetext>Also, we need to determine if there is a good reason for depending on LLVM static libs. Gentoo does not ship these at all. We ship them in Fedora, but in a separate llvm-static package. We&apos;re only allowed to link Fedora packages to static libraries in &quot;exceptional circumstances,&quot; and to my knowledge we do not have one here.

Hey Filip, do you know why we are linking with LLVM static libs instead of a proper shared library?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1144189</commentid>
    <comment_count>3</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2015-11-23 10:26:02 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; Also, we need to determine if there is a good reason for depending on LLVM
&gt; static libs. Gentoo does not ship these at all. We ship them in Fedora, but
&gt; in a separate llvm-static package. We&apos;re only allowed to link Fedora
&gt; packages to static libraries in &quot;exceptional circumstances,&quot; and to my
&gt; knowledge we do not have one here.
&gt; 
&gt; Hey Filip, do you know why we are linking with LLVM static libs instead of a
&gt; proper shared library?

https://trac.webkit.org/changeset/157260 answers the question why.

( https://bugs.webkit.org/show_bug.cgi?id=142128#c18 )</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1144201</commentid>
    <comment_count>4</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2015-11-23 11:22:22 -0800</bug_when>
    <thetext>That explains why we need to load a shared library with dlopen (libllvmForJSC.so) instead of linking to LLVM normally. That&apos;s unconventional but fine. Now, libllvmForJSC.so is linked statically to LLVM, which is not generally permitted in Fedora. I want to know why we don&apos;t dynamically link libllvmForJSC.so to the system LLVM. Surely we can override cxa_atexit regardless, so I don&apos;t think we need to link statically.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1151495</commentid>
    <comment_count>5</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2015-12-28 16:40:22 -0800</bug_when>
    <thetext>OK, my vote is to either fix this or disable FTL again before 2.12. Using static libs is not considered acceptable on Linux, and it&apos;s causing build problems for openSUSE and Gentoo, which don&apos;t have LLVM static libs at all; no doubt it will be problematic for other distros too.

openSUSE came up with a rather innovative solution [1] to use -DLLVM_CONFIG_EXE at cmake time to pointing cmake to a script that wraps llvm-config like so:

#!/bin/bash

/usr/bin/llvm-config $1 |sed &quot;s,\\.a,\\.so,g&quot;

Yuck, but their package is reportedly working without issues, so I doubt the static libs were ever really needed. It would be better to use a similar wrapper around llvm-config to handle this automagically than to continue using static libs.

[1] https://build.opensuse.org/package/rdiff/GNOME:Next/webkit2gtk3?opackage=webkit2gtk3&amp;oproject=GNOME:Factory&amp;rev=87</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1155055</commentid>
    <comment_count>6</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2016-01-13 03:23:18 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; OK, my vote is to either fix this or disable FTL again before 2.12. Using
&gt; static libs is not considered acceptable on Linux, and it&apos;s causing build
&gt; problems for openSUSE and Gentoo, which don&apos;t have LLVM static libs at all;
&gt; no doubt it will be problematic for other distros too.
&gt; 
&gt; openSUSE came up with a rather innovative solution [1] to use
&gt; -DLLVM_CONFIG_EXE at cmake time to pointing cmake to a script that wraps
&gt; llvm-config like so:
&gt; 
&gt; #!/bin/bash
&gt; 
&gt; /usr/bin/llvm-config $1 |sed &quot;s,\\.a,\\.so,g&quot;
&gt; 
&gt; Yuck, but their package is reportedly working without issues, so I doubt the
&gt; static libs were ever really needed. It would be better to use a similar
&gt; wrapper around llvm-config to handle this automagically than to continue
&gt; using static libs.

It&apos;s not that easy, this hack works for SUSE because they are building llvm with CMake, so they have a .so for each static library. However, if llvm is built using autotools (like debian and fedora do) what we have is a single .so file. So we need to detect this as well at configure.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1155056</commentid>
    <comment_count>7</comment_count>
      <attachid>268863</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2016-01-13 03:29:03 -0800</bug_when>
    <thetext>Created attachment 268863
Patch

I&apos;ve tested this in debian, having both the global .so and the individual .a files installed, and it uses the global .so. It would be great if someone could test this in other distros, fedora, gentoo and suse at least. It first checks if there&apos;s a global .so, and if it isn&apos;t it uses the libs information from llvm-config instead of the lib files, so that in case of having both the .so and .a files for the individual libs, it will still prefer the .so ones, and if only .a files are installed, it will use those.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1155075</commentid>
    <comment_count>8</comment_count>
      <attachid>268863</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-01-13 07:37:31 -0800</bug_when>
    <thetext>Comment on attachment 268863
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268863&amp;action=review

Thanks for working on this. I will test in on my Fedora box and on openSUSE OBS.

&gt; Source/cmake/FindLLVM.cmake:33
&gt; +# We need to build the soname manually in any case, since there&apos;s no way to get it from llvm-config.

There&apos;s currently no way to get it from llvm-config. I&apos;ve heard this might be possible with LLVM 3.8.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1155127</commentid>
    <comment_count>9</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-01-13 10:46:03 -0800</bug_when>
    <thetext>It builds and runs fine on Fedora. It also builds fine on openSUSE.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1155381</commentid>
    <comment_count>10</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2016-01-13 23:34:31 -0800</bug_when>
    <thetext>Committed r195009: &lt;http://trac.webkit.org/changeset/195009&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1156261</commentid>
    <comment_count>11</comment_count>
    <who name="Jeremy Huddleston Sequoia">jeremyhu</who>
    <bug_when>2016-01-16 21:37:23 -0800</bug_when>
    <thetext>This doesn&apos;t work on Windows or OSX, and it doesn&apos;t work for current development versions of llvm (on any platform).

Followup in bug #153191.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>268863</attachid>
            <date>2016-01-13 03:29:03 -0800</date>
            <delta_ts>2016-01-13 07:37:31 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>jsc-llvm-linking.diff</filename>
            <type>text/plain</type>
            <size>7442</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzYzgwNzExLi40MGRhNTI5
IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK
KzIwMTYtMDEtMTMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgor
CisgICAgICAgIFtDTWFrZV0gRG8gbm90IHVzZSBMTFZNIHN0YXRpYyBsaWJyYXJpZXMgZm9yIEZU
TCBKSVQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1
MTU1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFs
c28gZXhwb3J0IExMVk1fTElCUkFSSUVTIHZhcmlhYmxlIHRoYXQgY2FuIGJlIHVzZWQgdG8gcHJl
ZmVyCisgICAgICAgIGxpbmtpbmcgdG8gdGhlIGxsdm0gZHluYW1pYyBsaWJyYXJpZXMuCisKKyAg
ICAgICAgKiBTb3VyY2UvY21ha2UvRmluZExMVk0uY21ha2U6CisKIDIwMTYtMDEtMTIgIENhcmxv
cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3
ZWQuIFVwZGF0ZSBPcHRpb25zR1RLLmNtYWtlIGFuZCBORVdTIGZvciAyLjExLjMgcmVsZWFzZS4K
ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCAxNGQ5YWNkLi42ZDQ2ZmY3IDEw
MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291
cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC05NzIsMTAgKzk3Miw2IEBAIGxp
c3QoQVBQRU5EIEphdmFTY3JpcHRDb3JlX1NPVVJDRVMKIAogCiBpZiAoRU5BQkxFX0ZUTF9KSVQp
Ci0gICAgaWYgKE5PVCBMTFZNX1NUQVRJQ19MSUJSQVJJRVMpCi0gICAgICAgIG1lc3NhZ2UoRkFU
QUxfRVJST1IgIk5vIExMVk0gbGlicyBmb3VuZCwgYnV0IEZUTCBpcyBlbmFibGVkLiBTdG9wcGlu
ZyBidWlsZC4iKQotICAgIGVuZGlmICgpCi0KICAgICAjIENvbmZpZ3VyZSBsbHZtRm9ySlNDLnNv
CiAgICAgc2V0KGxsdm1Gb3JKU0NfU09VUkNFUwogICAgICAgICBsbHZtL2xpYnJhcnkvTExWTUFu
Y2hvci5jcHAKQEAgLTk4OSwxNyArOTg1LDkgQEAgaWYgKEVOQUJMRV9GVExfSklUKQogCiAgICAg
YWRkX2N1c3RvbV9jb21tYW5kKAogICAgICAgICBPVVRQVVQgJHtERVJJVkVEX1NPVVJDRVNfSkFW
QVNDUklQVENPUkVfRElSfS9XZWJLaXRMTFZNTGlicmFyeVRva2VuLmgKLSAgICAgICAgREVQRU5E
UyAke0xMVk1fU1RBVElDX0xJQlJBUklFU30KICAgICAgICAgQ09NTUFORCAke0NNQUtFX0NPTU1B
TkR9IC1FIHRvdWNoICR7REVSSVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0vV2ViS2l0
TExWTUxpYnJhcnlUb2tlbi5oCiAgICAgICAgIFZFUkJBVElNKQogCi0gICAgV0VCS0lUX1dSQVBf
U09VUkNFTElTVCgke2xsdm1Gb3JKU0NfU09VUkNFU30pCi0gICAgYWRkX2xpYnJhcnkobGx2bUZv
ckpTQyBTSEFSRUQgJHtsbHZtRm9ySlNDX1NPVVJDRVN9ICR7REVSSVZFRF9TT1VSQ0VTX0pBVkFT
Q1JJUFRDT1JFX0RJUn0vV2ViS2l0TExWTUxpYnJhcnlUb2tlbi5oKQotICAgIHRhcmdldF9saW5r
X2xpYnJhcmllcyhsbHZtRm9ySlNDICR7TExWTV9TVEFUSUNfTElCUkFSSUVTfSAke0xMVk1fU1lT
VEVNX0xJQlJBUklFU30pCi0gICAgaWYgKE5PVCBDTUFLRV9TWVNURU1fTkFNRSBNQVRDSEVTICJE
YXJ3aW4iKQotICAgICAgICBBRERfVEFSR0VUX1BST1BFUlRJRVMobGx2bUZvckpTQyBMSU5LX0ZM
QUdTICItV2wsLS12ZXJzaW9uLXNjcmlwdD0ke0pBVkFTQ1JJUFRDT1JFX0RJUn0vbGx2bS9saWJy
YXJ5L2xpYmxsdm1Gb3JKU0MudmVyc2lvbiIpCi0gICAgZW5kaWYgKCkKLQogICAgICMgQWRkZWQg
ZXh0cmEgaXRlbXMgZm9yIEphdmFTY3JpcHRDb3JlCiAgICAgbGlzdChBUFBFTkQgSmF2YVNjcmlw
dENvcmVfU1lTVEVNX0lOQ0xVREVfRElSRUNUT1JJRVMKICAgICAgICAgJHtMTFZNX0lOQ0xVREVf
RElSU30KQEAgLTEzNDYsNiArMTMzNCwyNSBAQCBlbmRpZiAoKQogCiBXRUJLSVRfSU5DTFVERV9D
T05GSUdfRklMRVNfSUZfRVhJU1RTKCkKIAoraWYgKEVOQUJMRV9GVExfSklUKQorICAgIGlmIChO
T1QgbGx2bUZvckpTQ19MSUJSQVJJRVMpCisgICAgICAgIHNldChsbHZtRm9ySlNDX0xJQlJBUklF
UyAke0xMVk1fU1RBVElDX0xJQlJBUklFU30pCisgICAgZW5kaWYgKCkKKyAgICBpZiAoTk9UIGxs
dm1Gb3JKU0NfTElCUkFSSUVTKQorICAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJObyBMTFZN
IGxpYnMgZm91bmQsIGJ1dCBGVEwgaXMgZW5hYmxlZC4gU3RvcHBpbmcgYnVpbGQuIikKKyAgICBl
bmRpZiAoKQorCisgICAgV0VCS0lUX1dSQVBfU09VUkNFTElTVCgke2xsdm1Gb3JKU0NfU09VUkNF
U30pCisgICAgYWRkX2xpYnJhcnkobGx2bUZvckpTQyBTSEFSRUQgJHtsbHZtRm9ySlNDX1NPVVJD
RVN9ICR7REVSSVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0vV2ViS2l0TExWTUxpYnJh
cnlUb2tlbi5oKQorICAgIHRhcmdldF9saW5rX2xpYnJhcmllcyhsbHZtRm9ySlNDICR7bGx2bUZv
ckpTQ19MSUJSQVJJRVN9ICR7TExWTV9TWVNURU1fTElCUkFSSUVTfSkKKyAgICBpZiAoTk9UIENN
QUtFX1NZU1RFTV9OQU1FIE1BVENIRVMgIkRhcndpbiIpCisgICAgICAgIEFERF9UQVJHRVRfUFJP
UEVSVElFUyhsbHZtRm9ySlNDIExJTktfRkxBR1MgIi1XbCwtLXZlcnNpb24tc2NyaXB0PSR7SkFW
QVNDUklQVENPUkVfRElSfS9sbHZtL2xpYnJhcnkvbGlibGx2bUZvckpTQy52ZXJzaW9uIikKKyAg
ICBlbmRpZiAoKQorICAgIGlmIChsbHZtRm9ySlNDX0lOU1RBTExfRElSKQorICAgICAgICBpbnN0
YWxsKFRBUkdFVFMgbGx2bUZvckpTQyBERVNUSU5BVElPTiAiJHtsbHZtRm9ySlNDX0lOU1RBTExf
RElSfSIpCisgICAgZW5kaWYgKCkKK2VuZGlmICgpCisKIFdFQktJVF9DUkVBVEVfRk9SV0FSRElO
R19IRUFERVJTKEphdmFTY3JpcHRDb3JlIERJUkVDVE9SSUVTICR7SmF2YVNjcmlwdENvcmVfRk9S
V0FSRElOR19IRUFERVJTX0RJUkVDVE9SSUVTfSBGSUxFUyAke0phdmFTY3JpcHRDb3JlX0ZPUldB
UkRJTkdfSEVBREVSU19GSUxFU30pCiAKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD
b3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggZmJl
N2Y0NS4uNWNhYTRjYSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxv
ZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAK
KzIwMTYtMDEtMTMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgor
CisgICAgICAgIFtDTWFrZV0gRG8gbm90IHVzZSBMTFZNIHN0YXRpYyBsaWJyYXJpZXMgZm9yIEZU
TCBKSVQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1
MTU1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFs
bG93IHBvcnRzIGRlY2lkZSB3aGV0aGVyIHRvIHByZWZlciBsaW5raW5nIHRvIGxsdm0gc3RhdGlj
IG9yCisgICAgICAgIGR5bmFtaWMgbGlicmFyaWVzLiBUaGlzIHBhdGNoIG9ubHkgY2hhbmdlcyB0
aGUgYmVoYXZpb3Igb2YgdGhlIEdUSworICAgICAgICBwb3J0LCBvdGhlciBwb3J0cyBjYW4gY2hh
bmdlIHRoZSBkZWZhdWx0IGJlaGF2aW9yIGJ5IHNldHRpbmcKKyAgICAgICAgbGx2bUZvckpTQ19M
SUJSQVJJRVMgaW4gdGhlaXIgcGxhdGZvcm0gc3BlY2lmaWMgY21ha2UgZmlsZXMuCisKKyAgICAg
ICAgKiBDTWFrZUxpc3RzLnR4dDogTW92ZSBsbHZtRm9ySlNDIGxpYnJhcnkgZGVmaW5pdGlvbiBh
ZnRlciB0aGUKKyAgICAgICAgV0VCS0lUX0lOQ0xVREVfQ09ORklHX0ZJTEVTX0lGX0VYSVNUUywg
dG8gYWxsb3cgcGxhdGZvcm0gc3BlY2lmaWMKKyAgICAgICAgZmlsZXMgdG8gc2V0IHRoZWlyIG93
biBsbHZtRm9ySlNDX0xJQlJBUklFUy4gV2hlbiBub3Qgc2V0LCBpdAorICAgICAgICBkZWZhdWx0
cyB0byBMTFZNX1NUQVRJQ19MSUJSQVJJRVMuIFRoZSBjb21tYW5kIHRvIGNyZWF0ZQorICAgICAg
ICBXZWJLaXRMTFZNTGlicmFyeVRva2VuLmggbm8gbG9uZ2VyIGRlcGVuZHMgb24gdGhlIHN0YXRp
YworICAgICAgICBsaWJyYXJpZXMsIHNpbmNlIHdlIGFyZSBnb2luZyB0byBtYWtlIHRoZSBidWls
ZCBmYWlsIGFueXdheSB3aGVuCisgICAgICAgIG5vdCBmb3VuZCBpbiBjYXNlIG9mIGxpbmtpbmcg
dG8gdGhlIHN0YXRpYyBsaWJyYXJpZXMuIElmIHBsYXRmb3JtCisgICAgICAgIHNwZWNpZmljIGZp
bGUgZGVmaW5lZCBsbHZtRm9ySlNDX0lOU1RBTExfRElSIGxsdm1Gb3JKU0MgaXMgYWxzbworICAg
ICAgICBpbnN0YWxsZWQgdG8gdGhlIGdpdmVuIGRlc3RpbmF0aW9uLgorICAgICAgICAqIFBsYXRm
b3JtR1RLLmNtYWtlOiBTZXQgbGx2bUZvckpTQ19MSUJSQVJJRVMgYW5kCisgICAgICAgIGxsdm1G
b3JKU0NfSU5TVEFMTF9ESVIuCisKIDIwMTYtMDEtMTIgIFBlciBBcm5lIFZvbGxhbiAgPHBlYXZv
QG91dGxvb2suY29tPgogCiAgICAgICAgIFtGVExdW1dpbjY0XSBDb21waWxlIGVycm9yLgpkaWZm
IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL1BsYXRmb3JtR1RLLmNtYWtlIGIvU291cmNl
L0phdmFTY3JpcHRDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCmluZGV4IGNiMjIxNTEuLjJmYjc4OTMg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9QbGF0Zm9ybUdUSy5jbWFrZQorKysg
Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTM5LDkgKzM5LDgg
QEAgaWYgKEVOQUJMRV9JTlRST1NQRUNUSU9OKQogZW5kaWYgKCkKIAogaWYgKEVOQUJMRV9GVExf
SklUKQotICAgIGluc3RhbGwoVEFSR0VUUyBsbHZtRm9ySlNDCi0gICAgICAgICAgICBERVNUSU5B
VElPTiAiJHtMSUJfSU5TVEFMTF9ESVJ9L2phdmFzY3JpcHRjb3JlZ3RrLSR7V0VCS0lUR1RLX0FQ
SV9WRVJTSU9OfSIKLSAgICApCisgICAgc2V0KGxsdm1Gb3JKU0NfTElCUkFSSUVTICR7TExWTV9M
SUJSQVJJRVN9KQorICAgIHNldChsbHZtRm9ySlNDX0lOU1RBTExfRElSICIke0xJQl9JTlNUQUxM
X0RJUn0vamF2YXNjcmlwdGNvcmVndGstJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059IikKIGVuZGlm
ICgpCiAKIGFkZF9kZWZpbml0aW9ucygtRFNUQVRJQ0FMTFlfTElOS0VEX1dJVEhfV1RGKQpkaWZm
IC0tZ2l0IGEvU291cmNlL2NtYWtlL0ZpbmRMTFZNLmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRM
TFZNLmNtYWtlCmluZGV4IDMxZTIwNTUuLmZmMDBlZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFr
ZS9GaW5kTExWTS5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvRmluZExMVk0uY21ha2UKQEAgLTIz
LDEzICsyMywyNyBAQCBlbmRmb3JlYWNoICgpCiBleGVjdXRlX3Byb2Nlc3MoQ09NTUFORCAke0xM
Vk1fQ09ORklHX0VYRX0gLS1pbmNsdWRlZGlyIE9VVFBVVF9WQVJJQUJMRSBMTFZNX0lOQ0xVREVf
RElSUyBPVVRQVVRfU1RSSVBfVFJBSUxJTkdfV0hJVEVTUEFDRSkKIGV4ZWN1dGVfcHJvY2VzcyhD
T01NQU5EICR7TExWTV9DT05GSUdfRVhFfSAtLWxpYmZpbGVzIE9VVFBVVF9WQVJJQUJMRSBMTFZN
X1NUQVRJQ19MSUJSQVJJRVMgT1VUUFVUX1NUUklQX1RSQUlMSU5HX1dISVRFU1BBQ0UpCiBleGVj
dXRlX3Byb2Nlc3MoQ09NTUFORCAke0xMVk1fQ09ORklHX0VYRX0gLS1zeXN0ZW0tbGlicyBPVVRQ
VVRfVkFSSUFCTEUgTExWTV9TWVNURU1fTElCUkFSSUVTIE9VVFBVVF9TVFJJUF9UUkFJTElOR19X
SElURVNQQUNFKQorZXhlY3V0ZV9wcm9jZXNzKENPTU1BTkQgJHtMTFZNX0NPTkZJR19FWEV9IC0t
bGliZGlyIE9VVFBVVF9WQVJJQUJMRSBMTFZNX0xJQlNfRElSRUNUT1JZIE9VVFBVVF9TVFJJUF9U
UkFJTElOR19XSElURVNQQUNFKQorZXhlY3V0ZV9wcm9jZXNzKENPTU1BTkQgJHtMTFZNX0NPTkZJ
R19FWEV9IC0tbGlicyBPVVRQVVRfVkFSSUFCTEUgTExWTV9MSUJTIE9VVFBVVF9TVFJJUF9UUkFJ
TElOR19XSElURVNQQUNFKQorZXhlY3V0ZV9wcm9jZXNzKENPTU1BTkQgJHtMTFZNX0NPTkZJR19F
WEV9IC0tbGRmbGFncyBPVVRQVVRfVkFSSUFCTEUgTExWTV9MREZMQUdTIE9VVFBVVF9TVFJJUF9U
UkFJTElOR19XSElURVNQQUNFKQorCisjIERlcGVuZGluZyBvbiBob3cgbGx2bSB3YXMgYnVpbHQs
IHdlIGNvdWxkIGhhdmUgZWl0aGVyIGEgZ2xvYmFsIC5zbyBmaWxlIHdoZW4gYnVpbHQgdXNpbmcg
YXV0b3Rvb2xzLAorIyBvciBtdWx0aXBsZSAuc28gZmlsZXMgZm9yIGVhY2ggc3RhdGljIGxpYnJh
cnkgd2hlbiBidWlsdCB1c2luZyBDTWFrZS4gU28sIHdlIHNldCB0aGUgTExWTV9MSUJTX0RJUkVD
VE9SWQorIyB2YXJpYWJsZSBoZXJlIGFjY29yZGluZ2x5IGZvciBlYWNoIGNhc2UuCisjIFdlIG5l
ZWQgdG8gYnVpbGQgdGhlIHNvbmFtZSBtYW51YWxseSBpbiBhbnkgY2FzZSwgc2luY2UgdGhlcmUn
cyBubyB3YXkgdG8gZ2V0IGl0IGZyb20gbGx2bS1jb25maWcuCitzZXQoTExWTV9TT05BTUUgIkxM
Vk0tJHtMTFZNX1ZFUlNJT059IikKK2lmIChFWElTVFMgIiR7TExWTV9MSUJTX0RJUkVDVE9SWX0v
bGliJHtMTFZNX1NPTkFNRX0uc28iKQorICAgIHNldChMTFZNX0xJQlJBUklFUyAiJHtMTFZNX0xE
RkxBR1N9IC1sJHtMTFZNX1NPTkFNRX0iKQorZWxzZSAoKQorICAgIHNldChMTFZNX0xJQlJBUklF
UyAiJHtMTFZNX0xERkxBR1N9ICR7TExWTV9MSUJTfSIpCitlbmRpZiAoKQogCiAjIGNvbnZlcnQg
dGhlIGxpc3Qgb2YgcGF0aHMgaW50byBhIGNtYWtlIGxpc3QKIHNlcGFyYXRlX2FyZ3VtZW50cyhM
TFZNX1NUQVRJQ19MSUJSQVJJRVMpCiAKIGluY2x1ZGUoRmluZFBhY2thZ2VIYW5kbGVTdGFuZGFy
ZEFyZ3MpCiBmaW5kX3BhY2thZ2VfaGFuZGxlX3N0YW5kYXJkX2FyZ3MoTExWTQotICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIFJFUVVJUkVEX1ZBUlMgTExWTV9WRVJTSU9OIExMVk1f
SU5DTFVERV9ESVJTIExMVk1fU1RBVElDX0xJQlJBUklFUworICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIFJFUVVJUkVEX1ZBUlMgTExWTV9WRVJTSU9OIExMVk1fSU5DTFVERV9ESVJT
IExMVk1fTElCUkFSSUVTIExMVk1fU1RBVElDX0xJQlJBUklFUwogICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIFZFUlNJT05fVkFSIExMVk1fVkVSU0lPTikKIAotbWFya19hc19hZHZh
bmNlZChMTFZNX1ZFUlNJT04gTExWTV9JTkNMVURFX0RJUlMgTExWTV9TVEFUSUNfTElCUkFSSUVT
KQorbWFya19hc19hZHZhbmNlZChMTFZNX1ZFUlNJT04gTExWTV9JTkNMVURFX0RJUlMgTExWTV9M
SUJSQVJJRVMgTExWTV9TVEFUSUNfTElCUkFSSUVTKQo=
</data>
<flag name="review"
          id="293833"
          type_id="1"
          status="+"
          setter="mcatanzaro"
    />
          </attachment>
      

    </bug>

</bugzilla>