151558 2015-11-23 00:49:16 -0800 [GStreamer] No need to assert the pipeline's bus presence in MediaPlayerPrivateGStreamerBase dtor 2015-11-23 05:39:19 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan cgarcia oldest_to_newest 1144135 0 zan 2015-11-23 00:49:16 -0800 [GStreamer] No need to assert the pipeline's bus presence 1144136 1 266082 zan 2015-11-23 00:51:09 -0800 Created attachment 266082 Patch 1144137 2 266082 svillar 2015-11-23 00:56:25 -0800 Comment on attachment 266082 Patch What about the clear() on the pipeline? 1144138 3 cgarcia 2015-11-23 00:59:25 -0800 (In reply to comment #2) > Comment on attachment 266082 [details] > Patch > > What about the clear() on the pipeline? It's the destructor, it will be done anyway, the point is whether it's needed explicitly at that point for whatever reason. 1144170 4 266082 zan 2015-11-23 05:39:03 -0800 Comment on attachment 266082 Patch Clearing flags on attachment: 266082 Committed r192744: <http://trac.webkit.org/changeset/192744> 1144171 5 zan 2015-11-23 05:39:19 -0800 All reviewed patches have been landed. Closing bug. 266082 2015-11-23 00:51:09 -0800 2015-11-23 05:39:03 -0800 Patch bug-151558-20151123005052.patch text/plain 2157 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjVmMWEyM2UyMjhlN2Rk YzBjOGJkMGJlMDFmNTA2NzAwZDc2YzljMS4uMTRkMDcxMzlmM2M5M2E4OWU1N2Y5MmUxNTgyMGEx NGQyZDc1ZDU2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTExLTIzICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBO byBuZWVkIHRvIGFzc2VydCB0aGUgcGlwZWxpbmUncyBidXMgcHJlc2VuY2UgaW4gTWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyQmFzZSBkdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE1NTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJbiB0aGUgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFz ZSBkZXN0cnVjdG9yLCB0aGVyZSdzIHNvbWUgbGVmdG92ZXIgY29kZQorICAgICAgICB0aGF0IGFj cXVpcmVzIGEgcmVmZXJlbmNlIHRvIHRoZSBHU3RyZWFtZXIgcGlwZWxpbmUncyBidXMgb2JqZWN0 IGFuZCB0aGVuCisgICAgICAgIGp1c3QgYXNzZXJ0cyB0aGF0IGl0J3Mgbm90IG51bGwuIE5vdCB2 ZXJ5IHVzZWZ1bCwgc28gcmVtb3ZlIGl0LgorCisgICAgICAgIEFsc28gdXNlIG51bGxwdHIgdG8g bnVsbCBvdXQgdGhlIG1fcGxheWVyIG1lbWJlci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6On5NZWRpYVBsYXll clByaXZhdGVHU3RyZWFtZXJCYXNlKToKKwogMjAxNS0xMS0yMiAgTXlsZXMgQy4gTWF4ZmllbGQg IDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIEZvbnQgc2VsZWN0aW9uIHNob3VsZCBu b3QgY29uc3VsdCBmb250LXZhcmlhbnQgcHJvcGVydHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXJCYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9N ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcAppbmRleCBlZGVkMjliOTY2ZDM3ZTcx M2QwOTRhMzI3YjFjNThmYThjODUxYzY4Li4yMDE3MDdmOGFhNTcxNTNkMTFiYTk0NTYwMjg2OGFh YzgxYjcwMDhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lckJhc2UuY3BwCkBAIC0xMjMsMTYgKzEyMywxMCBAQCBNZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXJCYXNlOjp+TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZSgpCiAKICAgICBn X211dGV4X2NsZWFyKCZtX3NhbXBsZU11dGV4KTsKIAotICAgIG1fcGxheWVyID0gMDsKKyAgICBt X3BsYXllciA9IG51bGxwdHI7CiAKICAgICBnX3NpZ25hbF9oYW5kbGVyc19kaXNjb25uZWN0X21h dGNoZWQobV92b2x1bWVFbGVtZW50LmdldCgpLCBHX1NJR05BTF9NQVRDSF9EQVRBLCAwLCAwLCBu dWxscHRyLCBudWxscHRyLCB0aGlzKTsKIAotICAgIGlmIChtX3BpcGVsaW5lKSB7Ci0gICAgICAg IEdSZWZQdHI8R3N0QnVzPiBidXMgPSBhZG9wdEdSZWYoZ3N0X3BpcGVsaW5lX2dldF9idXMoR1NU X1BJUEVMSU5FKG1fcGlwZWxpbmUuZ2V0KCkpKSk7Ci0gICAgICAgIEFTU0VSVChidXMpOwotICAg ICAgICBtX3BpcGVsaW5lLmNsZWFyKCk7Ci0gICAgfQotCiAjaWYgVVNFKFRFWFRVUkVfTUFQUEVS X0dMKSAmJiAhVVNFKENPT1JESU5BVEVEX0dSQVBISUNTKQogICAgIGlmIChjbGllbnQoKSkKICAg ICAgICAgY2xpZW50KCktPnBsYXRmb3JtTGF5ZXJXaWxsQmVEZXN0cm95ZWQoKTsK