151553 2015-11-22 12:12:54 -0800 [WTF][EFL] Fix signed overflow build break with gcc >= 5.1 2015-11-23 04:12:02 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Local Build Unspecified Unspecified RESOLVED DUPLICATE 150797 P2 Normal --- 1 jh718.park jh718.park benjamin cdumez cmarcelo commit-queue gyuyoung.kim hs85.jeong ossy oldest_to_newest 1144071 0 jh718.park 2015-11-22 12:12:54 -0800 When building with gcc >= 5.1, signed overflow warning occurs as below. ../../Source/WTF/wtf/dtoa/bignum.cc: In member function ‘void WTF::double_conversion::Bignum::AssignDecimalString(WTF::double_conversion::BufferReference<const char>)’: ../../Source/WTF/wtf/dtoa/bignum.cc:105:10: error: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Werror=strict-overflow] void Bignum::AssignDecimalString(BufferReference<const char> value) { ^ cc1plus: all warnings being treated as errors 1144073 1 266062 jh718.park 2015-11-22 12:17:10 -0800 Created attachment 266062 Patch 1144100 2 hs85.jeong 2015-11-22 16:23:21 -0800 ossy already tried to fix this bug, isn't it? *** This bug has been marked as a duplicate of bug 150797 *** 1144102 3 jh718.park 2015-11-22 16:34:30 -0800 Yes, it is as you said. If Darin's comment is applied, it seems to be resolved immediately. 1144161 4 266062 ossy 2015-11-23 04:12:02 -0800 Comment on attachment 266062 Patch Cleared review? from attachment 266062 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 266062 2015-11-22 12:17:10 -0800 2015-11-23 04:12:02 -0800 Patch bug-151553-20151123051655.patch text/plain 1424 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNzM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDgwYTU3OTRjMDZmNGZhYjA5ZmYwM2E2 NDE3ODBlM2YyNmFjM2FkOGQuLjNmNjBlYTQ3ZDZkYjQ5ZTY3ZjE2YWExNDJiZTdmNzIzY2MzNGJm MDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUtMTEtMjIgIEpvb25naHVuIFBhcmsgIDxqaDcx OC5wYXJrQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtXVEZdW0VGTF0gRml4IHNpZ25lZCBvdmVy ZmxvdyBidWlsZCBicmVhayB3aXRoIGdjYyA+PSA1LjEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTU1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gYnVpbGRpbmcgd2l0aCBnY2MgPj0gNS4xLCBz aWduZWQgb3ZlcmZsb3cgd2FybmluZyBvY2N1cnMuCisgICAgICAgIFRvIGZpeCB0aGlzLCB1c2Ug InVuc2lnbmVkIGludCIgaW5zdGVhZCBvZiAiaW50Ii4KKworICAgICAgICAqIHd0Zi9kdG9hL2Jp Z251bS5jYzoKKwogMjAxNS0xMS0xOCAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+ CiAKICAgICAgICAgW2lPU10gQVNTRVJUSU9OIEZBSUxFRDogdGVtcG9yYXJ5RmlsZVBhdGgubGFz dCgpID09ICcvJyBpbiBXZWJDb3JlOjpvcGVuVGVtcG9yYXJ5RmlsZSgpCmRpZmYgLS1naXQgYS9T b3VyY2UvV1RGL3d0Zi9kdG9hL2JpZ251bS5jYyBiL1NvdXJjZS9XVEYvd3RmL2R0b2EvYmlnbnVt LmNjCmluZGV4IDliYjkwNDlhMmQ0OTlhYzViMzg2ZTA2OTFhYjhiMjQ3ZGJiODUyZjQuLmQ5Nzc5 YmY2OWFjOWUzOTdjNjE2MDZmOTVjYTcyZmIyYzFmOGM3ODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X VEYvd3RmL2R0b2EvYmlnbnVtLmNjCisrKyBiL1NvdXJjZS9XVEYvd3RmL2R0b2EvYmlnbnVtLmNj CkBAIC0xMDcsNyArMTA3LDcgQEAgbmFtZXNwYWNlIGRvdWJsZV9jb252ZXJzaW9uIHsKICAgICAg ICAgY29uc3QgaW50IGtNYXhVaW50NjREZWNpbWFsRGlnaXRzID0gMTk7CiAgICAgICAgIFplcm8o KTsKICAgICAgICAgaW50IGxlbmd0aCA9IHZhbHVlLmxlbmd0aCgpOwotICAgICAgICBpbnQgcG9z ID0gMDsKKyAgICAgICAgdW5zaWduZWQgaW50IHBvcyA9IDA7CiAgICAgICAgIC8vIExldCdzIGp1 c3Qgc2F5IHRoYXQgZWFjaCBkaWdpdCBuZWVkcyA0IGJpdHMuCiAgICAgICAgIHdoaWxlIChsZW5n dGggPj0ga01heFVpbnQ2NERlY2ltYWxEaWdpdHMpIHsKICAgICAgICAgICAgIHVpbnQ2NF90IGRp Z2l0cyA9IFJlYWRVSW50NjQodmFsdWUsIHBvcywga01heFVpbnQ2NERlY2ltYWxEaWdpdHMpOwo=