151532 2015-11-20 19:32:40 -0800 Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=1 2015-11-23 10:39:35 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen oldest_to_newest 1143930 0 achristensen 2015-11-20 19:32:40 -0800 Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=1 1143931 1 266026 achristensen 2015-11-20 19:38:39 -0800 Created attachment 266026 Patch 1143998 2 266026 benjamin 2015-11-21 21:58:55 -0800 Comment on attachment 266026 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266026&action=review > Source/WebKit2/UIProcess/WebGeolocationManagerProxy.cpp:66 > + if (wasUpdating && !isUpdating()) > + m_provider.stopUpdating(this); > + else { Actually, you only need ASSERT(!isUpdating()); if (wasUpdating) m_provider.stopUpdating(this); If isUpdating() is true, something really fucked up is going on. It looks like the API contract does not require you to change the high accuracy settings if you stop the providers. Let's remove the else {} case. > Tools/ChangeLog:14 > + Properly load about:blank in all WebViews to clean up. IMHO, it would be worth explaining why. Can you add a paragraph explaining that we had a Geolocation provider stopping after its state tracker was destroyed with its stack frame? > Tools/TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:235 > + EXPECT_EQ(GeolocationEvent::DisableHighAccuracy, events[3]); We know these do not work. Can you find a way to make them work? If not, maybe turn them into assertions? 1144192 3 achristensen 2015-11-23 10:37:45 -0800 (In reply to comment #2) > Comment on attachment 266026 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=266026&action=review > > > Source/WebKit2/UIProcess/WebGeolocationManagerProxy.cpp:66 > > + if (wasUpdating && !isUpdating()) > > + m_provider.stopUpdating(this); > > + else { > > Actually, you only need > ASSERT(!isUpdating()); > if (wasUpdating) > m_provider.stopUpdating(this); > > If isUpdating() is true, something really fucked up is going on. > > It looks like the API contract does not require you to change the high > accuracy settings if you stop the providers. Let's remove the else {} case. Done. > > > Tools/ChangeLog:14 > > + Properly load about:blank in all WebViews to clean up. > > IMHO, it would be worth explaining why. > Can you add a paragraph explaining that we had a Geolocation provider > stopping after its state tracker was destroyed with its stack frame? Done. > > > Tools/TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:235 > > + EXPECT_EQ(GeolocationEvent::DisableHighAccuracy, events[3]); > > We know these do not work. Can you find a way to make them work? > > If not, maybe turn them into assertions? These do not work if the process crashes, but they do work if the process does not crash. I'm leaving them as they are. 1144193 4 achristensen 2015-11-23 10:39:35 -0800 http://trac.webkit.org/changeset/192747 266026 2015-11-20 19:38:39 -0800 2015-11-21 21:58:55 -0800 Patch bug-151532-20151120193827.patch text/plain 7545 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MjY5NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTExLTIwICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGNyYXNo IGluIH5XZWJQcm9jZXNzUG9vbCB3aGVuIHVzaW5nIEdlb2xvY2F0aW9uIHdpdGggdXNlTmV0d29y a1Byb2Nlc3M9dHJ1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTUxNTMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvV2ViR2VvbG9jYXRpb25NYW5hZ2VyUHJveHkuY3BwOgorICAgICAg ICAoV2ViS2l0OjpXZWJHZW9sb2NhdGlvbk1hbmFnZXJQcm94eTo6cHJvY2Vzc1Bvb2xEZXN0cm95 ZWQpOgorICAgICAgICAoV2ViS2l0OjpXZWJHZW9sb2NhdGlvbk1hbmFnZXJQcm94eTo6cHJvY2Vz c0RpZENsb3NlKToKKyAgICAgICAgV2hlbiBhIFdlYlByb2Nlc3NQb29sIGlzIGRlc3Ryb3llZCwg b25seSBjYWxsIHN0b3BVcGRhdGluZyBpZiBtX3VwZGF0ZVJlcXVlc3RlcnMuY2xlYXIoKQorICAg ICAgICBzdG9wcGVkIHRoZSB1cGRhdGluZywgbGlrZSB3ZSBkbyBpbiBXZWJHZW9sb2NhdGlvbk1h bmFnZXJQcm94eTo6cmVtb3ZlUmVxdWVzdGVyLgorICAgICAgICBPdGhlcndpc2UsIGNhbGwgc2V0 RW5hYmxlSGlnaEFjY3VyYWN5IGlmIG5lZWRlZCwgYWxzbyBsaWtlIHdlIGRvIGluIFdlYkdlb2xv Y2F0aW9uTWFuYWdlclByb3h5OjpyZW1vdmVSZXF1ZXN0ZXIuCisKIDIwMTUtMTEtMjAgIEFsZXgg Q2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUg TkVUV09SS19QUk9DRVNTIGNvbXBpbGUgZmxhZwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYkdlb2xvY2F0aW9uTWFuYWdlclByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViR2VvbG9jYXRpb25NYW5hZ2VyUHJveHkuY3BwCShyZXZpc2lv biAxOTI2OTQpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViR2VvbG9jYXRpb25NYW5h Z2VyUHJveHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Nyw4ICs1NywxNyBAQCB2b2lkIFdlYkdl b2xvY2F0aW9uTWFuYWdlclByb3h5Ojppbml0aWFsCiAKIHZvaWQgV2ViR2VvbG9jYXRpb25NYW5h Z2VyUHJveHk6OnByb2Nlc3NQb29sRGVzdHJveWVkKCkKIHsKKyAgICBib29sIHdhc1VwZGF0aW5n ID0gaXNVcGRhdGluZygpOworICAgIGJvb2wgaGlnaEFjY3VyYWN5V2FzRW5hYmxlZCA9IGlzSGln aEFjY3VyYWN5RW5hYmxlZCgpOwogICAgIG1fdXBkYXRlUmVxdWVzdGVycy5jbGVhcigpOwotICAg IG1fcHJvdmlkZXIuc3RvcFVwZGF0aW5nKHRoaXMpOworICAgIAorICAgIGlmICh3YXNVcGRhdGlu ZyAmJiAhaXNVcGRhdGluZygpKQorICAgICAgICBtX3Byb3ZpZGVyLnN0b3BVcGRhdGluZyh0aGlz KTsKKyAgICBlbHNlIHsKKyAgICAgICAgYm9vbCBoaWdoQWNjdXJhY3lTaG91bGRCZUVuYWJsZWQg PSBpc0hpZ2hBY2N1cmFjeUVuYWJsZWQoKTsKKyAgICAgICAgaWYgKGhpZ2hBY2N1cmFjeVNob3Vs ZEJlRW5hYmxlZCAhPSBoaWdoQWNjdXJhY3lXYXNFbmFibGVkKQorICAgICAgICAgICAgbV9wcm92 aWRlci5zZXRFbmFibGVIaWdoQWNjdXJhY3kodGhpcywgaGlnaEFjY3VyYWN5U2hvdWxkQmVFbmFi bGVkKTsKKyAgICB9CiB9CiAKIHZvaWQgV2ViR2VvbG9jYXRpb25NYW5hZ2VyUHJveHk6OnByb2Nl c3NEaWRDbG9zZShXZWJQcm9jZXNzUHJveHkqIHdlYlByb2Nlc3NQcm94eSkKSW5kZXg6IFRvb2xz L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5Mjcx OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisy MDE1LTExLTIwICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisK KyAgICAgICAgRml4IGNyYXNoIGluIH5XZWJQcm9jZXNzUG9vbCB3aGVuIHVzaW5nIEdlb2xvY2F0 aW9uIHdpdGggdXNlTmV0d29ya1Byb2Nlc3M9dHJ1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxNTMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDIvR2Vv bG9jYXRpb24uY3BwOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6R2VvbG9jYXRpb25UcmFuc2l0 aW9uVG9IaWdoQWNjdXJhY3lTdGF0ZVRyYWNrZXI6OmV2ZW50c0NoYW5nZWQpOgorICAgICAgICAo VGVzdFdlYktpdEFQSTo6VEVTVCk6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpHZW9sb2NhdGlv blRyYW5zaXRpb25Ub0xvd0FjY3VyYWN5U3RhdGVUcmFja2VyOjpldmVudHNDaGFuZ2VkKToKKyAg ICAgICAgKFRlc3RXZWJLaXRBUEk6Okdlb2xvY2F0aW9uVHJhbnNpdGlvblRvSGlnaEFjY3VyYWN5 U3RhdGVUcmFja2VyOjpHZW9sb2NhdGlvblRyYW5zaXRpb25Ub0hpZ2hBY2N1cmFjeVN0YXRlVHJh Y2tlcik6IERlbGV0ZWQuCisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpHZW9sb2NhdGlvblRyYW5z aXRpb25Ub0xvd0FjY3VyYWN5U3RhdGVUcmFja2VyOjpHZW9sb2NhdGlvblRyYW5zaXRpb25Ub0xv d0FjY3VyYWN5U3RhdGVUcmFja2VyKTogRGVsZXRlZC4KKyAgICAgICAgUHJvcGVybHkgbG9hZCBh Ym91dDpibGFuayBpbiBhbGwgV2ViVmlld3MgdG8gY2xlYW4gdXAuCisgICAgICAgIEFsc28sIGNh bGwgV0tDb250ZXh0U2V0VXNlc05ldHdvcmtQcm9jZXNzKGNvbnRleHQsIHRydWUpIHRvIHNob3cg d2hhdCBjcmFzaCB0aGlzIGZpeGVkLAorICAgICAgICBidXQgdGhhdCB3aWxsIGJlY29tZSB0aGUg ZGVmYXVsdCBzb29uIGFuZCB0aGF0IGNhbGwgd2lsbCBiZSByZW1vdmVkLgorCiAyMDE1LTExLTIw ICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgYWRkIHdhdGNobGlzdCBmb3IgUGVyZm9ybWFuY2VUZXN0cy9Bbmltb21ldGVy IGFuZCBhZGQgbXlzZWxmLgpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQy L0dlb2xvY2F0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dlYktpdDIvR2VvbG9jYXRpb24uY3BwCShyZXZpc2lvbiAxOTI2OTQpCisrKyBUb29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDIvR2VvbG9jYXRpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0zMCw2ICszMCw3IEBACiAjaW5jbHVkZSAiUGxhdGZvcm1VdGlsaXRpZXMuaCIKICNpbmNsdWRl ICJQbGF0Zm9ybVdlYlZpZXcuaCIKICNpbmNsdWRlICJUZXN0LmgiCisjaW5jbHVkZSA8V2ViS2l0 L1dLQ29udGV4dFByaXZhdGUuaD4KICNpbmNsdWRlIDxXZWJLaXQvV0tSZXRhaW5QdHIuaD4KICNp bmNsdWRlIDxzdHJpbmcuaD4KICNpbmNsdWRlIDx2ZWN0b3I+CkBAIC0yMTIsMTQgKzIxMyw5IEBA IFRFU1QoV2ViS2l0MiwgR2VvbG9jYXRpb25CYXNpY1dpdGhIaWdoQWMKIAogLy8gR2VvbG9jYXRp b24gc3RhcnQgd2l0aG91dCBIaWdoIEFjY3VyYWN5LCB0aGVuIHJlcXVpcmVzIEhpZ2ggQWNjdXJh Y3kuCiBzdHJ1Y3QgR2VvbG9jYXRpb25UcmFuc2l0aW9uVG9IaWdoQWNjdXJhY3lTdGF0ZVRyYWNr ZXIgOiBHZW9sb2NhdGlvblN0YXRlVHJhY2tlciB7Ci0gICAgYm9vbCBmaW5pc2hlZEZpcnN0U3Rl cDsKLSAgICBib29sIGZpbmlzaGVkOwotCi0gICAgR2VvbG9jYXRpb25UcmFuc2l0aW9uVG9IaWdo QWNjdXJhY3lTdGF0ZVRyYWNrZXIoKQotICAgICAgICA6IGZpbmlzaGVkRmlyc3RTdGVwKGZhbHNl KQotICAgICAgICAsIGZpbmlzaGVkKGZhbHNlKQotICAgIHsKLSAgICB9CisgICAgYm9vbCBmaW5p c2hlZEZpcnN0U3RlcCB7IGZhbHNlIH07CisgICAgYm9vbCBlbmFibGVkSGlnaEFjY3VyYWN5IHsg ZmFsc2UgfTsKKyAgICBib29sIGZpbmlzaGVkIHsgZmFsc2UgfTsKIAogICAgIHZpcnR1YWwgdm9p ZCBldmVudHNDaGFuZ2VkKCkKICAgICB7CkBAIC0yMzMsMTEgKzIyOSwxOSBAQCBzdHJ1Y3QgR2Vv bG9jYXRpb25UcmFuc2l0aW9uVG9IaWdoQWNjdXJhCiAgICAgICAgICAgICBicmVhazsKICAgICAg ICAgY2FzZSAzOgogICAgICAgICAgICAgRVhQRUNUX0VRKEdlb2xvY2F0aW9uRXZlbnQ6OkVuYWJs ZUhpZ2hBY2N1cmFjeSwgZXZlbnRzWzJdKTsKKyAgICAgICAgICAgIGVuYWJsZWRIaWdoQWNjdXJh Y3kgPSB0cnVlOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgNDoKKyAgICAgICAg ICAgIEVYUEVDVF9FUShHZW9sb2NhdGlvbkV2ZW50OjpEaXNhYmxlSGlnaEFjY3VyYWN5LCBldmVu dHNbM10pOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgNToKKyAgICAgICAgICAg IEVYUEVDVF9FUShHZW9sb2NhdGlvbkV2ZW50OjpTdG9wVXBkYXRpbmcsIGV2ZW50c1s0XSk7CiAg ICAgICAgICAgICBmaW5pc2hlZCA9IHRydWU7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAg ZGVmYXVsdDoKICAgICAgICAgICAgIEVYUEVDVF9UUlVFKGZhbHNlKTsKICAgICAgICAgICAgIGZp bmlzaGVkRmlyc3RTdGVwID0gdHJ1ZTsKKyAgICAgICAgICAgIGVuYWJsZWRIaWdoQWNjdXJhY3kg PSB0cnVlOwogICAgICAgICAgICAgZmluaXNoZWQgPSB0cnVlOwogICAgICAgICB9CiAgICAgfQpA QCAtMjQ2LDYgKzI1MCw3IEBAIHN0cnVjdCBHZW9sb2NhdGlvblRyYW5zaXRpb25Ub0hpZ2hBY2N1 cmEKIFRFU1QoV2ViS2l0MiwgR2VvbG9jYXRpb25UcmFuc2l0aW9uVG9IaWdoQWNjdXJhY3kpCiB7 CiAgICAgV0tSZXRhaW5QdHI8V0tDb250ZXh0UmVmPiBjb250ZXh0KEFkb3B0V0ssIFdLQ29udGV4 dENyZWF0ZSgpKTsKKyAgICBXS0NvbnRleHRTZXRVc2VzTmV0d29ya1Byb2Nlc3MoY29udGV4dC5n ZXQoKSwgdHJ1ZSk7CiAKICAgICBHZW9sb2NhdGlvblRyYW5zaXRpb25Ub0hpZ2hBY2N1cmFjeVN0 YXRlVHJhY2tlciBzdGF0ZVRyYWNrZXI7CiAgICAgc2V0dXBHZW9sb2NhdGlvblByb3ZpZGVyKGNv bnRleHQuZ2V0KCksICZzdGF0ZVRyYWNrZXIpOwpAQCAtMjYwLDE5ICsyNjUsMjAgQEAgVEVTVChX ZWJLaXQyLCBHZW9sb2NhdGlvblRyYW5zaXRpb25Ub0hpZwogICAgIHNldHVwVmlldyhoaWdoQWNj dXJhY3lXZWJWaWV3KTsKICAgICBXS1JldGFpblB0cjxXS1VSTFJlZj4gaGlnaEFjY3VyYWN5VVJM KEFkb3B0V0ssIFV0aWw6OmNyZWF0ZVVSTEZvclJlc291cmNlKCJnZW9sb2NhdGlvbldhdGNoUG9z aXRpb25XaXRoSGlnaEFjY3VyYWN5IiwgImh0bWwiKSk7CiAgICAgV0tQYWdlTG9hZFVSTChoaWdo QWNjdXJhY3lXZWJWaWV3LnBhZ2UoKSwgaGlnaEFjY3VyYWN5VVJMLmdldCgpKTsKKyAgICBVdGls OjpydW4oJnN0YXRlVHJhY2tlci5lbmFibGVkSGlnaEFjY3VyYWN5KTsKKyAgICAKKyAgICBXS1Jl dGFpblB0cjxXS1VSTFJlZj4gcmVzZXRVcmwgPSBhZG9wdFdLKFdLVVJMQ3JlYXRlV2l0aFVURjhD U3RyaW5nKCJhYm91dDpibGFuayIpKTsKKyAgICBXS1BhZ2VMb2FkVVJMKGhpZ2hBY2N1cmFjeVdl YlZpZXcucGFnZSgpLCByZXNldFVybC5nZXQoKSk7CisgICAgVXRpbDo6cnVuKCZzdGF0ZVRyYWNr ZXIuZW5hYmxlZEhpZ2hBY2N1cmFjeSk7CisgICAgV0tQYWdlTG9hZFVSTChsb3dBY2N1cmFjeVdl YlZpZXcucGFnZSgpLCByZXNldFVybC5nZXQoKSk7CiAgICAgVXRpbDo6cnVuKCZzdGF0ZVRyYWNr ZXIuZmluaXNoZWQpOwogfQogCiAvLyBHZW9sb2NhdGlvbiBzdGFydCB3aXRoIEhpZ2ggQWNjdXJh Y3ksIHRoZW4gc2hvdWxkIGZhbGwgYmFjayB0byBsb3cgYWNjdXJhY3kuCiBzdHJ1Y3QgR2VvbG9j YXRpb25UcmFuc2l0aW9uVG9Mb3dBY2N1cmFjeVN0YXRlVHJhY2tlciA6IEdlb2xvY2F0aW9uU3Rh dGVUcmFja2VyIHsKLSAgICBib29sIGZpbmlzaGVkRmlyc3RTdGVwOwotICAgIGJvb2wgZmluaXNo ZWQ7Ci0KLSAgICBHZW9sb2NhdGlvblRyYW5zaXRpb25Ub0xvd0FjY3VyYWN5U3RhdGVUcmFja2Vy KCkKLSAgICAgICAgOiBmaW5pc2hlZEZpcnN0U3RlcChmYWxzZSkKLSAgICAgICAgLCBmaW5pc2hl ZChmYWxzZSkKLSAgICB7Ci0gICAgfQorICAgIGJvb2wgZmluaXNoZWRGaXJzdFN0ZXAgeyBmYWxz ZSB9OworICAgIGJvb2wgZGlzYWJsZWRIaWdoQWNjdXJhY3kgeyBmYWxzZSB9OworICAgIGJvb2wg ZmluaXNoZWQgeyBmYWxzZSB9OwogCiAgICAgdmlydHVhbCB2b2lkIGV2ZW50c0NoYW5nZWQoKQog ICAgIHsKQEAgLTI4NiwxMSArMjkyLDE2IEBAIHN0cnVjdCBHZW9sb2NhdGlvblRyYW5zaXRpb25U b0xvd0FjY3VyYWMKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIDM6CiAgICAgICAg ICAgICBFWFBFQ1RfRVEoR2VvbG9jYXRpb25FdmVudDo6RGlzYWJsZUhpZ2hBY2N1cmFjeSwgZXZl bnRzWzJdKTsKKyAgICAgICAgICAgIGRpc2FibGVkSGlnaEFjY3VyYWN5ID0gdHJ1ZTsKKyAgICAg ICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIDQ6CisgICAgICAgICAgICBFWFBFQ1RfRVEoR2Vv bG9jYXRpb25FdmVudDo6U3RvcFVwZGF0aW5nLCBldmVudHNbM10pOwogICAgICAgICAgICAgZmlu aXNoZWQgPSB0cnVlOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGRlZmF1bHQ6CiAgICAg ICAgICAgICBFWFBFQ1RfVFJVRShmYWxzZSk7CiAgICAgICAgICAgICBmaW5pc2hlZEZpcnN0U3Rl cCA9IHRydWU7CisgICAgICAgICAgICBkaXNhYmxlZEhpZ2hBY2N1cmFjeSA9IHRydWU7CiAgICAg ICAgICAgICBmaW5pc2hlZCA9IHRydWU7CiAgICAgICAgIH0KICAgICB9CkBAIC0zMzQsNiArMzQ1 LDggQEAgVEVTVChXZWJLaXQyLCBHZW9sb2NhdGlvblRyYW5zaXRpb25Ub0xvdwogCiAgICAgV0tS ZXRhaW5QdHI8V0tVUkxSZWY+IHJlc2V0VXJsID0gYWRvcHRXSyhXS1VSTENyZWF0ZVdpdGhVVEY4 Q1N0cmluZygiYWJvdXQ6YmxhbmsiKSk7CiAgICAgV0tQYWdlTG9hZFVSTChoaWdoQWNjdXJhY3lX ZWJWaWV3LnBhZ2UoKSwgcmVzZXRVcmwuZ2V0KCkpOworICAgIFV0aWw6OnJ1bigmc3RhdGVUcmFj a2VyLmRpc2FibGVkSGlnaEFjY3VyYWN5KTsKKyAgICBXS1BhZ2VMb2FkVVJMKGxvd0FjY3VyYWN5 V2ViVmlldy5wYWdlKCksIHJlc2V0VXJsLmdldCgpKTsKICAgICBVdGlsOjpydW4oJnN0YXRlVHJh Y2tlci5maW5pc2hlZCk7CiB9CiAK