151530 2015-11-20 17:04:57 -0800 Web Inspector: Spacebar to toggle Timeline recording doesn't work in Timeline tab after reloading the page 2015-12-01 13:57:00 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1143906 0 joepeck 2015-11-20 17:04:57 -0800 * SUMMARY Spacebar to toggle Timeline recording doesn't work in Timeline tab after reloading the page. * STEPS TO REPRODUCE 1. Inspect this page 2. Show Timelines Tab 3. Cmd+R to reload the page 4. Spacebar to try to toggle start/stop recording => Doesn't work because quick console is focused and this is just inputing spaces * NOTES - Apparently we are focusing the QuickConsole as a result of clearing the log on reload CONSOLE LOG CM.focus() CONSOLE TRACE 0: focus(External/CodeMirror/codemirror.js:1357:22) 1: focus(External/CodeMirror/codemirror.js:4843:63) 2: focus(Views/ConsolePrompt.js:115:31) 3: clear(Controllers/JavaScriptLogViewController.js:84:26) 4: _logCleared(Views/LogContentView.js:643:38) 5: dispatch(Base/Object.js:155:55) 6: dispatchEventToListeners(Base/Object.js:162:17) 7: _delayedMessagesCleared(Controllers/LogManager.js:85:38) 8: _delayedMessagesCleared([native code]) - Apparently this means that if the inspected page does `console.clear` the inspector frontend will suddenly focus the Quick Console. lol! - Some users might be used to a Reload focusing the console. We may need to tweak behavior. 1143907 1 webkit-bug-importer 2015-11-20 17:05:17 -0800 <rdar://problem/23639291> 1143908 2 266021 joepeck 2015-11-20 17:11:21 -0800 Created attachment 266021 [PATCH] Proposed Fix I haven't lived on this much yet. We may want to tweak this. Some ideas: - Maybe Clicking Console Nav Bar's Clear Log button should focus the console - Maybe reload on tabs that support split content (WebInspector.doesCurrentTabSupportSplitContentBrowser()) should focus the console 1145382 3 joepeck 2015-12-01 13:57:00 -0800 <http://trac.webkit.org/changeset/192908> 266021 2015-11-20 17:11:21 -0800 2015-11-20 18:45:04 -0800 [PATCH] Proposed Fix console-focus.patch text/plain 2108 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDc3N2Q2OTYuLmEyMWQxZTEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDE1LTExLTIwICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU3BhY2Vi YXIgdG8gdG9nZ2xlIFRpbWVsaW5lIHJlY29yZGluZyBkb2Vzbid0IHdvcmsgaW4gVGltZWxpbmUg dGFiIGFmdGVyIHJlbG9hZGluZyB0aGUgcGFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxNTMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSWYgcmVsb2FkaW5nIHRoZSBwYWdlIGNhdXNlZCB0aGUgY29u c29sZSB0byBjbGVhciwgdGhhdCB3YXMgdHJpZ2dlcmluZworICAgICAgICB0aGUgY29uc29sZSBw cm9tcHQgdG8gYmUgZm9jdXNlZC4gV2hlbiB0aGUgY29uc29sZSBwcm9tcHQgaXMgZm9jdXNlZCwK KyAgICAgICAga2V5Ym9hcmQgaW5wdXQgbGlrZSBTcGFjZWJhciwgd2FzIGp1c3QgaW5wdXRpbmcg Y2hhcmFjdGVycyBpbnN0ZWFkIG9mCisgICAgICAgIHRyaWdnZXJpbmcgdGhlIGtleWJvYXJkIHNo b3J0Y3V0IHRoYXQgd2FzIGV4cGVjdGVkLgorCisgICAgICAgIFRoaXMgYWxzbyBtZWFucyB0aGF0 IGNvbnNvbGUuY2xlYXIoKSBpbiB0aGUgaW5zcGVjdGVkIHBhZ2Ugd291bGQgY2F1c2UKKyAgICAg ICAgdGhlIGluc3BlY3RvciB0byBmb2N1cyB0aGUgY29uc29sZS4gVGhhdCBpcyB1bmV4cGVjdGVk IGFzIHdlbGwuCisKKyAgICAgICAgRm9jdXNpbmcgdGhlIGNvbnNvbGUgcHJvbXB0IHdoZW5ldmVy IHRoZSBjb25zb2xlIGxvZyBpcyBjbGVhcmVkCisgICAgICAgIGlzIG5vdCBpZGVhbC4gSWYgd2Ug ZG8gd2FudCB0byBmb2N1cyB0aGUgcHJvbXB0IHRoZSBjYWxsZXIgc2hvdWxkCisgICAgICAgIG1h a2UgdGhhdCBkZXRlcm1pbmF0aW9uLCBub3QgY2xlYXIuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL0NvbnRyb2xsZXJzL0phdmFTY3JpcHRMb2dWaWV3Q29udHJvbGxlci5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5KYXZhU2NyaXB0TG9nVmlld0NvbnRyb2xsZXIucHJvdG90eXBlLmNsZWFy KToKKworMjAxNS0xMS0yMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgor CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFRpbWVsaW5lIGRvZXMgbm90IGltbWVkaWF0ZWx5IHVw ZGF0ZSBjdXJyZW50IHRpbWUgYWZ0ZXIgc3dpdGNoaW5nIHRhYnMgd2hpbGUgcmVjb3JkaW5nCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE1MjgKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxl cnMvSmF2YVNjcmlwdExvZ1ZpZXdDb250cm9sbGVyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvSmF2YVNjcmlwdExvZ1ZpZXdDb250cm9sbGVyLmpz CmluZGV4IDg3NTViN2IuLmMyMDBjMDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0phdmFTY3JpcHRMb2dWaWV3Q29udHJvbGxlci5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9K YXZhU2NyaXB0TG9nVmlld0NvbnRyb2xsZXIuanMKQEAgLTgwLDggKzgwLDYgQEAgV2ViSW5zcGVj dG9yLkphdmFTY3JpcHRMb2dWaWV3Q29udHJvbGxlciA9IGNsYXNzIEphdmFTY3JpcHRMb2dWaWV3 Q29udHJvbGxlciBleHQKICAgICAgICAgdGhpcy5fY2xlYXJlZCA9IHRydWU7CiAKICAgICAgICAg dGhpcy5zdGFydE5ld1Nlc3Npb24odHJ1ZSk7Ci0KLSAgICAgICAgdGhpcy5wcm9tcHQuZm9jdXMo KTsKICAgICB9CiAKICAgICBzdGFydE5ld1Nlc3Npb24oY2xlYXJQcmV2aW91c1Nlc3Npb25zKQo=