151529 2015-11-20 16:58:32 -0800 Internal perf dashboard loads ~30MB of data 2017-03-10 19:57:55 -0800 1 1 1 Unclassified WebKit Perf Dashboard WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 151582 1 rniwa rniwa cdumez commit-queue kling koivisto rniwa oldest_to_newest 1143903 0 rniwa 2015-11-20 16:58:32 -0800 Here's yet another JSON API optimization. Don't include data more than 366 days old. 1143909 1 266022 rniwa 2015-11-20 17:12:31 -0800 Created attachment 266022 Fixes the bug 1143924 2 rniwa 2015-11-20 19:12:16 -0800 Committed r192716: <http://trac.webkit.org/changeset/192716> 1144295 3 commit-queue 2015-11-23 22:51:46 -0800 Re-opened since this is blocked by bug 151582 1144314 4 266022 rniwa 2015-11-24 01:00:52 -0800 Comment on attachment 266022 Fixes the bug Alright, I need to change my approach. Change the format of JSON API can reduce the file size from 6.7MB to 2.2MB. Unfortunately, that requires a lot of front-end work so let me finish the rewrite of the interactive chart component first. 1144323 5 rniwa 2015-11-24 02:42:31 -0800 Hm... I can't quite do that either unless we want to create hundreds of tiny HTTP to fetch commit data :( 1286054 6 rniwa 2017-03-10 19:57:55 -0800 This has been fixed in v3 API. 266022 2015-11-20 17:12:31 -0800 2015-11-24 01:00:52 -0800 Fixes the bug bug-151529-20151120171218.patch text/plain 6084 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMTkyNzEwKQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDE1LTExLTIwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIFBlcmYgZGFzaGJvYXJkJ3Mgc2hvdWxkIG5vdCBpbmNsdWRlIHJlc3VsdHMgbW9y ZSB0aGFuIDM2NiBkYXlzIG9sZCBpbiBKU09OCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE1MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBEb24ndCByZXR1cm4gcmVzdWx0cyBtb3JlIHRoYW4gMzY2IGRh eXMgb2xkIGluIC9hcGkvcnVucy8gSlNPTiBBUEkuCisgICAgICAgIFRoaXMgaXMgYSB+NSUgcnVu dGltZSBpbXByb3ZlbWVudCBhbmQgcmVkdWNlcyB0aGUgSlNPTiBmaWxlIHNpemUgYnkgMjAtNTAl IGluIHRoZSBpbnRlcm5hbCBwZXJmIGRhc2hib2FyZC4KKworICAgICAgICAqIHB1YmxpYy9hcGkv cnVucy5waHA6CisgICAgICAgIChtYWluKTogQWRkZWQgdGhlIHN1cHBvcnQgZm9yICI/bm9SZXN1 bHRzIiB0byBhdm9pZCBlY2hvaW5nIHJlc3VsdHMuIFRoaXMgaXMgdXNlZnVsIGZvciBkZWJ1Z2dp bmcuCisgICAgICAgIEFsc28gaW5zdGFudGlhdGUgUnVuc0dlbmVyYXRvciBiZWZvcmUgaXNzdWlu ZyB0aGUgcXVlcnkgdG8gZmluZCBhbGwgY29uZmlndXJhdGlvbnMgc28gdGhhdCB0aGUgcnVudGlt ZSBjb3N0CisgICAgICAgIG9mIGRvaW5nIHNvIHdpbGwgYmUgaW5jbHVkZWQgaW4gZWxhcHNlZFRp bWUuCisgICAgICAgIChSdW5zR2VuZXJhdG9yOjpmZXRjaF9ydW5zKTogU2tpcCBhIHJvdyB3aGVu IGl0cyBidWlsZCBhbmQgY29tbWl0IHRpbWVzIGFyZSBtb3JlIHRoYW4gMzY2IGRheXMgb2xkLgor ICAgICAgICAoUnVuc0dlbmVyYXRvcjo6Zm9ybWF0X3J1bik6IFRha2VzIGJ1aWxkX3RpbWUgYW5k IHJldmlzaW9ucyBhcyBhcmd1bWVudHMgc2luY2UgZmV0Y2hfcnVucyB1c2VzIHRoZW0gbm93Lgor ICAgICAgICAoUnVuc0dlbmVyYXRvcjo6cGFyc2VfcmV2aXNpb25zX2FycmF5KTogQ29tcHV0ZSB0 aGUgbWF4IG9mIGNvbW1pdCB0aW1lcy4KKwogMjAxNS0xMS0yMCAgUnlvc3VrZSBOaXdhICA8cm5p d2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgY2hhcnRQb2ludFJhZGl1cyBmcm9tIGlu dGVyYWN0aXZlIGNoYXJ0IGNvbXBvbmVudApJbmRleDogV2Vic2l0ZXMvcGVyZi53ZWJraXQub3Jn L3B1YmxpYy9hcGkvcnVucy5waHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vic2l0ZXMvcGVyZi53ZWJraXQu b3JnL3B1YmxpYy9hcGkvcnVucy5waHAJKHJldmlzaW9uIDE5MjY5MSkKKysrIFdlYnNpdGVzL3Bl cmYud2Via2l0Lm9yZy9wdWJsaWMvYXBpL3J1bnMucGhwCSh3b3JraW5nIGNvcHkpCkBAIC0xMCwx MCArMTAsMTkgQEAgZnVuY3Rpb24gbWFpbigkcGF0aCkgewogICAgIGlmIChjb3VudCgkcGFydHMp ICE9IDIpCiAgICAgICAgIGV4aXRfd2l0aF9lcnJvcignSW52YWxpZFJlcXVlc3QnKTsKIAorICAg ICR0ZXN0X2dyb3VwX2lkID0gYXJyYXlfZ2V0KCRfR0VULCAndGVzdEdyb3VwJyk7CisgICAgJHNo b3VsZF9jYWNoZSA9IGFycmF5X2dldCgkX0dFVCwgJ2NhY2hlJyk7CisgICAgJHNob3VsZF9lY2hv X3Jlc3VsdHMgPSAhYXJyYXlfa2V5X2V4aXN0cygnbm9SZXN1bHQnLCAkX0dFVCk7CisKICAgICAk ZGIgPSBuZXcgRGF0YWJhc2U7CiAgICAgaWYgKCEkZGItPmNvbm5lY3QoKSkKICAgICAgICAgZXhp dF93aXRoX2Vycm9yKCdEYXRhYmFzZUNvbm5lY3Rpb25GYWlsdXJlJyk7CiAKKyAgICBpZiAoJHRl c3RfZ3JvdXBfaWQpCisgICAgICAgICRnZW5lcmF0b3IgPSBuZXcgUnVuc0dlbmVyYXRvckZvclRl c3RHcm91cCgkZGIsICR0ZXN0X2dyb3VwX2lkKTsKKyAgICBlbHNlCisgICAgICAgICRnZW5lcmF0 b3IgPSBuZXcgUnVuc0dlbmVyYXRvcigkZGIpOworCiAgICAgJHBsYXRmb3JtX2lkID0gaW50dmFs KCRwYXJ0c1swXSk7CiAgICAgJG1ldHJpY19pZCA9IGludHZhbCgkcGFydHNbMV0pOwogICAgICRj b25maWdfcm93cyA9ICRkYi0+cXVlcnlfYW5kX2ZldGNoX2FsbCgnU0VMRUNUICoKQEAgLTIxLDgg KzMwLDYgQEAgZnVuY3Rpb24gbWFpbigkcGF0aCkgewogICAgIGlmICghJGNvbmZpZ19yb3dzKQog ICAgICAgICBleGl0X3dpdGhfZXJyb3IoJ0NvbmZpZ3VyYXRpb25Ob3RGb3VuZCcpOwogCi0gICAg JHRlc3RfZ3JvdXBfaWQgPSBhcnJheV9nZXQoJF9HRVQsICd0ZXN0R3JvdXAnKTsKLSAgICAkc2hv dWxkX2NhY2hlID0gYXJyYXlfZ2V0KCRfR0VULCAnY2FjaGUnKTsKICAgICBpZiAoJHRlc3RfZ3Jv dXBfaWQpCiAgICAgICAgICR0ZXN0X2dyb3VwX2lkID0gaW50dmFsKCR0ZXN0X2dyb3VwX2lkKTsK ICAgICBlbHNlIGlmICgkc2hvdWxkX2NhY2hlKSB7IC8vIE9ubHkgdjEgVUkgbmVlZHMgY2FjaGlu Zy4KQEAgLTMxLDE1ICszOCwxNSBAQCBmdW5jdGlvbiBtYWluKCRwYXRoKSB7CiAgICAgICAgIGhl YWRlcigiQ2FjaGUtQ29udHJvbDogbWF4YWdlPSRtYXhhZ2UiKTsKICAgICB9CiAKLSAgICBpZiAo JHRlc3RfZ3JvdXBfaWQpCi0gICAgICAgICRnZW5lcmF0b3IgPSBuZXcgUnVuc0dlbmVyYXRvckZv clRlc3RHcm91cCgkZGIsICR0ZXN0X2dyb3VwX2lkKTsKLSAgICBlbHNlCi0gICAgICAgICRnZW5l cmF0b3IgPSBuZXcgUnVuc0dlbmVyYXRvcigkZGIpOwotCiAgICAgZm9yZWFjaCAoJGNvbmZpZ19y b3dzIGFzICRjb25maWcpCiAgICAgICAgICRnZW5lcmF0b3ItPmZldGNoX3J1bnMoJGNvbmZpZ1sn Y29uZmlnX3R5cGUnXSwgJGNvbmZpZ1snY29uZmlnX2lkJ10sICRjb25maWdbJ2NvbmZpZ19ydW5z X2xhc3RfbW9kaWZpZWQnXSk7CiAKICAgICAkY29udGVudCA9IHN1Y2Nlc3NfanNvbigkZ2VuZXJh dG9yLT5yZXN1bHRzKCkpOworICAgIGlmICghJHNob3VsZF9lY2hvX3Jlc3VsdHMpIHsKKyAgICAg ICAgZWNobyAkZ2VuZXJhdG9yLT5yZXN1bHRzKClbJ2VsYXBzZWRUaW1lJ107CisgICAgICAgIHJl dHVybjsKKyAgICB9CisKICAgICBpZiAoISR0ZXN0X2dyb3VwX2lkKQogICAgICAgICBnZW5lcmF0 ZV9kYXRhX2ZpbGUoIiRwbGF0Zm9ybV9pZC0kbWV0cmljX2lkLmpzb24iLCAkY29udGVudCk7CiAg ICAgZWNobyAkY29udGVudDsKQEAgLTYzLDExICs3MCwxOSBAQCBjbGFzcyBSdW5zR2VuZXJhdG9y IHsKICAgICBmdW5jdGlvbiBmZXRjaF9ydW5zKCRuYW1lLCAkY29uZmlnX2lkLCAkbGFzdF9tb2Rp ZmllZCkgewogICAgICAgICAkdGhpcy0+bGFzdF9tb2RpZmllZCA9IG1heCgkdGhpcy0+bGFzdF9t b2RpZmllZCwgRGF0YWJhc2U6OnRvX2pzX3RpbWUoJGxhc3RfbW9kaWZpZWQpKTsKIAorICAgICAg ICAkYmVnaW5uaW5nX29mX3RpbWUgPSBpbnR2YWwodGltZSgpIC0gMzY2ICogMjQgKiAzNjAwKSAq IDEwMDA7CisKICAgICAgICAgJHJlc3VsdHMgPSAkdGhpcy0+ZXhlY3V0ZV9xdWVyeSgkY29uZmln X2lkKTsKIAogICAgICAgICAkZm9ybWF0dGVkX3J1bnMgPSBhcnJheSgpOwotICAgICAgICB3aGls ZSAoJHJvdyA9ICR0aGlzLT5kYi0+ZmV0Y2hfbmV4dF9yb3coJHJlc3VsdHMpKQotICAgICAgICAg ICAgYXJyYXlfcHVzaCgkZm9ybWF0dGVkX3J1bnMsIHNlbGY6OmZvcm1hdF9ydW4oJHJvdykpOwor ICAgICAgICB3aGlsZSAoJHJvdyA9ICR0aGlzLT5kYi0+ZmV0Y2hfbmV4dF9yb3coJHJlc3VsdHMp KSB7CisgICAgICAgICAgICAkYnVpbGRfdGltZSA9IERhdGFiYXNlOjp0b19qc190aW1lKCRyb3db J2J1aWxkX3RpbWUnXSk7CisgICAgICAgICAgICAkbWF4X3RpbWUgPSAkYnVpbGRfdGltZTsKKyAg ICAgICAgICAgICRyZXZpc2lvbnMgPSBzZWxmOjpwYXJzZV9yZXZpc2lvbnNfYXJyYXkoJHJvd1sn cmV2aXNpb25zJ10sICRtYXhfdGltZSk7CisgICAgICAgICAgICBpZiAoJG1heF90aW1lIDwgJGJl Z2lubmluZ19vZl90aW1lKQorICAgICAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICAgICAg YXJyYXlfcHVzaCgkZm9ybWF0dGVkX3J1bnMsIHNlbGY6OmZvcm1hdF9ydW4oJHJvdywgJGJ1aWxk X3RpbWUsICRyZXZpc2lvbnMpKTsKKyAgICAgICAgfQogCiAgICAgICAgICR0aGlzLT5yZXN1bHRz WyRuYW1lXSA9ICRmb3JtYXR0ZWRfcnVuczsKICAgICB9CkBAIC04Miw3ICs5Nyw3IEBAIGNsYXNz IFJ1bnNHZW5lcmF0b3IgewogICAgICAgICAgICAgICAgIEdST1VQIEJZIGJ1aWxkX2lkLCBydW5f aWQnLCBhcnJheSgkY29uZmlnX2lkKSk7CiAgICAgfQogCi0gICAgcHJpdmF0ZSBzdGF0aWMgZnVu Y3Rpb24gZm9ybWF0X3J1bigkcnVuKSB7CisgICAgcHJpdmF0ZSBzdGF0aWMgZnVuY3Rpb24gZm9y bWF0X3J1bigkcnVuLCAkYnVpbGRfdGltZSwgJHJldmlzaW9ucykgewogICAgICAgICByZXR1cm4g YXJyYXkoCiAgICAgICAgICAgICAnaWQnID0+IGludHZhbCgkcnVuWydydW5faWQnXSksCiAgICAg ICAgICAgICAnbWVhbicgPT4gZmxvYXR2YWwoJHJ1blsncnVuX21lYW5fY2FjaGUnXSksCkBAIC05 MCwxNCArMTA1LDE0IEBAIGNsYXNzIFJ1bnNHZW5lcmF0b3IgewogICAgICAgICAgICAgJ3N1bScg PT4gZmxvYXR2YWwoJHJ1blsncnVuX3N1bV9jYWNoZSddKSwKICAgICAgICAgICAgICdzcXVhcmVT dW0nID0+IGZsb2F0dmFsKCRydW5bJ3J1bl9zcXVhcmVfc3VtX2NhY2hlJ10pLAogICAgICAgICAg ICAgJ21hcmtlZE91dGxpZXInID0+IERhdGFiYXNlOjppc190cnVlKCRydW5bJ3J1bl9tYXJrZWRf b3V0bGllciddKSwKLSAgICAgICAgICAgICdyZXZpc2lvbnMnID0+IHNlbGY6OnBhcnNlX3Jldmlz aW9uc19hcnJheSgkcnVuWydyZXZpc2lvbnMnXSksCisgICAgICAgICAgICAncmV2aXNpb25zJyA9 PiAkcmV2aXNpb25zLAogICAgICAgICAgICAgJ2J1aWxkJyA9PiAkcnVuWydidWlsZF9pZCddLAot ICAgICAgICAgICAgJ2J1aWxkVGltZScgPT4gRGF0YWJhc2U6OnRvX2pzX3RpbWUoJHJ1blsnYnVp bGRfdGltZSddKSwKKyAgICAgICAgICAgICdidWlsZFRpbWUnID0+ICRidWlsZF90aW1lLAogICAg ICAgICAgICAgJ2J1aWxkTnVtYmVyJyA9PiBpbnR2YWwoJHJ1blsnYnVpbGRfbnVtYmVyJ10pLAog ICAgICAgICAgICAgJ2J1aWxkZXInID0+ICRydW5bJ2J1aWxkX2J1aWxkZXInXSk7CiAgICAgfQog Ci0gICAgcHJpdmF0ZSBzdGF0aWMgZnVuY3Rpb24gcGFyc2VfcmV2aXNpb25zX2FycmF5KCRwb3N0 Z3Jlc19hcnJheSkgeworICAgIHByaXZhdGUgc3RhdGljIGZ1bmN0aW9uIHBhcnNlX3JldmlzaW9u c19hcnJheSgkcG9zdGdyZXNfYXJyYXksICYkbWF4X3RpbWUpIHsKICAgICAgICAgLy8gZS5nLiB7 IihXZWJLaXQsMTMxNDU2LFwiMjAxMi0xMC0xNiAxNDo1MzowMFwiKSIsIihDaHJvbWl1bSwxNjIw MDQsKSJ9CiAgICAgICAgICRvdXRlcl9hcnJheSA9IGpzb25fZGVjb2RlKCdbJyAuIHRyaW0oJHBv c3RncmVzX2FycmF5LCAne30nKSAuICddJyk7CiAgICAgICAgICRyZXZpc2lvbnMgPSBhcnJheSgp OwpAQCAtMTA2LDYgKzEyMSw3IEBAIGNsYXNzIFJ1bnNHZW5lcmF0b3IgewogICAgICAgICAgICAg aWYgKCEkbmFtZV9hbmRfcmV2aXNpb25bMF0pCiAgICAgICAgICAgICAgICAgY29udGludWU7CiAg ICAgICAgICAgICAkdGltZSA9IERhdGFiYXNlOjp0b19qc190aW1lKHRyaW0oJG5hbWVfYW5kX3Jl dmlzaW9uWzJdLCAnIicpKTsKKyAgICAgICAgICAgICRtYXhfdGltZSA9IG1heCgkbWF4X3RpbWUs ICR0aW1lKTsKICAgICAgICAgICAgICRyZXZpc2lvbnNbdHJpbSgkbmFtZV9hbmRfcmV2aXNpb25b MF0sICciJyldID0gYXJyYXkodHJpbSgkbmFtZV9hbmRfcmV2aXNpb25bMV0sICciJyksICR0aW1l KTsKICAgICAgICAgfQogICAgICAgICByZXR1cm4gJHJldmlzaW9uczsK