151517 2015-11-20 14:27:16 -0800 Web Inspector: Remove "Show only resources with breakpoints" filter button 2015-11-20 19:29:38 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 151119 1 mattbaker mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1143822 0 mattbaker 2015-11-20 14:27:16 -0800 * SUMMARY Remove "Show only resources with breakpoints" filter button. This is being done in preparation for https://bugs.webkit.org/show_bug.cgi?id=151119. The filter button helps locate breakpoints in a potentially long list of scripts, but once the sidebar has separate "Breakpoints" and "Scripts" details sections it won't be necessary. 1143823 1 webkit-bug-importer 2015-11-20 14:27:30 -0800 <rdar://problem/23636312> 1143832 2 266001 mattbaker 2015-11-20 14:35:11 -0800 Created attachment 266001 [Patch] Proposed Fix 1143926 3 266001 commit-queue 2015-11-20 19:29:36 -0800 Comment on attachment 266001 [Patch] Proposed Fix Clearing flags on attachment: 266001 Committed r192718: <http://trac.webkit.org/changeset/192718> 1143927 4 commit-queue 2015-11-20 19:29:38 -0800 All reviewed patches have been landed. Closing bug. 266001 2015-11-20 14:35:11 -0800 2015-11-20 19:29:36 -0800 [Patch] Proposed Fix bug-151517-20151120143500.patch text/plain 3323 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNjk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBi YjAyZGNmMDUzMDgxMTM1ZWQzMGJlODIwYzZmNTJiZjg0OTY5ZGFhLi45NjY4YjViODBhNmEyOGE0 ZjBiNzcyYWM3YTVmZmNlMDYxNWE3NTI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNS0xMS0yMCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3ZlICJTaG93IG9ubHkgcmVzb3VyY2VzIHdp dGggYnJlYWtwb2ludHMiIGZpbHRlciBidXR0b24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTUxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZWQgZmlsdGVyIGJ1dHRvbiBpbiBwcmVwYXJhdGlv biBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTExOS4KKwor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRGVidWdnZXJTaWRlYmFyUGFuZWwuanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuRGVidWdnZXJTaWRlYmFyUGFuZWwuc2hvd1Jlc291cmNlc1dp dGhCcmVha3BvaW50c09ubHlGaWx0ZXJGdW5jdGlvbik6IERlbGV0ZWQuCisgICAgICAgIChXZWJJ bnNwZWN0b3IuRGVidWdnZXJTaWRlYmFyUGFuZWwpOiBEZWxldGVkLgorCiAyMDE1LTExLTE5ICBC cmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHlh bmsva2lsbCBzaG9ydGN1dHMgKENUUkwrWSwgSykgZG9uJ3Qgd29yayBpbiBDb25zb2xlIC8gUXVp Y2tDb25zb2xlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9EZWJ1Z2dlclNpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpzCmluZGV4IDM4MTRjMWZm NGZlZmIzZTY4NzcwMmMyMGQ3OTY4NzNmMzUxNDkyMWUuLjc0YTU2Y2YyMjcxYjdmNzU4ZWYzNzIz MTM2ODY5ODgwMjA5OThlYzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBhbmVsLmpzCkBA IC05MywyMSArOTMsNiBAQCBXZWJJbnNwZWN0b3IuRGVidWdnZXJTaWRlYmFyUGFuZWwgPSBjbGFz cyBEZWJ1Z2dlclNpZGViYXJQYW5lbCBleHRlbmRzIFdlYkluc3BlYwogICAgICAgICB0aGlzLl9h bGxVbmNhdWdodEV4Y2VwdGlvbnNCcmVha3BvaW50VHJlZUVsZW1lbnQgPSBuZXcgV2ViSW5zcGVj dG9yLkJyZWFrcG9pbnRUcmVlRWxlbWVudChXZWJJbnNwZWN0b3IuZGVidWdnZXJNYW5hZ2VyLmFs bFVuY2F1Z2h0RXhjZXB0aW9uc0JyZWFrcG9pbnQsIFdlYkluc3BlY3Rvci5EZWJ1Z2dlclNpZGVi YXJQYW5lbC5FeGNlcHRpb25JY29uU3R5bGVDbGFzc05hbWUsIFdlYkluc3BlY3Rvci5VSVN0cmlu ZygiQWxsIFVuY2F1Z2h0IEV4Y2VwdGlvbnMiKSk7CiAKICAgICAgICAgdGhpcy5maWx0ZXJCYXIu cGxhY2Vob2xkZXIgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkZpbHRlciBCcmVha3BvaW50IExp c3QiKTsKLSAgICAgICAgdmFyIHNob3dSZXNvdXJjZXNXaXRoQnJlYWtwb2ludHNPbmx5RmlsdGVy RnVuY3Rpb24gPSBmdW5jdGlvbih0cmVlRWxlbWVudCkKLSAgICAgICAgewotICAgICAgICAgICAg Ly8gS2VlcCBicmVha3BvaW50cy4KLSAgICAgICAgICAgIGlmICh0cmVlRWxlbWVudCBpbnN0YW5j ZW9mIFdlYkluc3BlY3Rvci5CcmVha3BvaW50VHJlZUVsZW1lbnQpCi0gICAgICAgICAgICAgICAg cmV0dXJuIHRydWU7Ci0KLSAgICAgICAgICAgIC8vIEtlZXAgcmVzb3VyY2VzIHdpdGggYnJlYWtw b2ludHMuCi0gICAgICAgICAgICBpZiAodHJlZUVsZW1lbnQuaGFzQ2hpbGRyZW4pIHsKLSAgICAg ICAgICAgICAgICBmb3IgKHZhciBjaGlsZCBvZiB0cmVlRWxlbWVudC5jaGlsZHJlbikgewotICAg ICAgICAgICAgICAgICAgICBpZiAoY2hpbGQgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuQnJlYWtw b2ludFRyZWVFbGVtZW50KQotICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7Ci0g ICAgICAgICAgICAgICAgfQotICAgICAgICAgICAgfQotICAgICAgICAgICAgcmV0dXJuIGZhbHNl OwotICAgICAgICB9OwogCiAgICAgICAgIHZhciBzaG93UmVzb3VyY2VzV2l0aElzc3Vlc09ubHlG aWx0ZXJGdW5jdGlvbiA9IGZ1bmN0aW9uKHRyZWVFbGVtZW50KQogICAgICAgICB7CkBAIC0xMjUs NyArMTEwLDYgQEAgV2ViSW5zcGVjdG9yLkRlYnVnZ2VyU2lkZWJhclBhbmVsID0gY2xhc3MgRGVi dWdnZXJTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXZWJJbnNwZWMKICAgICAgICAgICAgIHJldHVybiBm YWxzZTsKICAgICAgICAgfTsKIAotICAgICAgICB0aGlzLmZpbHRlckJhci5hZGRGaWx0ZXJCYXJC dXR0b24oImRlYnVnZ2VyLXNob3ctcmVzb3VyY2VzLXdpdGgtYnJlYWtwb2ludHMtb25seSIsIHNo b3dSZXNvdXJjZXNXaXRoQnJlYWtwb2ludHNPbmx5RmlsdGVyRnVuY3Rpb24sIHRydWUsIFdlYklu c3BlY3Rvci5VSVN0cmluZygiU2hvdyBvbmx5IHJlc291cmNlcyB3aXRoIGJyZWFrcG9pbnRzLiIp LCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlNob3cgcmVzb3VyY2VzIHdpdGggYW5kIHdpdGhvdXQg YnJlYWtwb2ludHMuIiksICJJbWFnZXMvQnJlYWtwb2ludHMuc3ZnIiwgMTUsIDE1KTsKICAgICAg ICAgdGhpcy5maWx0ZXJCYXIuYWRkRmlsdGVyQmFyQnV0dG9uKCJkZWJ1Z2dlci1zaG93LXJlc291 cmNlcy13aXRoLWlzc3Vlcy1vbmx5Iiwgc2hvd1Jlc291cmNlc1dpdGhJc3N1ZXNPbmx5RmlsdGVy RnVuY3Rpb24sIHRydWUsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiU2hvdyBvbmx5IHJlc291cmNl cyB3aXRoIGlzc3Vlcy4iKSwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJTaG93IHJlc291cmNlcyB3 aXRoIGFuZCB3aXRob3V0IGlzc3Vlcy4iKSwgIkltYWdlcy9FcnJvcnMuc3ZnIiwgMTUsIDE1KTsK IAogICAgICAgICB0aGlzLl9icmVha3BvaW50c0NvbnRlbnRUcmVlT3V0bGluZSA9IHRoaXMuY29u dGVudFRyZWVPdXRsaW5lOwo=