151510 2015-11-20 13:17:52 -0800 Perf dashboard should always show comparison to baseline and target even if one is missing 2016-02-16 13:53:31 -0800 1 1 1 Unclassified WebKit Perf Dashboard WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa cdumez commit-queue dewei_zhu jond kling koivisto rniwa timothy oldest_to_newest 1143769 0 rniwa 2015-11-20 13:17:52 -0800 When either target or baseline is missing, we should always show the comparison against the other. 1143776 1 265986 rniwa 2015-11-20 13:23:19 -0800 Created attachment 265986 Fixes the bug 1144895 2 265986 commit-queue 2015-11-30 13:09:54 -0800 Comment on attachment 265986 Fixes the bug Clearing flags on attachment: 265986 Committed r192817: <http://trac.webkit.org/changeset/192817> 1144896 3 commit-queue 2015-11-30 13:09:58 -0800 All reviewed patches have been landed. Closing bug. 265986 2015-11-20 13:23:19 -0800 2015-11-30 13:09:54 -0800 Fixes the bug bug-151510-20151120132309.patch text/plain 3279 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMTkyNjk0KQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIzIEBACisyMDE1LTExLTIwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIFBlcmYgZGFzaGJvYXJkIHNob3VsZCBhbHdheXMgc2hvdyBjb21wYXJpc29uIHRv IGJhc2VsaW5lIGFuZCB0YXJnZXQgZXZlbiBpZiBvbmUgaXMgbWlzc2luZworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxNTEwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2hvdyB0aGUgY29tcGFyaXNvbiBz dGF0dXMgYWdhaW5zdCB0aGUgYmFzZWxpbmUgd2hlbiBiYXNlbGluZSBpcyBwcmVzZW50IGJ1dCB0 YXJnZXQgaXMgbWlzc2luZy4KKworICAgICAgICBUbyBtYWtlIHRoZSBjb2RlIG1vcmUgcmVhZGFi bGUsIHRoaXMgcGF0Y2ggc3BsaXRzIHRoZSBsb2dpYyBpbnRvIHRocmVlIGNhc2VzOgorICAgICAg ICAxLiBCb3RoIGJhc2VsaW5lIGFuZCB0YXJnZXQgYXJlIHByZXNlbnQKKyAgICAgICAgMi4gT25s eSBiYXNlbGluZSBpcyBwcmVzZW50CisgICAgICAgIDMuIE9ubHkgdGFyZ2V0IGlzIHByZXNlbnQK KworICAgICAgICBBbHNvIGV4dHJhY3RlZCBhIGhlbHBlciBmdW5jdGlvbiB0byBjb25zdHJ1Y3Qg dGhlIGxhYmVsLgorCisgICAgICAgICogcHVibGljL3YyL2FwcC5qczoKKyAgICAgICAgKC5sYWJl bEZvckRpZmYpOiBBZGRlZC4KKyAgICAgICAgKEFwcC5QYW5lLmNvbXB1dGVTdGF0dXMpOgorCiAy MDE1LTExLTIwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJl bW92ZSBjaGFydFBvaW50UmFkaXVzIGZyb20gaW50ZXJhY3RpdmUgY2hhcnQgY29tcG9uZW50Cklu ZGV4OiBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YyL2FwcC5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YyL2FwcC5qcwkocmV2aXNpb24g MTkyNjkxKQorKysgV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92Mi9hcHAuanMJKHdv cmtpbmcgY29weSkKQEAgLTQ4NiwxNSArNDg2LDI3IEBAIEFwcC5QYW5lID0gRW1iZXIuT2JqZWN0 LmV4dGVuZCh7CiAgICAgICAgIHZhciBjbGFzc05hbWUgPSAnJzsKICAgICAgICAgdmFyIGZvcm1h dHRlciA9IGQzLmZvcm1hdCgnLjNwJyk7CiAKKyAgICAgICAgZnVuY3Rpb24gbGFiZWxGb3JEaWZm KGRpZmYsIG5hbWUpIHsgcmV0dXJuIGZvcm1hdHRlcihNYXRoLmFicyhkaWZmKSkgKyAnICcgKyAo ZGlmZiA+IDAgPyAnYWJvdmUnIDogJ2JlbG93JykgKyAnICcgKyBuYW1lOyB9CisKICAgICAgICAg dmFyIHNtYWxsZXJJc0JldHRlciA9IGNoYXJ0RGF0YS5zbWFsbGVySXNCZXR0ZXI7Ci0gICAgICAg IGlmIChkaWZmRnJvbUJhc2VsaW5lICE9PSB1bmRlZmluZWQgJiYgZGlmZkZyb21CYXNlbGluZSA+ IDAgPT0gc21hbGxlcklzQmV0dGVyKSB7Ci0gICAgICAgICAgICBsYWJlbCA9IGZvcm1hdHRlcihN YXRoLmFicyhkaWZmRnJvbUJhc2VsaW5lKSkgKyAnICcgKyAoc21hbGxlcklzQmV0dGVyID8gJ2Fi b3ZlJyA6ICdiZWxvdycpICsgJyBiYXNlbGluZSc7Ci0gICAgICAgICAgICBjbGFzc05hbWUgPSAn d29yc2UnOwotICAgICAgICB9IGVsc2UgaWYgKGRpZmZGcm9tVGFyZ2V0ICE9PSB1bmRlZmluZWQg JiYgZGlmZkZyb21UYXJnZXQgPCAwID09IHNtYWxsZXJJc0JldHRlcikgewotICAgICAgICAgICAg bGFiZWwgPSBmb3JtYXR0ZXIoTWF0aC5hYnMoZGlmZkZyb21UYXJnZXQpKSArICcgJyArIChzbWFs bGVySXNCZXR0ZXIgPyAnYmVsb3cnIDogJ2Fib3ZlJykgKyAnIHRhcmdldCc7Ci0gICAgICAgICAg ICBjbGFzc05hbWUgPSAnYmV0dGVyJzsKLSAgICAgICAgfSBlbHNlIGlmIChkaWZmRnJvbVRhcmdl dCAhPT0gdW5kZWZpbmVkKQotICAgICAgICAgICAgbGFiZWwgPSBmb3JtYXR0ZXIoTWF0aC5hYnMo ZGlmZkZyb21UYXJnZXQpKSArICcgdW50aWwgdGFyZ2V0JzsKKyAgICAgICAgaWYgKGRpZmZGcm9t QmFzZWxpbmUgIT09IHVuZGVmaW5lZCAmJiBkaWZmRnJvbVRhcmdldCAhPT0gdW5kZWZpbmVkKSB7 CisgICAgICAgICAgICBpZiAoZGlmZkZyb21CYXNlbGluZSA+IDAgPT0gc21hbGxlcklzQmV0dGVy KSB7CisgICAgICAgICAgICAgICAgbGFiZWwgPSBsYWJlbEZvckRpZmYoZGlmZkZyb21CYXNlbGlu ZSwgJ2Jhc2VsaW5lJyk7CisgICAgICAgICAgICAgICAgY2xhc3NOYW1lID0gJ3dvcnNlJzsKKyAg ICAgICAgICAgIH0gZWxzZSBpZiAoZGlmZkZyb21UYXJnZXQgPCAwID09IHNtYWxsZXJJc0JldHRl cikgeworICAgICAgICAgICAgICAgIGxhYmVsID0gbGFiZWxGb3JEaWZmKGRpZmZGcm9tQmFzZWxp bmUsICd0YXJnZXQnKTsKKyAgICAgICAgICAgICAgICBjbGFzc05hbWUgPSAnYmV0dGVyJzsKKyAg ICAgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgICAgIGxhYmVsID0gZm9ybWF0dGVyKE1hdGgu YWJzKGRpZmZGcm9tVGFyZ2V0KSkgKyAnIHVudGlsIHRhcmdldCc7CisgICAgICAgIH0gZWxzZSBp ZiAoZGlmZkZyb21CYXNlbGluZSAhPT0gdW5kZWZpbmVkKSB7CisgICAgICAgICAgICBsYWJlbCA9 IGxhYmVsRm9yRGlmZihkaWZmRnJvbUJhc2VsaW5lLCAnYmFzZWxpbmUnKTsKKyAgICAgICAgICAg IGlmIChkaWZmRnJvbUJhc2VsaW5lID4gMCA9PSBzbWFsbGVySXNCZXR0ZXIpCisgICAgICAgICAg ICAgICAgY2xhc3NOYW1lID0gJ3dvcnNlJzsKKyAgICAgICAgfSBlbHNlIGlmIChkaWZmRnJvbVRh cmdldCAhPT0gdW5kZWZpbmVkKSB7CisgICAgICAgICAgICBsYWJlbCA9IGxhYmVsRm9yRGlmZihk aWZmRnJvbVRhcmdldCwgJ3RhcmdldCcpOworICAgICAgICAgICAgaWYgKGRpZmZGcm9tVGFyZ2V0 IDwgMCA9PSBzbWFsbGVySXNCZXR0ZXIpCisgICAgICAgICAgICAgICAgY2xhc3NOYW1lID0gJ2Jl dHRlcic7CisgICAgICAgIH0KIAogICAgICAgICB2YXIgdmFsdWVEZWx0YSA9IG51bGw7CiAgICAg ICAgIHZhciByZWxhdGl2ZURlbHRhID0gbnVsbDsK