151507 2015-11-20 12:23:44 -0800 Modern IDB: IDBTransaction::hasPendingActivity() was wrong, leading to premature GC of the wrapper 2015-12-08 16:08:45 -0800 1 1 1 Unclassified WebKit WebCore Misc. Safari 9 Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 beidson beidson ryanhaddad oldest_to_newest 1143732 0 beidson 2015-11-20 12:23:44 -0800 Modern IDB: IDBTransaction::hasPendingActivity() was wrong, leading to premature GC of the wrapper Since the JS wrapper for an IDBTransaction might have been GC'ed before the transaction was done, javascript event callbacks to the transaction would fail. This would stall many tests, which would fail with a timeout. Because it's GC and therefore timing related, it showed up as flakiness. Known cases: https://bugs.webkit.org/show_bug.cgi?id=151219 https://bugs.webkit.org/show_bug.cgi?id=151364 https://bugs.webkit.org/show_bug.cgi?id=151389 https://bugs.webkit.org/show_bug.cgi?id=151448 However, the bug was fixed in https://trac.webkit.org/changeset/192687 So I suspect that all of these tests will un-flake going forward. I'll be closing all of those bugs as dupes of this one, and then once we're sure they've unflaked we can revert the TestExpectations changes made in each of those bugs. 1143735 1 beidson 2015-11-20 12:24:26 -0800 *** Bug 151219 has been marked as a duplicate of this bug. *** 1143737 2 beidson 2015-11-20 12:24:29 -0800 *** Bug 151364 has been marked as a duplicate of this bug. *** 1143739 3 beidson 2015-11-20 12:24:32 -0800 *** Bug 151389 has been marked as a duplicate of this bug. *** 1143741 4 beidson 2015-11-20 12:24:36 -0800 *** Bug 151448 has been marked as a duplicate of this bug. *** 1147510 5 beidson 2015-12-08 16:02:26 -0800 (In reply to comment #0) > Known cases: > https://bugs.webkit.org/show_bug.cgi?id=151219 > https://bugs.webkit.org/show_bug.cgi?id=151364 > https://bugs.webkit.org/show_bug.cgi?id=151389 > https://bugs.webkit.org/show_bug.cgi?id=151448 > > However, the bug was fixed in https://trac.webkit.org/changeset/192687 All of the tests marked flaky in those 4 bugs have unflaked since 192687. 1147513 6 266950 beidson 2015-12-08 16:04:34 -0800 Created attachment 266950 Patch v1 1147517 7 beidson 2015-12-08 16:08:45 -0800 https://trac.webkit.org/changeset/193792 266950 2015-12-08 16:04:34 -0800 2015-12-08 16:06:56 -0800 Patch v1 patch text/plain 1893 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwMTE3YTE2Li45YzUzOWE5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTUtMTIt MDggIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisgICAgICAgIE1vZGVybiBJ REI6IElEQlRyYW5zYWN0aW9uOjpoYXNQZW5kaW5nQWN0aXZpdHkoKSB3YXMgd3JvbmcsIGxlYWRp bmcgdG8gcHJlbWF0dXJlIEdDIG9mIHRoZSB3cmFwcGVyLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxNTA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQSBoYW5kZnVsIG9mIHRlc3RzIHdlcmUgbWFya2Vk IGZsYWt5IGFuZCB0cmFja2VkIGJhY2sgdG8gdGhpcyBidWcuCisgICAgICAgIAorICAgICAgICBF dmVyIHNpbmNlIHRoZSBwcmVzdW1lZCBmaXggZm9yIHRoaXMgYnVnIChyMTkyNjg3KSB0aGUgZmxh a2luZXNzIGRhc2hib2FyZCBzYXlzIHRoZXkgcGFzcy4KKyAgICAgICAgCisgICAgICAgICogcGxh dGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25zOiBSZS1lbmFibGUgdGhlIG5vLWxvbmdlci1m bGFreSB0ZXN0cy4KKworMjAxNS0xMi0wOCAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5j b20+CisKICAgICAgICAgTW9yZSBJREIgVGVzdEV4cGVjdGF0aW9ucyBnYXJkZW5pbmcuCiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgQWxleCBDaHJpc3RlbnNlbi4KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3BsYXRmb3JtL21hYy13azEvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy13azEvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBiMzM2MDM0Li5lOWUzMjUyIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2sxL1Rlc3RFeHBlY3RhdGlvbnMKKysr IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMS9UZXN0RXhwZWN0YXRpb25zCkBAIC0yMjUs MTYgKzIyNSw2IEBAIHdlYmtpdC5vcmcvYi8xNTAzNjcgWyBNYXZlcmlja3MgXSBmYXN0L2NhbnZh cy93ZWJnbC9vZXMtdGV4dHVyZS1oYWxmLWZsb2F0Lmh0bWwKICMgVGhpcyB0ZXN0IGdpdmVzIGEg ZGlmZmVyZW50IG91dHB1dCBvbiBFbENhcGl0YW4td2sxIG9ubHkuCiBbIEVsQ2FwaXRhbisgXSBm YXN0L3JlcGxhY2VkL3JlcGxhY2VkLWJyZWFraW5nLmh0bWwgWyBGYWlsdXJlIF0KIAotd2Via2l0 Lm9yZy9iLzE1MTIxOSBzdG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vaWRiaW5kZXgtcHJvcGVydGll cy1iYXNpYy5odG1sIFsgUGFzcyBUaW1lb3V0IF0KLQotd2Via2l0Lm9yZy9iLzE1MTM2NCBzdG9y YWdlL2luZGV4ZWRkYi9tb2Rlcm4vZ2V0LWluZGV4LWZhaWx1cmVzLmh0bWwgWyBQYXNzIFRpbWVv dXQgXQotCi13ZWJraXQub3JnL2IvMTUxMzg5IHN0b3JhZ2UvaW5kZXhlZGRiL21vZGVybi9hYm9y dGVkLXB1dC5odG1sIFsgUGFzcyBUaW1lb3V0IF0KLQotd2Via2l0Lm9yZy9iLzE1MTQ0OCBzdG9y YWdlL2luZGV4ZWRkYi9tb2Rlcm4vY3Vyc29yLTIuaHRtbCBbIFBhc3MgVGltZW91dCBdCi13ZWJr aXQub3JnL2IvMTUxNDQ4IHN0b3JhZ2UvaW5kZXhlZGRiL21vZGVybi9jdXJzb3ItMy5odG1sIFsg UGFzcyBUaW1lb3V0IF0KLXdlYmtpdC5vcmcvYi8xNTE0NDggc3RvcmFnZS9pbmRleGVkZGIvbW9k ZXJuL2N1cnNvci00Lmh0bWwgWyBQYXNzIFRpbWVvdXQgXQotCiAjIyMgRU5EIE9GICgyKSBGYWls dXJlcyB3aXRob3V0IGJ1ZyByZXBvcnRzCiAjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjCiAK