151500 2015-11-20 10:17:36 -0800 super use should be recorded in per-function scope 2015-11-20 13:20:07 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 150792 1 ysuzuki ysuzuki benjamin commit-queue fpizlo ggaren keith_miller mark.lam msaboff saam oldest_to_newest 1143680 0 ysuzuki 2015-11-20 10:17:36 -0800 Super use should be recorded in per-function scope 1143682 1 265968 ysuzuki 2015-11-20 10:26:14 -0800 Created attachment 265968 Patch 1143683 2 ysuzuki 2015-11-20 10:27:41 -0800 While implementing "super" with generator in 150792, I've found it. 1143706 3 265968 ggaren 2015-11-20 11:02:54 -0800 Comment on attachment 265968 Patch r=me 1143744 4 265968 ysuzuki 2015-11-20 12:32:58 -0800 Comment on attachment 265968 Patch Thanks :) 1143772 5 265968 commit-queue 2015-11-20 13:20:03 -0800 Comment on attachment 265968 Patch Clearing flags on attachment: 265968 Committed r192695: <http://trac.webkit.org/changeset/192695> 1143773 6 commit-queue 2015-11-20 13:20:07 -0800 All reviewed patches have been landed. Closing bug. 265968 2015-11-20 10:26:14 -0800 2015-11-20 13:20:03 -0800 Patch bug-151500-20151121032601.patch text/plain 6710 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNjg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj NDhjNjBhNTMzYjYzNDM5MjVmM2U2NzVkZWNlNTZiNDk3Y2Q3MWVjLi5jODIxYzhmYzA5ZWM2NGRm ZDZlMWI3NzY5MzUyMzI2Yzk2ZTYzZTJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNyBAQAorMjAxNS0xMS0yMCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBTdXBlciB1c2Ugc2hvdWxkIGJlIHJlY29yZGVkIGluIHBlci1mdW5j dGlvbiBzY29wZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTUxNTAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgInN1cGVyIiB1c2UgaXMgcHJvaGliaXRlZCB1bmRlciB0aGUgbm9uLWNvbnN0cnVjdG9yIC8g bm9uLWNsYXNzLW1ldGhvZC1yZWxhdGVkIGZ1bmN0aW9ucy4KKyAgICAgICAgVGhpcyAic3VwZXIi IHVzZSBzaG91bGQgYmUgcmVjb3JkZWQgaW4gcGVyLWZ1bmN0aW9uIHNjb3BlIHRvIGNoZWNrIGl0 cyBpbmNvcnJlY3QgdXNlIGFmdGVyCisgICAgICAgIHBhcnNpbmcgYSBmdW5jdGlvbi4KKyAgICAg ICAgQ3VycmVudGx5LCB3ZSBhY2NpZGVudGFsbHkgcmVjb3JkIGl0IHRvIGEgbGV4aWNhbCBjdXJy ZW50IHNjb3BlLiBTbyB3aGVuIHVzaW5nICJzdXBlciIgaW5zaWRlCisgICAgICAgIGEgYmxvY2sg c2NvcGUsIG91ciAic3VwZXIiIHVzZSBndWFyZCBtaXNzIGl0LgorCisgICAgICAgICogcGFyc2Vy L1BhcnNlci5jcHA6CisgICAgICAgIChKU0M6OlBhcnNlcjxMZXhlclR5cGU+OjpwYXJzZU1lbWJl ckV4cHJlc3Npb24pOgorICAgICAgICAqIHBhcnNlci9QYXJzZXIuaDoKKyAgICAgICAgKEpTQzo6 UGFyc2VyOjpjdXJyZW50VmFyaWFibGVTY29wZSk6CisgICAgICAgIChKU0M6OlBhcnNlcjo6Y3Vy cmVudEZ1bmN0aW9uU2NvcGUpOgorICAgICAgICAoSlNDOjpQYXJzZXI6OmRlY2xhcmVWYXJpYWJs ZSk6CisgICAgICAgICogdGVzdHMvc3RyZXNzL3N1cGVyLWluLWxleGljYWwtc2NvcGUuanM6IEFk ZGVkLgorICAgICAgICAodGVzdFN5bnRheCk6CisgICAgICAgICh0ZXN0U3ludGF4RXJyb3IpOgor ICAgICAgICAodGVzdFN5bnRheEVycm9yLnRlc3QpOgorCiAyMDE1LTExLTE5ICBKb3NlcGggUGVj b3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTg5NDMz KSBXZWIgSW5zcGVjdG9yOiBKU0NvbnRleHQgaW5zcGVjdGlvbiBleGNlcHRpb25zIHNob3VsZCBp bmNsdWRlIG5hdGl2ZSBjYWxsIGZyYW1lcyBieSBkZWZhdWx0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cGFyc2VyL1BhcnNlci5jcHAKaW5kZXggNGViODU1YTYzN2M4ODU5YmI1OTVkNDYxMWJjMmVjNTZk NGIyNjAyMi4uNjg3NGIyN2UzOTA5MDdjOGU0MTQ5ODI2YzM3OWU0MmNmNTljZTUyYSAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcApAQCAtMzU1NSw3ICszNTU1LDcgQEAg QUxXQVlTX0lOTElORSBzdGF0aWMgYm9vbCBpc1VuYXJ5T3AoSlNUb2tlblR5cGUgdG9rZW4pCiAg ICAgICAgIHNlbWFudGljRmFpbElmRmFsc2UoY3VycmVudFNjb3BlKCktPmlzRnVuY3Rpb24oKSwg InN1cGVyIGlzIG9ubHkgdmFsaWQgaW5zaWRlIGZ1bmN0aW9ucyIpOwogICAgICAgICBiYXNlID0g Y29udGV4dC5jcmVhdGVTdXBlckV4cHIobG9jYXRpb24pOwogICAgICAgICBuZXh0KCk7Ci0gICAg ICAgIGN1cnJlbnRTY29wZSgpLT5zZXROZWVkc1N1cGVyQmluZGluZygpOworICAgICAgICBjdXJy ZW50RnVuY3Rpb25TY29wZSgpLT5zZXROZWVkc1N1cGVyQmluZGluZygpOwogICAgIH0gZWxzZSBp ZiAoIWJhc2VJc05ld1RhcmdldCkKICAgICAgICAgYmFzZSA9IHBhcnNlUHJpbWFyeUV4cHJlc3Np b24oY29udGV4dCk7CiAKQEAgLTM1OTAsNyArMzU5MCw3IEBAIEFMV0FZU19JTkxJTkUgc3RhdGlj IGJvb2wgaXNVbmFyeU9wKEpTVG9rZW5UeXBlIHRva2VuKQogICAgICAgICAgICAgICAgIFRyZWVB cmd1bWVudHMgYXJndW1lbnRzID0gcGFyc2VBcmd1bWVudHMoY29udGV4dCwgQWxsb3dTcHJlYWQp OwogICAgICAgICAgICAgICAgIGZhaWxJZkZhbHNlKGFyZ3VtZW50cywgIkNhbm5vdCBwYXJzZSBj YWxsIGFyZ3VtZW50cyIpOwogICAgICAgICAgICAgICAgIGlmIChiYXNlSXNTdXBlcikKLSAgICAg ICAgICAgICAgICAgICAgY3VycmVudFNjb3BlKCktPnNldEhhc0RpcmVjdFN1cGVyKCk7CisgICAg ICAgICAgICAgICAgICAgIGN1cnJlbnRGdW5jdGlvblNjb3BlKCktPnNldEhhc0RpcmVjdFN1cGVy KCk7CiAgICAgICAgICAgICAgICAgYmFzZSA9IGNvbnRleHQubWFrZUZ1bmN0aW9uQ2FsbE5vZGUo c3RhcnRMb2NhdGlvbiwgYmFzZSwgYXJndW1lbnRzLCBleHByZXNzaW9uU3RhcnQsIGV4cHJlc3Np b25FbmQsIGxhc3RUb2tlbkVuZFBvc2l0aW9uKCkpOwogICAgICAgICAgICAgfQogICAgICAgICAg ICAgbV9ub25MSFNDb3VudCA9IG5vbkxIU0NvdW50OwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIv UGFyc2VyLmgKaW5kZXggNjI5NGYzMTQxMjYwNThmODIzNGJlOGI0NDk5NmZkMTZmYTFhMDhiNi4u MTdiMGU4MWFlYTFkODljNGZlYzk0NDc1N2M3ZjQ5NWVjNTA0NzczZSAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcGFyc2VyL1BhcnNlci5oCkBAIC03ODcsNiArNzg3LDMwIEBAIGNsYXNzIFBhcnNlciB7 CiAgICAgewogICAgICAgICByZXR1cm4gU2NvcGVSZWYoJm1fc2NvcGVTdGFjaywgbV9zY29wZVN0 YWNrLnNpemUoKSAtIDEpOwogICAgIH0KKworICAgIFNjb3BlUmVmIGN1cnJlbnRWYXJpYWJsZVNj b3BlKCkKKyAgICB7CisgICAgICAgIHVuc2lnbmVkIGkgPSBtX3Njb3BlU3RhY2suc2l6ZSgpIC0g MTsKKyAgICAgICAgQVNTRVJUKGkgPCBtX3Njb3BlU3RhY2suc2l6ZSgpKTsKKyAgICAgICAgd2hp bGUgKCFtX3Njb3BlU3RhY2tbaV0uYWxsb3dzVmFyRGVjbGFyYXRpb25zKCkpIHsKKyAgICAgICAg ICAgIGktLTsKKyAgICAgICAgICAgIEFTU0VSVChpIDwgbV9zY29wZVN0YWNrLnNpemUoKSk7Cisg ICAgICAgIH0KKyAgICAgICAgcmV0dXJuIFNjb3BlUmVmKCZtX3Njb3BlU3RhY2ssIGkpOworICAg IH0KKworICAgIFNjb3BlUmVmIGN1cnJlbnRGdW5jdGlvblNjb3BlKCkKKyAgICB7CisgICAgICAg IHVuc2lnbmVkIGkgPSBtX3Njb3BlU3RhY2suc2l6ZSgpIC0gMTsKKyAgICAgICAgQVNTRVJUKGkg PCBtX3Njb3BlU3RhY2suc2l6ZSgpKTsKKyAgICAgICAgd2hpbGUgKGkgJiYgIW1fc2NvcGVTdGFj a1tpXS5pc0Z1bmN0aW9uQm91bmRhcnkoKSkgeworICAgICAgICAgICAgaS0tOworICAgICAgICAg ICAgQVNTRVJUKGkgPCBtX3Njb3BlU3RhY2suc2l6ZSgpKTsKKyAgICAgICAgfQorICAgICAgICAv LyBXaGVuIHJlYWNoaW5nIHRoZSB0b3AgbGV2ZWwgc2NvcGUgKGl0IGNhbiBiZSBub24gZnVuY3Rp b24gc2NvcGUpLCB3ZSByZXR1cm4gaXQuCisgICAgICAgIHJldHVybiBTY29wZVJlZigmbV9zY29w ZVN0YWNrLCBpKTsKKyAgICB9CisKICAgICAKICAgICBTY29wZVJlZiBwdXNoU2NvcGUoKQogICAg IHsKQEAgLTgzMywxOCArODU3LDExIEBAIGNsYXNzIFBhcnNlciB7CiAgICAgCiAgICAgRGVjbGFy YXRpb25SZXN1bHRNYXNrIGRlY2xhcmVWYXJpYWJsZShjb25zdCBJZGVudGlmaWVyKiBpZGVudCwg RGVjbGFyYXRpb25UeXBlIHR5cGUgPSBEZWNsYXJhdGlvblR5cGU6OlZhckRlY2xhcmF0aW9uLCBE ZWNsYXJhdGlvbkltcG9ydFR5cGUgaW1wb3J0VHlwZSA9IERlY2xhcmF0aW9uSW1wb3J0VHlwZTo6 Tm90SW1wb3J0ZWQpCiAgICAgeworICAgICAgICBpZiAodHlwZSA9PSBEZWNsYXJhdGlvblR5cGU6 OlZhckRlY2xhcmF0aW9uKQorICAgICAgICAgICAgcmV0dXJuIGN1cnJlbnRWYXJpYWJsZVNjb3Bl KCktPmRlY2xhcmVWYXJpYWJsZShpZGVudCk7CisKICAgICAgICAgdW5zaWduZWQgaSA9IG1fc2Nv cGVTdGFjay5zaXplKCkgLSAxOwogICAgICAgICBBU1NFUlQoaSA8IG1fc2NvcGVTdGFjay5zaXpl KCkpOwotCi0gICAgICAgIGlmICh0eXBlID09IERlY2xhcmF0aW9uVHlwZTo6VmFyRGVjbGFyYXRp b24pIHsKLSAgICAgICAgICAgIHdoaWxlICghbV9zY29wZVN0YWNrW2ldLmFsbG93c1ZhckRlY2xh cmF0aW9ucygpKSB7Ci0gICAgICAgICAgICAgICAgaS0tOwotICAgICAgICAgICAgICAgIEFTU0VS VChpIDwgbV9zY29wZVN0YWNrLnNpemUoKSk7Ci0gICAgICAgICAgICB9Ci0KLSAgICAgICAgICAg IHJldHVybiBtX3Njb3BlU3RhY2tbaV0uZGVjbGFyZVZhcmlhYmxlKGlkZW50KTsKLSAgICAgICAg fQotCiAgICAgICAgIEFTU0VSVCh0eXBlID09IERlY2xhcmF0aW9uVHlwZTo6TGV0RGVjbGFyYXRp b24gfHwgdHlwZSA9PSBEZWNsYXJhdGlvblR5cGU6OkNvbnN0RGVjbGFyYXRpb24pOwogCiAgICAg ICAgIC8vIExleGljYWwgdmFyaWFibGVzIGRlY2xhcmVkIGF0IGEgdG9wIGxldmVsIHNjb3BlIHRo YXQgc2hhZG93IGFyZ3VtZW50cyBvciB2YXJzIGFyZSBub3QgYWxsb3dlZC4KZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3Mvc3VwZXItaW4tbGV4aWNhbC1zY29w ZS5qcyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3Mvc3VwZXItaW4tbGV4aWNh bC1zY29wZS5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41MGYzODhiMTU0NmE5OTQyMTgzNWVkZmEwOGJiZWQ5OTRl ZmE0YTRhCi0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0 cmVzcy9zdXBlci1pbi1sZXhpY2FsLXNjb3BlLmpzCkBAIC0wLDAgKzEsNjMgQEAKK2Z1bmN0aW9u IHRlc3RTeW50YXgoc2NyaXB0KSB7CisgICAgdHJ5IHsKKyAgICAgICAgZXZhbChzY3JpcHQpOwor ICAgIH0gY2F0Y2ggKGVycm9yKSB7CisgICAgICAgIGlmIChlcnJvciBpbnN0YW5jZW9mIFN5bnRh eEVycm9yKQorICAgICAgICAgICAgdGhyb3cgbmV3IEVycm9yKCJCYWQgZXJyb3I6ICIgKyBTdHJp bmcoZXJyb3IpKTsKKyAgICB9Cit9CisKK2Z1bmN0aW9uIHRlc3RTeW50YXhFcnJvcihzY3JpcHQs IG1lc3NhZ2UpIHsKKyAgICB2YXIgZXJyb3IgPSBudWxsOworICAgIHRyeSB7CisgICAgICAgIGV2 YWwoc2NyaXB0KTsKKyAgICB9IGNhdGNoIChlKSB7CisgICAgICAgIGVycm9yID0gZTsKKyAgICB9 CisgICAgaWYgKCFlcnJvcikKKyAgICAgICAgdGhyb3cgbmV3IEVycm9yKCJFeHBlY3RlZCBzeW50 YXggZXJyb3Igbm90IHRocm93biIpOworCisgICAgaWYgKFN0cmluZyhlcnJvcikgIT09IG1lc3Nh Z2UpCisgICAgICAgIHRocm93IG5ldyBFcnJvcigiQmFkIGVycm9yOiAiICsgU3RyaW5nKGVycm9y KSk7Cit9CisKK3Rlc3RTeW50YXhFcnJvcihgc3VwZXIoKWAsIGBTeW50YXhFcnJvcjogc3VwZXIg aXMgb25seSB2YWxpZCBpbnNpZGUgZnVuY3Rpb25zLmApOwordGVzdFN5bnRheEVycm9yKGBzdXBl ci5oZWxsbygpYCwgYFN5bnRheEVycm9yOiBzdXBlciBpcyBvbmx5IHZhbGlkIGluc2lkZSBmdW5j dGlvbnMuYCk7Cit0ZXN0U3ludGF4RXJyb3IoYAoreworICAgIHN1cGVyKCk7Cit9CitgLCBgU3lu dGF4RXJyb3I6IHN1cGVyIGlzIG9ubHkgdmFsaWQgaW5zaWRlIGZ1bmN0aW9ucy5gKTsKK3Rlc3RT eW50YXhFcnJvcihgCit7CisgICAgc3VwZXIuaGVsbG8oKTsKK30KK2AsIGBTeW50YXhFcnJvcjog c3VwZXIgaXMgb25seSB2YWxpZCBpbnNpZGUgZnVuY3Rpb25zLmApOwordGVzdFN5bnRheEVycm9y KGAKK2Z1bmN0aW9uIHRlc3QoKQoreworICAgIHN1cGVyKCk7Cit9CitgLCBgU3ludGF4RXJyb3I6 IENhbm5vdCBjYWxsIHN1cGVyKCkgb3V0c2lkZSBvZiBhIGNsYXNzIGNvbnN0cnVjdG9yLmApOwor dGVzdFN5bnRheEVycm9yKGAKK2Z1bmN0aW9uIHRlc3QoKQoreworICAgIHN1cGVyLmhlbGxvKCk7 Cit9CitgLCBgU3ludGF4RXJyb3I6IHN1cGVyIGNhbiBvbmx5IGJlIHVzZWQgaW4gYSBtZXRob2Qg b2YgYSBkZXJpdmVkIGNsYXNzLmApOwordGVzdFN5bnRheEVycm9yKGAKK2Z1bmN0aW9uIHRlc3Qo KQoreworICAgIHsKKyAgICAgICAgc3VwZXIoKTsKKyAgICB9Cit9CitgLCBgU3ludGF4RXJyb3I6 IENhbm5vdCBjYWxsIHN1cGVyKCkgb3V0c2lkZSBvZiBhIGNsYXNzIGNvbnN0cnVjdG9yLmApOwor dGVzdFN5bnRheEVycm9yKGAKK2Z1bmN0aW9uIHRlc3QoKQoreworICAgIHsKKyAgICAgICAgc3Vw ZXIuaGVsbG8oKTsKKyAgICB9Cit9CitgLCBgU3ludGF4RXJyb3I6IHN1cGVyIGNhbiBvbmx5IGJl IHVzZWQgaW4gYSBtZXRob2Qgb2YgYSBkZXJpdmVkIGNsYXNzLmApOwo=