151497 2015-11-20 09:32:50 -0800 [Streams API] pull function of tee should call readFromReadableStreamReader directly 2015-12-01 03:02:48 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf benjamin calvaris commit-queue darin oldest_to_newest 1143663 0 youennf 2015-11-20 09:32:50 -0800 pull function of tee should call readFromReadableStreamReader directly. Currently it calls ReadableStream.read() which is suboptimal. 1143665 1 265960 youennf 2015-11-20 09:34:58 -0800 Created attachment 265960 Patch 1144144 2 265960 calvaris 2015-11-23 01:43:56 -0800 Comment on attachment 265960 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265960&action=review > Source/WebCore/Modules/streams/ReadableStreamInternals.js:-119 > - @Promise.prototype.@then.@call(reader.read(), function(result) { I was kind of puzzled when I read this the first time so I guess it makes quite a lot of sense to change it. 1144150 3 265960 youennf 2015-11-23 02:58:46 -0800 Comment on attachment 265960 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265960&action=review >> Source/WebCore/Modules/streams/ReadableStreamInternals.js:-119 >> - @Promise.prototype.@then.@call(reader.read(), function(result) { > > I was kind of puzzled when I read this the first time so I guess it makes quite a lot of sense to change it. In that specific case, it is safe to write (and much easier to read): @readFromReadableStreamReader(reader).@then(function ...); It would be good to write it that way for most (if not all) parts of streams API code to keep consistency and improve readability. That may mean some refactoring in invokeOrNoop and the likes to ensure @then is available. All these changes might best be adressed as a follow-up patch. 1145198 4 266348 youennf 2015-12-01 01:42:51 -0800 Created attachment 266348 Patch for landing 1145200 5 266348 commit-queue 2015-12-01 01:44:41 -0800 Comment on attachment 266348 Patch for landing Rejecting attachment 266348 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 266348, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: with fuzz 1. patching file LayoutTests/streams/streams-promises-expected.txt Hunk #1 FAILED at 8. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/streams/streams-promises-expected.txt.rej patching file LayoutTests/streams/streams-promises.html Hunk #1 FAILED at 125. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/streams/streams-promises.html.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/500863 1145201 6 youennf 2015-12-01 01:46:06 -0800 (In reply to comment #4) > Created attachment 266348 [details] > Patch for landing Thanks for the r+ Along the lines of other related patches, I added a test to ensure we no longer use ReadableStreamReader.read(). It uses promise_test as a way to execute sequentially an otherwise async_test. 1145211 7 266348 commit-queue 2015-12-01 02:16:47 -0800 Comment on attachment 266348 Patch for landing Rejecting attachment 266348 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 266348, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/500949 1145212 8 266350 youennf 2015-12-01 02:20:26 -0800 Created attachment 266350 Patch for landing 1145216 9 266350 commit-queue 2015-12-01 03:02:44 -0800 Comment on attachment 266350 Patch for landing Clearing flags on attachment: 266350 Committed r192879: <http://trac.webkit.org/changeset/192879> 1145217 10 commit-queue 2015-12-01 03:02:48 -0800 All reviewed patches have been landed. Closing bug. 265960 2015-11-20 09:34:58 -0800 2015-12-01 01:42:46 -0800 Patch bug-151497-20151120183445.patch text/plain 1702 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODExOWFkYTlmZjE1MDA4 NWM4ZDc2YzhjM2MyYWY3MzNlNWVmODllMy4uZDY3YTBkZDdjYTBlMWQwNDJkNmRiODQ3MGY5OTRm OTRhYWZjMTMxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE1LTExLTIwICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKKyAgICAgICAgW1N0cmVh bXMgQVBJXSBwdWxsIGZ1bmN0aW9uIG9mIHRlZSBzaG91bGQgY2FsbCByZWFkRnJvbVJlYWRhYmxl U3RyZWFtUmVhZGVyIGRpcmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTE0OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBNb2R1bGVz L3N0cmVhbXMvUmVhZGFibGVTdHJlYW1JbnRlcm5hbHMuanM6CisgICAgICAgICh0ZWVSZWFkYWJs ZVN0cmVhbVB1bGxGdW5jdGlvbik6IGRpcmVjdGx5IGNhbGxpbmcgcmVhZEZyb21SZWFkYWJsZVN0 cmVhbVJlYWRlci4KKworMjAxNS0xMS0yMCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubi5mYWJsZXRA Y3JmLmNhbm9uLmZyPgorCiAgICAgICAgIFVzZSBIVFRQSGVhZGVyTmFtZSBhcyBtdWNoIGFzIHBv c3NpYmxlIGluIFhNTEh0dHBSZXF1ZXN0CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTE0MzgKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9zdHJlYW1zL1JlYWRhYmxlU3RyZWFtSW50ZXJuYWxzLmpzIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9zdHJlYW1zL1JlYWRhYmxlU3RyZWFtSW50ZXJuYWxzLmpzCmluZGV4IDM2N2IxNjFl YWFiNjAwOGVmOWE5OWVhYTdhM2M2ZDc5YWNmZGNmOTUuLjc4ZjE3MzZmMWEwZjg3MmZiNGNkNjM3 ZWZjNmYzM2QyZDdhZjY5YjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3Ry ZWFtcy9SZWFkYWJsZVN0cmVhbUludGVybmFscy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL3N0cmVhbXMvUmVhZGFibGVTdHJlYW1JbnRlcm5hbHMuanMKQEAgLTExNiw3ICsxMTYsNyBA QCBmdW5jdGlvbiB0ZWVSZWFkYWJsZVN0cmVhbVB1bGxGdW5jdGlvbih0ZWVTdGF0ZSwgcmVhZGVy LCBzaG91bGRDbG9uZSkKICAgICAidXNlIHN0cmljdCI7CiAKICAgICByZXR1cm4gZnVuY3Rpb24o KSB7Ci0gICAgICAgIEBQcm9taXNlLnByb3RvdHlwZS5AdGhlbi5AY2FsbChyZWFkZXIucmVhZCgp LCBmdW5jdGlvbihyZXN1bHQpIHsKKyAgICAgICAgQFByb21pc2UucHJvdG90eXBlLkB0aGVuLkBj YWxsKEByZWFkRnJvbVJlYWRhYmxlU3RyZWFtUmVhZGVyKHJlYWRlciksIGZ1bmN0aW9uKHJlc3Vs dCkgewogICAgICAgICAgICAgQGFzc2VydChAaXNPYmplY3QocmVzdWx0KSk7CiAgICAgICAgICAg ICBAYXNzZXJ0KHR5cGVvZiByZXN1bHQuZG9uZSA9PT0gImJvb2xlYW4iKTsKICAgICAgICAgICAg IGlmIChyZXN1bHQuZG9uZSAmJiAhdGVlU3RhdGUuY2xvc2VkT3JFcnJvcmVkKSB7Cg== 266348 2015-12-01 01:42:51 -0800 2015-12-01 02:20:20 -0800 Patch for landing bug-151497-20151201104228.patch text/plain 4576 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyODc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTIxNzYwZTljNWFhOTgx YTY5YTE3YjA4NTAwZTc1M2U4YTA4MmZlZS4uNGE4NTVkZmU5Yjk0MzE4YWJhYTEyMjVjMDUwODk3 YTFjMjZjYzVhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE1LTEyLTAxICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKKyAgICAgICAgW1N0cmVh bXMgQVBJXSBwdWxsIGZ1bmN0aW9uIG9mIHRlZSBzaG91bGQgY2FsbCByZWFkRnJvbVJlYWRhYmxl U3RyZWFtUmVhZGVyIGRpcmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTE0OTcKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4K KworICAgICAgICBDb3ZlcmVkIGJ5IGFkZGVkIHRlc3QuCisKKyAgICAgICAgKiBNb2R1bGVzL3N0 cmVhbXMvUmVhZGFibGVTdHJlYW1JbnRlcm5hbHMuanM6CisgICAgICAgICh0ZWVSZWFkYWJsZVN0 cmVhbVB1bGxGdW5jdGlvbik6IGRpcmVjdGx5IGNhbGxpbmcgcmVhZEZyb21SZWFkYWJsZVN0cmVh bVJlYWRlci4KKworMjAxNS0xMi0wMSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubi5mYWJsZXRAY3Jm LmNhbm9uLmZyPgorCiAgICAgICAgIFtTdHJlYW1zIEFQSV0gdGVlUmVhZGFibGVTdHJlYW0gc2hv dWxkIG5vdCBkaXJlY3RseSB1c2Ugc3RyZWFtLmdldFJlYWRlcigpCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE0ODcKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9zdHJlYW1zL1JlYWRhYmxlU3RyZWFtSW50ZXJuYWxzLmpzIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9zdHJlYW1zL1JlYWRhYmxlU3RyZWFtSW50ZXJuYWxzLmpz CmluZGV4IDNmZDhjMDU4NjA1ZGVjMjdmYjI3ZmJiMzMyNzExMzkyMDA3MDNhNGIuLmI4NDY4ODM0 N2UwYmQ1MzdkNTk5YjRkM2M1MjhhYTc2NjU2YzdiNjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvc3RyZWFtcy9SZWFkYWJsZVN0cmVhbUludGVybmFscy5qcworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVTdHJlYW1JbnRlcm5hbHMuanMKQEAg LTExNiw3ICsxMTYsNyBAQCBmdW5jdGlvbiB0ZWVSZWFkYWJsZVN0cmVhbVB1bGxGdW5jdGlvbih0 ZWVTdGF0ZSwgcmVhZGVyLCBzaG91bGRDbG9uZSkKICAgICAidXNlIHN0cmljdCI7CiAKICAgICBy ZXR1cm4gZnVuY3Rpb24oKSB7Ci0gICAgICAgIEBQcm9taXNlLnByb3RvdHlwZS5AdGhlbi5AY2Fs bChyZWFkZXIucmVhZCgpLCBmdW5jdGlvbihyZXN1bHQpIHsKKyAgICAgICAgQFByb21pc2UucHJv dG90eXBlLkB0aGVuLkBjYWxsKEByZWFkRnJvbVJlYWRhYmxlU3RyZWFtUmVhZGVyKHJlYWRlciks IGZ1bmN0aW9uKHJlc3VsdCkgewogICAgICAgICAgICAgQGFzc2VydChAaXNPYmplY3QocmVzdWx0 KSk7CiAgICAgICAgICAgICBAYXNzZXJ0KHR5cGVvZiByZXN1bHQuZG9uZSA9PT0gImJvb2xlYW4i KTsKICAgICAgICAgICAgIGlmIChyZXN1bHQuZG9uZSAmJiAhdGVlU3RhdGUuY2xvc2VkT3JFcnJv cmVkKSB7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKaW5kZXggODg1Y2VhNDdmMDZlZjQ0Y2Y5ZDI4N2UwMjRjOWY1NTA3NmZhOTc1ZS4u NWQ2MDZmZWVhMjFkYmQwNGMxODUyOTM4NWQyZmUyOTg3NjdhOWJhOCAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsx LDE3IEBACiAyMDE1LTEyLTAxICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fu b24uZnI+CiAKKyAgICAgICAgW1N0cmVhbXMgQVBJXSBwdWxsIGZ1bmN0aW9uIG9mIHRlZSBzaG91 bGQgY2FsbCByZWFkRnJvbVJlYWRhYmxlU3RyZWFtUmVhZGVyIGRpcmVjdGx5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE0OTcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpbmcgbm9uIHJlZ3Jlc3Np b24gdGVzdC4KKworICAgICAgICAqIHN0cmVhbXMvc3RyZWFtcy1wcm9taXNlcy1leHBlY3RlZC50 eHQ6CisgICAgICAgICogc3RyZWFtcy9zdHJlYW1zLXByb21pc2VzLmh0bWw6CisKKzIwMTUtMTIt MDEgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4KKwogICAgICAg ICBbU3RyZWFtcyBBUEldIHRlZVJlYWRhYmxlU3RyZWFtIHNob3VsZCBub3QgZGlyZWN0bHkgdXNl IHN0cmVhbS5nZXRSZWFkZXIoKQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUxNDg3CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0cmVhbXMvc3Ry ZWFtcy1wcm9taXNlcy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9zdHJlYW1zL3N0cmVhbXMt cHJvbWlzZXMtZXhwZWN0ZWQudHh0CmluZGV4IGUzNmU2YjlmOGFkMWYyYTdmMGFhMjc0NTU0Zjcz YjkxOWFjNjViOTcuLjMyYTI4NWJiNGE4MGVkYzVjMmYwNTkwYzhhMjU4NjY0Y2MzZjRhMjUgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL3N0cmVhbXMvc3RyZWFtcy1wcm9taXNlcy1leHBlY3RlZC50 eHQKKysrIGIvTGF5b3V0VGVzdHMvc3RyZWFtcy9zdHJlYW1zLXByb21pc2VzLWV4cGVjdGVkLnR4 dApAQCAtOCw0ICs4LDUgQEAgUEFTUyBTdHJlYW1zIGFuZCBwcm9taXNlczogcmVwbGFjZSBjYXRj aCBtZXRob2QgaW4gUHJvbWlzZSBwcm90b3R5cGUKIFBBU1MgU3RyZWFtcyBhbmQgcHJvbWlzZXM6 IHJlcGxhY2UgdGhlbiBtZXRob2QgaW4gcHJvbWlzZSBvYmplY3QgCiBQQVNTIFN0cmVhbXMgc2hv dWxkIG5vdCBkaXJlY3RseSB1c2UgTnVtYmVyIGFuZCByZWxhdGVkIG1ldGhvZHMgCiBQQVNTIFN0 cmVhbXMgc2hvdWxkIG5vdCBkaXJlY3RseSB1c2UgUmVhZGFibGVTdHJlYW0gcHVibGljIEFQSXMg CitQQVNTIFN0cmVhbXMgc2hvdWxkIG5vdCBkaXJlY3RseSB1c2UgUmVhZGFibGVTdHJlYW1SZWFk ZXIgcmVhZCBwdWJsaWMgQVBJIAogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdHJlYW1zL3N0 cmVhbXMtcHJvbWlzZXMuaHRtbCBiL0xheW91dFRlc3RzL3N0cmVhbXMvc3RyZWFtcy1wcm9taXNl cy5odG1sCmluZGV4IGU4NTk5MDIyYTVmMjc3NjI1MzNlMmM0YTM5ZDYyY2NmZmVlZDIyMjEuLmVk ZGYzYmI0ZTRkOWJmNWQwNzcxZmVlMjQzZGRlMTZlNGE1NzM5YWYgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL3N0cmVhbXMvc3RyZWFtcy1wcm9taXNlcy5odG1sCisrKyBiL0xheW91dFRlc3RzL3N0 cmVhbXMvc3RyZWFtcy1wcm9taXNlcy5odG1sCkBAIC0xMjUsNCArMTI1LDI4IEBAIHRlc3QoZnVu Y3Rpb24oKSB7CiAgICAgICAgIFJlYWRhYmxlU3RyZWFtLnByb3RvdHlwZS5nZXRSZWFkZXIgPSBS ZWFkYWJsZVN0cmVhbUdldFJlYWRlckJhY2t1cDsKICAgICB9CiB9LCAnU3RyZWFtcyBzaG91bGQg bm90IGRpcmVjdGx5IHVzZSBSZWFkYWJsZVN0cmVhbSBwdWJsaWMgQVBJcycpOworCitwcm9taXNl X3Rlc3QoZnVuY3Rpb24oKSB7CisgICAgY29uc3QgUmVhZGFibGVTdHJlYW1SZWFkZXIgPSBuZXcg UmVhZGFibGVTdHJlYW0oKS5nZXRSZWFkZXIoKS5jb25zdHJ1Y3RvcjsKKyAgICBjb25zdCBSZWFk YWJsZVN0cmVhbVJlYWRlclJlYWRCYWNrdXAgPSBSZWFkYWJsZVN0cmVhbVJlYWRlci5wcm90b3R5 cGUucmVhZDsKKworICAgIGZ1bmN0aW9uIGNsZWFuVGVzdCgpIHsKKyAgICAgICAgUmVhZGFibGVT dHJlYW1SZWFkZXIucHJvdG90eXBlLnJlYWQgPSBSZWFkYWJsZVN0cmVhbVJlYWRlclJlYWRCYWNr dXA7CisgICAgfQorCisgICAgdHJ5IHsKKyAgICAgICAgUmVhZGFibGVTdHJlYW1SZWFkZXIucHJv dG90eXBlLnJlYWQgPSBmdW5jdGlvbigpIHsgYXNzZXJ0X3VucmVhY2hlZCgic3RyZWFtcyBzaG91 bGQgbm90IHVzZSB0aGlzIFJlYWRhYmxlU3RyZWFtUmVhZGVyLnJlYWQgbWV0aG9kIik7IH07CisK KyAgICAgICAgW3MxLCBzMl0gPSBuZXcgUmVhZGFibGVTdHJlYW0oeworICAgICAgICAgICAgc3Rh cnQ6IGZ1bmN0aW9uKGNvbnRyb2xsZXIpIHsKKyAgICAgICAgICAgICAgICBjb250cm9sbGVyLmNs b3NlKCk7CisgICAgICAgICAgICB9CisgICAgICAgIH0pLnRlZSgpOworICAgICAgICByZXR1cm4g czEuZ2V0UmVhZGVyKCkuY2xvc2VkLnRoZW4oY2xlYW5UZXN0LCBjbGVhblRlc3QpOworCisgICAg fSBjYXRjaCAoZXJyb3IpIHsKKyAgICAgICAgY2xlYW5UZXN0KCk7CisgICAgICAgIGFzc2VydF91 bnJlYWNoZWQoInRlc3Qgc2hvdWxkIG5vdCB0aHJvdyIpOworICAgIH0KK30sICdTdHJlYW1zIHNo b3VsZCBub3QgZGlyZWN0bHkgdXNlIFJlYWRhYmxlU3RyZWFtUmVhZGVyIHJlYWQgcHVibGljIEFQ SScpOwogPC9zY3JpcHQ+Cg== 266350 2015-12-01 02:20:26 -0800 2015-12-01 03:02:44 -0800 Patch for landing bug-151497-20151201112002.patch text/plain 4560 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyODc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTIxNzYwZTljNWFhOTgx YTY5YTE3YjA4NTAwZTc1M2U4YTA4MmZlZS4uNGE4NTVkZmU5Yjk0MzE4YWJhYTEyMjVjMDUwODk3 YTFjMjZjYzVhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE1LTEyLTAxICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKKyAgICAgICAgW1N0cmVh bXMgQVBJXSBwdWxsIGZ1bmN0aW9uIG9mIHRlZSBzaG91bGQgY2FsbCByZWFkRnJvbVJlYWRhYmxl U3RyZWFtUmVhZGVyIGRpcmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTE0OTcKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4K KworICAgICAgICBDb3ZlcmVkIGJ5IGFkZGVkIHRlc3QuCisKKyAgICAgICAgKiBNb2R1bGVzL3N0 cmVhbXMvUmVhZGFibGVTdHJlYW1JbnRlcm5hbHMuanM6CisgICAgICAgICh0ZWVSZWFkYWJsZVN0 cmVhbVB1bGxGdW5jdGlvbik6IGRpcmVjdGx5IGNhbGxpbmcgcmVhZEZyb21SZWFkYWJsZVN0cmVh bVJlYWRlci4KKworMjAxNS0xMi0wMSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubi5mYWJsZXRAY3Jm LmNhbm9uLmZyPgorCiAgICAgICAgIFtTdHJlYW1zIEFQSV0gdGVlUmVhZGFibGVTdHJlYW0gc2hv dWxkIG5vdCBkaXJlY3RseSB1c2Ugc3RyZWFtLmdldFJlYWRlcigpCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE0ODcKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9zdHJlYW1zL1JlYWRhYmxlU3RyZWFtSW50ZXJuYWxzLmpzIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9zdHJlYW1zL1JlYWRhYmxlU3RyZWFtSW50ZXJuYWxzLmpz CmluZGV4IDNmZDhjMDU4NjA1ZGVjMjdmYjI3ZmJiMzMyNzExMzkyMDA3MDNhNGIuLmI4NDY4ODM0 N2UwYmQ1MzdkNTk5YjRkM2M1MjhhYTc2NjU2YzdiNjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvc3RyZWFtcy9SZWFkYWJsZVN0cmVhbUludGVybmFscy5qcworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVTdHJlYW1JbnRlcm5hbHMuanMKQEAg LTExNiw3ICsxMTYsNyBAQCBmdW5jdGlvbiB0ZWVSZWFkYWJsZVN0cmVhbVB1bGxGdW5jdGlvbih0 ZWVTdGF0ZSwgcmVhZGVyLCBzaG91bGRDbG9uZSkKICAgICAidXNlIHN0cmljdCI7CiAKICAgICBy ZXR1cm4gZnVuY3Rpb24oKSB7Ci0gICAgICAgIEBQcm9taXNlLnByb3RvdHlwZS5AdGhlbi5AY2Fs bChyZWFkZXIucmVhZCgpLCBmdW5jdGlvbihyZXN1bHQpIHsKKyAgICAgICAgQFByb21pc2UucHJv dG90eXBlLkB0aGVuLkBjYWxsKEByZWFkRnJvbVJlYWRhYmxlU3RyZWFtUmVhZGVyKHJlYWRlciks IGZ1bmN0aW9uKHJlc3VsdCkgewogICAgICAgICAgICAgQGFzc2VydChAaXNPYmplY3QocmVzdWx0 KSk7CiAgICAgICAgICAgICBAYXNzZXJ0KHR5cGVvZiByZXN1bHQuZG9uZSA9PT0gImJvb2xlYW4i KTsKICAgICAgICAgICAgIGlmIChyZXN1bHQuZG9uZSAmJiAhdGVlU3RhdGUuY2xvc2VkT3JFcnJv cmVkKSB7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKaW5kZXggODg1Y2VhNDdmMDZlZjQ0Y2Y5ZDI4N2UwMjRjOWY1NTA3NmZhOTc1ZS4u MDlkMmUxYTAwZDVjMmExNzMwYTI1MGViODBhOTNjNmM0ZmM4MTk2OSAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsx LDE3IEBACiAyMDE1LTEyLTAxICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fu b24uZnI+CiAKKyAgICAgICAgW1N0cmVhbXMgQVBJXSBwdWxsIGZ1bmN0aW9uIG9mIHRlZSBzaG91 bGQgY2FsbCByZWFkRnJvbVJlYWRhYmxlU3RyZWFtUmVhZGVyIGRpcmVjdGx5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE0OTcKKworICAgICAgICBV bnJldmlld2VkLgorCisgICAgICAgIEFkZGluZyBub24gcmVncmVzc2lvbiB0ZXN0LgorCisgICAg ICAgICogc3RyZWFtcy9zdHJlYW1zLXByb21pc2VzLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBz dHJlYW1zL3N0cmVhbXMtcHJvbWlzZXMuaHRtbDoKKworMjAxNS0xMi0wMSAgWW91ZW5uIEZhYmxl dCAgPHlvdWVubi5mYWJsZXRAY3JmLmNhbm9uLmZyPgorCiAgICAgICAgIFtTdHJlYW1zIEFQSV0g dGVlUmVhZGFibGVTdHJlYW0gc2hvdWxkIG5vdCBkaXJlY3RseSB1c2Ugc3RyZWFtLmdldFJlYWRl cigpCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE0 ODcKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3RyZWFtcy9zdHJlYW1zLXByb21pc2VzLWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3N0cmVhbXMvc3RyZWFtcy1wcm9taXNlcy1leHBlY3Rl ZC50eHQKaW5kZXggZTM2ZTZiOWY4YWQxZjJhN2YwYWEyNzQ1NTRmNzNiOTE5YWM2NWI5Ny4uMzJh Mjg1YmI0YTgwZWRjNWMyZjA1OTBjOGEyNTg2NjRjYzNmNGEyNSAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvc3RyZWFtcy9zdHJlYW1zLXByb21pc2VzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRU ZXN0cy9zdHJlYW1zL3N0cmVhbXMtcHJvbWlzZXMtZXhwZWN0ZWQudHh0CkBAIC04LDQgKzgsNSBA QCBQQVNTIFN0cmVhbXMgYW5kIHByb21pc2VzOiByZXBsYWNlIGNhdGNoIG1ldGhvZCBpbiBQcm9t aXNlIHByb3RvdHlwZQogUEFTUyBTdHJlYW1zIGFuZCBwcm9taXNlczogcmVwbGFjZSB0aGVuIG1l dGhvZCBpbiBwcm9taXNlIG9iamVjdCAKIFBBU1MgU3RyZWFtcyBzaG91bGQgbm90IGRpcmVjdGx5 IHVzZSBOdW1iZXIgYW5kIHJlbGF0ZWQgbWV0aG9kcyAKIFBBU1MgU3RyZWFtcyBzaG91bGQgbm90 IGRpcmVjdGx5IHVzZSBSZWFkYWJsZVN0cmVhbSBwdWJsaWMgQVBJcyAKK1BBU1MgU3RyZWFtcyBz aG91bGQgbm90IGRpcmVjdGx5IHVzZSBSZWFkYWJsZVN0cmVhbVJlYWRlciByZWFkIHB1YmxpYyBB UEkgCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0cmVhbXMvc3RyZWFtcy1wcm9taXNlcy5o dG1sIGIvTGF5b3V0VGVzdHMvc3RyZWFtcy9zdHJlYW1zLXByb21pc2VzLmh0bWwKaW5kZXggZTg1 OTkwMjJhNWYyNzc2MjUzM2UyYzRhMzlkNjJjY2ZmZWVkMjIyMS4uZWRkZjNiYjRlNGQ5YmY1ZDA3 NzFmZWUyNDNkZGUxNmU0YTU3MzlhZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3RyZWFtcy9z dHJlYW1zLXByb21pc2VzLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvc3RyZWFtcy9zdHJlYW1zLXBy b21pc2VzLmh0bWwKQEAgLTEyNSw0ICsxMjUsMjggQEAgdGVzdChmdW5jdGlvbigpIHsKICAgICAg ICAgUmVhZGFibGVTdHJlYW0ucHJvdG90eXBlLmdldFJlYWRlciA9IFJlYWRhYmxlU3RyZWFtR2V0 UmVhZGVyQmFja3VwOwogICAgIH0KIH0sICdTdHJlYW1zIHNob3VsZCBub3QgZGlyZWN0bHkgdXNl IFJlYWRhYmxlU3RyZWFtIHB1YmxpYyBBUElzJyk7CisKK3Byb21pc2VfdGVzdChmdW5jdGlvbigp IHsKKyAgICBjb25zdCBSZWFkYWJsZVN0cmVhbVJlYWRlciA9IG5ldyBSZWFkYWJsZVN0cmVhbSgp LmdldFJlYWRlcigpLmNvbnN0cnVjdG9yOworICAgIGNvbnN0IFJlYWRhYmxlU3RyZWFtUmVhZGVy UmVhZEJhY2t1cCA9IFJlYWRhYmxlU3RyZWFtUmVhZGVyLnByb3RvdHlwZS5yZWFkOworCisgICAg ZnVuY3Rpb24gY2xlYW5UZXN0KCkgeworICAgICAgICBSZWFkYWJsZVN0cmVhbVJlYWRlci5wcm90 b3R5cGUucmVhZCA9IFJlYWRhYmxlU3RyZWFtUmVhZGVyUmVhZEJhY2t1cDsKKyAgICB9CisKKyAg ICB0cnkgeworICAgICAgICBSZWFkYWJsZVN0cmVhbVJlYWRlci5wcm90b3R5cGUucmVhZCA9IGZ1 bmN0aW9uKCkgeyBhc3NlcnRfdW5yZWFjaGVkKCJzdHJlYW1zIHNob3VsZCBub3QgdXNlIHRoaXMg UmVhZGFibGVTdHJlYW1SZWFkZXIucmVhZCBtZXRob2QiKTsgfTsKKworICAgICAgICBbczEsIHMy XSA9IG5ldyBSZWFkYWJsZVN0cmVhbSh7CisgICAgICAgICAgICBzdGFydDogZnVuY3Rpb24oY29u dHJvbGxlcikgeworICAgICAgICAgICAgICAgIGNvbnRyb2xsZXIuY2xvc2UoKTsKKyAgICAgICAg ICAgIH0KKyAgICAgICAgfSkudGVlKCk7CisgICAgICAgIHJldHVybiBzMS5nZXRSZWFkZXIoKS5j bG9zZWQudGhlbihjbGVhblRlc3QsIGNsZWFuVGVzdCk7CisKKyAgICB9IGNhdGNoIChlcnJvcikg eworICAgICAgICBjbGVhblRlc3QoKTsKKyAgICAgICAgYXNzZXJ0X3VucmVhY2hlZCgidGVzdCBz aG91bGQgbm90IHRocm93Iik7CisgICAgfQorfSwgJ1N0cmVhbXMgc2hvdWxkIG5vdCBkaXJlY3Rs eSB1c2UgUmVhZGFibGVTdHJlYW1SZWFkZXIgcmVhZCBwdWJsaWMgQVBJJyk7CiA8L3NjcmlwdD4K