151487 2015-11-20 02:46:52 -0800 [Streams API] teeReadableStream should not directly use stream.getReader() 2015-12-01 02:14:21 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf benjamin calvaris commit-queue darin oldest_to_newest 1143611 0 youennf 2015-11-20 02:46:52 -0800 teeReadableStream should not directly use stream.getReader() 1143613 1 265947 youennf 2015-11-20 02:50:03 -0800 Created attachment 265947 Patch 1144861 2 265947 darin 2015-11-30 11:59:26 -0800 Comment on attachment 265947 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265947&action=review > Source/WebCore/ChangeLog:8 > + No change in behavior. This is not true. The comment below says “may be disrupted by user scripts”, so there is an observable behavior change we could and should test. 1145185 3 266342 youennf 2015-12-01 01:17:55 -0800 Created attachment 266342 Patch for landing 1145186 4 youennf 2015-12-01 01:19:59 -0800 (In reply to comment #2) > Comment on attachment 265947 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=265947&action=review > > > Source/WebCore/ChangeLog:8 > > + No change in behavior. > > This is not true. The comment below says “may be disrupted by user scripts”, > so there is an observable behavior change we could and should test. Right, I added a test to cover non regression. 1145209 5 266342 commit-queue 2015-12-01 02:14:17 -0800 Comment on attachment 266342 Patch for landing Clearing flags on attachment: 266342 Committed r192877: <http://trac.webkit.org/changeset/192877> 1145210 6 commit-queue 2015-12-01 02:14:21 -0800 All reviewed patches have been landed. Closing bug. 265947 2015-11-20 02:50:03 -0800 2015-12-01 01:17:49 -0800 Patch bug-151487-20151120114950.patch text/plain 1581 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODExOWFkYTlmZjE1MDA4 NWM4ZDc2YzhjM2MyYWY3MzNlNWVmODllMy4uM2ZkNTA4NjkwMjRhZGM5MzRiYmUxY2M1MmE5Yzg4 M2ZiOWRhZDhhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE1LTExLTIwICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKKyAgICAgICAgW1N0cmVh bXMgQVBJXSB0ZWVSZWFkYWJsZVN0cmVhbSBzaG91bGQgbm90IGRpcmVjdGx5IHVzZSBzdHJlYW0u Z2V0UmVhZGVyKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1MTQ4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIE1vZHVsZXMvc3RyZWFtcy9S ZWFkYWJsZVN0cmVhbUludGVybmFscy5qczoKKyAgICAgICAgKHRlZVJlYWRhYmxlU3RyZWFtKTog Q3JlYXRlIGEgQFJlYWRhYmxlU3RyZWFtUmVhZGVyIGluc3RlYWQgb2YgY2FsbGluZyBnZXRSZWFk ZXIoKSB3aGljaCBtYXkgYmUgZGlzcnVwdGVkIGJ5IHVzZXIgc2NyaXB0cy4KKworMjAxNS0xMS0y MCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubi5mYWJsZXRAY3JmLmNhbm9uLmZyPgorCiAgICAgICAg IFVzZSBIVFRQSGVhZGVyTmFtZSBhcyBtdWNoIGFzIHBvc3NpYmxlIGluIFhNTEh0dHBSZXF1ZXN0 CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE0MzgK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9zdHJlYW1zL1JlYWRhYmxlU3Ry ZWFtSW50ZXJuYWxzLmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9zdHJlYW1zL1JlYWRhYmxl U3RyZWFtSW50ZXJuYWxzLmpzCmluZGV4IDM2N2IxNjFlYWFiNjAwOGVmOWE5OWVhYTdhM2M2ZDc5 YWNmZGNmOTUuLjg4ZWI5MWY4NzMzMTU5ODBiMzMyMGNhMjczZTg2NzY1Njg5NDFjMzEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3RyZWFtcy9SZWFkYWJsZVN0cmVhbUludGVy bmFscy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVTdHJl YW1JbnRlcm5hbHMuanMKQEAgLTczLDcgKzczLDcgQEAgZnVuY3Rpb24gdGVlUmVhZGFibGVTdHJl YW0oc3RyZWFtLCBzaG91bGRDbG9uZSkKICAgICBAYXNzZXJ0KEBpc1JlYWRhYmxlU3RyZWFtKHN0 cmVhbSkpOwogICAgIEBhc3NlcnQodHlwZW9mKHNob3VsZENsb25lKSA9PT0gImJvb2xlYW4iKTsK IAotICAgIGNvbnN0IHJlYWRlciA9IHN0cmVhbS5nZXRSZWFkZXIoKTsKKyAgICBjb25zdCByZWFk ZXIgPSBuZXcgQFJlYWRhYmxlU3RyZWFtUmVhZGVyKHN0cmVhbSk7CiAKICAgICBjb25zdCB0ZWVT dGF0ZSA9IHsKICAgICAgICAgY2xvc2VkT3JFcnJvcmVkOiBmYWxzZSwK 266342 2015-12-01 01:17:55 -0800 2015-12-01 02:14:17 -0800 Patch for landing bug-151487-20151201101732.patch text/plain 3993 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyODc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzExZTYzYzBmZmFkN2M1 ODIyOWMwOTFlMzNjZDdkMDk2NTVlMWYyZS4uNTIxNzYwZTljNWFhOTgxYTY5YTE3YjA4NTAwZTc1 M2U4YTA4MmZlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE1LTEyLTAxICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKKyAgICAgICAgW1N0cmVh bXMgQVBJXSB0ZWVSZWFkYWJsZVN0cmVhbSBzaG91bGQgbm90IGRpcmVjdGx5IHVzZSBzdHJlYW0u Z2V0UmVhZGVyKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1MTQ4NworCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgorCisgICAgICAg IENvdmVyZWQgYnkgYWRkZWQgdGVzdC4KKworICAgICAgICAqIE1vZHVsZXMvc3RyZWFtcy9SZWFk YWJsZVN0cmVhbUludGVybmFscy5qczoKKyAgICAgICAgKHRlZVJlYWRhYmxlU3RyZWFtKTogQ3Jl YXRlIGEgQFJlYWRhYmxlU3RyZWFtUmVhZGVyIGluc3RlYWQgb2YgY2FsbGluZyBnZXRSZWFkZXIo KSB3aGljaCBtYXkgYmUgZGlzcnVwdGVkIGJ5IHVzZXIgc2NyaXB0cy4KKworMjAxNS0xMi0wMSAg WW91ZW5uIEZhYmxldCAgPHlvdWVubi5mYWJsZXRAY3JmLmNhbm9uLmZyPgorCiAgICAgICAgIFtT dHJlYW1zIEFQSV0gc3RyZWFtcyBzaG91bGQgbm90IGRpcmVjdGx5IHVzZSBOdW1iZXIgYW5kIHJl bGF0ZWQgbWV0aG9kcwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTUxNDk5CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3RyZWFt cy9SZWFkYWJsZVN0cmVhbUludGVybmFscy5qcyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3Ry ZWFtcy9SZWFkYWJsZVN0cmVhbUludGVybmFscy5qcwppbmRleCAzNmZkMjc3YzIzZGY5MTRlYWEz Mjk3NjVlMjg1OGE4ZTMwN2UzMWMxLi4zZmQ4YzA1ODYwNWRlYzI3ZmIyN2ZiYjMzMjcxMTM5MjAw NzAzYTRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3N0cmVhbXMvUmVhZGFi bGVTdHJlYW1JbnRlcm5hbHMuanMKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9zdHJlYW1z L1JlYWRhYmxlU3RyZWFtSW50ZXJuYWxzLmpzCkBAIC03Myw3ICs3Myw3IEBAIGZ1bmN0aW9uIHRl ZVJlYWRhYmxlU3RyZWFtKHN0cmVhbSwgc2hvdWxkQ2xvbmUpCiAgICAgQGFzc2VydChAaXNSZWFk YWJsZVN0cmVhbShzdHJlYW0pKTsKICAgICBAYXNzZXJ0KHR5cGVvZihzaG91bGRDbG9uZSkgPT09 ICJib29sZWFuIik7CiAKLSAgICBjb25zdCByZWFkZXIgPSBzdHJlYW0uZ2V0UmVhZGVyKCk7Cisg ICAgY29uc3QgcmVhZGVyID0gbmV3IEBSZWFkYWJsZVN0cmVhbVJlYWRlcihzdHJlYW0pOwogCiAg ICAgY29uc3QgdGVlU3RhdGUgPSB7CiAgICAgICAgIGNsb3NlZE9yRXJyb3JlZDogZmFsc2UsCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK aW5kZXggNDE5ZDdmOGQyMDdmYWZiZDk0Zjg4ODIyMjRlYWEyYTM0YTE2NDJiYi4uODg1Y2VhNDdm MDZlZjQ0Y2Y5ZDI4N2UwMjRjOWY1NTA3NmZhOTc1ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAy MDE1LTEyLTAxICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAK KyAgICAgICAgW1N0cmVhbXMgQVBJXSB0ZWVSZWFkYWJsZVN0cmVhbSBzaG91bGQgbm90IGRpcmVj dGx5IHVzZSBzdHJlYW0uZ2V0UmVhZGVyKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1MTQ4NworCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFk bGVyLgorCisgICAgICAgIEFkZGluZyBub24tcmVncmVzc2lvbiB0ZXN0LgorCisgICAgICAgICog c3RyZWFtcy9zdHJlYW1zLXByb21pc2VzLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBzdHJlYW1z L3N0cmVhbXMtcHJvbWlzZXMuaHRtbDoKKworMjAxNS0xMi0wMSAgWW91ZW5uIEZhYmxldCAgPHlv dWVubi5mYWJsZXRAY3JmLmNhbm9uLmZyPgorCiAgICAgICAgIFtTdHJlYW1zIEFQSV0gc3RyZWFt cyBzaG91bGQgbm90IGRpcmVjdGx5IHVzZSBOdW1iZXIgYW5kIHJlbGF0ZWQgbWV0aG9kcwogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxNDk5CiAKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0cmVhbXMvc3RyZWFtcy1wcm9taXNlcy1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9zdHJlYW1zL3N0cmVhbXMtcHJvbWlzZXMtZXhwZWN0ZWQudHh0Cmlu ZGV4IGJhMWFlMjI2YWE1MTIxMmI5ZjBiMWVhMzljNjQ2Yjk1ODBiYjM5MDMuLmUzNmU2YjlmOGFk MWYyYTdmMGFhMjc0NTU0ZjczYjkxOWFjNjViOTcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3N0 cmVhbXMvc3RyZWFtcy1wcm9taXNlcy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvc3Ry ZWFtcy9zdHJlYW1zLXByb21pc2VzLWV4cGVjdGVkLnR4dApAQCAtNyw0ICs3LDUgQEAgUEFTUyBT dHJlYW1zIGFuZCBwcm9taXNlczogcmVwbGFjZSB0aGVuIG1ldGhvZCBpbiBQcm9taXNlIHByb3Rv dHlwZQogUEFTUyBTdHJlYW1zIGFuZCBwcm9taXNlczogcmVwbGFjZSBjYXRjaCBtZXRob2QgaW4g UHJvbWlzZSBwcm90b3R5cGUgCiBQQVNTIFN0cmVhbXMgYW5kIHByb21pc2VzOiByZXBsYWNlIHRo ZW4gbWV0aG9kIGluIHByb21pc2Ugb2JqZWN0IAogUEFTUyBTdHJlYW1zIHNob3VsZCBub3QgZGly ZWN0bHkgdXNlIE51bWJlciBhbmQgcmVsYXRlZCBtZXRob2RzIAorUEFTUyBTdHJlYW1zIHNob3Vs ZCBub3QgZGlyZWN0bHkgdXNlIFJlYWRhYmxlU3RyZWFtIHB1YmxpYyBBUElzIAogCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9zdHJlYW1zL3N0cmVhbXMtcHJvbWlzZXMuaHRtbCBiL0xheW91dFRl c3RzL3N0cmVhbXMvc3RyZWFtcy1wcm9taXNlcy5odG1sCmluZGV4IGFlMGY0YjZkOTg4YmJmOTIw N2ZlZjExYzI5MTBmNDQwMWZmOWFmNjAuLmU4NTk5MDIyYTVmMjc3NjI1MzNlMmM0YTM5ZDYyY2Nm ZmVlZDIyMjEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3N0cmVhbXMvc3RyZWFtcy1wcm9taXNl cy5odG1sCisrKyBiL0xheW91dFRlc3RzL3N0cmVhbXMvc3RyZWFtcy1wcm9taXNlcy5odG1sCkBA IC0xMTUsNCArMTE1LDE0IEBAIHRlc3QoZnVuY3Rpb24oKSB7CiAgICAgICAgIE51bWJlci5pc0Zp bml0ZSA9IE51bWJlcklzRmluaXRlQmFja3VwOwogICAgIH0KIH0sICdTdHJlYW1zIHNob3VsZCBu b3QgZGlyZWN0bHkgdXNlIE51bWJlciBhbmQgcmVsYXRlZCBtZXRob2RzJyk7Cit0ZXN0KGZ1bmN0 aW9uKCkgeworICAgIGNvbnN0IFJlYWRhYmxlU3RyZWFtR2V0UmVhZGVyQmFja3VwID0gUmVhZGFi bGVTdHJlYW0ucHJvdG90eXBlLmdldFJlYWRlcjsKKworICAgIHRyeSB7CisgICAgICAgIFJlYWRh YmxlU3RyZWFtLnByb3RvdHlwZS5nZXRSZWFkZXIgPSBmdW5jdGlvbigpIHsgYXNzZXJ0X3VucmVh Y2hlZCgic3RyZWFtcyBzaG91bGQgbm90IHVzZSB0aGlzIFJlYWRhYmxlU3RyZWFtLmdldFJlYWRl ciBtZXRob2QiKTsgfTsKKyAgICAgICAgbmV3IFJlYWRhYmxlU3RyZWFtKCkudGVlKCk7CisgICAg fSBmaW5hbGx5IHsKKyAgICAgICAgUmVhZGFibGVTdHJlYW0ucHJvdG90eXBlLmdldFJlYWRlciA9 IFJlYWRhYmxlU3RyZWFtR2V0UmVhZGVyQmFja3VwOworICAgIH0KK30sICdTdHJlYW1zIHNob3Vs ZCBub3QgZGlyZWN0bHkgdXNlIFJlYWRhYmxlU3RyZWFtIHB1YmxpYyBBUElzJyk7CiA8L3Njcmlw dD4K