151485 2015-11-20 02:37:24 -0800 New JSC tests introduced in r192664 fail on ARM 2015-11-20 15:46:25 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 151465 1 ossy mark.lam cgarcia clopez commit-queue ggaren keith_miller mark.lam msaboff saam oldest_to_newest 1143606 0 ossy 2015-11-20 02:37:24 -0800 New tests introduced in http://trac.webkit.org/r192664 fail on ARM Linux tester bots. Maybe they fail on iOS too, but I don't know, because there is no (public) iOS JSC tester. 32 bit ARM bots: ----------------- - https://build.webkit.org/builders/EFL%20Linux%20ARMv7%20Thumb2%20Release/builds/16232 - https://build.webkit.org/builders/EFL%20Linux%20ARMv7%20Traditional%20Release/builds/16078 - https://build.webkit.org/builders/GTK%20Linux%20ARM%20Release/builds/9401 ** The following JSC stress test failures have been introduced: stress/op_rshift.js.always-trigger-copy-phase stress/op_rshift.js.default stress/op_rshift.js.dfg-maximal-flush-validate-no-cjit stress/op_rshift.js.no-cjit-validate-phases stress/op_rshift.js.no-llint stress/op_urshift.js.always-trigger-copy-phase stress/op_urshift.js.default stress/op_urshift.js.dfg-maximal-flush-validate-no-cjit stress/op_urshift.js.no-cjit-validate-phases stress/op_urshift.js.no-llint the 64 bit ARM bot: -------------------- - https://build.webkit.org/builders/EFL%20Linux%20AArch64%20Release/builds/4437 ** The following JSC stress test failures have been introduced: [snip] (older failures) stress/op_div.js.always-trigger-copy-phase stress/op_div.js.default stress/op_div.js.dfg-eager stress/op_div.js.dfg-eager-no-cjit-validate stress/op_div.js.dfg-maximal-flush-validate-no-cjit stress/op_div.js.no-cjit-validate-phases stress/op_div.js.no-llint [snip] (older failures) 1143761 1 mark.lam 2015-11-20 13:08:18 -0800 I've confirmed the op_div failures on ARM64. Checking ARMv7 now. 1143811 2 mark.lam 2015-11-20 14:11:38 -0800 I've also confirmed the op_rshift and op_urshift failures on ARMv7. 1143844 3 mark.lam 2015-11-20 15:13:26 -0800 I filed https://bugs.webkit.org/show_bug.cgi?id=151514 to track the ARM32 bugs, and https://bugs.webkit.org/show_bug.cgi?id=151515 to track the ARM64 bug. I will skip those tests for now. 1143849 4 266004 mark.lam 2015-11-20 15:16:53 -0800 Created attachment 266004 proposed patch. 1143850 5 266004 ggaren 2015-11-20 15:20:59 -0800 Comment on attachment 266004 proposed patch. r=me 1143856 6 266004 mark.lam 2015-11-20 15:42:11 -0800 Comment on attachment 266004 proposed patch. Cancelling commit queue. Will commit manually. 1143859 7 mark.lam 2015-11-20 15:46:25 -0800 Thanks for the review. Landed in r192708: <http://trac.webkit.org/r192708>. 266004 2015-11-20 15:16:53 -0800 2015-11-20 15:42:11 -0800 proposed patch. bug-151485.patch text/plain 2433 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkyNzAzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE1LTExLTIwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBO ZXcgSlNDIHRlc3RzIGludHJvZHVjZWQgaW4gcjE5MjY2NCBmYWlsIG9uIEFSTS4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTQ4NQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBuZXdseSBhZGRlZCB0 ZXN0cyBhcmUgZXhwb3Npbmcgc29tZSBwcmUtZXhpc3RpbmcgYnVncy4gIFRoZSBidWdzIGFyZSB0 cmFja2VkIGhlcmU6CisgICAgICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTUxNTE0CisgICAgICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUxNTE1CisKKyAgICAgICAgU2tpcHBpbmcgdGhlIHRlc3RzIGZvciBub3cu CisKKyAgICAgICAgKiB0ZXN0cy9zdHJlc3Mvb3BfZGl2LmpzOgorICAgICAgICAqIHRlc3RzL3N0 cmVzcy9vcF9yc2hpZnQuanM6CisgICAgICAgICogdGVzdHMvc3RyZXNzL29wX3Vyc2hpZnQuanM6 CisKIDIwMTUtMTEtMjAgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAg ICBCMyBzaG91bGQgaGF2ZSBhIFNlbGVjdCBvcGNvZGUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS90ZXN0cy9zdHJlc3Mvb3BfZGl2LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS90ZXN0cy9zdHJlc3Mvb3BfZGl2LmpzCShyZXZpc2lvbiAxOTI2ODUpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL29wX2Rpdi5qcwkod29ya2luZyBjb3B5KQpA QCAtMSw0ICsxLDUgQEAKLS8vQCBydW5GVExOb0NKSVQKKy8vQCBza2lwCisvLyBGSVhNRTogaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTUxNQogCiAvLyBJZiBhbGwg Z29lcyB3ZWxsLCB0aGlzIHRlc3QgbW9kdWxlIHdpbGwgdGVybWluYXRlIHNpbGVudGx5LiBJZiBu b3QsIGl0IHdpbGwgcHJpbnQKIC8vIGVycm9ycy4gU2VlIGJpbmFyeS1vcC10ZXN0LmpzIGZvciBk ZWJ1Z2dpbmcgb3B0aW9ucyBpZiBuZWVkZWQuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv dGVzdHMvc3RyZXNzL29wX3JzaGlmdC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvdGVzdHMvc3RyZXNzL29wX3JzaGlmdC5qcwkocmV2aXNpb24gMTkyNjg1KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9vcF9yc2hpZnQuanMJKHdvcmtpbmcgY29w eSkKQEAgLTEsNCArMSw1IEBACi0vL0AgcnVuRlRMTm9DSklUCisvL0Agc2tpcAorLy8gRklYTUU6 IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE1MTQKIAogLy8gSWYg YWxsIGdvZXMgd2VsbCwgdGhpcyB0ZXN0IG1vZHVsZSB3aWxsIHRlcm1pbmF0ZSBzaWxlbnRseS4g SWYgbm90LCBpdCB3aWxsIHByaW50CiAvLyBlcnJvcnMuIFNlZSBiaW5hcnktb3AtdGVzdC5qcyBm b3IgZGVidWdnaW5nIG9wdGlvbnMgaWYgbmVlZGVkLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL3Rlc3RzL3N0cmVzcy9vcF91cnNoaWZ0LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS90ZXN0cy9zdHJlc3Mvb3BfdXJzaGlmdC5qcwkocmV2aXNpb24gMTkyNjg1KQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9vcF91cnNoaWZ0LmpzCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDQgKzEsNSBAQAotLy9AIHJ1bkZUTE5vQ0pJVAorLy9AIHNraXAKKy8v IEZJWE1FOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxNTE0CiAK IC8vIElmIGFsbCBnb2VzIHdlbGwsIHRoaXMgdGVzdCBtb2R1bGUgd2lsbCB0ZXJtaW5hdGUgc2ls ZW50bHkuIElmIG5vdCwgaXQgd2lsbCBwcmludAogLy8gZXJyb3JzLiBTZWUgYmluYXJ5LW9wLXRl c3QuanMgZm9yIGRlYnVnZ2luZyBvcHRpb25zIGlmIG5lZWRlZC4K