151484 2015-11-19 22:23:24 -0800 Modern IDB: Get IDBRequest.readyState right 2015-11-20 10:55:20 -0800 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 149117 1 beidson beidson achristensen alecflett commit-queue jer.noble jsbell oldest_to_newest 1143584 0 beidson 2015-11-19 22:23:24 -0800 Modern IDB: Get IDBRequest.readyState right Not much effort gone in to getting it right so far. Revealed on many of the legacy tests, such as storage/indexeddb/mozilla/add-twice-failure.html 1143587 1 beidson 2015-11-19 22:31:23 -0800 (In reply to comment #0) > Modern IDB: Get IDBRequest.readyState right > > Not much effort gone in to getting it right so far. Actually, it appears we do keep the flag updated appropriately, but we just never returned the correct string for the readyState accessor. Doh! 1143670 2 265963 beidson 2015-11-20 09:41:28 -0800 Created attachment 265963 Patch v1 1143702 3 265963 commit-queue 2015-11-20 10:55:17 -0800 Comment on attachment 265963 Patch v1 Clearing flags on attachment: 265963 Committed r192686: <http://trac.webkit.org/changeset/192686> 1143703 4 commit-queue 2015-11-20 10:55:20 -0800 All reviewed patches have been landed. Closing bug. 265963 2015-11-20 09:41:28 -0800 2015-11-20 10:55:17 -0800 Patch v1 patch text/plain 5525 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyMmYyODU0Li5jN2NiODY3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTUtMTEt MjAgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIE1vZGVybiBJ REI6IEdldCBJREJSZXF1ZXN0LnJlYWR5U3RhdGUgcmlnaHQuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE0ODQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL21vZGVybi9y ZXF1ZXN0LXJlYWR5c3RhdGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBzdG9yYWdl L2luZGV4ZWRkYi9tb2Rlcm4vcmVxdWVzdC1yZWFkeXN0YXRlLmh0bWw6IEFkZGVkLgorCiAyMDE1 LTExLTIwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKICAg ICAgICAgQ2hhbmdpbmcgc29tZSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwv c2VtYW50aWNzIGV4cGVjdGF0aW9ucyBmcm9tIFRpbWVvdXQvRmFpbHVyZSB0byBQYXNzCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vcmVxdWVzdC1yZWFk eXN0YXRlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL21vZGVy bi9yZXF1ZXN0LXJlYWR5c3RhdGUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAuLjhmNGMxMWIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9zdG9y YWdlL2luZGV4ZWRkYi9tb2Rlcm4vcmVxdWVzdC1yZWFkeXN0YXRlLWV4cGVjdGVkLnR4dApAQCAt MCwwICsxLDExIEBACitUaGlzIHRlc3QgbWFrZXMgc3VyZSB0aGF0IElEQlJlcXVlc3QucmVhZHlT dGF0ZSByZXR1cm5zIGV4cGVjdGVkIHZhbHVlcy4KK0FmdGVyIGNhbGxpbmcgaW5kZXhlZERCLm9w ZW4oKSwgY3JlYXRlIHJlcXVlc3QgcmVhZHlTdGF0ZSBpczogcGVuZGluZworSW5pdGlhbCB1cGdy YWRlIG5lZWRlZDogT2xkIHZlcnNpb24gLSAwIE5ldyB2ZXJzaW9uIC0gMQorQ3JlYXRlIHJlcXVl c3QgcmVhZHlTdGF0ZSBpczogZG9uZQorQWZ0ZXIgY2FsbGluZyBvcGVuQ3Vyc29yLCByZXF1ZXN0 IHJlYWR5U3RhdGUgaXM6IHBlbmRpbmcKK0FmdGVyIHN1Y2Nlc3NmdWwgb3BlbmluZyBvZiB0aGUg Y3Vyc29yLCByZXF1ZXN0IHJlYWR5U3RhdGUgaXM6IGRvbmUKK0FmdGVyIGNhbGxpbmcgY29udGlu dWUoKSwgcmVxdWVzdCByZWFkeVN0YXRlIGlzOiBwZW5kaW5nCitBZnRlciBjb250aW51ZSgpIGNv bXBsZXRlZCwgcmVxdWVzdCByZWFkeVN0YXRlIGlzOiBkb25lCitJbml0aWFsIHVwZ3JhZGUgdmVy c2lvbmNoYW5nZSB0cmFuc2FjdGlvbiBjb21wbGV0ZQorRG9uZQorCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vcmVxdWVzdC1yZWFkeXN0YXRlLmh0bWwg Yi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vcmVxdWVzdC1yZWFkeXN0YXRl Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMjAxNzBhOAotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL21vZGVybi9yZXF1ZXN0 LXJlYWR5c3RhdGUuaHRtbApAQCAtMCwwICsxLDY1IEBACitUaGlzIHRlc3QgbWFrZXMgc3VyZSB0 aGF0IElEQlJlcXVlc3QucmVhZHlTdGF0ZSByZXR1cm5zIGV4cGVjdGVkIHZhbHVlcy48YnI+Cis8 ZGl2IGlkPSJsb2dnZXIiPjwvZGl2PgorPHNjcmlwdD4KKworaWYgKHdpbmRvdy50ZXN0UnVubmVy KSB7CisgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7CisgICAgdGVzdFJ1bm5lci5kdW1w QXNUZXh0KCk7Cit9CisKK2Z1bmN0aW9uIGRvbmUoKQoreworICAgIGxvZygiRG9uZSIpOworICAg IGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7 Cit9CisKK2Z1bmN0aW9uIGxvZyhtZXNzYWdlKQoreworICAgIGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJsb2dnZXIiKS5pbm5lckhUTUwgKz0gbWVzc2FnZSArICI8YnI+IjsKK30KKwordmFyIGNy ZWF0ZVJlcXVlc3QgPSB3aW5kb3cuaW5kZXhlZERCLm9wZW4oIlJlcXVlc3RSZWFkeVN0YXRlRGF0 YWJhc2UiLCAxKTsKK2xvZygiQWZ0ZXIgY2FsbGluZyBpbmRleGVkREIub3BlbigpLCBjcmVhdGUg cmVxdWVzdCByZWFkeVN0YXRlIGlzOiAiICsgY3JlYXRlUmVxdWVzdC5yZWFkeVN0YXRlKTsKKwor Y3JlYXRlUmVxdWVzdC5vbnVwZ3JhZGVuZWVkZWQgPSBmdW5jdGlvbihldmVudCkgeworICAgIGxv ZygiSW5pdGlhbCB1cGdyYWRlIG5lZWRlZDogT2xkIHZlcnNpb24gLSAiICsgZXZlbnQub2xkVmVy c2lvbiArICIgTmV3IHZlcnNpb24gLSAiICsgZXZlbnQubmV3VmVyc2lvbik7CisgICAgbG9nKCJD cmVhdGUgcmVxdWVzdCByZWFkeVN0YXRlIGlzOiAiICsgY3JlYXRlUmVxdWVzdC5yZWFkeVN0YXRl KTsKKworICAgIHZhciB2ZXJzaW9uVHJhbnNhY3Rpb24gPSBjcmVhdGVSZXF1ZXN0LnRyYW5zYWN0 aW9uOworICAgIHZhciBkYXRhYmFzZSA9IGV2ZW50LnRhcmdldC5yZXN1bHQ7CisgICAgdmFyIG9i amVjdFN0b3JlID0gZGF0YWJhc2UuY3JlYXRlT2JqZWN0U3RvcmUoIlRlc3RPYmplY3RTdG9yZSIp OworCisgICAgZm9yICh2YXIgaSA9IDA7IGkgPCAyOyArK2kpCisgICAgICAgIG9iamVjdFN0b3Jl LnB1dCgiUmVjb3JkICIgKyBpLCBpKTsKKyAgICAKKyAgICB2YXIgcmVxdWVzdCA9IG9iamVjdFN0 b3JlLm9wZW5DdXJzb3IoKTsKKyAgICBsb2coIkFmdGVyIGNhbGxpbmcgb3BlbkN1cnNvciwgcmVx dWVzdCByZWFkeVN0YXRlIGlzOiAiICsgcmVxdWVzdC5yZWFkeVN0YXRlKTsKKyAgICByZXF1ZXN0 Lm9uc3VjY2VzcyA9IGZ1bmN0aW9uKCkgeworICAgICAgICBsb2coIkFmdGVyIHN1Y2Nlc3NmdWwg b3BlbmluZyBvZiB0aGUgY3Vyc29yLCByZXF1ZXN0IHJlYWR5U3RhdGUgaXM6ICIgKyByZXF1ZXN0 LnJlYWR5U3RhdGUpOworCisgICAgICAgIHJlcXVlc3Qub25zdWNjZXNzID0gZnVuY3Rpb24oKSB7 CisgICAgICAgICAgICBsb2coIkFmdGVyIGNvbnRpbnVlKCkgY29tcGxldGVkLCByZXF1ZXN0IHJl YWR5U3RhdGUgaXM6ICIgKyByZXF1ZXN0LnJlYWR5U3RhdGUpOworICAgICAgICB9CisKKyAgICAg ICAgcmVxdWVzdC5yZXN1bHQuY29udGludWUoKTsKKyAgICAgICAgbG9nKCJBZnRlciBjYWxsaW5n IGNvbnRpbnVlKCksIHJlcXVlc3QgcmVhZHlTdGF0ZSBpczogIiArIHJlcXVlc3QucmVhZHlTdGF0 ZSk7CisgICAgfQorICAgICAgICAgIAorICAgIHZlcnNpb25UcmFuc2FjdGlvbi5vbmFib3J0ID0g ZnVuY3Rpb24oZXZlbnQpIHsKKyAgICAgICAgbG9nKCJJbml0aWFsIHVwZ3JhZGUgdmVyc2lvbmNo YW5nZSB0cmFuc2FjdGlvbiB1bmV4cGVjdGVkIGFib3J0ZWQiKTsKKyAgICAgICAgZG9uZSgpOwor ICAgIH0KKworICAgIHZlcnNpb25UcmFuc2FjdGlvbi5vbmNvbXBsZXRlID0gZnVuY3Rpb24oZXZl bnQpIHsKKyAgICAgICAgbG9nKCJJbml0aWFsIHVwZ3JhZGUgdmVyc2lvbmNoYW5nZSB0cmFuc2Fj dGlvbiBjb21wbGV0ZSIpOworICAgICAgICBkb25lKCk7CisgICAgfQorCisgICAgdmVyc2lvblRy YW5zYWN0aW9uLm9uZXJyb3IgPSBmdW5jdGlvbihldmVudCkgeworICAgICAgICBsb2coIkluaXRp YWwgdXBncmFkZSB2ZXJzaW9uY2hhbmdlIHRyYW5zYWN0aW9uIHVuZXhwZWN0ZWQgZXJyb3IiICsg ZXZlbnQpOworICAgICAgICBkb25lKCk7CisgICAgfQorfQorCis8L3NjcmlwdD4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCA4MTE5YWRhLi5kYjM4OWNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUt MTEtMjAgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIE1vZGVy biBJREI6IEdldCBJREJSZXF1ZXN0LnJlYWR5U3RhdGUgcmlnaHQuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE0ODQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBzdG9yYWdlL2luZGV4ZWRkYi9t b2Rlcm4vcmVxdWVzdC1yZWFkeXN0YXRlLmh0bWwKKworICAgICAgICAqIE1vZHVsZXMvaW5kZXhl ZGRiL2NsaWVudC9JREJSZXF1ZXN0SW1wbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJDbGll bnQ6OklEQlJlcXVlc3Q6OnJlYWR5U3RhdGUpOgorCiAyMDE1LTExLTIwICBZb3Vlbm4gRmFibGV0 ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKICAgICAgICAgVXNlIEhUVFBIZWFkZXJO YW1lIGFzIG11Y2ggYXMgcG9zc2libGUgaW4gWE1MSHR0cFJlcXVlc3QKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL2NsaWVudC9JREJSZXF1ZXN0SW1wbC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9jbGllbnQvSURCUmVxdWVzdEltcGwu Y3BwCmluZGV4IDExMWZhOGEuLjI5ZDMyY2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvaW5kZXhlZGRiL2NsaWVudC9JREJSZXF1ZXN0SW1wbC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvY2xpZW50L0lEQlJlcXVlc3RJbXBsLmNwcApAQCAtMTUw LDggKzE1MCwxNyBAQCBSZWZQdHI8V2ViQ29yZTo6SURCVHJhbnNhY3Rpb24+IElEQlJlcXVlc3Q6 OnRyYW5zYWN0aW9uKCkgY29uc3QKIAogY29uc3QgU3RyaW5nJiBJREJSZXF1ZXN0OjpyZWFkeVN0 YXRlKCkgY29uc3QKIHsKLSAgICBzdGF0aWMgV1RGOjpOZXZlckRlc3Ryb3llZDxTdHJpbmc+IHJl YWR5U3RhdGU7Ci0gICAgcmV0dXJuIHJlYWR5U3RhdGU7CisgICAgc3RhdGljIFdURjo6TmV2ZXJE ZXN0cm95ZWQ8U3RyaW5nPiBwZW5kaW5nU3RyaW5nKCJwZW5kaW5nIik7CisgICAgc3RhdGljIFdU Rjo6TmV2ZXJEZXN0cm95ZWQ8U3RyaW5nPiBkb25lU3RyaW5nKCJkb25lIik7CisKKyAgICBzd2l0 Y2ggKG1fcmVhZHlTdGF0ZSkgeworICAgIGNhc2UgSURCUmVxdWVzdFJlYWR5U3RhdGU6OlBlbmRp bmc6CisgICAgICAgIHJldHVybiBwZW5kaW5nU3RyaW5nOworICAgIGNhc2UgSURCUmVxdWVzdFJl YWR5U3RhdGU6OkRvbmU6CisgICAgICAgIHJldHVybiBkb25lU3RyaW5nOworICAgIGRlZmF1bHQ6 CisgICAgICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgfQogfQogCiB1aW50 NjRfdCBJREJSZXF1ZXN0Ojpzb3VyY2VPYmplY3RTdG9yZUlkZW50aWZpZXIoKSBjb25zdAo=