<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>151473</bug_id>
          
          <creation_ts>2015-11-19 18:46:18 -0800</creation_ts>
          <short_desc>[GTK] Reimplement webkit_web_context_[get,set]_process_model</short_desc>
          <delta_ts>2015-11-20 06:00:35 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>Other</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>151418</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Michael Catanzaro">mcatanzaro</assigned_to>
          <cc>achristensen</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>ossy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1143537</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2015-11-19 18:46:18 -0800</bug_when>
    <thetext>Reimplement webkit_web_context_[get,set]_process_model() to keep the API working as before. We can implement WEBKIT_PROCESS_MODEL_SHARED_SECONDARY_PROCESS by setting a process limit of 1.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1143563</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2015-11-19 20:17:06 -0800</bug_when>
    <thetext>This applies on top of the patch in bug #151418.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1143564</commentid>
    <comment_count>2</comment_count>
      <attachid>265935</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2015-11-19 20:17:17 -0800</bug_when>
    <thetext>Created attachment 265935
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1143590</commentid>
    <comment_count>3</comment_count>
      <attachid>265935</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-11-19 23:26:13 -0800</bug_when>
    <thetext>Comment on attachment 265935
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265935&amp;action=review

The original patch has been rolled out, maybe we can land this as part of the network process option removal instead of a follow up patch.

&gt; Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:1149
&gt; +        if (context-&gt;priv-&gt;context-&gt;maximumNumberOfProcesses() != 1)
&gt; +            context-&gt;priv-&gt;context-&gt;setMaximumNumberOfProcesses(1);

Don&apos;t need to check the value didn&apos;t change, this simply sets the value, there&apos;s no ipc traffic or any other thing to avoid here.

&gt; Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:1153
&gt; +        if (context-&gt;priv-&gt;context-&gt;maximumNumberOfProcesses() == 1)
&gt; +            context-&gt;priv-&gt;context-&gt;setMaximumNumberOfProcesses(0);

Ditto.

&gt; Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:1156
&gt; +    default:
&gt; +        ASSERT_NOT_REACHED();

Just remove the default, since there aren&apos;t more values in the enum. That way we will get a compile warning/error if we add a new value and it&apos;s not handled here.

&gt; Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:1174
&gt; +    return context-&gt;priv-&gt;context-&gt;maximumNumberOfProcesses() == 1 ?
&gt; +        WEBKIT_PROCESS_MODEL_SHARED_SECONDARY_PROCESS : WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES;

This is not accurate. You can do set_process_model (MULTIPLE_SECONDARY_PROCESSES); set set_web_process_count_limit(1) and then get_process_model will return SHARED_SECONDARY_PROCESS. What we set with the setter is what we should return in the getter, the fact that now it&apos;s implemented changing the limit should be an implementation detail not exposed to the users.

&gt; Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:1186
&gt; - * The default value is 0 and means no limit.
&gt; + * The default value is 1. If you change the process model to
&gt; + * %WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES, then the process count
&gt; + * limit will be removed. Setting the process count limit to a value other than
&gt; + * 1 automatically changes the process model to %WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES.

Don&apos;t change this either. We should just keep the current model cached in the instance and return that in the getter, and here we could just return early if the process model is SHARED_SECONDARY_PROCESS and in the getter we always return 0 when process model is SHARED_SECONDARY_PROCESS even if it&apos;s actually 1 internally.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1143630</commentid>
    <comment_count>4</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2015-11-20 06:00:35 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; Don&apos;t change this either. We should just keep the current model cached in
&gt; the instance and return that in the getter, and here we could just return
&gt; early if the process model is SHARED_SECONDARY_PROCESS and in the getter we
&gt; always return 0 when process model is SHARED_SECONDARY_PROCESS even if it&apos;s
&gt; actually 1 internally.

OK, if that&apos;s what you prefer. You did that in bug #151418, so we don&apos;t need this bug anymore.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>265935</attachid>
            <date>2015-11-19 20:17:17 -0800</date>
            <delta_ts>2015-11-19 23:26:13 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-151473-20151119221705.patch</filename>
            <type>text/plain</type>
            <size>6863</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNjcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTRkZjMyMjRmNGNjZmYw
ZjU4YTY2M2VhZTFkODZkOTJmNmRhODgzYi4uNDRiN2ViNjZhZmRlNzYyMDQ1MmM1MDIzMzYwMzhj
MTQyYTEzN2UyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTExLTE5ICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBS
ZWltcGxlbWVudCB3ZWJraXRfd2ViX2NvbnRleHRfW2dldCxzZXRdX3Byb2Nlc3NfbW9kZWwKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTQ3MworCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNz
L0FQSS9ndGsvV2ViS2l0V2ViQ29udGV4dC5jcHA6CisgICAgICAgICh3ZWJraXRXZWJDb250ZXh0
Q29uc3RydWN0ZWQpOiBTZXQgdGhlIGRlZmF1bHQgcHJvY2VzcyBsaW1pdCB0byAxIHRvIGVuc3Vy
ZSB0aGUgZGVmYXVsdAorICAgICAgICBwcm9jZXNzIG1vZGVsIHJlbWFpbnMgV0VCS0lUX1BST0NF
U1NfTU9ERUxfU0hBUkVEX1NFQ09OREFSWV9QUk9DRVNTLgorICAgICAgICAod2Via2l0X3dlYl9j
b250ZXh0X3NldF9wcm9jZXNzX21vZGVsKTogUmVpbXBsZW1lbnQgaW4gdGVybXMgb2YgdGhlIG1h
eCBwcm9jZXNzIGNvdW50LgorICAgICAgICAod2Via2l0X3dlYl9jb250ZXh0X2dldF9wcm9jZXNz
X21vZGVsKTogRGl0dG8uCisKIDIwMTUtMTEtMTkgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0
ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBGaXggR1RLIEJ1aWxkIGFmdGVyIHIxOTI2Njcu
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJD
b250ZXh0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkNv
bnRleHQuY3BwCmluZGV4IDQxZTg0M2I2M2RlN2NjMTY0ZGEwZTE4OTQzNDA1OTUwNzhiNDdlMWQu
LjU3ZDUxYjEzM2Y5YWJhYmNhZDQzMzcwZmVlMzFlNjI1YzY2ZmFmOTEgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkNvbnRleHQuY3BwCisrKyBi
L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkNvbnRleHQuY3BwCkBA
IC0yNzMsNiArMjczLDcgQEAgc3RhdGljIHZvaWQgd2Via2l0V2ViQ29udGV4dENvbnN0cnVjdGVk
KEdPYmplY3QqIG9iamVjdCkKICAgICAgICAgY29uZmlndXJhdGlvbi5zZXRMb2NhbFN0b3JhZ2VE
aXJlY3RvcnkoV2ViQ29yZTo6ZmlsZW5hbWVUb1N0cmluZyhwcml2LT5sb2NhbFN0b3JhZ2VEaXJl
Y3RvcnkuZGF0YSgpKSk7CiAKICAgICBwcml2LT5jb250ZXh0ID0gV2ViUHJvY2Vzc1Bvb2w6OmNy
ZWF0ZShjb25maWd1cmF0aW9uKTsKKyAgICBwcml2LT5jb250ZXh0LT5zZXRNYXhpbXVtTnVtYmVy
T2ZQcm9jZXNzZXMoMSk7CiAKICAgICBpZiAoIXByaXYtPndlYnNpdGVEYXRhTWFuYWdlcikKICAg
ICAgICAgcHJpdi0+d2Vic2l0ZURhdGFNYW5hZ2VyID0gd2Via2l0V2Vic2l0ZURhdGFNYW5hZ2Vy
Q3JlYXRlKHdlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0aW9uRm9yV2ViUHJvY2Vzc1Bvb2xDb25m
aWd1cmF0aW9uKGNvbmZpZ3VyYXRpb24pKTsKQEAgLTExMzgsOSArMTEzOSwyMiBAQCB2b2lkIHdl
YmtpdF93ZWJfY29udGV4dF9hbGxvd190bHNfY2VydGlmaWNhdGVfZm9yX2hvc3QoV2ViS2l0V2Vi
Q29udGV4dCogY29udGV4dAogICoKICAqIFNpbmNlOiAyLjQKICAqLwotdm9pZCB3ZWJraXRfd2Vi
X2NvbnRleHRfc2V0X3Byb2Nlc3NfbW9kZWwoV2ViS2l0V2ViQ29udGV4dCosIFdlYktpdFByb2Nl
c3NNb2RlbCkKK3ZvaWQgd2Via2l0X3dlYl9jb250ZXh0X3NldF9wcm9jZXNzX21vZGVsKFdlYktp
dFdlYkNvbnRleHQqIGNvbnRleHQsIFdlYktpdFByb2Nlc3NNb2RlbCBwcm9jZXNzTW9kZWwpCiB7
Ci0gICAgLy8gRklYTUU6IFRoaXMgaXMgZGVwcmVjYXRlZC4gT25seSBXRUJLSVRfUFJPQ0VTU19N
T0RFTF9NVUxUSVBMRV9TRUNPTkRBUllfUFJPQ0VTU0VTIGlzIHN1cHBvcnRlZCBub3cuCisgICAg
Z19yZXR1cm5faWZfZmFpbChXRUJLSVRfSVNfV0VCX0NPTlRFWFQoY29udGV4dCkpOworCisgICAg
c3dpdGNoIChwcm9jZXNzTW9kZWwpIHsKKyAgICBjYXNlIFdFQktJVF9QUk9DRVNTX01PREVMX1NI
QVJFRF9TRUNPTkRBUllfUFJPQ0VTUzoKKyAgICAgICAgaWYgKGNvbnRleHQtPnByaXYtPmNvbnRl
eHQtPm1heGltdW1OdW1iZXJPZlByb2Nlc3NlcygpICE9IDEpCisgICAgICAgICAgICBjb250ZXh0
LT5wcml2LT5jb250ZXh0LT5zZXRNYXhpbXVtTnVtYmVyT2ZQcm9jZXNzZXMoMSk7CisgICAgICAg
IGJyZWFrOworICAgIGNhc2UgV0VCS0lUX1BST0NFU1NfTU9ERUxfTVVMVElQTEVfU0VDT05EQVJZ
X1BST0NFU1NFUzoKKyAgICAgICAgaWYgKGNvbnRleHQtPnByaXYtPmNvbnRleHQtPm1heGltdW1O
dW1iZXJPZlByb2Nlc3NlcygpID09IDEpCisgICAgICAgICAgICBjb250ZXh0LT5wcml2LT5jb250
ZXh0LT5zZXRNYXhpbXVtTnVtYmVyT2ZQcm9jZXNzZXMoMCk7CisgICAgICAgIGJyZWFrOworICAg
IGRlZmF1bHQ6CisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIH0KIH0KIAogLyoq
CkBAIC0xMTU2LDcgKzExNzAsOCBAQCB2b2lkIHdlYmtpdF93ZWJfY29udGV4dF9zZXRfcHJvY2Vz
c19tb2RlbChXZWJLaXRXZWJDb250ZXh0KiwgV2ViS2l0UHJvY2Vzc01vZGVsKQogICovCiBXZWJL
aXRQcm9jZXNzTW9kZWwgd2Via2l0X3dlYl9jb250ZXh0X2dldF9wcm9jZXNzX21vZGVsKFdlYktp
dFdlYkNvbnRleHQqIGNvbnRleHQpCiB7Ci0gICAgcmV0dXJuIFdFQktJVF9QUk9DRVNTX01PREVM
X01VTFRJUExFX1NFQ09OREFSWV9QUk9DRVNTRVM7CisgICAgcmV0dXJuIGNvbnRleHQtPnByaXYt
PmNvbnRleHQtPm1heGltdW1OdW1iZXJPZlByb2Nlc3NlcygpID09IDEgPworICAgICAgICBXRUJL
SVRfUFJPQ0VTU19NT0RFTF9TSEFSRURfU0VDT05EQVJZX1BST0NFU1MgOiBXRUJLSVRfUFJPQ0VT
U19NT0RFTF9NVUxUSVBMRV9TRUNPTkRBUllfUFJPQ0VTU0VTOwogfQogCiAvKioKQEAgLTExNjUs
NyArMTE4MCwxMCBAQCBXZWJLaXRQcm9jZXNzTW9kZWwgd2Via2l0X3dlYl9jb250ZXh0X2dldF9w
cm9jZXNzX21vZGVsKFdlYktpdFdlYkNvbnRleHQqIGNvbnRleAogICogQGxpbWl0OiB0aGUgbWF4
aW11bSBudW1iZXIgb2Ygd2ViIHByb2Nlc3NlcwogICoKICAqIFNldHMgdGhlIG1heGltdW0gbnVt
YmVyIG9mIHdlYiBwcm9jZXNzZXMgdGhhdCBjYW4gYmUgY3JlYXRlZCBhdCB0aGUgc2FtZSB0aW1l
IGZvciB0aGUgQGNvbnRleHQuCi0gKiBUaGUgZGVmYXVsdCB2YWx1ZSBpcyAwIGFuZCBtZWFucyBu
byBsaW1pdC4KKyAqIFRoZSBkZWZhdWx0IHZhbHVlIGlzIDEuIElmIHlvdSBjaGFuZ2UgdGhlIHBy
b2Nlc3MgbW9kZWwgdG8KKyAqICVXRUJLSVRfUFJPQ0VTU19NT0RFTF9NVUxUSVBMRV9TRUNPTkRB
UllfUFJPQ0VTU0VTLCB0aGVuIHRoZSBwcm9jZXNzIGNvdW50CisgKiBsaW1pdCB3aWxsIGJlIHJl
bW92ZWQuIFNldHRpbmcgdGhlIHByb2Nlc3MgY291bnQgbGltaXQgdG8gYSB2YWx1ZSBvdGhlciB0
aGFuCisgKiAxIGF1dG9tYXRpY2FsbHkgY2hhbmdlcyB0aGUgcHJvY2VzcyBtb2RlbCB0byAlV0VC
S0lUX1BST0NFU1NfTU9ERUxfTVVMVElQTEVfU0VDT05EQVJZX1BST0NFU1NFUy4KICAqCiAgKiBU
aGlzIG1ldGhvZCAqKm11c3QgYmUgY2FsbGVkIGJlZm9yZSBhbnkgd2ViIHByb2Nlc3MgaGFzIGJl
ZW4gY3JlYXRlZCoqLAogICogYXMgZWFybHkgYXMgcG9zc2libGUgaW4geW91ciBhcHBsaWNhdGlv
bi4gQ2FsbGluZyBpdCBsYXRlciB3aWxsIG1ha2UKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxv
ZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkZTNkOGQ0NmVmNWFiNjk5YWE1YTUzYzFmMDU3ZDlk
MjYzOGMzNGE0Li44NzhlNzQ3ZjRjNjAwZDBiMmZmNzRkY2JmYTA2MTM1NzIyMzhmZTAxIDEwMDY0
NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs
MTQgQEAKKzIwMTUtMTEtMTkgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEu
Y29tPgorCisgICAgICAgIFtHVEtdIFJlaW1wbGVtZW50IHdlYmtpdF93ZWJfY29udGV4dF9bZ2V0
LHNldF1fcHJvY2Vzc19tb2RlbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MTUxNDczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJHdGsvVGVzdE11bHRpcHJv
Y2Vzcy5jcHA6CisgICAgICAgICh0ZXN0V2ViUHJvY2Vzc0xpbWl0KToKKyAgICAgICAgKGJlZm9y
ZUFsbCk6CisKIDIwMTUtMTEtMTkgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Vi
a2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgdGhlIG5vbi1OZXR3b3JrUHJvY2VzcyBjb25maWd1
cmF0aW9ucwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyR3Rr
L1Rlc3RNdWx0aXByb2Nlc3MuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQy
R3RrL1Rlc3RNdWx0aXByb2Nlc3MuY3BwCmluZGV4IDAyMGFkMzUyOWEyODA3NTU1YzU3ODg4YzA2
OGY1ODhlOWI1ZDMwOWUuLjM0Y2E5ZGU4NDRkNjZlNWQ1NzgzNGRhMzBjMGQzMDMxZGUyMmMxMWQg
MTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0TXVs
dGlwcm9jZXNzLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJHdGsv
VGVzdE11bHRpcHJvY2Vzcy5jcHAKQEAgLTI0Myw5ICsyNDMsMTMgQEAgc3RhdGljIHZvaWQgdGVz
dE11bHRpcHJvY2Vzc1dlYlZpZXdDcmVhdGVSZWFkeUNsb3NlKFVJQ2xpZW50TXVsdGlwcm9jZXNz
VGVzdCogdGUKIHN0YXRpYyB2b2lkIHRlc3RXZWJQcm9jZXNzTGltaXQoTXVsdGlwcm9jZXNzVGVz
dCogdGVzdCwgZ2NvbnN0cG9pbnRlcikKIHsKICAgICBnX2Fzc2VydF9jbXB1aW50KHdlYmtpdF93
ZWJfY29udGV4dF9nZXRfd2ViX3Byb2Nlc3NfY291bnRfbGltaXQodGVzdC0+bV93ZWJDb250ZXh0
LmdldCgpKSwgPT0sIDApOworICAgIGdfYXNzZXJ0X2NtcHVpbnQod2Via2l0X3dlYl9jb250ZXh0
X2dldF9wcm9jZXNzX21vZGVsKHRlc3QtPm1fd2ViQ29udGV4dC5nZXQoKSksCisgICAgICAgID09
LCBXRUJLSVRfUFJPQ0VTU19NT0RFTF9NVUxUSVBMRV9TRUNPTkRBUllfUFJPQ0VTU0VTKTsKIAog
ICAgIHdlYmtpdF93ZWJfY29udGV4dF9zZXRfd2ViX3Byb2Nlc3NfY291bnRfbGltaXQodGVzdC0+
bV93ZWJDb250ZXh0LmdldCgpLCAxKTsKICAgICBnX2Fzc2VydF9jbXB1aW50KHdlYmtpdF93ZWJf
Y29udGV4dF9nZXRfd2ViX3Byb2Nlc3NfY291bnRfbGltaXQodGVzdC0+bV93ZWJDb250ZXh0Lmdl
dCgpKSwgPT0sIDEpOworICAgIGdfYXNzZXJ0X2NtcHVpbnQod2Via2l0X3dlYl9jb250ZXh0X2dl
dF9wcm9jZXNzX21vZGVsKHRlc3QtPm1fd2ViQ29udGV4dC5nZXQoKSksCisgICAgICAgID09LCBX
RUJLSVRfUFJPQ0VTU19NT0RFTF9TSEFSRURfU0VDT05EQVJZX1BST0NFU1MpOwogCiAgICAgLy8g
Q3JlYXRlIHR3byB3ZWIgdmlld3MgYnV0IHRoZXJlIHNob3VsZCBiZSBvbmx5IG9uZSB3ZWIgcHJv
Y2Vzcy4KICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbnVtVmlld3M7IGkrKykgewpAQCAt
MjYxLDYgKzI2NSw3IEBAIHZvaWQgYmVmb3JlQWxsKCkKICAgICAvLyBDaGVjayB0aGF0IGRlZmF1
bHQgc2V0dGluZyBpcyB0aGUgb25lIHN0YXRlZCBpbiB0aGUgZG9jdW1lbnRhdGlvbgogICAgIGdf
YXNzZXJ0X2NtcHVpbnQod2Via2l0X3dlYl9jb250ZXh0X2dldF9wcm9jZXNzX21vZGVsKHdlYmtp
dF93ZWJfY29udGV4dF9nZXRfZGVmYXVsdCgpKSwKICAgICAgICAgPT0sIFdFQktJVF9QUk9DRVNT
X01PREVMX1NIQVJFRF9TRUNPTkRBUllfUFJPQ0VTUyk7CisgICAgZ19hc3NlcnRfY21wdWludCh3
ZWJraXRfd2ViX2NvbnRleHRfZ2V0X3dlYl9wcm9jZXNzX2NvdW50X2xpbWl0KHdlYmtpdF93ZWJf
Y29udGV4dF9nZXRfZGVmYXVsdCgpKSwgPT0sIDEpOwogCiAgICAgd2Via2l0X3dlYl9jb250ZXh0
X3NldF9wcm9jZXNzX21vZGVsKHdlYmtpdF93ZWJfY29udGV4dF9nZXRfZGVmYXVsdCgpLAogICAg
ICAgICBXRUJLSVRfUFJPQ0VTU19NT0RFTF9NVUxUSVBMRV9TRUNPTkRBUllfUFJPQ0VTU0VTKTsK
QEAgLTI2OCw2ICsyNzMsNyBAQCB2b2lkIGJlZm9yZUFsbCgpCiAgICAgLy8gQ2hlY2sgdGhhdCB0
aGUgZ2V0dGVyIHJldHVybnMgdGhlIG5ld2x5LXNldCB2YWx1ZQogICAgIGdfYXNzZXJ0X2NtcHVp
bnQod2Via2l0X3dlYl9jb250ZXh0X2dldF9wcm9jZXNzX21vZGVsKHdlYmtpdF93ZWJfY29udGV4
dF9nZXRfZGVmYXVsdCgpKSwKICAgICAgICAgPT0sIFdFQktJVF9QUk9DRVNTX01PREVMX01VTFRJ
UExFX1NFQ09OREFSWV9QUk9DRVNTRVMpOworICAgIGdfYXNzZXJ0X2NtcHVpbnQod2Via2l0X3dl
Yl9jb250ZXh0X2dldF93ZWJfcHJvY2Vzc19jb3VudF9saW1pdCh3ZWJraXRfd2ViX2NvbnRleHRf
Z2V0X2RlZmF1bHQoKSksID09LCAwKTsKIAogICAgIGJ1cyA9IG5ldyBXZWJLaXRUZXN0QnVzKCk7
CiAgICAgaWYgKCFidXMtPnJ1bigpKQo=
</data>
<flag name="review"
          id="290962"
          type_id="1"
          status="-"
          setter="cgarcia"
    />
          </attachment>
      

    </bug>

</bugzilla>