151470 2015-11-19 18:10:13 -0800 Web Inspector: Code hotness visualizer: introduce "isScope: true" property 2026-01-12 09:03:14 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All ASSIGNED InRadar P2 Normal --- 146115 1 nvasilyev nvasilyev graouts inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1143526 0 nvasilyev 2015-11-19 18:10:13 -0800 TL;DR https://github.com/WebKit/webkit/blob/a7970c63ab35ad903f6060e2ba28eaf1bd562801/Source/JavaScriptCore/runtime/ControlFlowProfiler.cpp#L97 Instead emitting "executionCount: 1" for scopes, we should introduce a separate property. We could name it "parsed: true" instead of "executionCount: 1". I'm not sure if "parsed" is technically accurate, so bike-shedding is welcome. Longer explanation: var x = 1; function foo() { return 42; } Upon reading executing the JS code above, one of the ranges RuntimeAgent.getBasicBlocks would emit be: { startOffset: 0, endOffset: // end of the file hasExecuted: true, executionCount: 1 } This is a bit misleading, since function foo hasn't been executed. I suggest to instead emit: { startOffset: 0, endOffset: // end of the file hasExecuted: true, parsed: true } Having a different property would allow to style these ranges differently. 1143527 1 webkit-bug-importer 2015-11-19 18:10:54 -0800 <rdar://problem/23623352> 1147159 2 nvasilyev 2015-12-07 19:37:20 -0800 (In reply to comment #0) > TL;DR > https://github.com/WebKit/webkit/blob/ > a7970c63ab35ad903f6060e2ba28eaf1bd562801/Source/JavaScriptCore/runtime/ > ControlFlowProfiler.cpp#L97 > Instead emitting "executionCount: 1" for scopes, we should introduce a > separate property. We could name it "parsed: true" instead of > "executionCount: 1". I'm not sure if "parsed" is technically accurate, so > bike-shedding is welcome. I renamed it from "parsed" to "isScope".