151457 2015-11-19 12:21:46 -0800 FTL->B3 lowering should support absolute(), double comparisons, and intToDouble() 2015-11-19 12:27:17 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 151428 1 fpizlo fpizlo benjamin commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1143381 0 fpizlo 2015-11-19 12:21:46 -0800 Patch forthcoming. 1143382 1 265882 fpizlo 2015-11-19 12:22:45 -0800 Created attachment 265882 the patch 1143383 2 265882 benjamin 2015-11-19 12:25:25 -0800 Comment on attachment 265882 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=265882&action=review > Source/JavaScriptCore/dfg/DFGCommon.h:41 > -#define FTL_USES_B3 0 > +#define FTL_USES_B3 1 Don't forget that one. 1143385 3 fpizlo 2015-11-19 12:27:17 -0800 Landed in http://trac.webkit.org/changeset/192651 265882 2015-11-19 12:22:45 -0800 2015-11-19 12:25:25 -0800 the patch blah.patch text/plain 7255 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkyNjUwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM5IEBA CisyMDE1LTExLTE5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RlRMLT5CMyBsb3dlcmluZyBzaG91bGQgc3VwcG9ydCBhYnNvbHV0ZSgpLCBkb3VibGUgY29tcGFy aXNvbnMsIGFuZCBpbnRUb0RvdWJsZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTE0NTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGZ0bC9GVExCM091dHB1dC5oOgorICAgICAgICAoSlNDOjpGVEw6 Ok91dHB1dDo6ZnBUb0ludDMyKToKKyAgICAgICAgKEpTQzo6RlRMOjpPdXRwdXQ6OmZwVG9VSW50 MzIpOgorICAgICAgICAoSlNDOjpGVEw6Ok91dHB1dDo6aW50VG9GUCk6CisgICAgICAgIChKU0M6 OkZUTDo6T3V0cHV0OjppbnRUb0RvdWJsZSk6CisgICAgICAgIChKU0M6OkZUTDo6T3V0cHV0Ojp1 bnNpZ25lZFRvRlApOgorICAgICAgICAoSlNDOjpGVEw6Ok91dHB1dDo6dW5zaWduZWRUb0RvdWJs ZSk6CisgICAgICAgIChKU0M6OkZUTDo6T3V0cHV0OjppbnRDYXN0KToKKyAgICAgICAgKEpTQzo6 RlRMOjpPdXRwdXQ6OmJhc2VJbmRleCk6CisgICAgICAgIChKU0M6OkZUTDo6T3V0cHV0OjphYnNv bHV0ZSk6CisgICAgICAgIChKU0M6OkZUTDo6T3V0cHV0Ojpsb2FkOFNpZ25FeHQzMik6CisgICAg ICAgIChKU0M6OkZUTDo6T3V0cHV0Ojpsb2FkOFplcm9FeHQzMik6CisgICAgICAgIChKU0M6OkZU TDo6T3V0cHV0OjpsZXNzVGhhbk9yRXF1YWwpOgorICAgICAgICAoSlNDOjpGVEw6Ok91dHB1dDo6 ZmNtcCk6CisgICAgICAgIChKU0M6OkZUTDo6T3V0cHV0Ojpkb3VibGVFcXVhbCk6CisgICAgICAg IChKU0M6OkZUTDo6T3V0cHV0Ojpkb3VibGVOb3RFcXVhbE9yVW5vcmRlcmVkKToKKyAgICAgICAg KEpTQzo6RlRMOjpPdXRwdXQ6OmRvdWJsZUxlc3NUaGFuKToKKyAgICAgICAgKEpTQzo6RlRMOjpP dXRwdXQ6OmRvdWJsZUxlc3NUaGFuT3JFcXVhbCk6CisgICAgICAgIChKU0M6OkZUTDo6T3V0cHV0 Ojpkb3VibGVHcmVhdGVyVGhhbik6CisgICAgICAgIChKU0M6OkZUTDo6T3V0cHV0Ojpkb3VibGVH cmVhdGVyVGhhbk9yRXF1YWwpOgorICAgICAgICAoSlNDOjpGVEw6Ok91dHB1dDo6ZG91YmxlRXF1 YWxPclVub3JkZXJlZCk6CisgICAgICAgIChKU0M6OkZUTDo6T3V0cHV0Ojpkb3VibGVOb3RFcXVh bCk6CisgICAgICAgIChKU0M6OkZUTDo6T3V0cHV0Ojpkb3VibGVMZXNzVGhhbk9yVW5vcmRlcmVk KToKKyAgICAgICAgKEpTQzo6RlRMOjpPdXRwdXQ6OmRvdWJsZUxlc3NUaGFuT3JFcXVhbE9yVW5v cmRlcmVkKToKKyAgICAgICAgKEpTQzo6RlRMOjpPdXRwdXQ6OmRvdWJsZUdyZWF0ZXJUaGFuT3JV bm9yZGVyZWQpOgorICAgICAgICAoSlNDOjpGVEw6Ok91dHB1dDo6ZG91YmxlR3JlYXRlclRoYW5P ckVxdWFsT3JVbm9yZGVyZWQpOgorICAgICAgICAoSlNDOjpGVEw6Ok91dHB1dDo6aXNaZXJvMzIp OgorICAgICAgICAoSlNDOjpGVEw6Ok91dHB1dDo6bm90WmVybzMyKToKKwogMjAxNS0xMS0xOSAg RmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEZUTC0+QjMgbG93ZXJp bmcgc2hvdWxkIHN1cHBvcnQgY2hlY2tlZCBpbnQgbWF0aApJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdDb21tb24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR0NvbW1vbi5oCShyZXZpc2lvbiAxOTI2MzgpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR0NvbW1vbi5oCSh3b3JraW5nIGNvcHkpCkBAIC0zOCw3ICszOCw3IEBAIG5h bWVzcGFjZSBKU0MgeyBuYW1lc3BhY2UgREZHIHsKIC8vIFdlIGFyZSBpbiB0aGUgbWlkZGxlIG9m IGFuIGV4cGVyaW1lbnRhbCB0cmFuc2l0aW9uIGZyb20gTExWTSB0byBCMyBhcyB0aGUgYmFja2Vu ZCBmb3IgdGhlIEZUTC4gV2UgZG9uJ3QKIC8vIHlldCBrbm93IGhvdyBpdCB3aWxsIHR1cm4gb3V0 LiBGb3Igbm93LCB0aGlzIGZsYWcgd2lsbCBjb250cm9sIHdoZXRoZXIgRlRMIHVzZXMgQjMuIFJl bWVtYmVyIHRvIHNldCB0aGlzCiAvLyB0byAwIGJlZm9yZSBjb21taXR0aW5nIQotI2RlZmluZSBG VExfVVNFU19CMyAwCisjZGVmaW5lIEZUTF9VU0VTX0IzIDEKIAogc3RydWN0IE5vZGU7CiAKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQjNPdXRwdXQuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEIzT3V0cHV0LmgJKHJldmlzaW9uIDE5MjY0 OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQjNPdXRwdXQuaAkod29ya2luZyBj b3B5KQpAQCAtMTgxLDcgKzE4MSw3IEBAIHB1YmxpYzoKICAgICBMVmFsdWUgZnBUb0ludDMyKExW YWx1ZSB2YWx1ZSkgeyBDUkFTSCgpOyB9CiAgICAgTFZhbHVlIGZwVG9VSW50MzIoTFZhbHVlIHZh bHVlKSB7IENSQVNIKCk7IH0KICAgICBMVmFsdWUgaW50VG9GUChMVmFsdWUgdmFsdWUsIExUeXBl IHR5cGUpIHsgQ1JBU0goKTsgfQotICAgIExWYWx1ZSBpbnRUb0RvdWJsZShMVmFsdWUgdmFsdWUp IHsgQ1JBU0goKTsgfQorICAgIExWYWx1ZSBpbnRUb0RvdWJsZShMVmFsdWUgdmFsdWUpIHsgcmV0 dXJuIG1fYmxvY2stPmFwcGVuZE5ldzxCMzo6VmFsdWU+KG1fcHJvYywgQjM6OklUb0QsIG9yaWdp bigpLCB2YWx1ZSk7IH0KICAgICBMVmFsdWUgdW5zaWduZWRUb0ZQKExWYWx1ZSB2YWx1ZSwgTFR5 cGUgdHlwZSkgeyBDUkFTSCgpOyB9CiAgICAgTFZhbHVlIHVuc2lnbmVkVG9Eb3VibGUoTFZhbHVl IHZhbHVlKSB7IENSQVNIKCk7IH0KICAgICBMVmFsdWUgaW50Q2FzdChMVmFsdWUgdmFsdWUsIExU eXBlIHR5cGUpIHsgQ1JBU0goKTsgfQpAQCAtMjUwLDcgKzI1MCwxMCBAQCBwdWJsaWM6CiAgICAg VHlwZWRQb2ludGVyIGJhc2VJbmRleChjb25zdCBBYnN0cmFjdEhlYXAmIGhlYXAsIExWYWx1ZSBi YXNlLCBMVmFsdWUgaW5kZXgsIFNjYWxlIHNjYWxlLCBwdHJkaWZmX3Qgb2Zmc2V0ID0gMCkgeyBD UkFTSCgpOyB9CiAgICAgVHlwZWRQb2ludGVyIGJhc2VJbmRleChJbmRleGVkQWJzdHJhY3RIZWFw JiBoZWFwLCBMVmFsdWUgYmFzZSwgTFZhbHVlIGluZGV4LCBKU1ZhbHVlIGluZGV4QXNDb25zdGFu dCA9IEpTVmFsdWUoKSwgcHRyZGlmZl90IG9mZnNldCA9IDApIHsgQ1JBU0goKTsgfQogCi0gICAg VHlwZWRQb2ludGVyIGFic29sdXRlKHZvaWQqIGFkZHJlc3MpIHsgQ1JBU0goKTsgfQorICAgIFR5 cGVkUG9pbnRlciBhYnNvbHV0ZSh2b2lkKiBhZGRyZXNzKQorICAgIHsKKyAgICAgICAgcmV0dXJu IFR5cGVkUG9pbnRlcihtX2hlYXBzLT5hYnNvbHV0ZVthZGRyZXNzXSwgY29uc3RJbnRQdHIoYWRk cmVzcykpOworICAgIH0KIAogICAgIExWYWx1ZSBsb2FkOFNpZ25FeHQzMihMVmFsdWUgYmFzZSwg Y29uc3QgQWJzdHJhY3RGaWVsZCYgZmllbGQpIHsgQ1JBU0goKTsgfQogICAgIExWYWx1ZSBsb2Fk OFplcm9FeHQzMihMVmFsdWUgYmFzZSwgY29uc3QgQWJzdHJhY3RGaWVsZCYgZmllbGQpIHsgQ1JB U0goKTsgfQpAQCAtMjg1LDE4ICsyODgsNDIgQEAgcHVibGljOgogICAgIExWYWx1ZSBsZXNzVGhh bk9yRXF1YWwoTFZhbHVlIGxlZnQsIExWYWx1ZSByaWdodCkgeyBDUkFTSCgpOyB9CiAKICAgICBM VmFsdWUgZmNtcChMUmVhbFByZWRpY2F0ZSBjb25kLCBMVmFsdWUgbGVmdCwgTFZhbHVlIHJpZ2h0 KSB7IENSQVNIKCk7IH0KLSAgICBMVmFsdWUgZG91YmxlRXF1YWwoTFZhbHVlIGxlZnQsIExWYWx1 ZSByaWdodCkgeyBDUkFTSCgpOyB9Ci0gICAgTFZhbHVlIGRvdWJsZU5vdEVxdWFsT3JVbm9yZGVy ZWQoTFZhbHVlIGxlZnQsIExWYWx1ZSByaWdodCkgeyBDUkFTSCgpOyB9Ci0gICAgTFZhbHVlIGRv dWJsZUxlc3NUaGFuKExWYWx1ZSBsZWZ0LCBMVmFsdWUgcmlnaHQpIHsgQ1JBU0goKTsgfQotICAg IExWYWx1ZSBkb3VibGVMZXNzVGhhbk9yRXF1YWwoTFZhbHVlIGxlZnQsIExWYWx1ZSByaWdodCkg eyBDUkFTSCgpOyB9Ci0gICAgTFZhbHVlIGRvdWJsZUdyZWF0ZXJUaGFuKExWYWx1ZSBsZWZ0LCBM VmFsdWUgcmlnaHQpIHsgQ1JBU0goKTsgfQotICAgIExWYWx1ZSBkb3VibGVHcmVhdGVyVGhhbk9y RXF1YWwoTFZhbHVlIGxlZnQsIExWYWx1ZSByaWdodCkgeyBDUkFTSCgpOyB9CisgICAgTFZhbHVl IGRvdWJsZUVxdWFsKExWYWx1ZSBsZWZ0LCBMVmFsdWUgcmlnaHQpIHsgcmV0dXJuIG1fYmxvY2st PmFwcGVuZE5ldzxCMzo6VmFsdWU+KG1fcHJvYywgQjM6OkVxdWFsLCBvcmlnaW4oKSwgbGVmdCwg cmlnaHQpOyB9CisgICAgTFZhbHVlIGRvdWJsZU5vdEVxdWFsT3JVbm9yZGVyZWQoTFZhbHVlIGxl ZnQsIExWYWx1ZSByaWdodCkgeyByZXR1cm4gbV9ibG9jay0+YXBwZW5kTmV3PEIzOjpWYWx1ZT4o bV9wcm9jLCBCMzo6Tm90RXF1YWwsIG9yaWdpbigpLCBsZWZ0LCByaWdodCk7IH0KKyAgICBMVmFs dWUgZG91YmxlTGVzc1RoYW4oTFZhbHVlIGxlZnQsIExWYWx1ZSByaWdodCkgeyByZXR1cm4gbV9i bG9jay0+YXBwZW5kTmV3PEIzOjpWYWx1ZT4obV9wcm9jLCBCMzo6TGVzc1RoYW4sIG9yaWdpbigp LCBsZWZ0LCByaWdodCk7IH0KKyAgICBMVmFsdWUgZG91YmxlTGVzc1RoYW5PckVxdWFsKExWYWx1 ZSBsZWZ0LCBMVmFsdWUgcmlnaHQpIHsgcmV0dXJuIG1fYmxvY2stPmFwcGVuZE5ldzxCMzo6VmFs dWU+KG1fcHJvYywgQjM6Okxlc3NFcXVhbCwgb3JpZ2luKCksIGxlZnQsIHJpZ2h0KTsgfQorICAg IExWYWx1ZSBkb3VibGVHcmVhdGVyVGhhbihMVmFsdWUgbGVmdCwgTFZhbHVlIHJpZ2h0KSB7IHJl dHVybiBtX2Jsb2NrLT5hcHBlbmROZXc8QjM6OlZhbHVlPihtX3Byb2MsIEIzOjpHcmVhdGVyVGhh biwgb3JpZ2luKCksIGxlZnQsIHJpZ2h0KTsgfQorICAgIExWYWx1ZSBkb3VibGVHcmVhdGVyVGhh bk9yRXF1YWwoTFZhbHVlIGxlZnQsIExWYWx1ZSByaWdodCkgeyByZXR1cm4gbV9ibG9jay0+YXBw ZW5kTmV3PEIzOjpWYWx1ZT4obV9wcm9jLCBCMzo6R3JlYXRlckVxdWFsLCBvcmlnaW4oKSwgbGVm dCwgcmlnaHQpOyB9CiAgICAgTFZhbHVlIGRvdWJsZUVxdWFsT3JVbm9yZGVyZWQoTFZhbHVlIGxl ZnQsIExWYWx1ZSByaWdodCkgeyBDUkFTSCgpOyB9CiAgICAgTFZhbHVlIGRvdWJsZU5vdEVxdWFs KExWYWx1ZSBsZWZ0LCBMVmFsdWUgcmlnaHQpIHsgQ1JBU0goKTsgfQotICAgIExWYWx1ZSBkb3Vi bGVMZXNzVGhhbk9yVW5vcmRlcmVkKExWYWx1ZSBsZWZ0LCBMVmFsdWUgcmlnaHQpIHsgQ1JBU0go KTsgfQotICAgIExWYWx1ZSBkb3VibGVMZXNzVGhhbk9yRXF1YWxPclVub3JkZXJlZChMVmFsdWUg bGVmdCwgTFZhbHVlIHJpZ2h0KSB7IENSQVNIKCk7IH0KLSAgICBMVmFsdWUgZG91YmxlR3JlYXRl clRoYW5PclVub3JkZXJlZChMVmFsdWUgbGVmdCwgTFZhbHVlIHJpZ2h0KSB7IENSQVNIKCk7IH0K LSAgICBMVmFsdWUgZG91YmxlR3JlYXRlclRoYW5PckVxdWFsT3JVbm9yZGVyZWQoTFZhbHVlIGxl ZnQsIExWYWx1ZSByaWdodCkgeyBDUkFTSCgpOyB9CisgICAgTFZhbHVlIGRvdWJsZUxlc3NUaGFu T3JVbm9yZGVyZWQoTFZhbHVlIGxlZnQsIExWYWx1ZSByaWdodCkKKyAgICB7CisgICAgICAgIHJl dHVybiBtX2Jsb2NrLT5hcHBlbmROZXc8QjM6OlZhbHVlPigKKyAgICAgICAgICAgIG1fcHJvYywg QjM6OkVxdWFsLCBvcmlnaW4oKSwKKyAgICAgICAgICAgIG1fYmxvY2stPmFwcGVuZE5ldzxCMzo6 VmFsdWU+KG1fcHJvYywgQjM6OkdyZWF0ZXJFcXVhbCwgb3JpZ2luKCksIGxlZnQsIHJpZ2h0KSwK KyAgICAgICAgICAgIGludDMyWmVybyk7CisgICAgfQorICAgIExWYWx1ZSBkb3VibGVMZXNzVGhh bk9yRXF1YWxPclVub3JkZXJlZChMVmFsdWUgbGVmdCwgTFZhbHVlIHJpZ2h0KQorICAgIHsKKyAg ICAgICAgcmV0dXJuIG1fYmxvY2stPmFwcGVuZE5ldzxCMzo6VmFsdWU+KAorICAgICAgICAgICAg bV9wcm9jLCBCMzo6RXF1YWwsIG9yaWdpbigpLAorICAgICAgICAgICAgbV9ibG9jay0+YXBwZW5k TmV3PEIzOjpWYWx1ZT4obV9wcm9jLCBCMzo6R3JlYXRlclRoYW4sIG9yaWdpbigpLCBsZWZ0LCBy aWdodCksCisgICAgICAgICAgICBpbnQzMlplcm8pOworICAgIH0KKyAgICBMVmFsdWUgZG91Ymxl R3JlYXRlclRoYW5PclVub3JkZXJlZChMVmFsdWUgbGVmdCwgTFZhbHVlIHJpZ2h0KQorICAgIHsK KyAgICAgICAgcmV0dXJuIG1fYmxvY2stPmFwcGVuZE5ldzxCMzo6VmFsdWU+KAorICAgICAgICAg ICAgbV9wcm9jLCBCMzo6RXF1YWwsIG9yaWdpbigpLAorICAgICAgICAgICAgbV9ibG9jay0+YXBw ZW5kTmV3PEIzOjpWYWx1ZT4obV9wcm9jLCBCMzo6TGVzc0VxdWFsLCBvcmlnaW4oKSwgbGVmdCwg cmlnaHQpLAorICAgICAgICAgICAgaW50MzJaZXJvKTsKKyAgICB9CisgICAgTFZhbHVlIGRvdWJs ZUdyZWF0ZXJUaGFuT3JFcXVhbE9yVW5vcmRlcmVkKExWYWx1ZSBsZWZ0LCBMVmFsdWUgcmlnaHQp CisgICAgeworICAgICAgICByZXR1cm4gbV9ibG9jay0+YXBwZW5kTmV3PEIzOjpWYWx1ZT4oCisg ICAgICAgICAgICBtX3Byb2MsIEIzOjpFcXVhbCwgb3JpZ2luKCksCisgICAgICAgICAgICBtX2Js b2NrLT5hcHBlbmROZXc8QjM6OlZhbHVlPihtX3Byb2MsIEIzOjpMZXNzVGhhbiwgb3JpZ2luKCks IGxlZnQsIHJpZ2h0KSwKKyAgICAgICAgICAgIGludDMyWmVybyk7CisgICAgfQogCiAgICAgTFZh bHVlIGlzWmVybzMyKExWYWx1ZSB2YWx1ZSkgeyByZXR1cm4gbV9ibG9jay0+YXBwZW5kTmV3PEIz OjpWYWx1ZT4obV9wcm9jLCBCMzo6RXF1YWwsIG9yaWdpbigpLCB2YWx1ZSwgaW50MzJaZXJvKTsg fQogICAgIExWYWx1ZSBub3RaZXJvMzIoTFZhbHVlIHZhbHVlKSB7IHJldHVybiBtX2Jsb2NrLT5h cHBlbmROZXc8QjM6OlZhbHVlPihtX3Byb2MsIEIzOjpOb3RFcXVhbCwgb3JpZ2luKCksIHZhbHVl LCBpbnQzMlplcm8pOyB9Cg==