15143 2007-09-04 13:20:12 -0700 Crash seen on Windows 2007-09-13 11:18:50 -0700 1 1 1 Unclassified WebKit Frames 523.x (Safari 3) PC Windows XP RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 0 kuchhal webkit-unassigned andersca oldest_to_newest 930 0 kuchhal 2007-09-04 13:20:12 -0700 I came across this crash couple of times on Windows XP: 0x1017c440 [document.cpp] WebCore::Document::frame() 0x102d2746 [plugindocument.cpp] WebCore::PluginTokenizer::writeRawData(char const *,int) 0x101ac513 [frameloader.cpp ] WebCore::FrameLoader::write(char const *,int,bool) 0x101ac8e0 [frameloader.cpp] WebCore::FrameLoader::addData(char const *,int) ... 0x101cea30 [ documentloader.cpp] WebCore::DocumentLoader::commitLoad(char const *,int) 0x101ceac7 [documentloader.cpp] WebCore::DocumentLoader::receivedData(char const *,int) 0x10283928 [mainresourceloader.cpp] WebCore::MainResourceLoader::addData(char const *,int,bool) 0x102852c1 [resourceloader.cpp] WebCore::ResourceLoader::didReceiveData(char const *,int,__int64,bool) 0x10283ad7 [mainresourceloader.cpp] WebCore::MainResourceLoader::didReceiveData(char const *,int,__int64,bool) 0x1028516a [resourceloader.cpp] WebCore::ResourceLoader::didReceiveData(WebCore::ResourceHandle *,char const *,int,int) Its not easily reproducible but does happen occasionally. 927 1 16200 kuchhal 2007-09-04 13:43:45 -0700 Created attachment 16200 Patch for this bug 901 2 ddkilzer 2007-09-04 22:52:21 -0700 <rdar://problem/5461153> 530 3 16200 andersca 2007-09-13 11:15:26 -0700 Comment on attachment 16200 Patch for this bug The patch looks great and I'm about to commit it. A tip is to use the prepare-ChangeLog script when creating the ChangeLog, as this figures out the changes in the repository automatically. Finally, if you provide your full name I can add that to the change log. 531 4 andersca 2007-09-13 11:18:50 -0700 Committed revision 25540. 16200 2007-09-04 13:43:45 -0700 2007-09-13 11:15:26 -0700 Patch for this bug patch.txt text/plain 2018 kuchhal SW5kZXg6IENoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIENoYW5nZUxvZwkocmV2aXNpb24gMjUz NTUpCisrKyBDaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAwNy0w OS0wNCAga3VjaGhhbCAgPGt1Y2hoYWxAeWFob28uY29tPgorICAgICAgICBGaXggZm9yIGh0dHA6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTQzLiBUaGUgY29kZSBjaGVja3MK Kwlmb3IgdmFsaWQgZnJhbWUgb24gdGhlIG5leHQgbGluZSBidXQgbm90IHdoaWxlIGNhbGxpbmcg c2V0dGluZ3MoKQorCW1ldGhvZC4gTWFjIHZlcnNpb24gc2VlbXMgdG8gY2hlY2sgZm9yIHZhbGlk IGZyYW1lIGluCisJV2ViQ29yZUZyYW1lQnJpZGdlLm1tIGJ1dCBpdCBpcyBwcm9iYWJseSBzYWZl IHRvIGNoZWNrIGZvciB2YWxpZCBmcmFtZQorCWhlcmUgaW4gd3JpdGVSYXdEYXRhKCkgYmVmb3Jl IGNhbGxpbmcgc2V0dGluZ3MoKSBtZXRob2QuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlXGxvYWRlclxQbHVnaW5Eb2N1bWVudC5jcHAN OgorCiAyMDA3LTA3LTI5ICBCcmlhbiBNYXN0ZW5icm9vayAgPGJyaWFuQG1hc3RlbmJyb29rLm5l dD4KIAogICAgICAgICBCdWlsZCBmaXggZm9yIFdlYktpdC9HdGsgdG8gY29tcGlsZSBvbiBGZWRv cmEgNyBhcyBkZXNjcmliZWQgaW4KSW5kZXg6IFdlYkNvcmUvbG9hZGVyL1BsdWdpbkRvY3VtZW50 LmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQ0KLS0tIFdlYkNvcmUvbG9hZGVyL1BsdWdpbkRvY3VtZW50LmNwcAko cmV2aXNpb24gMjUzNTUpCisrKyBXZWJDb3JlL2xvYWRlci9QbHVnaW5Eb2N1bWVudC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTk3LDE1ICs5NywxNiBAQCBib29sIFBsdWdpblRva2VuaXplcjo6d3Jp dGVSYXdEYXRhKGNvbnN0CiAgICAgaWYgKCFtX2VtYmVkRWxlbWVudCkgewogICAgICAgICBjcmVh dGVEb2N1bWVudFN0cnVjdHVyZSgpOwogCi0gICAgICAgIEZyYW1lKiBmcmFtZSA9IG1fZG9jLT5m cmFtZSgpOwotICAgICAgICBTZXR0aW5ncyogc2V0dGluZ3MgPSBmcmFtZS0+c2V0dGluZ3MoKTsK LSAgICAgICAgaWYgKGZyYW1lICYmIHNldHRpbmdzICYmIHNldHRpbmdzLT5hcmVQbHVnaW5zRW5h YmxlZCgpKSB7Ci0gICAgICAgICAgICBtX2RvYy0+dXBkYXRlTGF5b3V0KCk7Ci0gICAgICAgICAg ICAKLSAgICAgICAgICAgIGlmIChSZW5kZXJXaWRnZXQqIHJlbmRlcmVyID0gc3RhdGljX2Nhc3Q8 UmVuZGVyV2lkZ2V0Kj4obV9lbWJlZEVsZW1lbnQtPnJlbmRlcmVyKCkpKQotICAgICAgICAgICAg ICAgIGZyYW1lLT5sb2FkZXIoKS0+Y2xpZW50KCktPnJlZGlyZWN0RGF0YVRvUGx1Z2luKHJlbmRl cmVyLT53aWRnZXQoKSk7Ci0gICAgICAgICAgICAKLSAgICAgICAgICAgIGZpbmlzaCgpOworICAg ICAgICBpZiAoRnJhbWUqIGZyYW1lID0gbV9kb2MtPmZyYW1lKCkpIHsKKyAgICAgICAgICAgIFNl dHRpbmdzKiBzZXR0aW5ncyA9IGZyYW1lLT5zZXR0aW5ncygpOworICAgICAgICAgICAgaWYgKHNl dHRpbmdzICYmIHNldHRpbmdzLT5hcmVQbHVnaW5zRW5hYmxlZCgpKSB7CisgICAgICAgICAgICAg ICAgbV9kb2MtPnVwZGF0ZUxheW91dCgpOworCisgICAgICAgICAgICAgICAgaWYgKFJlbmRlcldp ZGdldCogcmVuZGVyZXIgPSBzdGF0aWNfY2FzdDxSZW5kZXJXaWRnZXQqPihtX2VtYmVkRWxlbWVu dC0+cmVuZGVyZXIoKSkpCisgICAgICAgICAgICAgICAgICAgIGZyYW1lLT5sb2FkZXIoKS0+Y2xp ZW50KCktPnJlZGlyZWN0RGF0YVRvUGx1Z2luKHJlbmRlcmVyLT53aWRnZXQoKSk7CisKKyAgICAg ICAgICAgICAgICBmaW5pc2goKTsKKyAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgICAgICAK ICAgICAgICAgcmV0dXJuIGZhbHNlOwo=