151426 2015-11-18 18:06:00 -0800 A window with a hung tab waits 5s before becoming active 2015-11-20 15:11:02 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren andersca bdakin mitz sam oldest_to_newest 1143115 0 ggaren 2015-11-18 18:06:00 -0800 A window with a hung tab waits 5s before becoming active 1143116 1 265819 ggaren 2015-11-18 18:17:32 -0800 Created attachment 265819 Patch 1143342 2 265819 andersca 2015-11-19 10:58:46 -0800 Comment on attachment 265819 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265819&action=review > Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:1163 > + if (!mightBeginDragWhileInactive()) > return false; Should we check mightBeginScrollWhileInactive here too? 1143355 3 265819 ggaren 2015-11-19 11:28:13 -0800 Comment on attachment 265819 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265819&action=review >> Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:1163 >> return false; > > Should we check mightBeginScrollWhileInactive here too? According to TextEdit's behavior, a scrollbar scroll that begins while the window is inactive will activate the window. In other words, scrolls do not delay window ordering. So, there's no need to check mightBeginScrollWhileInactive here. 1143842 4 265819 ggaren 2015-11-20 15:10:59 -0800 Comment on attachment 265819 Patch Clearing flags on attachment: 265819 Committed r192703: <http://trac.webkit.org/changeset/192703> 1143843 5 ggaren 2015-11-20 15:11:02 -0800 All reviewed patches have been landed. Closing bug. 265819 2015-11-18 18:17:32 -0800 2015-11-20 15:10:59 -0800 Patch bug-151426-20151118181721.patch text/plain 5968 ggaren SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MjYwNCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQ0IEBACisyMDE1LTExLTE4ICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgQSB3aW5kb3cgd2l0aCBhIGh1 bmcgdGFiIHdhaXRzIDVzIGJlZm9yZSBiZWNvbWluZyBhY3RpdmUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTQyNgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBhbiBvcHRpbWl6 YXRpb24gdG8gc2tpcCB0aGUgc3luY2hyb25vdXMgd2ViIHByb2Nlc3MKKyAgICAgICAgbWVzc2Fn ZSB0byBjaGVjayBmb3IgYSBsZWdhY3kgc2Nyb2xsYmFyIHdoZW4gd2Uga25vdyB0aGF0IGxlZ2Fj eQorICAgICAgICBzY3JvbGxiYXJzIGFyZSBub3QgZW5hYmxlZC4KKworICAgICAgICAoTm90ZSB0 aGF0IGxlZ2FjeSBzY3JvbGxiYXJzIGRvbid0IHdvcmsgcXVpdGUgcmlnaHQsIGR1ZSB0bworICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMjM1ODU0MjA+IGFuZCA8cmRhcjovL3Byb2JsZW0vMjM2MDUy OTY+LiBTdGlsbCwgSSB2ZXJpZmllZAorICAgICAgICB3aXRoIGxvZ2dpbmcgdGhhdCB3ZSBkbyB0 aGUgc3luY2hyb25vdXMgbWVzc2FnZSB3aGVuIGxlZ2FjeSBzY3JvbGxiYXJzCisgICAgICAgIGFy ZSBlbmFibGVkLikKKworICAgICAgICBBIGNvbnNlcXVlbmNlIG9mIHRoaXMgY2hhbmdlIGlzIHRo YXQgd2Ugd2lsbCBubyBsb25nZXIgc3VwcG9ydAorICAgICAgICBjbGljay10by1zY3JvbGwtd2hp bGUtaW5hY3RpdmUgYmVoYXZpb3IgZm9yIHNjcm9sbGJhcnMgd2l0aCBjdXN0b20gbG9va3MKKyAg ICAgICAgb24gc3lzdGVtcyB3aXRoIG1vZGVybiBzY3JvbGxiYXJzLiBJIHNwb2tlIHdpdGggQmV0 aCBhbmQgRGFuLCBhbmQgdGhleQorICAgICAgICBhZ3JlZWQgdGhhdCB0aGlzIGlzIGEgcmVhc29u YWJsZSBjaGFuZ2UgdG8gbWFrZSwgc2luY2Ugd2UgZG9uJ3Qgc3VwcG9ydAorICAgICAgICBjbGlj ay10by1zY3JvbGwtd2hpbGUtaW5hY3RpdmUgYmVoYXZpb3IgZm9yIGZ1bGx5IGN1c3RvbSBzY3Jv bGxiYXJzIGVpdGhlciwKKyAgICAgICAgYW5kIHNpbmNlIHN5c3RlbXMgd2l0aCBtb2Rlcm4gc2Ny b2xsYmFycyB0eXBpY2FsbHkgdXNlIHN3aXBlIHRvIHNjcm9sbC4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5oOiBBZGRlZCBzb21lIGhlbHBlciBmdW5jdGlvbnMgdG8g ZXhwbGFpbgorICAgICAgICB0aGUgYmVoYXZpb3JzIHdlJ3JlIGNoZWNraW5nIGZvci4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbToKKyAgICAgICAgKFdlYktpdDo6 V2ViVmlld0ltcGw6Om1pZ2h0QmVnaW5EcmFnV2hpbGVJbmFjdGl2ZSk6IEZhY3RvcmVkIG91dCBm cm9tCisgICAgICAgIHNob3VsZERlbGF5V2luZG93T3JkZXJpbmdGb3JFdmVudC4KKworICAgICAg ICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6bWlnaHRCZWdpblNjcm9sbFdoaWxlSW5hY3RpdmUpOiBO ZXcgZnVuY3Rpb24uCisKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OmFjY2VwdHNGaXJz dE1vdXNlKTogTW92ZWQgdGhpcyBmdW5jdGlvbiBuZXh0IHRvCisgICAgICAgIHNob3VsZERlbGF5 V2luZG93T3JkZXJpbmdGb3JFdmVudCBiZWNhdXNlIHRoZWlyIHJlc3BvbnNpYmlsaXRpZXMgYXJl CisgICAgICAgIHZlcnkgc2ltaWxhci4gQWRkZWQgYSBmYXN0IHBhdGggY2hlY2sgZm9yIHdoZW4g d2Uga25vdyB0aGF0IHdlIHdpbGwKKyAgICAgICAgbm90IGFjY2VwdCBmaXJzdCBtb3VzZSBiZWNh dXNlIHdlIGNhbid0IHN0YXJ0IGEgZHJhZyBvciBzY3JvbGwgYnkKKyAgICAgICAgY2xpY2tpbmcg d2hpbGUgaW5hY3RpdmUuCisKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OnNob3VsZERl bGF5V2luZG93T3JkZXJpbmdGb3JFdmVudCk6IFJlZmFjdG9yZWQKKyAgICAgICAgdG8gdXNlIHRo ZSBoZWxwZXIgZnVuY3Rpb24uIEJlaGF2aW9yIHVuY2hhbmdlZC4KKwogMjAxNS0xMS0xOCAgQWxl eCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFByb2dy ZXNzIHRvd2FyZHMgaW1wbGVtZW50aW5nIERvd25sb2FkcyB3aXRoIE5FVFdPUktfU0VTU0lPTgpJ bmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLmgJKHJl dmlzaW9uIDE5MjU5OSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3 SW1wbC5oCSh3b3JraW5nIGNvcHkpCkBAIC01MDQsNiArNTA0LDkgQEAgcHJpdmF0ZToKICAgICB2 b2lkIG1vdXNlVXBJbnRlcm5hbChOU0V2ZW50ICopOwogICAgIHZvaWQgbW91c2VEcmFnZ2VkSW50 ZXJuYWwoTlNFdmVudCAqKTsKIAorICAgIGJvb2wgbWlnaHRCZWdpbkRyYWdXaGlsZUluYWN0aXZl KCk7CisgICAgYm9vbCBtaWdodEJlZ2luU2Nyb2xsV2hpbGVJbmFjdGl2ZSgpOworCiAgICAgTlNW aWV3IDxXZWJWaWV3SW1wbERlbGVnYXRlPiAqbV92aWV3OwogICAgIHN0ZDo6dW5pcXVlX3B0cjxQ YWdlQ2xpZW50PiBtX3BhZ2VDbGllbnQ7CiAgICAgUmVmPFdlYlBhZ2VQcm94eT4gbV9wYWdlOwpJ bmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQko cmV2aXNpb24gMTkyNTk5KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL1dlYlZp ZXdJbXBsLm1tCSh3b3JraW5nIGNvcHkpCkBAIC01NTUsMjIgKzU1NSw2IEBAIGJvb2wgV2ViVmll d0ltcGw6OmlzT3BhcXVlKCkgY29uc3QKICAgICByZXR1cm4gbV9wYWdlLT5kcmF3c0JhY2tncm91 bmQoKTsKIH0KIAotYm9vbCBXZWJWaWV3SW1wbDo6YWNjZXB0c0ZpcnN0TW91c2UoTlNFdmVudCAq ZXZlbnQpCi17Ci0gICAgLy8gVGhlcmUncyBhIGNoYW5jZSB0aGF0IHJlc3BvbmRpbmcgdG8gdGhp cyBldmVudCB3aWxsIHJ1biBhIG5lc3RlZCBldmVudCBsb29wLCBhbmQKLSAgICAvLyBmZXRjaGlu ZyBhIG5ldyBldmVudCBtaWdodCByZWxlYXNlIHRoZSBvbGQgb25lLiBSZXRhaW5pbmcgYW5kIHRo ZW4gYXV0b3JlbGVhc2luZwotICAgIC8vIHRoZSBjdXJyZW50IGV2ZW50IHByZXZlbnRzIHRoYXQg ZnJvbSBjYXVzaW5nIGEgcHJvYmxlbSBpbnNpZGUgV2ViS2l0IG9yIEFwcEtpdCBjb2RlLgotICAg IFtbZXZlbnQgcmV0YWluXSBhdXRvcmVsZWFzZV07Ci0KLSAgICBpZiAoIVttX3ZpZXcgaGl0VGVz dDpldmVudC5sb2NhdGlvbkluV2luZG93XSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotCi0gICAg c2V0TGFzdE1vdXNlRG93bkV2ZW50KGV2ZW50KTsKLSAgICBib29sIHJlc3VsdCA9IG1fcGFnZS0+ YWNjZXB0c0ZpcnN0TW91c2UoZXZlbnQuZXZlbnROdW1iZXIsIFdlYkV2ZW50RmFjdG9yeTo6Y3Jl YXRlV2ViTW91c2VFdmVudChldmVudCwgbV9sYXN0UHJlc3N1cmVFdmVudC5nZXQoKSwgbV92aWV3 KSk7Ci0gICAgc2V0TGFzdE1vdXNlRG93bkV2ZW50KG5pbCk7Ci0gICAgcmV0dXJuIHJlc3VsdDsK LX0KLQogYm9vbCBXZWJWaWV3SW1wbDo6YWNjZXB0c0ZpcnN0UmVzcG9uZGVyKCkKIHsKICAgICBy ZXR1cm4gdHJ1ZTsKQEAgLTExMzQsMTEgKzExMTgsNDggQEAgdm9pZCBXZWJWaWV3SW1wbDo6d2lu ZG93RGlkQ2hhbmdlT2NjbHVzaQogICAgIG1fcGFnZS0+dmlld1N0YXRlRGlkQ2hhbmdlKFdlYkNv cmU6OlZpZXdTdGF0ZTo6SXNWaXNpYmxlKTsKIH0KIAorYm9vbCBXZWJWaWV3SW1wbDo6bWlnaHRC ZWdpbkRyYWdXaGlsZUluYWN0aXZlKCkKK3sKKyAgICBpZiAobV92aWV3LndpbmRvdy5pc0tleVdp bmRvdykKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgaWYgKG1fcGFnZS0+ZWRpdG9yU3Rh dGUoKS5zZWxlY3Rpb25Jc05vbmUgfHwgIW1fcGFnZS0+ZWRpdG9yU3RhdGUoKS5zZWxlY3Rpb25J c1JhbmdlKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICByZXR1cm4gdHJ1ZTsKK30KKwor Ym9vbCBXZWJWaWV3SW1wbDo6bWlnaHRCZWdpblNjcm9sbFdoaWxlSW5hY3RpdmUoKQoreworICAg IC8vIExlZ2FjeSBzdHlsZSBzY3JvbGxiYXJzIGhhdmUgZGVzaWduIGRldGFpbHMgdGhhdCByZWx5 IG9uIHRyYWNraW5nIHRoZSBtb3VzZSBhbGwgdGhlIHRpbWUuCisgICAgaWYgKFdLUmVjb21tZW5k ZWRTY3JvbGxlclN0eWxlKCkgPT0gTlNTY3JvbGxlclN0eWxlTGVnYWN5KQorICAgICAgICByZXR1 cm4gdHJ1ZTsKKworICAgIHJldHVybiBmYWxzZTsKK30KKworYm9vbCBXZWJWaWV3SW1wbDo6YWNj ZXB0c0ZpcnN0TW91c2UoTlNFdmVudCAqZXZlbnQpCit7CisgICAgaWYgKCFtaWdodEJlZ2luRHJh Z1doaWxlSW5hY3RpdmUoKSAmJiAhbWlnaHRCZWdpblNjcm9sbFdoaWxlSW5hY3RpdmUoKSkKKyAg ICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgLy8gVGhlcmUncyBhIGNoYW5jZSB0aGF0IHJlc3Bv bmRpbmcgdG8gdGhpcyBldmVudCB3aWxsIHJ1biBhIG5lc3RlZCBldmVudCBsb29wLCBhbmQKKyAg ICAvLyBmZXRjaGluZyBhIG5ldyBldmVudCBtaWdodCByZWxlYXNlIHRoZSBvbGQgb25lLiBSZXRh aW5pbmcgYW5kIHRoZW4gYXV0b3JlbGVhc2luZworICAgIC8vIHRoZSBjdXJyZW50IGV2ZW50IHBy ZXZlbnRzIHRoYXQgZnJvbSBjYXVzaW5nIGEgcHJvYmxlbSBpbnNpZGUgV2ViS2l0IG9yIEFwcEtp dCBjb2RlLgorICAgIFtbZXZlbnQgcmV0YWluXSBhdXRvcmVsZWFzZV07CisKKyAgICBpZiAoIVtt X3ZpZXcgaGl0VGVzdDpldmVudC5sb2NhdGlvbkluV2luZG93XSkKKyAgICAgICAgcmV0dXJuIGZh bHNlOworCisgICAgc2V0TGFzdE1vdXNlRG93bkV2ZW50KGV2ZW50KTsKKyAgICBib29sIHJlc3Vs dCA9IG1fcGFnZS0+YWNjZXB0c0ZpcnN0TW91c2UoZXZlbnQuZXZlbnROdW1iZXIsIFdlYkV2ZW50 RmFjdG9yeTo6Y3JlYXRlV2ViTW91c2VFdmVudChldmVudCwgbV9sYXN0UHJlc3N1cmVFdmVudC5n ZXQoKSwgbV92aWV3KSk7CisgICAgc2V0TGFzdE1vdXNlRG93bkV2ZW50KG5pbCk7CisgICAgcmV0 dXJuIHJlc3VsdDsKK30KKwogYm9vbCBXZWJWaWV3SW1wbDo6c2hvdWxkRGVsYXlXaW5kb3dPcmRl cmluZ0ZvckV2ZW50KE5TRXZlbnQgKmV2ZW50KQogewotICAgIC8vIElmIHRoaXMgaXMgdGhlIGFj dGl2ZSB3aW5kb3cgb3Igd2UgZG9uJ3QgaGF2ZSBhIHJhbmdlIHNlbGVjdGlvbiwgdGhlcmUgaXMg bm8gbmVlZCB0byBwZXJmb3JtIGFkZGl0aW9uYWwgY2hlY2tzCi0gICAgLy8gYW5kIHdlIGNhbiBh dm9pZCBtYWtpbmcgYSBzeW5jaHJvbm91cyBjYWxsIHRvIHRoZSBXZWJQcm9jZXNzLgotICAgIGlm IChtX3ZpZXcud2luZG93LmlzS2V5V2luZG93IHx8IG1fcGFnZS0+ZWRpdG9yU3RhdGUoKS5zZWxl Y3Rpb25Jc05vbmUgfHwgIW1fcGFnZS0+ZWRpdG9yU3RhdGUoKS5zZWxlY3Rpb25Jc1JhbmdlKQor ICAgIGlmICghbWlnaHRCZWdpbkRyYWdXaGlsZUluYWN0aXZlKCkpCiAgICAgICAgIHJldHVybiBm YWxzZTsKIAogICAgIC8vIFRoZXJlJ3MgYSBjaGFuY2UgdGhhdCByZXNwb25kaW5nIHRvIHRoaXMg ZXZlbnQgd2lsbCBydW4gYSBuZXN0ZWQgZXZlbnQgbG9vcCwgYW5kCg==