151425 2015-11-18 17:07:29 -0800 build.webkit.org/dashboard: Move layoutTestResultsDirectoryURLForIteration implementation to base class 2015-11-19 09:42:42 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue dbates jmarcell lforschler thorton oldest_to_newest 1143097 0 ap 2015-11-18 17:07:29 -0800 Now that we have the information about branches stored separately, we don't need custom results URL building code for each buildbot instance. 1143098 1 265814 ap 2015-11-18 17:09:33 -0800 Created attachment 265814 proposed patch 1143312 2 265814 commit-queue 2015-11-19 09:42:38 -0800 Comment on attachment 265814 proposed patch Clearing flags on attachment: 265814 Committed r192630: <http://trac.webkit.org/changeset/192630> 1143313 3 commit-queue 2015-11-19 09:42:42 -0800 All reviewed patches have been landed. Closing bug. 265814 2015-11-18 17:09:33 -0800 2015-11-19 09:42:38 -0800 proposed patch MoveResultsDirectoryCode.txt text/plain 3166 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5MjYwMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE1LTExLTE4ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIGJ1aWxkLndlYmtpdC5vcmcvZGFzaGJvYXJkOiBNb3ZlIGxheW91dFRlc3RS ZXN1bHRzRGlyZWN0b3J5VVJMRm9ySXRlcmF0aW9uIGltcGxlbWVudGF0aW9uIHRvIGJhc2UgY2xh c3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTQy NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVp bGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJv YXJkL1NjcmlwdHMvQnVpbGRib3QuanM6CisgICAgICAgIChCdWlsZGJvdC5wcm90b3R5cGUubGF5 b3V0VGVzdFJlc3VsdHNEaXJlY3RvcnlVUkxGb3JJdGVyYXRpb24pOgorICAgICAgICAqIEJ1aWxk U2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2Fy ZC9TY3JpcHRzL1dlYktpdEJ1aWxkYm90LmpzOgorICAgICAgICAoV2ViS2l0QnVpbGRib3QucHJv dG90eXBlLmxheW91dFRlc3RSZXN1bHRzRGlyZWN0b3J5VVJMRm9ySXRlcmF0aW9uKTogRGVsZXRl ZC4KKwogMjAxNS0xMS0xOCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAog ICAgICAgICBbTWFjXSBTd2lwZSB0ZXN0cyBkZXBlbmQgb24gdXNlciBwcmVmZXJlbmNlcwpJbmRl eDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGlj X2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRib3QuanMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFz aGJvYXJkL1NjcmlwdHMvQnVpbGRib3QuanMJKHJldmlzaW9uIDE5MjU3OSkKKysrIFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hi b2FyZC9TY3JpcHRzL0J1aWxkYm90LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xNTEsNiArMTUxLDE5 IEBAIEJ1aWxkYm90LnByb3RvdHlwZSA9IHsKICAgICAgICAgcmV0dXJuIHRoaXMuYmFzZVVSTCAr ICJidWlsZGVycy8iICsgZW5jb2RlVVJJQ29tcG9uZW50KGl0ZXJhdGlvbi5xdWV1ZS5pZCkgKyAi L2J1aWxkcy8iICsgaXRlcmF0aW9uLmlkOwogICAgIH0sCiAKKyAgICBsYXlvdXRUZXN0UmVzdWx0 c0RpcmVjdG9yeVVSTEZvckl0ZXJhdGlvbjogZnVuY3Rpb24oaXRlcmF0aW9uKQorICAgIHsKKyAg ICAgICAgdmFyIHVuZGVyc2NvcmVTZXBhcmF0ZWRSZXZpc2lvbnMgPSAiciI7CisgICAgICAgIHNv cnREaWN0aW9uYXJpZXNCeU9yZGVyKERhc2hib2FyZC5SZXBvc2l0b3J5KS5mb3JFYWNoKGZ1bmN0 aW9uKHJlcG9zaXRvcnkpIHsKKyAgICAgICAgICAgIGlmIChpdGVyYXRpb24ucmV2aXNpb25bcmVw b3NpdG9yeS5uYW1lXSkgeworICAgICAgICAgICAgICAgIGlmICh1bmRlcnNjb3JlU2VwYXJhdGVk UmV2aXNpb25zLmxlbmd0aCA+IDEpCisgICAgICAgICAgICAgICAgICAgIHVuZGVyc2NvcmVTZXBh cmF0ZWRSZXZpc2lvbnMgKz0gIl8iOworICAgICAgICAgICAgICAgIHVuZGVyc2NvcmVTZXBhcmF0 ZWRSZXZpc2lvbnMgKz0gaXRlcmF0aW9uLnJldmlzaW9uW3JlcG9zaXRvcnkubmFtZV07CisgICAg ICAgICAgICB9CisgICAgICAgIH0pOworICAgICAgICByZXR1cm4gdGhpcy5iYXNlVVJMICsgInJl c3VsdHMvIiArIGVuY29kZVVSSUNvbXBvbmVudChpdGVyYXRpb24ucXVldWUuaWQpICsgIi8iICsg ZW5jb2RlVVJJQ29tcG9uZW50KHVuZGVyc2NvcmVTZXBhcmF0ZWRSZXZpc2lvbnMgKyAiICgiICsg aXRlcmF0aW9uLmlkICsgIikiKTsKKyAgICB9LAorCiAgICAgbGF5b3V0VGVzdFJlc3VsdHNVUkxG b3JJdGVyYXRpb246IGZ1bmN0aW9uKGl0ZXJhdGlvbikKICAgICB7CiAgICAgICAgIHJldHVybiB0 aGlzLmxheW91dFRlc3RSZXN1bHRzRGlyZWN0b3J5VVJMRm9ySXRlcmF0aW9uKGl0ZXJhdGlvbikg KyAiL3Jlc3VsdHMuaHRtbCI7CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9XZWJLaXRCdWls ZGJvdC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9XZWJLaXRCdWlsZGJv dC5qcwkocmV2aXNpb24gMTkyNTc5KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQu d2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvV2ViS2l0QnVp bGRib3QuanMJKHdvcmtpbmcgY29weSkKQEAgLTk3LDEwICs5Nyw1IEBAIFdlYktpdEJ1aWxkYm90 LnByb3RvdHlwZSA9IHsKICAgICBnZXQgZGVmYXVsdEJyYW5jaGVzKCkKICAgICB7CiAgICAgICAg IHJldHVybiBbeyByZXBvc2l0b3J5OiBEYXNoYm9hcmQuUmVwb3NpdG9yeS5PcGVuU291cmNlLCBu YW1lOiAidHJ1bmsiIH1dOwotICAgIH0sCi0KLSAgICBsYXlvdXRUZXN0UmVzdWx0c0RpcmVjdG9y eVVSTEZvckl0ZXJhdGlvbjogZnVuY3Rpb24oaXRlcmF0aW9uKQotICAgIHsKLSAgICAgICAgcmV0 dXJuIHRoaXMuYmFzZVVSTCArICJyZXN1bHRzLyIgKyBlbmNvZGVVUklDb21wb25lbnQoaXRlcmF0 aW9uLnF1ZXVlLmlkKSArICIvIiArIGVuY29kZVVSSUNvbXBvbmVudCgiciIgKyBpdGVyYXRpb24u cmV2aXNpb25bRGFzaGJvYXJkLlJlcG9zaXRvcnkuT3BlblNvdXJjZS5uYW1lXSArICIgKCIgKyBp dGVyYXRpb24uaWQgKyAiKSIpOwogICAgIH0KIH07Cg==