151411 2015-11-18 15:08:20 -0800 js/regress/script-tests/ftl-object-sub.js needs more iterations for benchmarking. 2015-11-19 15:16:36 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue oldest_to_newest 1143003 0 mark.lam 2015-11-18 15:08:20 -0800 Previously, in r192392, I reduced the test iteration count to make the layout test happy and not time out. Unfortunately, this defeats the use of this test for benchmarking. I've changed it to now use different iteration counts depending on who is running it. 1143004 1 265785 mark.lam 2015-11-18 15:11:00 -0800 Created attachment 265785 proposed patch. 1143005 2 265785 fpizlo 2015-11-18 15:12:29 -0800 Comment on attachment 265785 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=265785&action=review > LayoutTests/js/regress/script-tests/ftl-object-sub.js:33 > + // We're doing a benchmark run and need more iterations. > + iterations = 100000; > + expectedResult = 2000020; run-jsc-stress-tests will take this path, so you're not getting what you intended. 1143090 3 265810 mark.lam 2015-11-18 16:56:41 -0800 Created attachment 265810 patch 2: reworded comments, and change run config to runFTLNoCJIT only. 1143465 4 265810 mark.lam 2015-11-19 15:10:49 -0800 Comment on attachment 265810 patch 2: reworded comments, and change run config to runFTLNoCJIT only. Cancelling commit. Will land manually. 1143470 5 mark.lam 2015-11-19 15:16:36 -0800 Thanks for the review. Landed in r192663: <http://trac.webkit.org/r192663>. 265785 2015-11-18 15:11:00 -0800 2015-11-18 16:56:41 -0800 proposed patch. bug-151411.patch text/plain 1845 mark.lam SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE5MjU4OCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTExLTE4ICBNYXJrIExhbSAgPG1hcmsu bGFtQGFwcGxlLmNvbT4KKworICAgICAgICBqcy9yZWdyZXNzL3NjcmlwdC10ZXN0cy9mdGwtb2Jq ZWN0LXN1Yi5qcyBuZWVkcyBtb3JlIGl0ZXJhdGlvbnMgZm9yIGJlbmNobWFya2luZy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTQxMQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByZXZpb3VzbHksIGlu IHIxOTIzOTIsIEkgcmVkdWNlZCB0aGUgdGVzdCBpdGVyYXRpb24gY291bnQgdG8gbWFrZSB0aGUg bGF5b3V0CisgICAgICAgIHRlc3QgaGFwcHkgYW5kIG5vdCB0aW1lIG91dC4gIFVuZm9ydHVuYXRl bHksIHRoaXMgZGVmZWF0cyB0aGUgdXNlIG9mIHRoaXMgdGVzdAorICAgICAgICBmb3IgYmVuY2ht YXJraW5nLiAgSSd2ZSBjaGFuZ2VkIGl0IHRvIG5vdyB1c2UgZGlmZmVyZW50IGl0ZXJhdGlvbiBj b3VudHMKKyAgICAgICAgZGVwZW5kaW5nIG9uIHdobyBpcyBydW5uaW5nIGl0LgorCisgICAgICAg ICoganMvcmVncmVzcy9zY3JpcHQtdGVzdHMvZnRsLW9iamVjdC1zdWIuanM6CisKIDIwMTUtMTEt MTggIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZCwgc2tpcCBhZGRpdGlvbmFsIG1lZGlhc3RyZWFtIHRlc3RzIHRoYXQgY3Jhc2ggd2hl biBwYWludGluZyBhIG1vY2sgdmlkZW8gc291cmNlLgpJbmRleDogTGF5b3V0VGVzdHMvanMvcmVn cmVzcy9zY3JpcHQtdGVzdHMvZnRsLW9iamVjdC1zdWIuanMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvanMvcmVncmVzcy9zY3JpcHQtdGVzdHMvZnRsLW9iamVjdC1zdWIuanMJKHJldmlzaW9u IDE5MjU4OCkKKysrIExheW91dFRlc3RzL2pzL3JlZ3Jlc3Mvc2NyaXB0LXRlc3RzL2Z0bC1vYmpl Y3Qtc3ViLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0yMSwxMSArMjEsMjQgQEAgZnVuY3Rpb24gZm9v KGEsIGIpIHsKIH0KIG5vSW5saW5lKGZvbyk7CiAKLWZvciAodmFyIGkgPSAwOyBpIDw9IDEwMDAw OyBpKyspIHsKK3ZhciBpdGVyYXRpb25zOwordmFyIGV4cGVjdGVkUmVzdWx0OworaWYgKHRoaXMu d2luZG93KSB7CisgICAgLy8gV2UncmUgcnVubmluZyB0aGlzIGluIHRoZSBsYXlvdXQgdGVzdCBh bmQgZG9uJ3QgbmVlZCB0byBydW4gdG9vIGxvbmcuCisgICAgaXRlcmF0aW9ucyA9IDEwMDAwOwor ICAgIGV4cGVjdGVkUmVzdWx0ID0gMjAwMDIwOworfSBlbHNlIHsKKyAgICAvLyBXZSdyZSBkb2lu ZyBhIGJlbmNobWFyayBydW4gYW5kIG5lZWQgbW9yZSBpdGVyYXRpb25zLgorICAgIGl0ZXJhdGlv bnMgPSAxMDAwMDA7CisgICAgZXhwZWN0ZWRSZXN1bHQgPSAyMDAwMDIwOworfQorCisKK2ZvciAo dmFyIGkgPSAwOyBpIDw9IGl0ZXJhdGlvbnM7IGkrKykgewogICAgIG8xLmkgPSBpICsgMjsKICAg ICBvMi5pID0gaTsKICAgICByZXN1bHQgKz0gZm9vKG8xLCBvMik7CiB9CiAKLWlmIChyZXN1bHQg IT0gMjAwMDIwKQoraWYgKHJlc3VsdCAhPSBleHBlY3RlZFJlc3VsdCkKICAgICB0aHJvdyAiQmFk IHJlc3VsdDogIiArIHJlc3VsdDsK 265810 2015-11-18 16:56:41 -0800 2015-11-19 15:10:49 -0800 patch 2: reworded comments, and change run config to runFTLNoCJIT only. bug-151411.patch text/plain 2179 mark.lam SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE5MjU5MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE1LTExLTE4ICBNYXJrIExhbSAgPG1hcmsu bGFtQGFwcGxlLmNvbT4KKworICAgICAgICBqcy9yZWdyZXNzL3NjcmlwdC10ZXN0cy9mdGwtb2Jq ZWN0LXN1Yi5qcyBuZWVkcyBtb3JlIGl0ZXJhdGlvbnMgZm9yIGJlbmNobWFya2luZy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTQxMQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByZXZpb3VzbHksIGlu IHIxOTIzOTIsIEkgcmVkdWNlZCB0aGUgdGVzdCBpdGVyYXRpb24gY291bnQgdG8gbWFrZSB0aGUg bGF5b3V0CisgICAgICAgIHRlc3QgaGFwcHkgYW5kIG5vdCB0aW1lIG91dC4gIFVuZm9ydHVuYXRl bHksIHRoaXMgZGVmZWF0cyB0aGUgdXNlIG9mIHRoaXMgdGVzdAorICAgICAgICBmb3IgYmVuY2ht YXJraW5nLiAgSSd2ZSBjaGFuZ2VkIGl0IHRvIG5vdyB1c2UgZGlmZmVyZW50IGl0ZXJhdGlvbiBj b3VudHMKKyAgICAgICAgZGVwZW5kaW5nIG9uIHdobyBpcyBydW5uaW5nIGl0LiAgcnVuLWpzYy1z dHJlc3MtdGVzdHMgaXMgZmluZSB3aXRoIHRoZSBoaWdoZXIKKyAgICAgICAgaXRlcmF0aW9uIGNv dW50LgorCisgICAgICAgIFNpbmNlIHRoaXMgdGVzdCBpcyBzbG93IGFuZCBvbmx5IG1lYW50IHRv IHRlc3QgdGhlIEZUTCwgSSBhbHNvIGNoYW5nZWQgdGhlIHJ1bgorICAgICAgICBjb25maWd1cmF0 aW9uIHRvIGJlIHJ1bkZUTE5vQ0pJVCB0byBtaW5pbWl6ZSB0aGUgc2xvd25lc3MgaGl0IHdoZW4g cnVubmluZyBqc2MKKyAgICAgICAgc3RyZXNzIHRlc3RzLgorCisgICAgICAgICoganMvcmVncmVz cy9zY3JpcHQtdGVzdHMvZnRsLW9iamVjdC1zdWIuanM6CisKIDIwMTUtMTEtMTggIEpvc2VwaCBQ ZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBD bGllbnQgQmxvY2tlZCBSZXNvdXJjZSBSZXF1ZXN0cyBjYXVzZXMgQ3Jhc2ggdW5kZXIgSW5zcGVj dG9yUGFnZUFnZW50OjpjYWNoZWRSZXNvdXJjZQpJbmRleDogTGF5b3V0VGVzdHMvanMvcmVncmVz cy9zY3JpcHQtdGVzdHMvZnRsLW9iamVjdC1zdWIuanMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvanMvcmVncmVzcy9zY3JpcHQtdGVzdHMvZnRsLW9iamVjdC1zdWIuanMJKHJldmlzaW9uIDE5 MjU5MykKKysrIExheW91dFRlc3RzL2pzL3JlZ3Jlc3Mvc2NyaXB0LXRlc3RzL2Z0bC1vYmplY3Qt c3ViLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNCBAQAotLy9AIHJ1bkRlZmF1bHQKKy8v QCBydW5GVExOb0NKSVQKIHZhciBvMSA9IHsKICAgICBpOiAwLAogICAgIHZhbHVlT2Y6IGZ1bmN0 aW9uKCkgeyByZXR1cm4gdGhpcy5pOyB9CkBAIC0yMSwxMSArMjEsMjMgQEAgZnVuY3Rpb24gZm9v KGEsIGIpIHsKIH0KIG5vSW5saW5lKGZvbyk7CiAKLWZvciAodmFyIGkgPSAwOyBpIDw9IDEwMDAw OyBpKyspIHsKK3ZhciBpdGVyYXRpb25zOwordmFyIGV4cGVjdGVkUmVzdWx0OworaWYgKHRoaXMu d2luZG93KSB7CisgICAgLy8gVGhlIGxheW91dCB0ZXN0IGRvZXNuJ3QgbGlrZSB0b28gbWFueSBp dGVyYXRpb25zIGFuZCBtYXkgdGltZSBvdXQuCisgICAgaXRlcmF0aW9ucyA9IDEwMDAwOworICAg IGV4cGVjdGVkUmVzdWx0ID0gMjAwMDIwOworfSBlbHNlIHsKKyAgICBpdGVyYXRpb25zID0gMTAw MDAwOworICAgIGV4cGVjdGVkUmVzdWx0ID0gMjAwMDAyMDsKK30KKworCitmb3IgKHZhciBpID0g MDsgaSA8PSBpdGVyYXRpb25zOyBpKyspIHsKICAgICBvMS5pID0gaSArIDI7CiAgICAgbzIuaSA9 IGk7CiAgICAgcmVzdWx0ICs9IGZvbyhvMSwgbzIpOwogfQogCi1pZiAocmVzdWx0ICE9IDIwMDAy MCkKK2lmIChyZXN1bHQgIT0gZXhwZWN0ZWRSZXN1bHQpCiAgICAgdGhyb3cgIkJhZCByZXN1bHQ6 ICIgKyByZXN1bHQ7Cg==