151376 2015-11-17 18:00:28 -0800 run-webkit-tests should not truncate persistent lines 2015-11-17 22:27:33 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap commit-queue glenn koivisto lforschler oldest_to_newest 1142742 0 ap 2015-11-17 18:00:28 -0800 For whatever reason (or more precisely, to match ninja behavior), run-webkit-tests truncates its output, so that progress messages fit in one line. This is sort of OK for transient progress lines that get erased immediately, but not for what remains on the screen, especially for failures. rdar://problem/23162775 1142743 1 265725 ap 2015-11-17 18:08:30 -0800 Created attachment 265725 proposed fix 1142758 2 265725 koivisto 2015-11-17 21:27:52 -0800 Comment on attachment 265725 proposed fix Nice, thanks! 1142770 3 265725 commit-queue 2015-11-17 22:14:24 -0800 Comment on attachment 265725 proposed fix Rejecting attachment 265725 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 265725, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 151376. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.webkit.org/results/444229 1142771 4 ap 2015-11-17 22:27:33 -0800 Oops. Landed manually in http://trac.webkit.org/r192565 265725 2015-11-17 18:08:30 -0800 2015-11-17 22:14:24 -0800 proposed fix truncate.txt text/plain 3125 ap SW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3ZpZXdzL3ByaW50aW5n LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Zp ZXdzL3ByaW50aW5nLnB5CShyZXZpc2lvbiAxOTI0NDkpCisrKyBUb29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy92aWV3cy9wcmludGluZy5weQkod29ya2luZyBjb3B5KQpAQCAtMjg3 LDEwICsyODcsMTAgQEAgY2xhc3MgUHJpbnRlcihvYmplY3QpOgogICAgICAgICBzZWxmLl9wcmlu dF9xdWlldChzdW1tYXJ5KQogICAgICAgICBzZWxmLl9wcmludF9xdWlldCgiIikKIAotICAgIGRl ZiBfdGVzdF9zdGF0dXNfbGluZShzZWxmLCB0ZXN0X25hbWUsIHN1ZmZpeCk6CisgICAgZGVmIF90 ZXN0X3N0YXR1c19saW5lKHNlbGYsIHRlc3RfbmFtZSwgc3VmZml4LCB0cnVuY2F0ZT1UcnVlKToK ICAgICAgICAgZm9ybWF0X3N0cmluZyA9ICdbJWQvJWRdICVzJXMnCiAgICAgICAgIHN0YXR1c19s aW5lID0gZm9ybWF0X3N0cmluZyAlIChzZWxmLm51bV9zdGFydGVkLCBzZWxmLm51bV90ZXN0cywg dGVzdF9uYW1lLCBzdWZmaXgpCi0gICAgICAgIGlmIGxlbihzdGF0dXNfbGluZSkgPiBzZWxmLl9t ZXRlci5udW1iZXJfb2ZfY29sdW1ucygpOgorICAgICAgICBpZiB0cnVuY2F0ZSBhbmQgbGVuKHN0 YXR1c19saW5lKSA+IHNlbGYuX21ldGVyLm51bWJlcl9vZl9jb2x1bW5zKCk6CiAgICAgICAgICAg ICBvdmVyZmxvd19jb2x1bW5zID0gbGVuKHN0YXR1c19saW5lKSAtIHNlbGYuX21ldGVyLm51bWJl cl9vZl9jb2x1bW5zKCkKICAgICAgICAgICAgIGVsbGlwc2lzID0gJy4uLicKICAgICAgICAgICAg IGlmIGxlbih0ZXN0X25hbWUpIDwgb3ZlcmZsb3dfY29sdW1ucyArIGxlbihlbGxpcHNpcykgKyAy OgpAQCAtMzI0LDcgKzMyNCw3IEBAIGNsYXNzIFByaW50ZXIob2JqZWN0KToKICAgICAgICAgaWYg c2VsZi5fb3B0aW9ucy5kZXRhaWxzOgogICAgICAgICAgICAgc2VsZi5fcHJpbnRfdGVzdF90cmFj ZShyZXN1bHQsIGV4cF9zdHIsIGdvdF9zdHIpCiAgICAgICAgIGVsaWYgKHNlbGYuX29wdGlvbnMu dmVyYm9zZSBhbmQgbm90IHNlbGYuX29wdGlvbnMuZGVidWdfcnd0X2xvZ2dpbmcpIG9yIG5vdCBl eHBlY3RlZDoKLSAgICAgICAgICAgIHNlbGYud3JpdGVsbihzZWxmLl90ZXN0X3N0YXR1c19saW5l KHRlc3RfbmFtZSwgcmVzdWx0X21lc3NhZ2UpKQorICAgICAgICAgICAgc2VsZi53cml0ZWxuKHNl bGYuX3Rlc3Rfc3RhdHVzX2xpbmUodGVzdF9uYW1lLCByZXN1bHRfbWVzc2FnZSwgdHJ1bmNhdGU9 RmFsc2UpKQogICAgICAgICBlbGlmIHNlbGYubnVtX3N0YXJ0ZWQgPT0gc2VsZi5udW1fdGVzdHM6 CiAgICAgICAgICAgICBzZWxmLl9tZXRlci53cml0ZV91cGRhdGUoJycpCiAgICAgICAgIGVsc2U6 CkBAIC0zMzQsNyArMzM0LDcgQEAgY2xhc3MgUHJpbnRlcihvYmplY3QpOgogICAgICAgICAgICAg ICAgIHNlbGYuX2NvbXBsZXRlZF90ZXN0cy5hcHBlbmQoW3Rlc3RfbmFtZSwgcmVzdWx0X21lc3Nh Z2VdKQogCiAgICAgICAgICAgICBmb3IgdGVzdF9uYW1lLCByZXN1bHRfbWVzc2FnZSBpbiBzZWxm Ll9jb21wbGV0ZWRfdGVzdHM6Ci0gICAgICAgICAgICAgICAgc2VsZi5fbWV0ZXIud3JpdGVfdGhy b3R0bGVkX3VwZGF0ZShzZWxmLl90ZXN0X3N0YXR1c19saW5lKHRlc3RfbmFtZSwgcmVzdWx0X21l c3NhZ2UpKQorICAgICAgICAgICAgICAgIHNlbGYuX21ldGVyLndyaXRlX3Rocm90dGxlZF91cGRh dGUoc2VsZi5fdGVzdF9zdGF0dXNfbGluZSh0ZXN0X25hbWUsIHJlc3VsdF9tZXNzYWdlLCB0cnVu Y2F0ZT1GYWxzZSkpCiAgICAgICAgICAgICBzZWxmLl9jb21wbGV0ZWRfdGVzdHMgPSBbXQogICAg ICAgICBzZWxmLl9ydW5uaW5nX3Rlc3RzLnJlbW92ZSh0ZXN0X25hbWUpCiAKSW5kZXg6IFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3ZpZXdzL3ByaW50aW5nX3VuaXR0ZXN0LnB5 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3ZpZXdz L3ByaW50aW5nX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAxOTI0NDkpCisrKyBUb29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy92aWV3cy9wcmludGluZ191bml0dGVzdC5weQkod29ya2lu ZyBjb3B5KQpAQCAtMTUwLDYgKzE1MCwxMSBAQCBjbGFzcyAgVGVzdHByaW50ZXIodW5pdHRlc3Qu VGVzdENhc2UpOgogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKDgwLCBsZW4oYWN0dWFsKSkKICAg ICAgICAgc2VsZi5hc3NlcnRFcXVhbChhY3R1YWwsICdbMC8wXSBmYXN0L2RvbS9IVE1MRm9ybUVs ZW1lbnQvYXNzb2NpYS4uLmFmdGVyLWluZGV4LWFzc2VydGlvbi1mYWlsMS5odG1sIHBhc3NlZCcp CiAKKyAgICAgICAgcHJpbnRlci5fbWV0ZXIubnVtYmVyX29mX2NvbHVtbnMgPSBsYW1iZGE6IDgw CisgICAgICAgIGFjdHVhbCA9IHByaW50ZXIuX3Rlc3Rfc3RhdHVzX2xpbmUoJ2Zhc3QvZG9tL0hU TUxGb3JtRWxlbWVudC9hc3NvY2lhdGVkLWVsZW1lbnRzLWFmdGVyLWluZGV4LWFzc2VydGlvbi1m YWlsMS5odG1sJywgJyBwYXNzZWQnLCB0cnVuY2F0ZT1GYWxzZSkKKyAgICAgICAgc2VsZi5hc3Nl cnRFcXVhbCg5MCwgbGVuKGFjdHVhbCkpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoYWN0dWFs LCAnWzAvMF0gZmFzdC9kb20vSFRNTEZvcm1FbGVtZW50L2Fzc29jaWF0ZWQtZWxlbWVudHMtYWZ0 ZXItaW5kZXgtYXNzZXJ0aW9uLWZhaWwxLmh0bWwgcGFzc2VkJykKKwogICAgICAgICBwcmludGVy Ll9tZXRlci5udW1iZXJfb2ZfY29sdW1ucyA9IGxhbWJkYTogODkKICAgICAgICAgYWN0dWFsID0g cHJpbnRlci5fdGVzdF9zdGF0dXNfbGluZSgnZmFzdC9kb20vSFRNTEZvcm1FbGVtZW50L2Fzc29j aWF0ZWQtZWxlbWVudHMtYWZ0ZXItaW5kZXgtYXNzZXJ0aW9uLWZhaWwxLmh0bWwnLCAnIHBhc3Nl ZCcpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoODksIGxlbihhY3R1YWwpKQo=