151361 2015-11-17 14:38:56 -0800 Disable flattening the stage iframe of the graphics benchmark when running on iOS 2015-11-17 16:27:26 -0800 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sabouhallawa sabouhallawa cdumez commit-queue dino rniwa simon.fraser oldest_to_newest 1142668 0 sabouhallawa 2015-11-17 14:38:56 -0800 This was happening because the iframe's width and height not fixed. When animating the particles, the size of the stage gets changed. On iOS the iframe, by default, gets flattened if its contents go beyond the its boundaries. Also ensure the bouncing particles tests do not go outside the boundaries of the graphic benchmark stage. 1142673 1 265709 sabouhallawa 2015-11-17 14:44:50 -0800 Created attachment 265709 Patch 1142674 2 265709 simon.fraser 2015-11-17 14:47:42 -0800 Comment on attachment 265709 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265709&action=review > PerformanceTests/Animometer/runner/resources/animometer.css:359 > + section#running > #running-test > iframe { It's rare that you need both the element name and #id, since the #id should be enough. And is #running-test > iframe not sufficient? > PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-particles.js:64 > // If particle is going to move off right side > if (this._position.x + this._size.x > this._stageSize.x) { > - // If direction is East-South > + // If direction is East-South, go West-South. > if (this._angle >= 0 && this._angle < Math.PI / 2) > this._angle = Math.PI - this._angle; > - // If angle is East-North > + // If angle is East-North, go West-North. > else if (this._angle > Math.PI / 2 * 3) > this._angle = this._angle - (this._angle - Math.PI / 2 * 3) * 2; > + // Make sure the particle does not go outside the stage boundaries. > + this._position.x = this._stageSize.x - this._size.x; > } > > // If particle is going to move off left side > if (this._position.x < 0) { > - // If angle is West-South > + // If angle is West-South, go East-South. > if (this._angle > Math.PI / 2 && this._angle < Math.PI) > this._angle = Math.PI - this._angle; > - // If angle is West-North > + // If angle is West-North, go East-North. > else if (this._angle > Math.PI && this._angle < Math.PI / 2 * 3) > this._angle = this._angle + (Math.PI / 2 * 3 - this._angle) * 2; > + // Make sure the particle does not go outside the stage boundaries. > + this._position.x = 0; > } > > // If particle is going to move off bottom side > if (this._position.y + this._size.y > this._stageSize.y) { > - // If direction is South > + // If direction is South, go North. > if (this._angle > 0 && this._angle < Math.PI) > this._angle = Math.PI * 2 - this._angle; > + // Make sure the particle does not go outside the stage boundaries. > + this._position.y = this._stageSize.y - this._size.y; > } > > // If particle is going to move off top side > if (this._position.y < 0) { > - // If direction is North > + // If direction is North, go South. > if (this._angle > Math.PI && this._angle < Math.PI * 2) > this._angle = this._angle - (this._angle - Math.PI) * 2; > + // Make sure the particle does not go outside the stage boundaries. > + this._position.y = 0; > } Do you still need this bit? 1142704 3 sabouhallawa 2015-11-17 16:18:23 -0800 Committed r192550: <http://trac.webkit.org/changeset/192550> 1142709 4 265709 sabouhallawa 2015-11-17 16:27:26 -0800 Comment on attachment 265709 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265709&action=review >> PerformanceTests/Animometer/runner/resources/animometer.css:359 >> + section#running > #running-test > iframe { > > It's rare that you need both the element name and #id, since the #id should be enough. And is #running-test > iframe not sufficient? Yes either of the element name to its id is sufficient. And even #running-test > iframe is sufficient to select the iframe. But I found the css more readable when being very specific in writing the css selectors for in this stylesheet. For example, I can read the above line without returning to the HTML file like this: This css rule is for the <iframe> element which is inside a frame container whose id is #running-test which is inside a <section> element whose id is #running. I may not following the css best practices by doing that. So I will look for an example and file a bug to clean the animometer.css from this verbosity since the above rule is not the only which has this issue. >> PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-particles.js:64 >> } > > Do you still need this bit? No is not needed to disable the flattening but it makes the animation looks cleaner. So I kept it. 265709 2015-11-17 14:44:50 -0800 2015-11-17 14:47:42 -0800 Patch bug-151361-20151117144440.patch text/plain 4975 sabouhallawa SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxOTI1NDApCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE1LTExLTE3ICBT YWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgRGlz YWJsZSBmbGF0dGVuaW5nIHRoZSBzdGFnZSBpZnJhbWUgb2YgdGhlIGdyYXBoaWNzIGJlbmNobWFy ayB3aGVuIHJ1bm5pbmcgb24gaU9TCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTEzNjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKyAgICAgICAgCisgICAgICAgIFVzZSBmaXhlZCB3aWR0aCBmb3Igc3RhZ2UgaWZyYW1lIG9m IHRoZSBncmFwaGljcyBiZW5jaG1hcmsgdG8gZGlzYWJsZQorICAgICAgICBmbGF0dGVuaW5nIHRo ZSBpZnJhbWUgd2hpbGUgYW5pbWF0aW5nIHRoZSBwYXJ0aWNsZXMuIEFsc28gZW5zdXJlIHRoZQor ICAgICAgICBib3VuY2luZyBwYXJ0aWNsZXMgZG8gbm90IGdvIG91dHNpZGUgdGhlIGlmcmFtZSdz IGJvdW5kYXJpZXMuCisKKyAgICAgICAgKiBBbmltb21ldGVyL3J1bm5lci9yZXNvdXJjZXMvYW5p bW9tZXRlci5jc3M6CisgICAgICAgIChzZWN0aW9uI3J1bm5pbmcgPiAjcnVubmluZy10ZXN0ID4g aWZyYW1lKToKKyAgICAgICAgKEBtZWRpYSBzY3JlZW4gYW5kIChtaW4tZGV2aWNlLXdpZHRoOiAx ODAwcHgpKToKKyAgICAgICAgKiBBbmltb21ldGVyL3Rlc3RzL2JvdW5jaW5nLXBhcnRpY2xlcy9y ZXNvdXJjZXMvYm91bmNpbmctcGFydGljbGVzLmpzOgorICAgICAgICAoQm91bmNpbmdQYXJ0aWNs ZS5wcm90b3R5cGUuYW5pbWF0ZSk6CisKIDIwMTUtMTEtMTYgIFNhaWQgQWJvdS1IYWxsYXdhICA8 c2Fib3VoYWxsYXdhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgdGhlIG9wdGlvbiBmb3Ig YW5pbWF0aW5nIHVzaW5nIHNldEludGVydmFsIGZyb20gdGhlIGdyYXBoaWNzIGJlbmNobWFyawpJ bmRleDogUGVyZm9ybWFuY2VUZXN0cy9Bbmltb21ldGVyL3J1bm5lci9yZXNvdXJjZXMvYW5pbW9t ZXRlci5jc3MKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gUGVyZm9ybWFuY2VUZXN0cy9Bbmltb21ldGVyL3J1bm5l ci9yZXNvdXJjZXMvYW5pbW9tZXRlci5jc3MJKHJldmlzaW9uIDE5MjUxNikKKysrIFBlcmZvcm1h bmNlVGVzdHMvQW5pbW9tZXRlci9ydW5uZXIvcmVzb3VyY2VzL2FuaW1vbWV0ZXIuY3NzCSh3b3Jr aW5nIGNvcHkpCkBAIC0zMjEsOSArMzIxLDEwIEBAIHNlY3Rpb24jcnVubmluZyA+ICNydW5uaW5n LXRlc3QgewogfQogCiBzZWN0aW9uI3J1bm5pbmcgPiAjcnVubmluZy10ZXN0ID4gaWZyYW1lIHsK LSAgICB3aWR0aDogMTAwJTsKLSAgICBoZWlnaHQ6IDEwMCU7CisgICAgd2lkdGg6IDgwMHB4Owor ICAgIGhlaWdodDogNjAwcHg7CiAgICAgYm9yZGVyOiAwcHggbm9uZTsKKyAgICBvdmVyZmxvdzog aGlkZGVuOwogfQogCiBzZWN0aW9uI3J1bm5pbmcgPiAjcHJvZ3Jlc3MgewpAQCAtMzU0LDYgKzM1 NSwxMyBAQCBzZWN0aW9uI3J1bm5pbmcgPiAjcmVjb3JkIHsKICAgICBwYWRkaW5nOiAxNnB4Owog fQogCitAbWVkaWEgc2NyZWVuIGFuZCAobWluLWRldmljZS13aWR0aDogMTgwMHB4KSB7CisgICAg c2VjdGlvbiNydW5uaW5nID4gI3J1bm5pbmctdGVzdCA+IGlmcmFtZSB7CisgICAgICAgIHdpZHRo OiAxNjAwcHg7CisgICAgICAgIGhlaWdodDogODAwcHg7CisgICAgfQorfQorCiAvKiAtLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLSAqLwogLyogICAgICAgICAgICAgICAgICAgICAgICAgICBSZXN1bHRzIFNlY3Rp b24gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKi8KIC8qIC0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tICovCkluZGV4OiBQZXJmb3JtYW5jZVRlc3RzL0FuaW1vbWV0ZXIvdGVzdHMvYm91bmNpbmct cGFydGljbGVzL3Jlc291cmNlcy9ib3VuY2luZy1wYXJ0aWNsZXMuanMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g UGVyZm9ybWFuY2VUZXN0cy9Bbmltb21ldGVyL3Rlc3RzL2JvdW5jaW5nLXBhcnRpY2xlcy9yZXNv dXJjZXMvYm91bmNpbmctcGFydGljbGVzLmpzCShyZXZpc2lvbiAxOTI1MTYpCisrKyBQZXJmb3Jt YW5jZVRlc3RzL0FuaW1vbWV0ZXIvdGVzdHMvYm91bmNpbmctcGFydGljbGVzL3Jlc291cmNlcy9i b3VuY2luZy1wYXJ0aWNsZXMuanMJKHdvcmtpbmcgY29weSkKQEAgLTIzLDM2ICsyMyw0NCBAQCBC b3VuY2luZ1BhcnRpY2xlLnByb3RvdHlwZSA9CiAKICAgICAgICAgLy8gSWYgcGFydGljbGUgaXMg Z29pbmcgdG8gbW92ZSBvZmYgcmlnaHQgc2lkZQogICAgICAgICBpZiAodGhpcy5fcG9zaXRpb24u eCArIHRoaXMuX3NpemUueCA+IHRoaXMuX3N0YWdlU2l6ZS54KSB7Ci0gICAgICAgICAgICAvLyBJ ZiBkaXJlY3Rpb24gaXMgRWFzdC1Tb3V0aAorICAgICAgICAgICAgLy8gSWYgZGlyZWN0aW9uIGlz IEVhc3QtU291dGgsIGdvIFdlc3QtU291dGguCiAgICAgICAgICAgICBpZiAodGhpcy5fYW5nbGUg Pj0gMCAmJiB0aGlzLl9hbmdsZSA8IE1hdGguUEkgLyAyKQogICAgICAgICAgICAgICAgIHRoaXMu X2FuZ2xlID0gTWF0aC5QSSAtIHRoaXMuX2FuZ2xlOwotICAgICAgICAgICAgLy8gSWYgYW5nbGUg aXMgRWFzdC1Ob3J0aAorICAgICAgICAgICAgLy8gSWYgYW5nbGUgaXMgRWFzdC1Ob3J0aCwgZ28g V2VzdC1Ob3J0aC4KICAgICAgICAgICAgIGVsc2UgaWYgKHRoaXMuX2FuZ2xlID4gTWF0aC5QSSAv IDIgKiAzKQogICAgICAgICAgICAgICAgIHRoaXMuX2FuZ2xlID0gdGhpcy5fYW5nbGUgLSAodGhp cy5fYW5nbGUgLSBNYXRoLlBJIC8gMiAqIDMpICogMjsKKyAgICAgICAgICAgIC8vIE1ha2Ugc3Vy ZSB0aGUgcGFydGljbGUgZG9lcyBub3QgZ28gb3V0c2lkZSB0aGUgc3RhZ2UgYm91bmRhcmllcy4K KyAgICAgICAgICAgIHRoaXMuX3Bvc2l0aW9uLnggPSB0aGlzLl9zdGFnZVNpemUueCAtIHRoaXMu X3NpemUueDsKICAgICAgICAgfQogICAgICAgICAKICAgICAgICAgLy8gSWYgcGFydGljbGUgaXMg Z29pbmcgdG8gbW92ZSBvZmYgbGVmdCBzaWRlCiAgICAgICAgIGlmICh0aGlzLl9wb3NpdGlvbi54 IDwgMCkgewotICAgICAgICAgICAgLy8gSWYgYW5nbGUgaXMgV2VzdC1Tb3V0aAorICAgICAgICAg ICAgLy8gSWYgYW5nbGUgaXMgV2VzdC1Tb3V0aCwgZ28gRWFzdC1Tb3V0aC4KICAgICAgICAgICAg IGlmICh0aGlzLl9hbmdsZSA+IE1hdGguUEkgLyAyICYmIHRoaXMuX2FuZ2xlIDwgTWF0aC5QSSkK ICAgICAgICAgICAgICAgICB0aGlzLl9hbmdsZSA9IE1hdGguUEkgLSB0aGlzLl9hbmdsZTsKLSAg ICAgICAgICAgIC8vIElmIGFuZ2xlIGlzIFdlc3QtTm9ydGgKKyAgICAgICAgICAgIC8vIElmIGFu Z2xlIGlzIFdlc3QtTm9ydGgsIGdvIEVhc3QtTm9ydGguCiAgICAgICAgICAgICBlbHNlIGlmICh0 aGlzLl9hbmdsZSA+IE1hdGguUEkgJiYgdGhpcy5fYW5nbGUgPCBNYXRoLlBJIC8gMiAqIDMpCiAg ICAgICAgICAgICAgICAgdGhpcy5fYW5nbGUgPSB0aGlzLl9hbmdsZSArIChNYXRoLlBJIC8gMiAq IDMgLSB0aGlzLl9hbmdsZSkgKiAyOworICAgICAgICAgICAgLy8gTWFrZSBzdXJlIHRoZSBwYXJ0 aWNsZSBkb2VzIG5vdCBnbyBvdXRzaWRlIHRoZSBzdGFnZSBib3VuZGFyaWVzLgorICAgICAgICAg ICAgdGhpcy5fcG9zaXRpb24ueCA9IDA7CiAgICAgICAgIH0KIAogICAgICAgICAvLyBJZiBwYXJ0 aWNsZSBpcyBnb2luZyB0byBtb3ZlIG9mZiBib3R0b20gc2lkZQogICAgICAgICBpZiAodGhpcy5f cG9zaXRpb24ueSArIHRoaXMuX3NpemUueSA+IHRoaXMuX3N0YWdlU2l6ZS55KSB7Ci0gICAgICAg ICAgICAvLyBJZiBkaXJlY3Rpb24gaXMgU291dGgKKyAgICAgICAgICAgIC8vIElmIGRpcmVjdGlv biBpcyBTb3V0aCwgZ28gTm9ydGguCiAgICAgICAgICAgICBpZiAodGhpcy5fYW5nbGUgPiAwICYm IHRoaXMuX2FuZ2xlIDwgTWF0aC5QSSkKICAgICAgICAgICAgICAgICB0aGlzLl9hbmdsZSA9IE1h dGguUEkgKiAyIC0gdGhpcy5fYW5nbGU7CisgICAgICAgICAgICAvLyBNYWtlIHN1cmUgdGhlIHBh cnRpY2xlIGRvZXMgbm90IGdvIG91dHNpZGUgdGhlIHN0YWdlIGJvdW5kYXJpZXMuCisgICAgICAg ICAgICB0aGlzLl9wb3NpdGlvbi55ID0gdGhpcy5fc3RhZ2VTaXplLnkgLSB0aGlzLl9zaXplLnk7 CiAgICAgICAgIH0KIAogICAgICAgICAvLyBJZiBwYXJ0aWNsZSBpcyBnb2luZyB0byBtb3ZlIG9m ZiB0b3Agc2lkZQogICAgICAgICBpZiAodGhpcy5fcG9zaXRpb24ueSA8IDApIHsKLSAgICAgICAg ICAgIC8vIElmIGRpcmVjdGlvbiBpcyBOb3J0aAorICAgICAgICAgICAgLy8gSWYgZGlyZWN0aW9u IGlzIE5vcnRoLCBnbyBTb3V0aC4KICAgICAgICAgICAgIGlmICh0aGlzLl9hbmdsZSA+IE1hdGgu UEkgJiYgdGhpcy5fYW5nbGUgPCBNYXRoLlBJICogMikKICAgICAgICAgICAgICAgICB0aGlzLl9h bmdsZSA9IHRoaXMuX2FuZ2xlIC0gKHRoaXMuX2FuZ2xlIC0gTWF0aC5QSSkgKiAyOworICAgICAg ICAgICAgLy8gTWFrZSBzdXJlIHRoZSBwYXJ0aWNsZSBkb2VzIG5vdCBnbyBvdXRzaWRlIHRoZSBz dGFnZSBib3VuZGFyaWVzLgorICAgICAgICAgICAgdGhpcy5fcG9zaXRpb24ueSA9IDA7CiAgICAg ICAgIH0KICAgICB9CiB9Cg==