151351 2015-11-17 10:39:32 -0800 Reserved VM pool established in r187125 is likely too conservative 2015-11-17 13:38:20 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff commit-queue keith_miller mark.lam saam oldest_to_newest 1142551 0 msaboff 2015-11-17 10:39:32 -0800 In change set 187125, a 25% reserve of the VM allocation pool was established. The platform with smallest VM pool is 16MB and a reserve of 25% is 4MB. Given that the reserve is for "compile must succeed compilations", which are typically for OSR stub generation and other contingent code, this seems a little large. The proposal is to reduce the reserve from 25% to 15%. <rdar://problem/22910951> 1142554 1 265680 msaboff 2015-11-17 10:42:15 -0800 Created attachment 265680 Patch 1142555 2 265680 fpizlo 2015-11-17 10:43:59 -0800 Comment on attachment 265680 Patch I seem to recall 0.25 being necessary to fix a bug. 1142586 3 265688 msaboff 2015-11-17 11:51:52 -0800 Created attachment 265688 Updated patch After discussing this with Phil and Geoff, we think it would be safer to limit this change to ARM 32 bit only. 1142591 4 265688 fpizlo 2015-11-17 11:56:39 -0800 Comment on attachment 265688 Updated patch Nice. 1142592 5 265688 fpizlo 2015-11-17 11:57:23 -0800 Comment on attachment 265688 Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=265688&action=review > Source/JavaScriptCore/ChangeLog:8 > + Reduce the VM allocation reserved pool from 25% to 15% for ARM. I'd say "ARM32" in the changelog, to make sure that if someone reads this, they don't think you also reduced it for ARM64. 1142593 6 msaboff 2015-11-17 11:58:08 -0800 (In reply to comment #5) > Comment on attachment 265688 [details] > Updated patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=265688&action=review > > > Source/JavaScriptCore/ChangeLog:8 > > + Reduce the VM allocation reserved pool from 25% to 15% for ARM. > > I'd say "ARM32" in the changelog, to make sure that if someone reads this, > they don't think you also reduced it for ARM64. Will do. 1142606 7 265696 msaboff 2015-11-17 12:30:33 -0800 Created attachment 265696 Patch for landing Added feedback from prior reviewed patch. 1142633 8 265696 commit-queue 2015-11-17 13:30:05 -0800 Comment on attachment 265696 Patch for landing Clearing flags on attachment: 265696 Committed r192527: <http://trac.webkit.org/changeset/192527> 265680 2015-11-17 10:42:15 -0800 2015-11-17 11:51:52 -0800 Patch 151351.patch text/plain 1279 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkyNTE0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE1LTExLTE3ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFJlc2VydmVkIFZNIHBvb2wgZXN0YWJsaXNoZWQgaW4gcjE4NzEyNSBpcyBsaWtlbHkgdG9v IGNvbnNlcnZhdGl2ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTUxMzUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmVkdWNlIHRoZSBWTSBhbGxvY2F0aW9uIHJlc2VydmVkIHBvb2wgZnJvbSAyNSUgdG8g MTUlLgorCisgICAgICAgICogaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuaDoKKwogMjAxNS0xMS0x NiAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlND XSBNYWtlIEZUTE91dHB1dCdzIGxvYWQ4KCkgYW5kIGxvYWQxNigpIGNvbXBhdGlibGUgd2l0aCBC MwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2Nh dG9yLmgJKHJldmlzaW9uIDE5MjUxNCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhl Y3V0YWJsZUFsbG9jYXRvci5oCSh3b3JraW5nIGNvcHkpCkBAIC04Miw3ICs4Miw3IEBAIHN0YXRp YyBjb25zdCBzaXplX3QgZml4ZWRFeGVjdXRhYmxlTWVtb3IKICNlbHNlCiBzdGF0aWMgY29uc3Qg c2l6ZV90IGZpeGVkRXhlY3V0YWJsZU1lbW9yeVBvb2xTaXplID0gMzIgKiAxMDI0ICogMTAyNDsK ICNlbmRpZgotc3RhdGljIGNvbnN0IGRvdWJsZSBleGVjdXRhYmxlUG9vbFJlc2VydmF0aW9uRnJh Y3Rpb24gPSAwLjI1Oworc3RhdGljIGNvbnN0IGRvdWJsZSBleGVjdXRhYmxlUG9vbFJlc2VydmF0 aW9uRnJhY3Rpb24gPSAwLjE1OwogCiBleHRlcm4gdWludHB0cl90IHN0YXJ0T2ZGaXhlZEV4ZWN1 dGFibGVNZW1vcnlQb29sOwogI2VuZGlmCg== 265688 2015-11-17 11:51:52 -0800 2015-11-17 11:56:39 -0800 Updated patch 151351-2.patch text/plain 1317 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkyNTE0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE1LTExLTE3ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFJlc2VydmVkIFZNIHBvb2wgZXN0YWJsaXNoZWQgaW4gcjE4NzEyNSBpcyBsaWtlbHkgdG9v IGNvbnNlcnZhdGl2ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTUxMzUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmVkdWNlIHRoZSBWTSBhbGxvY2F0aW9uIHJlc2VydmVkIHBvb2wgZnJvbSAyNSUgdG8g MTUlIGZvciBBUk0uCisKKyAgICAgICAgKiBqaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oOgorCiAy MDE1LTExLTE2ICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFtKU0NdIE1ha2UgRlRMT3V0cHV0J3MgbG9hZDgoKSBhbmQgbG9hZDE2KCkgY29tcGF0aWJs ZSB3aXRoIEIzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxv Y2F0b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFi bGVBbGxvY2F0b3IuaAkocmV2aXNpb24gMTkyNTE0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTgyLDcgKzgyLDEx IEBAIHN0YXRpYyBjb25zdCBzaXplX3QgZml4ZWRFeGVjdXRhYmxlTWVtb3IKICNlbHNlCiBzdGF0 aWMgY29uc3Qgc2l6ZV90IGZpeGVkRXhlY3V0YWJsZU1lbW9yeVBvb2xTaXplID0gMzIgKiAxMDI0 ICogMTAyNDsKICNlbmRpZgorI2lmIENQVShBUk0pCitzdGF0aWMgY29uc3QgZG91YmxlIGV4ZWN1 dGFibGVQb29sUmVzZXJ2YXRpb25GcmFjdGlvbiA9IDAuMTU7CisjZWxzZQogc3RhdGljIGNvbnN0 IGRvdWJsZSBleGVjdXRhYmxlUG9vbFJlc2VydmF0aW9uRnJhY3Rpb24gPSAwLjI1OworI2VuZGlm CiAKIGV4dGVybiB1aW50cHRyX3Qgc3RhcnRPZkZpeGVkRXhlY3V0YWJsZU1lbW9yeVBvb2w7CiAj ZW5kaWYK 265696 2015-11-17 12:30:33 -0800 2015-11-17 13:30:05 -0800 Patch for landing 151351-3.patch text/plain 1282 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkyNTI0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE1LTExLTE3ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFJlc2VydmVkIFZNIHBvb2wgZXN0YWJsaXNoZWQgaW4gcjE4NzEyNSBpcyBsaWtlbHkgdG9v IGNvbnNlcnZhdGl2ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTUxMzUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRmlsaXAgUGl6bG8uCisKKyAgICAg ICAgUmVkdWNlIHRoZSBWTSBhbGxvY2F0aW9uIHJlc2VydmVkIHBvb2wgZnJvbSAyNSUgdG8gMTUl IGZvciBBUk0zMi4KKworICAgICAgICAqIGppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmg6CisKIDIw MTUtMTEtMTcgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0Nd IFN1cHBvcnQgRG91YmxlcyB3aXRoIEIzJ3MgTXVsLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmgJKHJldmlzaW9uIDE5MjUyNCkKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oCSh3b3JraW5n IGNvcHkpCkBAIC04Miw3ICs4MiwxMSBAQCBzdGF0aWMgY29uc3Qgc2l6ZV90IGZpeGVkRXhlY3V0 YWJsZU1lbW9yCiAjZWxzZQogc3RhdGljIGNvbnN0IHNpemVfdCBmaXhlZEV4ZWN1dGFibGVNZW1v cnlQb29sU2l6ZSA9IDMyICogMTAyNCAqIDEwMjQ7CiAjZW5kaWYKKyNpZiBDUFUoQVJNKQorc3Rh dGljIGNvbnN0IGRvdWJsZSBleGVjdXRhYmxlUG9vbFJlc2VydmF0aW9uRnJhY3Rpb24gPSAwLjE1 OworI2Vsc2UKIHN0YXRpYyBjb25zdCBkb3VibGUgZXhlY3V0YWJsZVBvb2xSZXNlcnZhdGlvbkZy YWN0aW9uID0gMC4yNTsKKyNlbmRpZgogCiBleHRlcm4gdWludHB0cl90IHN0YXJ0T2ZGaXhlZEV4 ZWN1dGFibGVNZW1vcnlQb29sOwogI2VuZGlmCg==