151349 2015-11-17 10:31:48 -0800 HTTP authentication dialog should focus on first input field 2017-05-10 07:46:47 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bitlord0xff csaavedra berto bugs-noreply buildbot cgarcia commit-queue csaavedra gustavo ialeksiev3 mcatanzaro oldest_to_newest 1142548 0 bitlord0xff 2015-11-17 10:31:48 -0800 This is example from my dsl router, every time I try to open its web interface it ask for authentication, but if you start typing nothing happens, you first need to click into text field to switch focus to it. On other browsers same dialog and first input field is in focus automatically. 1142550 1 mcatanzaro 2015-11-17 10:35:06 -0800 The request is just to focus the username field in the WebKitAuthenticationDialog by default. 1306826 2 309601 csaavedra 2017-05-10 07:15:50 -0700 Created attachment 309601 Patch 1306829 3 buildbot 2017-05-10 07:18:21 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1306840 4 309601 mcatanzaro 2017-05-10 07:32:00 -0700 Comment on attachment 309601 Patch OK. Since this is GTK+, I guess it's probably not possible to add a layout test for this... and it's very minor anyway. 1306847 5 309601 commit-queue 2017-05-10 07:46:45 -0700 Comment on attachment 309601 Patch Clearing flags on attachment: 309601 Committed r216584: <http://trac.webkit.org/changeset/216584> 1306848 6 commit-queue 2017-05-10 07:46:47 -0700 All reviewed patches have been landed. Closing bug. 309601 2017-05-10 07:15:50 -0700 2017-05-10 07:46:45 -0700 Patch bug-151349-20170510171549.patch text/plain 2050 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2NTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDM0YTAzZWZiOWYxMWIz NzNlYTdmYjUyNGM2MTNhYzMzOGE5NzUxOC4uYzBkZGZlMDg4MzM5OGQzMmJkOGI2MmYxMWUwM2Yy YzNkMGEyNzZhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA1LTEwICBDbGF1 ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gSFRU UCBhdXRoZW50aWNhdGlvbiBkaWFsb2cgc2hvdWxkIGZvY3VzIG9uIGZpcnN0IGlucHV0IGZpZWxk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTEzNDkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXR0aW5n IGZvY3VzIG9uIGEgd2lkZ2V0IGJlZm9yZSBpdCdzIG1hcHBlZCBkb2VzIG5vdGhpbmcuIE1vdmUK KyAgICAgICAgdGhlIGNhbGwgdG8gdGhlIHJpZ2h0IHBsYWNlLgorCisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0QXV0aGVudGljYXRpb25EaWFsb2cuY3BwOgorICAgICAgICAod2Vi a2l0QXV0aGVudGljYXRpb25EaWFsb2dJbml0aWFsaXplKToKKyAgICAgICAgKHdlYmtpdEF1dGhl bnRpY2F0aW9uRGlhbG9nTWFwKToKKwogMjAxNy0wNS0wOSAgRXJpYyBDYXJsc29uICA8ZXJpYy5j YXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWVkaWFTdHJlYW1dIGRldmljZUlkIGNvbnN0 cmFpbnQgZG9lc24ndCB3b3JrIHdpdGggZ2V0VXNlck1lZGlhCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRBdXRoZW50aWNhdGlvbkRpYWxvZy5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRBdXRoZW50aWNhdGlvbkRp YWxvZy5jcHAKaW5kZXggYWRhODA0MWUxMDFkNTE3NjBiNmM4YzRjZjcyZjFjNTZhNjc1NDY0Yy4u YjBiYjJiODU0MWM5ZTU2ZjM2YjRhYTQ3YzQ5NGEyMjAwYTIwMGJmOCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0QXV0aGVudGljYXRpb25EaWFsb2cu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEF1dGhlbnRp Y2F0aW9uRGlhbG9nLmNwcApAQCAtMTgzLDggKzE4Myw2IEBAIHN0YXRpYyB2b2lkIHdlYmtpdEF1 dGhlbnRpY2F0aW9uRGlhbG9nSW5pdGlhbGl6ZShXZWJLaXRBdXRoZW50aWNhdGlvbkRpYWxvZyog YXV0CiAgICAgICAgIGd0a190b2dnbGVfYnV0dG9uX3NldF9hY3RpdmUoR1RLX1RPR0dMRV9CVVRU T04ocHJpdi0+cmVtZW1iZXJDaGVja0J1dHRvbiksIFRSVUUpOwogICAgIH0KIAotICAgIGd0a193 aWRnZXRfZ3JhYl9mb2N1cyhwcml2LT5sb2dpbkVudHJ5KTsKLQogICAgIGd0a19ib3hfcGFja19z dGFydChHVEtfQk9YKHZCb3gpLCBhdXRoQm94LCBUUlVFLCBUUlVFLCAwKTsKICAgICBndGtfd2lk Z2V0X3Nob3coYXV0aEJveCk7CiAKQEAgLTIyNiw2ICsyMjQsNyBAQCBzdGF0aWMgZ2Jvb2xlYW4g d2Via2l0QXV0aGVudGljYXRpb25EaWFsb2dEcmF3KEd0a1dpZGdldCogd2lkZ2V0LCBjYWlyb190 KiBjcikKIHN0YXRpYyB2b2lkIHdlYmtpdEF1dGhlbnRpY2F0aW9uRGlhbG9nTWFwKEd0a1dpZGdl dCogd2lkZ2V0KQogewogICAgIFdlYktpdEF1dGhlbnRpY2F0aW9uRGlhbG9nUHJpdmF0ZSogcHJp diA9IFdFQktJVF9BVVRIRU5USUNBVElPTl9ESUFMT0cod2lkZ2V0KS0+cHJpdjsKKyAgICBndGtf d2lkZ2V0X2dyYWJfZm9jdXMocHJpdi0+bG9naW5FbnRyeSk7CiAgICAgZ3RrX3dpZGdldF9ncmFi X2RlZmF1bHQocHJpdi0+ZGVmYXVsdEJ1dHRvbik7CiAKICAgICBHVEtfV0lER0VUX0NMQVNTKHdl YmtpdF9hdXRoZW50aWNhdGlvbl9kaWFsb2dfcGFyZW50X2NsYXNzKS0+bWFwKHdpZGdldCk7Cg==