151347 2015-11-17 04:12:32 -0800 REGRESSION(r192459): [GTK] User agent string is broken after r192459 2015-11-17 23:48:16 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply darin gyuyoung.kim svillar zan oldest_to_newest 1142525 0 cgarcia 2015-11-17 04:12:32 -0800 This is our UA string after r192459: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/USER_AGENT_GTK_MAJOR_VERSION.USER_AGENT_GTK_MINOR_VERSION (KHTML, like Gecko) Version/8.0 Safari/USER_AGENT_GTK_MAJOR_VERSION.USER_AGENT_GTK_MINOR_VERSION 1142526 1 265673 cgarcia 2015-11-17 04:15:44 -0800 Created attachment 265673 Patch I think it's simpler to pass the values as strings. 1142775 2 cgarcia 2015-11-17 23:48:16 -0800 Committed r192566: <http://trac.webkit.org/changeset/192566> 265673 2015-11-17 04:15:44 -0800 2015-11-17 06:43:46 -0800 Patch wk2-ua-string.diff text/plain 2834 cgarcia ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA2ZWE1NzRhLi4wZTA1NDRm IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTUtMTEtMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgor CisgICAgICAgIFJFR1JFU1NJT04ocjE5MjQ1OSk6IFtHVEtdIFVzZXIgYWdlbnQgc3RyaW5nIGlz IGJyb2tlbiBhZnRlciByMTkyNDU5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTEzNDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBQYXNzIFVBIHZlcnNpb24gbnVtYmVycyBhcyBzdHJpbmdzIHRvIHRoZSBi dWlsZC4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlOgorCiAyMDE1 LTExLTE2ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgRml4IENNYWtlIGJ1aWxkIGFuZCBtYWtlIFBsdWdpblByb2Nlc3MgZXhlY3V0YWJsZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IDc2NDJlZjMuLjA0MTdlMGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBA QAorMjAxNS0xMS0xNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+ CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTkyNDU5KTogW0dUS10gVXNlciBhZ2VudCBzdHJpbmcg aXMgYnJva2VuIGFmdGVyIHIxOTI0NTkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE1MTM0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFJlbW92ZSB0aGUgaW5jb3JyZWN0IG1hY3JvIGFuZCBzaW1wbHkgdXNl IHRoZSBnaXZlbiB2YWx1ZXMKKyAgICAgICAgVVNFUl9BR0VOVF9HVEtfTUFKT1JfVkVSU0lPTiBh bmQgVVNFUl9BR0VOVF9HVEtfTUlOT1JfVkVSU0lPTiB0aGF0CisgICAgICAgIGFyZSBub3cgc3Ry aW5ncy4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6dmVyc2lvbkZvclVBU3RyaW5nKToKKyAgICAgICAgKFdlYkNvcmU6OmJ1aWxk VXNlckFnZW50U3RyaW5nKToKKwogMjAxNS0xMS0xNyAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2 aWxsYXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBBU1NFUlRJT04gRkFJTEVEOiBjb250ZW50U2l6 ZSA+PSAwIGluIFdlYkNvcmU6OlJlbmRlckZsZXhpYmxlQm94OjphZGp1c3RDaGlsZFNpemVGb3JN aW5BbmRNYXgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Vc2VyQWdl bnRHdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1VzZXJBZ2VudEd0ay5jcHAK aW5kZXggMTg1MGRkNS4uMDY4NWZjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3RrL1VzZXJBZ2VudEd0ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Rr L1VzZXJBZ2VudEd0ay5jcHAKQEAgLTExMyw5ICsxMTMsNyBAQCBzdGF0aWMgY29uc3QgU3RyaW5n IHBsYXRmb3JtVmVyc2lvbkZvclVBU3RyaW5nKCkKIAogc3RhdGljIGNvbnN0IGNoYXIqIHZlcnNp b25Gb3JVQVN0cmluZygpCiB7Ci0jZGVmaW5lIE1BS0VfVkVSU0lPTihtYWpvciwgbWlub3IpICNt YWpvciAiLiIgI21pbm9yCi0gICAgcmV0dXJuIE1BS0VfVkVSU0lPTihVU0VSX0FHRU5UX0dUS19N QUpPUl9WRVJTSU9OLCBVU0VSX0FHRU5UX0dUS19NSU5PUl9WRVJTSU9OKTsKLSN1bmRlZiBNQUtF X1ZFUlNJT04KKyAgICByZXR1cm4gVVNFUl9BR0VOVF9HVEtfTUFKT1JfVkVSU0lPTiAiLiIgVVNF Ul9BR0VOVF9HVEtfTUlOT1JfVkVSU0lPTjsKIH0KIAogc3RhdGljIFN0cmluZyBidWlsZFVzZXJB Z2VudFN0cmluZyhjb25zdCBVc2VyQWdlbnRRdWlya3MmIHF1aXJrcykKZGlmZiAtLWdpdCBhL1Nv dXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21h a2UKaW5kZXggOGY4NzA1ZS4uOTg2YWZmZiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlv bnNHVEsuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UKQEAgLTIxNSw4 ICsyMTUsOCBAQCBzZXQoRU5BQkxFX1BMVUdJTl9QUk9DRVNTICR7RU5BQkxFX1gxMV9UQVJHRVR9 KQogYWRkX2RlZmluaXRpb25zKC1EQlVJTERJTkdfR1RLX189MSkKIGFkZF9kZWZpbml0aW9ucygt REdFVFRFWFRfUEFDS0FHRT0iV2ViS2l0MkdUSy0ke1dFQktJVEdUS19BUElfVkVSU0lPTn0iKQog YWRkX2RlZmluaXRpb25zKC1EREFUQV9ESVI9IiR7Q01BS0VfSU5TVEFMTF9EQVRBRElSfSIpCi1h ZGRfZGVmaW5pdGlvbnMoLURVU0VSX0FHRU5UX0dUS19NQUpPUl9WRVJTSU9OPTYwMikKLWFkZF9k ZWZpbml0aW9ucygtRFVTRVJfQUdFTlRfR1RLX01JTk9SX1ZFUlNJT049MSkKK2FkZF9kZWZpbml0 aW9ucygtRFVTRVJfQUdFTlRfR1RLX01BSk9SX1ZFUlNJT049IjYwMiIpCithZGRfZGVmaW5pdGlv bnMoLURVU0VSX0FHRU5UX0dUS19NSU5PUl9WRVJTSU9OPSIxIikKIGFkZF9kZWZpbml0aW9ucygt RFdFQktJVEdUS19BUElfVkVSU0lPTl9TVFJJTkc9IiR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfSIp CiAKIHNldChHVEtfTElCUkFSSUVTICR7R1RLM19MSUJSQVJJRVN9KQo=