151342 2015-11-16 23:06:01 -0800 [JSC] Remove FTLOutput operations that act directly on floats 2015-12-09 20:15:51 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue fpizlo keith_miller mark.lam msaboff saam oldest_to_newest 1142482 0 benjamin 2015-11-16 23:06:01 -0800 [JSC] Remove FTLOutput operations that act directly on floats 1142483 1 265665 benjamin 2015-11-16 23:06:15 -0800 Created attachment 265665 Patch 1142651 2 265665 ggaren 2015-11-17 14:03:03 -0800 Comment on attachment 265665 Patch r=me 1142675 3 265665 commit-queue 2015-11-17 14:48:23 -0800 Comment on attachment 265665 Patch Clearing flags on attachment: 265665 Committed r192543: <http://trac.webkit.org/changeset/192543> 1142676 4 commit-queue 2015-11-17 14:48:26 -0800 All reviewed patches have been landed. Closing bug. 1148059 5 265665 fpizlo 2015-12-09 20:13:08 -0800 Comment on attachment 265665 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265665&action=review > Source/JavaScriptCore/ftl/FTLOutput.cpp:95 > + if (refType == refFloat) > + value = buildFPCast(m_builder, value, floatType); Is this really needed? 1148060 6 fpizlo 2015-12-09 20:15:51 -0800 Actually, seems like we should probably just roll this out now that B3 supports floats! 265665 2015-11-16 23:06:15 -0800 2015-11-17 14:48:23 -0800 Patch bug-151342-20151116230605.patch text/plain 5213 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 NmEwYjI3Yzg5N2NlNDgxNWM3NWExNmZhN2JhNDRiOWQyNjNjYTc3Li5iZGM1N2RjOGE5Yjk5ZGQx MjljZDI4MWJmNjkyZjliYTE3ZmM2NTZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMyBAQAogMjAxNS0xMS0xNiAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KIAorICAgICAgICBbSlNDXSBSZW1vdmUgRlRMT3V0cHV0IG9wZXJhdGlvbnMgdGhhdCBh Y3QgZGlyZWN0bHkgb24gZmxvYXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTEzNDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGZ0bC9GVExMb3dlckRGR1RvTExWTS5jcHA6CisgICAgICAgIChKU0M6 OkZUTDo6REZHOjpMb3dlckRGR1RvTExWTTo6Y29tcGlsZUFyaXRoRlJvdW5kKToKKyAgICAgICAg KEpTQzo6RlRMOjpERkc6Okxvd2VyREZHVG9MTFZNOjpjb21waWxlR2V0QnlWYWwpOgorICAgICAg ICAoSlNDOjpGVEw6OkRGRzo6TG93ZXJERkdUb0xMVk06OmNvbXBpbGVQdXRCeVZhbCk6CisgICAg ICAgICogZnRsL0ZUTE91dHB1dC5jcHA6CisgICAgICAgIChKU0M6OkZUTDo6T3V0cHV0OjpzdG9y ZSk6CisgICAgICAgICogZnRsL0ZUTE91dHB1dC5oOgorICAgICAgICAoSlNDOjpGVEw6Ok91dHB1 dDo6bG9hZEZsb2F0VG9Eb3VibGUpOgorICAgICAgICAoSlNDOjpGVEw6Ok91dHB1dDo6ZnJvdW5k KToKKyAgICAgICAgKEpTQzo6RlRMOjpPdXRwdXQ6OmxvYWRGbG9hdCk6IERlbGV0ZWQuCisKKzIw MTUtMTEtMTYgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CisKICAgICAg ICAgW0pTQ10gTWFrZSBGVExPdXRwdXQncyBsb2FkOCgpIGFuZCBsb2FkMTYoKSBjb21wYXRpYmxl IHdpdGggQjMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE1MTMzNgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2Vy REZHVG9MTFZNLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xM Vk0uY3BwCmluZGV4IDlmN2JiNDQxMGRlYWNhZDQ0ZWFiMjdiZDQ3M2E4YzgyMTAyZTBmYjAuLmJk NDJmNDNjNThlODIyMTJkYmViOGJiNWFiMDJjMWJlMzFiN2U4YzcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCkBAIC0yMDM1LDggKzIwMzUs NyBAQCBwcml2YXRlOgogICAgIAogICAgIHZvaWQgY29tcGlsZUFyaXRoRlJvdW5kKCkKICAgICB7 Ci0gICAgICAgIExWYWx1ZSBmbG9hdFZhbHVlID0gbV9vdXQuZnBDYXN0KGxvd0RvdWJsZShtX25v ZGUtPmNoaWxkMSgpKSwgbV9vdXQuZmxvYXRUeXBlKTsKLSAgICAgICAgc2V0RG91YmxlKG1fb3V0 LmZwQ2FzdChmbG9hdFZhbHVlLCBtX291dC5kb3VibGVUeXBlKSk7CisgICAgICAgIHNldERvdWJs ZShtX291dC5mcm91bmQobG93RG91YmxlKG1fbm9kZS0+Y2hpbGQxKCkpKSk7CiAgICAgfQogICAg IAogICAgIHZvaWQgY29tcGlsZUFyaXRoTmVnYXRlKCkKQEAgLTI3ODksNyArMjc4OCw3IEBAIHBy aXZhdGU6CiAgICAgICAgICAgICAgICAgTFZhbHVlIHJlc3VsdDsKICAgICAgICAgICAgICAgICBz d2l0Y2ggKHR5cGUpIHsKICAgICAgICAgICAgICAgICBjYXNlIFR5cGVGbG9hdDMyOgotICAgICAg ICAgICAgICAgICAgICByZXN1bHQgPSBtX291dC5mcENhc3QobV9vdXQubG9hZEZsb2F0KHBvaW50 ZXIpLCBtX291dC5kb3VibGVUeXBlKTsKKyAgICAgICAgICAgICAgICAgICAgcmVzdWx0ID0gbV9v dXQubG9hZEZsb2F0VG9Eb3VibGUocG9pbnRlcik7CiAgICAgICAgICAgICAgICAgICAgIGJyZWFr OwogICAgICAgICAgICAgICAgIGNhc2UgVHlwZUZsb2F0NjQ6CiAgICAgICAgICAgICAgICAgICAg IHJlc3VsdCA9IG1fb3V0LmxvYWREb3VibGUocG9pbnRlcik7CkBAIC0zMDYyLDcgKzMwNjEsNyBA QCBwcml2YXRlOgogICAgICAgICAgICAgICAgICAgICBMVmFsdWUgdmFsdWUgPSBsb3dEb3VibGUo Y2hpbGQzKTsKICAgICAgICAgICAgICAgICAgICAgc3dpdGNoICh0eXBlKSB7CiAgICAgICAgICAg ICAgICAgICAgIGNhc2UgVHlwZUZsb2F0MzI6Ci0gICAgICAgICAgICAgICAgICAgICAgICB2YWx1 ZVRvU3RvcmUgPSBtX291dC5mcENhc3QodmFsdWUsIG1fb3V0LmZsb2F0VHlwZSk7CisgICAgICAg ICAgICAgICAgICAgICAgICB2YWx1ZVRvU3RvcmUgPSB2YWx1ZTsKICAgICAgICAgICAgICAgICAg ICAgICAgIHJlZlR5cGUgPSBtX291dC5yZWZGbG9hdDsKICAgICAgICAgICAgICAgICAgICAgICAg IGJyZWFrOwogICAgICAgICAgICAgICAgICAgICBjYXNlIFR5cGVGbG9hdDY0OgpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExPdXRwdXQuY3BwIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2Z0bC9GVExPdXRwdXQuY3BwCmluZGV4IDMwZDVmYmQ1MDcxMzlkNDkyMTcwMWIx MTJjODg0Y2E5MjNkYTE0MzguLmFlNzk0MWE3NjljNmMzZTRlZDljMGQ1ODMyMzA2MTE2Y2U3ZGQw MDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMT3V0cHV0LmNwcAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTE91dHB1dC5jcHAKQEAgLTkxLDYgKzkx LDggQEAgTFZhbHVlIE91dHB1dDo6bG9hZChUeXBlZFBvaW50ZXIgcG9pbnRlciwgTFR5cGUgcmVm VHlwZSkKIAogdm9pZCBPdXRwdXQ6OnN0b3JlKExWYWx1ZSB2YWx1ZSwgVHlwZWRQb2ludGVyIHBv aW50ZXIsIExUeXBlIHJlZlR5cGUpCiB7CisgICAgaWYgKHJlZlR5cGUgPT0gcmVmRmxvYXQpCisg ICAgICAgIHZhbHVlID0gYnVpbGRGUENhc3QobV9idWlsZGVyLCB2YWx1ZSwgZmxvYXRUeXBlKTsK ICAgICBMVmFsdWUgcmVzdWx0ID0gc2V0KHZhbHVlLCBpbnRUb1B0cihwb2ludGVyLnZhbHVlKCks IHJlZlR5cGUpKTsKICAgICBwb2ludGVyLmhlYXAoKS5kZWNvcmF0ZUluc3RydWN0aW9uKHJlc3Vs dCwgKm1faGVhcHMpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9G VExPdXRwdXQuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMT3V0cHV0LmgKaW5kZXgg MDVjZjFkMjUyZGJhYWM4MjU1YjRkYWJmY2Y0MmQxNDIwMDBiNTZjOS4uNjgyMWE5NGRhY2I3N2Ew ZDU2MjhiYjExM2VkZTI0OWU4NWU1YzU3YyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2Z0bC9GVExPdXRwdXQuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTE91 dHB1dC5oCkBAIC0yMjQsNiArMjI0LDggQEAgcHVibGljOgogICAgIExWYWx1ZSBpbnRUb1B0cihM VmFsdWUgdmFsdWUsIExUeXBlIHR5cGUpIHsgcmV0dXJuIGJ1aWxkSW50VG9QdHIobV9idWlsZGVy LCB2YWx1ZSwgdHlwZSk7IH0KICAgICBMVmFsdWUgcHRyVG9JbnQoTFZhbHVlIHZhbHVlLCBMVHlw ZSB0eXBlKSB7IHJldHVybiBidWlsZFB0clRvSW50KG1fYnVpbGRlciwgdmFsdWUsIHR5cGUpOyB9 CiAgICAgTFZhbHVlIGJpdENhc3QoTFZhbHVlIHZhbHVlLCBMVHlwZSB0eXBlKSB7IHJldHVybiBi dWlsZEJpdENhc3QobV9idWlsZGVyLCB2YWx1ZSwgdHlwZSk7IH0KKworICAgIExWYWx1ZSBmcm91 bmQoTFZhbHVlIGRvdWJsZVZhbHVlKTsKICAgICAKICAgICAvLyBIaWxhcmlvdXNseSwgdGhlICNk ZWZpbmUgbWFjaGluZXJ5IGluIHRoZSBzdGRsaWIgbWVhbnMgdGhhdCB0aGlzIG1ldGhvZCBpcyBh Y3R1YWxseSBjYWxsZWQKICAgICAvLyBfX2J1aWx0aW5fYWxsb2NhLiBTbyBmYXIgdGhpcyBhcHBl YXJzIGJlbmlnbi4gOi18CkBAIC0yNDksNyArMjUxLDcgQEAgcHVibGljOgogICAgIExWYWx1ZSBs b2FkMzIoVHlwZWRQb2ludGVyIHBvaW50ZXIpIHsgcmV0dXJuIGxvYWQocG9pbnRlciwgcmVmMzIp OyB9CiAgICAgTFZhbHVlIGxvYWQ2NChUeXBlZFBvaW50ZXIgcG9pbnRlcikgeyByZXR1cm4gbG9h ZChwb2ludGVyLCByZWY2NCk7IH0KICAgICBMVmFsdWUgbG9hZFB0cihUeXBlZFBvaW50ZXIgcG9p bnRlcikgeyByZXR1cm4gbG9hZChwb2ludGVyLCByZWZQdHIpOyB9Ci0gICAgTFZhbHVlIGxvYWRG bG9hdChUeXBlZFBvaW50ZXIgcG9pbnRlcikgeyByZXR1cm4gbG9hZChwb2ludGVyLCByZWZGbG9h dCk7IH0KKyAgICBMVmFsdWUgbG9hZEZsb2F0VG9Eb3VibGUoVHlwZWRQb2ludGVyIHBvaW50ZXIp IHsgcmV0dXJuIGJ1aWxkRlBDYXN0KG1fYnVpbGRlciwgbG9hZChwb2ludGVyLCByZWZGbG9hdCks IGRvdWJsZVR5cGUpOyB9CiAgICAgTFZhbHVlIGxvYWREb3VibGUoVHlwZWRQb2ludGVyIHBvaW50 ZXIpIHsgcmV0dXJuIGxvYWQocG9pbnRlciwgcmVmRG91YmxlKTsgfQogICAgIHZvaWQgc3RvcmUx NihMVmFsdWUgdmFsdWUsIFR5cGVkUG9pbnRlciBwb2ludGVyKSB7IHN0b3JlKHZhbHVlLCBwb2lu dGVyLCByZWYxNik7IH0KICAgICB2b2lkIHN0b3JlMzIoTFZhbHVlIHZhbHVlLCBUeXBlZFBvaW50 ZXIgcG9pbnRlcikgeyBzdG9yZSh2YWx1ZSwgcG9pbnRlciwgcmVmMzIpOyB9CkBAIC00NjMsNiAr NDY1LDEyIEBAIGlubGluZSBMVmFsdWUgT3V0cHV0Ojpsb2FkMTZaZXJvRXh0MzIoVHlwZWRQb2lu dGVyIHBvaW50ZXIpCiAgICAgcmV0dXJuIHplcm9FeHQodmFsdWUxNiwgaW50MzIpOwogfQogCitp bmxpbmUgTFZhbHVlIE91dHB1dDo6ZnJvdW5kKExWYWx1ZSBkb3VibGVWYWx1ZSkKK3sKKyAgICBM VmFsdWUgZmxvYXRWYWx1ZSA9IGJ1aWxkRlBDYXN0KG1fYnVpbGRlciwgZG91YmxlVmFsdWUsIGZs b2F0VHlwZSk7CisgICAgcmV0dXJuIGJ1aWxkRlBDYXN0KG1fYnVpbGRlciwgZmxvYXRWYWx1ZSwg ZG91YmxlVHlwZSk7Cit9CisKICNkZWZpbmUgRlRMX05FV19CTE9DSyhvdXRwdXQsIG5hbWVBcmd1 bWVudHMpIFwKICAgICAoTElLRUxZKCF2ZXJib3NlQ29tcGlsYXRpb25FbmFibGVkKCkpIFwKICAg ICA/IChvdXRwdXQpLm5ld0Jsb2NrKCkgXAo=