151319 2015-11-16 12:18:15 -0800 A window with a hung tab waits 5s before closing 2015-11-17 13:32:04 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren andersca commit-queue sam oldest_to_newest 1142298 0 ggaren 2015-11-16 12:18:15 -0800 A window with a hung tab waits 5s before closing 1142312 1 265607 ggaren 2015-11-16 13:23:43 -0800 Created attachment 265607 Patch 1142366 2 265607 andersca 2015-11-16 15:45:41 -0800 Comment on attachment 265607 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265607&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:867 > + // Close without delay if the process allows it. Our goal is to terminate > + // the process, so we check a per-process status bit. > + if (m_process->isSuddenTerminationEnabled()) > + return true; Don't you also want to check that the process has one page? 1142451 3 ggaren 2015-11-16 19:32:08 -0800 > > Source/WebKit2/UIProcess/WebPageProxy.cpp:867 > > + // Close without delay if the process allows it. Our goal is to terminate > > + // the process, so we check a per-process status bit. > > + if (m_process->isSuddenTerminationEnabled()) > > + return true; > > Don't you also want to check that the process has one page? I don't think we need to. Returning true here just means that we skip the tryClose message and go straight to close. That should be safe even if there's another page in the process. (WKWebView always does this.) Skipping the tryClose message in a process with more than one page is a tiny optimization -- but I mostly did it because it is simpler this way. 1142631 4 265607 ggaren 2015-11-17 13:25:01 -0800 Comment on attachment 265607 Patch cq+ 1142635 5 265607 commit-queue 2015-11-17 13:32:01 -0800 Comment on attachment 265607 Patch Clearing flags on attachment: 265607 Committed r192528: <http://trac.webkit.org/changeset/192528> 1142636 6 commit-queue 2015-11-17 13:32:04 -0800 All reviewed patches have been landed. Closing bug. 265607 2015-11-16 13:23:43 -0800 2015-11-17 13:32:01 -0800 Patch bug-151319-20151116132333.patch text/plain 2205 ggaren SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MjQ3OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE1LTExLTE2ICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgQSB3aW5kb3cgd2l0aCBhIGh1 bmcgdGFiIHdhaXRzIDVzIGJlZm9yZSBjbG9zaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTEzMTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJIG1hbnVhbGx5IHRlc3RlZCB0aGF0IEkgZGlkIG5vdCBi cmVhayB1bmxvYWQgZXZlbnRzIHVwb24gd2luZG93IGNsb3NlCisgICAgICAgIGJ5IHJ1bm5pbmcg cnVuLXdlYmtpdC1odHRwZCBhbmQgaW52b2tpbmcgYSAxeDEgaW1hZ2UgbG9hZCBvZgorICAgICAg ICBodHRwOi8vMTI3LjAuMC4xOjgwMDAvbmF2aWdhdGlvbi9yZXNvdXJjZXMvc2F2ZS1QaW5nLnBo cCBmcm9tIGFuIHVubG9hZAorICAgICAgICBoYW5kbGVyLgorCisgICAgICAgICogVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6dHJ5Q2xv c2UpOiBVc2UgdGhlIHN1ZGRlbiB0ZXJtaW5hdGlvbiBiaXQgdG8KKyAgICAgICAgY2xvc2Ugd2l0 aG91dCB3YWl0aW5nIGZvciBhIHJlc3BvbnNlLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBy b2Nlc3NQcm94eS5oOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUHJveHk6OmlzU3VkZGVu VGVybWluYXRpb25FbmFibGVkKTogRXhwb3NlIHRoZSBiaXQuCisKIDIwMTUtMTEtMTYgIFNpbW9u IEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgU29ydCB0aGUgWGNv ZGUgcHJvamVjdCBmaWxlcy4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdl UHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdl UHJveHkuY3BwCShyZXZpc2lvbiAxOTI0NzUpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtODYxLDYgKzg2MSwxMSBAQCBib29s IFdlYlBhZ2VQcm94eTo6dHJ5Q2xvc2UoKQogICAgIGlmICghaXNWYWxpZCgpKQogICAgICAgICBy ZXR1cm4gdHJ1ZTsKIAorICAgIC8vIENsb3NlIHdpdGhvdXQgZGVsYXkgaWYgdGhlIHByb2Nlc3Mg YWxsb3dzIGl0LiBPdXIgZ29hbCBpcyB0byB0ZXJtaW5hdGUKKyAgICAvLyB0aGUgcHJvY2Vzcywg c28gd2UgY2hlY2sgYSBwZXItcHJvY2VzcyBzdGF0dXMgYml0LgorICAgIGlmIChtX3Byb2Nlc3Mt PmlzU3VkZGVuVGVybWluYXRpb25FbmFibGVkKCkpCisgICAgICAgIHJldHVybiB0cnVlOworCiAg ICAgbV9wcm9jZXNzLT5zZW5kKE1lc3NhZ2VzOjpXZWJQYWdlOjpUcnlDbG9zZSgpLCBtX3BhZ2VJ RCk7CiAgICAgbV9wcm9jZXNzLT5yZXNwb25zaXZlbmVzc1RpbWVyKCkuc3RhcnQoKTsKICAgICBy ZXR1cm4gZmFsc2U7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJvY2Vzc1By b3h5LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlByb2Nlc3NQ cm94eS5oCShyZXZpc2lvbiAxOTI0NzUpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vi UHJvY2Vzc1Byb3h5LmgJKHdvcmtpbmcgY29weSkKQEAgLTEzMSw2ICsxMzEsNyBAQCBwdWJsaWM6 CiAKICAgICB2b2lkIGVuYWJsZVN1ZGRlblRlcm1pbmF0aW9uKCk7CiAgICAgdm9pZCBkaXNhYmxl U3VkZGVuVGVybWluYXRpb24oKTsKKyAgICBib29sIGlzU3VkZGVuVGVybWluYXRpb25FbmFibGVk KCkgeyByZXR1cm4gIW1fbnVtYmVyT2ZUaW1lc1N1ZGRlblRlcm1pbmF0aW9uV2FzRGlzYWJsZWQ7 IH0KIAogICAgIHZvaWQgcmVxdWVzdFRlcm1pbmF0aW9uKCk7CiAK