151312 2015-11-16 10:39:06 -0800 Web Inspector: delete-by-word and similar shortcuts should add text to the WebCore kill ring 2015-11-30 10:35:27 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=151663 InRadar P2 Normal --- 151157 1 bburg bburg bburg commit-queue darin graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1142260 0 bburg 2015-11-16 10:39:06 -0800 Follow-up work for 151157 to address other uses of kill ring. 1143959 1 266030 bburg 2015-11-21 12:05:09 -0800 Created attachment 266030 Proposed Fix 1143960 2 webkit-bug-importer 2015-11-21 12:05:32 -0800 <rdar://problem/23642146> 1143961 3 webkit-bug-importer 2015-11-21 12:05:40 -0800 <rdar://problem/23642148> 1144793 4 266030 darin 2015-11-30 10:00:22 -0800 Comment on attachment 266030 Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=266030&action=review > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTextKillController.js:44 > + // FIXME: these keybindings match CodeMirror's default keymap for OS X. > + // They should probably be altered for Windows / Linux someday. Unfortunate to have to hard code these like this. Generally speaking, Safari and WebKit respect the OS X system-wide key bindings <https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/EventOverview/TextDefaultsBindings/TextDefaultsBindings.html>. 1144810 5 266030 commit-queue 2015-11-30 10:27:08 -0800 Comment on attachment 266030 Proposed Fix Clearing flags on attachment: 266030 Committed r192804: <http://trac.webkit.org/changeset/192804> 1144812 6 commit-queue 2015-11-30 10:27:13 -0800 All reviewed patches have been landed. Closing bug. 1144814 7 bburg 2015-11-30 10:29:49 -0800 (In reply to comment #4) > Comment on attachment 266030 [details] > Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=266030&action=review > > > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTextKillController.js:44 > > + // FIXME: these keybindings match CodeMirror's default keymap for OS X. > > + // They should probably be altered for Windows / Linux someday. > > Unfortunate to have to hard code these like this. Generally speaking, Safari > and WebKit respect the OS X system-wide key bindings > <https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/ > EventOverview/TextDefaultsBindings/TextDefaultsBindings.html>. Wow, I had no idea that this exists! I'll file a bug to see if we can integrate it. 266030 2015-11-21 12:05:09 -0800 2015-11-30 10:27:08 -0800 Proposed Fix bug-151312-20151121120455.patch text/plain 6164 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAw ZTYyY2QzNjIzM2MyMzE4MmJiMTRkZTZlMDcyZTExMWM0MjcyNmFmLi4zODUyMTIxYTZlYjU0NmEw ZGQ1NWQ5YWMzMjYxNzk2MzY2ODk0MWM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyOCBAQAorMjAxNS0xMS0yMSAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBkZWxldGUtYnktd29yZCBhbmQgc2ltaWxhciBzaG9ydGN1 dHMgc2hvdWxkIGFkZCB0ZXh0IHRvIHRoZSBXZWJDb3JlIGtpbGwgcmluZworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxMzEyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIG90aGVy IGtpbGwgcmluZy1lbGlnaWJsZSBrZXliaW5kaW5zZywgc3VjaCBhcworICAgICAgICBkZWxldGlu ZyBieSB3b3JkLCBncm91cCwgb3IgbGluZSBmb3J3YXJkcyBhbmQgYmFja3dhcmRzLgorCisgICAg ICAgICogVXNlckludGVyZmFjZS9Db250cm9sbGVycy9Db2RlTWlycm9yVGV4dEtpbGxDb250cm9s bGVyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0S2lsbENvbnRyb2xs ZXIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0S2lsbENvbnRyb2xsZXIu cHJvdG90eXBlLl9oYW5kbGVUZXh0S2lsbENvbW1hbmQpOiBSZW5hbWVkIGZyb20gX2hhbmRsZUtp bGxMaW5lLgorCisgICAgICAgICAgICBQYXJhbWV0ZXJpemUgdGhlIGZ1bmN0aW9uIHNvIGl0IGNh biBoYW5kbGUgYW55IGtleWJpbmRpbmcgYW5kCisgICAgICAgICAgICBjb21tYW5kLiBUYWtlIGEg a2lsbCByaW5nIGluc2VydGlvbiBtb2RlIGFyZ3VtZW50LCB0b28uCisKKyAgICAgICAgKFdlYklu c3BlY3Rvci5Db2RlTWlycm9yVGV4dEtpbGxDb250cm9sbGVyLnByb3RvdHlwZS5faGFuZGxlVGV4 dENoYW5nZSk6CisKKyAgICAgICAgICAgIEFkZCBzb21lIHNwZWNpYWwgY2FzaW5nIGZvciBjaGFu Z2VzIHJlY2VpdmVkIGZyb20gRGVsZXRlIExpbmUKKyAgICAgICAgICAgIChDbWQtRCkgc28gdGhl IHJpZ2h0IHRleHQgaXMgYWRkZWQgdG8gdGhlIGtpbGwgcmluZy4gVGhyZWFkIHRoZQorICAgICAg ICAgICAga2lsbCByaW5nIGluc2VydGlvbiBtb2RlIHRvIHRoZSBmcm9udGVuZCBob3N0IGNhbGwu CisKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db2RlTWlycm9yVGV4dEtpbGxDb250cm9sbGVyLnBy b3RvdHlwZS5faGFuZGxlS2lsbExpbmUpOiBEZWxldGVkLgorCiAyMDE1LTExLTIwICBKb3NlcGgg UGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog VGltZWxpbmUgZG9lcyBub3QgaW1tZWRpYXRlbHkgdXBkYXRlIGN1cnJlbnQgdGltZSBhZnRlciBz d2l0Y2hpbmcgdGFicyB3aGlsZSByZWNvcmRpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JUZXh0S2lsbENvbnRy b2xsZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVy cy9Db2RlTWlycm9yVGV4dEtpbGxDb250cm9sbGVyLmpzCmluZGV4IDY2ZTc2MTQ5MmI2OGIxNzBi ZTQwZjFjNGNlYzUyOTQ5NDljZWMxNDkuLmU0NTM2MzFiYjY1YjA2M2RhNGM5YjJiNmMyYzY4MGNk ODcxZGYxNTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JUZXh0S2lsbENvbnRyb2xsZXIuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ29kZU1pcnJvclRleHRL aWxsQ29udHJvbGxlci5qcwpAQCAtMzQsMzAgKzM0LDQ0IEBAIFdlYkluc3BlY3Rvci5Db2RlTWly cm9yVGV4dEtpbGxDb250cm9sbGVyID0gY2xhc3MgQ29kZU1pcnJvclRleHRLaWxsQ29udHJvbGxl ciBlCiAgICAgICAgIHRoaXMuX2NvZGVNaXJyb3IgPSBjb2RlTWlycm9yOwogICAgICAgICB0aGlz Ll9leHBlY3RpbmdDaGFuZ2VFdmVudEZvcktpbGwgPSBmYWxzZTsKICAgICAgICAgdGhpcy5fbmV4 dEtpbGxTdGFydHNOZXdTZXF1ZW5jZSA9IHRydWU7CisgICAgICAgIHRoaXMuX3Nob3VsZFByZXBl bmRUb0tpbGxSaW5nID0gZmFsc2U7CiAKICAgICAgICAgdGhpcy5faGFuZGxlVGV4dENoYW5nZUxp c3RlbmVyID0gdGhpcy5faGFuZGxlVGV4dENoYW5nZS5iaW5kKHRoaXMpOwogICAgICAgICB0aGlz Ll9oYW5kbGVFZGl0b3JCbHVyTGlzdGVuZXIgPSB0aGlzLl9oYW5kbGVFZGl0b3JCbHVyLmJpbmQo dGhpcyk7CiAgICAgICAgIHRoaXMuX2hhbmRsZVNlbGVjdGlvbk9yQ2FyZXRDaGFuZ2VMaXN0ZW5l ciA9IHRoaXMuX2hhbmRsZVNlbGVjdGlvbk9yQ2FyZXRDaGFuZ2UuYmluZCh0aGlzKTsKIAorICAg ICAgICAvLyBGSVhNRTogdGhlc2Uga2V5YmluZGluZ3MgbWF0Y2ggQ29kZU1pcnJvcidzIGRlZmF1 bHQga2V5bWFwIGZvciBPUyBYLgorICAgICAgICAvLyBUaGV5IHNob3VsZCBwcm9iYWJseSBiZSBh bHRlcmVkIGZvciBXaW5kb3dzIC8gTGludXggc29tZWRheS4KICAgICAgICAgdGhpcy5fY29kZU1p cnJvci5hZGRLZXlNYXAoewotICAgICAgICAgICAgIkN0cmwtSyI6IHRoaXMuX2hhbmRsZUtpbGxM aW5lLmJpbmQodGhpcyksCisgICAgICAgICAgICAvLyBPdmVycmlkZXMgZm9yIHRoZSAnZW1hY3N5 JyBrZXltYXAuCisgICAgICAgICAgICAiQ3RybC1LIjogdGhpcy5faGFuZGxlVGV4dEtpbGxDb21t YW5kLmJpbmQodGhpcywgImtpbGxMaW5lIiwgZmFsc2UpLAorICAgICAgICAgICAgIkFsdC1EIjog dGhpcy5faGFuZGxlVGV4dEtpbGxDb21tYW5kLmJpbmQodGhpcywgImRlbFdvcmRBZnRlciIsIGZh bHNlKSwKKyAgICAgICAgICAgICJDbWQtRCI6IHRoaXMuX2hhbmRsZVRleHRLaWxsQ29tbWFuZC5i aW5kKHRoaXMsICJkZWxldGVMaW5lIiwgZmFsc2UpLAorICAgICAgICAgICAgLy8gT3ZlcnJpZGVz IGZvciB0aGUgJ21hY0RlZmF1bHQnIGtleW1hcC4KKyAgICAgICAgICAgICJBbHQtRGVsZXRlIjog dGhpcy5faGFuZGxlVGV4dEtpbGxDb21tYW5kLmJpbmQodGhpcywgImRlbEdyb3VwQWZ0ZXIiLCBm YWxzZSksCisgICAgICAgICAgICAiQ21kLUJhY2tzcGFjZSI6IHRoaXMuX2hhbmRsZVRleHRLaWxs Q29tbWFuZC5iaW5kKHRoaXMsICJkZWxXcmFwcGVkTGluZUxlZnQiLCB0cnVlKSwKKyAgICAgICAg ICAgICJDbWQtRGVsZXRlIjogdGhpcy5faGFuZGxlVGV4dEtpbGxDb21tYW5kLmJpbmQodGhpcywg ImRlbFdyYXBwZWRMaW5lUmlnaHQiLCBmYWxzZSksCisgICAgICAgICAgICAiQWx0LUJhY2tzcGFj ZSI6IHRoaXMuX2hhbmRsZVRleHRLaWxsQ29tbWFuZC5iaW5kKHRoaXMsICJkZWxHcm91cEJlZm9y ZSIsIHRydWUpLAorICAgICAgICAgICAgIkN0cmwtQWx0LUJhY2tzcGFjZSI6IHRoaXMuX2hhbmRs ZVRleHRLaWxsQ29tbWFuZC5iaW5kKHRoaXMsICJkZWxHcm91cEFmdGVyIiwgZmFsc2UpLAogICAg ICAgICB9KTsKICAgICB9CiAKLSAgICBfaGFuZGxlS2lsbExpbmUoY29kZU1pcnJvcikKKyAgICBf aGFuZGxlVGV4dEtpbGxDb21tYW5kKGNvbW1hbmQsIHByZXBlbmRzVG9LaWxsUmluZywgY29kZU1p cnJvcikKICAgICB7CiAgICAgICAgIC8vIFJlYWQtb25seSBtb2RlIGlzIGR5bmFtaWMgaW4gc29t ZSBlZGl0b3JzLCBzbyBjaGVjayBldmVyeSB0aW1lCiAgICAgICAgIC8vIGFuZCBpZ25vcmUgdGhl IHNob3J0Y3V0IGlmIGluIHJlYWQtb25seSBtb2RlLgogICAgICAgICBpZiAodGhpcy5fY29kZU1p cnJvci5nZXRPcHRpb24oInJlYWRPbmx5IikpCiAgICAgICAgICAgICByZXR1cm47CiAKKyAgICAg ICAgdGhpcy5fc2hvdWxkUHJlcGVuZFRvS2lsbFJpbmcgPSBwcmVwZW5kc1RvS2lsbFJpbmc7CisK ICAgICAgICAgLy8gRG9uJ3QgYWRkIHRoZSBsaXN0ZW5lciBpZiBpdCdzIHN0aWxsIHJlZ2lzdGVy ZWQgYmVjYXVzZQogICAgICAgICAvLyBhIHByZXZpb3VzIGVtcHR5IGtpbGwgZGlkbid0IGdlbmVy YXRlIGNoYW5nZSBldmVudHMuCiAgICAgICAgIGlmICghdGhpcy5fZXhwZWN0aW5nQ2hhbmdlRXZl bnRGb3JLaWxsKQotICAgICAgICAgICAgY29kZU1pcnJvci5vbigiY2hhbmdlcyIsIHRoaXMuX2hh bmRsZVRleHRDaGFuZ2VMaXN0ZW5lcik7CisgICAgICAgICAgICB0aGlzLl9jb2RlTWlycm9yLm9u KCJjaGFuZ2VzIiwgdGhpcy5faGFuZGxlVGV4dENoYW5nZUxpc3RlbmVyKTsKIAogICAgICAgICB0 aGlzLl9leHBlY3RpbmdDaGFuZ2VFdmVudEZvcktpbGwgPSB0cnVlOwotICAgICAgICBjb2RlTWly cm9yLmV4ZWNDb21tYW5kKCJraWxsTGluZSIpOworICAgICAgICB0aGlzLl9jb2RlTWlycm9yLmV4 ZWNDb21tYW5kKGNvbW1hbmQpOwogICAgIH0KIAogICAgIF9oYW5kbGVUZXh0Q2hhbmdlKGNvZGVN aXJyb3IsIGNoYW5nZXMpCkBAIC04MSwxOCArOTUsMjIgQEAgV2ViSW5zcGVjdG9yLkNvZGVNaXJy b3JUZXh0S2lsbENvbnRyb2xsZXIgPSBjbGFzcyBDb2RlTWlycm9yVGV4dEtpbGxDb250cm9sbGVy IGUKICAgICAgICAgaWYgKGNoYW5nZS5vcmlnaW4gIT09ICIrZGVsZXRlIikKICAgICAgICAgICAg IHJldHVybjsKIAotICAgICAgICAvLyBLaWxsaW5nIGEgbmV3bGluZSBieSBpdHNlbGYgaXMgcmVw b3J0ZWQgYXMgZGVsZXRpb24gb2YgdHdvCi0gICAgICAgIC8vIGVtcHR5IHN0cmluZ3MsIHNvIGNo ZWNrIHRoZSBjaGFuZ2UncyByYW5nZXMgdG8gZGV0ZWN0IHRoaXMuCisgICAgICAgIC8vIFdoZW4g a2lsbGVkIHRleHQgaW5jbHVkZXMgYSBuZXdsaW5lLCBDb2RlTWlycm9yIHJldHVybnMKKyAgICAg ICAgLy8gc3RyYW5nZSBjaGFuZ2Ugb2JqZWN0cy4gU3BlY2lhbC1jYXNlIGZvciB3aGVuIHRoaXMg Y291bGQgaGFwcGVuLgogICAgICAgICBsZXQga2lsbGVkVGV4dDsKLSAgICAgICAgaWYgKGNoYW5n ZS50by5saW5lID09PSBjaGFuZ2UuZnJvbS5saW5lICsgMSkKLSAgICAgICAgICAgIGtpbGxlZFRl eHQgPSAiXG4iOwotICAgICAgICBlbHNlIHsKKyAgICAgICAgaWYgKGNoYW5nZS50by5saW5lID09 PSBjaGFuZ2UuZnJvbS5saW5lICsgMSAmJiBjaGFuZ2UucmVtb3ZlZC5sZW5ndGggPT09IDIpIHsK KyAgICAgICAgICAgIC8vIEFuIGVudGlyZSBsaW5lIHdhcyBkZWxldGVkLCBpbmNsdWRpbmcgbmV3 bGluZSAoQ21kLUQpLgorICAgICAgICAgICAgaWYgKGNoYW5nZS5yZW1vdmVkWzBdLmxlbmd0aCAm JiAhY2hhbmdlLnJlbW92ZWRbMV0ubGVuZ3RoKSAKKyAgICAgICAgICAgICAgICBraWxsZWRUZXh0 ID0gY2hhbmdlLnJlbW92ZWRbMF0gKyAiXG4iOworICAgICAgICAgICAgLy8gQSBuZXdsaW5lIHdh cyBraWxsZWQgYnkgaXRzZWxmIChDdHJsLUspLgorICAgICAgICAgICAgZWxzZQorICAgICAgICAg ICAgICAgIGtpbGxlZFRleHQgPSAiXG4iOworICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAg Y29uc29sZS5hc3NlcnQoY2hhbmdlLnJlbW92ZWQubGVuZ3RoID09PSAxKTsKICAgICAgICAgICAg IGtpbGxlZFRleHQgPSBjaGFuZ2UucmVtb3ZlZFswXTsKICAgICAgICAgfQogCi0gICAgICAgIGNv bnN0IHNob3VsZFByZXBlbmRUb0tpbGxSaW5nID0gZmFsc2U7Ci0gICAgICAgIEluc3BlY3RvckZy b250ZW5kSG9zdC5raWxsVGV4dChraWxsZWRUZXh0LCBzaG91bGRQcmVwZW5kVG9LaWxsUmluZywg dGhpcy5fbmV4dEtpbGxTdGFydHNOZXdTZXF1ZW5jZSk7CisgICAgICAgIEluc3BlY3RvckZyb250 ZW5kSG9zdC5raWxsVGV4dChraWxsZWRUZXh0LCB0aGlzLl9zaG91bGRQcmVwZW5kVG9LaWxsUmlu ZywgdGhpcy5fbmV4dEtpbGxTdGFydHNOZXdTZXF1ZW5jZSk7CiAKICAgICAgICAgLy8gSWYgdGhl IGVkaXRvciBsb3NlcyBmb2N1cyBvciB0aGUgY2FyZXQgLyBzZWxlY3Rpb24gY2hhbmdlcwogICAg ICAgICAvLyAobm90IGFzIGEgcmVzdWx0IG9mIHRoZSBraWxsKSwgdGhlbiB0aGUgbmV4dCBraWxs IHNob3VsZAo=