151289 2015-11-13 18:47:22 -0800 Eliminate a request for layout every time an item is added to the stage of the graphics benchmark 2015-11-13 21:51:32 -0800 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sabouhallawa sabouhallawa cdumez commit-queue dino rniwa simon.fraser oldest_to_newest 1142012 0 sabouhallawa 2015-11-13 18:47:22 -0800 The graphics item usually asks for the stage size when it is created. Because the stage size was not cached but rather was requested via clientWidth and clientHeight an implicit request for layout was invoked. This impact of this bug was very obvious when the benchmark was running with large fixed size in non adaptive mode. This was taking few seconds for benchmark to show the first animation frame. 1142013 1 265527 sabouhallawa 2015-11-13 18:50:19 -0800 Created attachment 265527 Patch 1142033 2 265527 commit-queue 2015-11-13 21:51:28 -0800 Comment on attachment 265527 Patch Clearing flags on attachment: 265527 Committed r192455: <http://trac.webkit.org/changeset/192455> 1142034 3 commit-queue 2015-11-13 21:51:32 -0800 All reviewed patches have been landed. Closing bug. 265527 2015-11-13 18:50:19 -0800 2015-11-13 21:51:28 -0800 Patch bug-151289-20151113185012.patch text/plain 2643 sabouhallawa SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxOTI0NTMpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE1LTExLTEzICBT YWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgRWxp bWluYXRlIGEgcmVxdWVzdCBmb3IgbGF5b3V0IGV2ZXJ5IHRpbWUgYW4gaXRlbSBpcyBhZGRlZCB0 byB0aGUgc3RhZ2Ugb2YgdGhlIGdyYXBoaWNzIGJlbmNobWFyaworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxMjg5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBDYWNoZSB0aGUgc3RhZ2Ugc2l6 ZSB3aGVuIGl0IGlzIGNyZWF0ZWQgaW5zdGVhZCBvZiByZXF1ZXN0aW5nIGV2ZXJ5IHRpbWUKKyAg ICAgICAgYW4gb2JqZWN0IGlzIGFkZGVkIHZpYSBjbGllbnRXaWR0aCBhbmQgY2xpZW50SGVpZ2h0 LgorCisgICAgICAgICogQW5pbW9tZXRlci9yZXNvdXJjZXMvZXh0ZW5zaW9ucy5qczoKKyAgICAg ICAgKEluc2V0cy5lbGVtZW50UGFkZGluZyk6CisgICAgICAgICogQW5pbW9tZXRlci90ZXN0cy9y ZXNvdXJjZXMvc3RhZ2UuanM6CisgICAgICAgIChTdGFnZSk6CisgICAgICAgIChTdGFnZS5wcm90 b3R5cGUuZ2V0IHNpemUpOgorCiAyMDE1LTExLTA2ICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhYm91 aGFsbGF3YUBhcHBsZS5jb20+CiAKICAgICAgICAgSW5pdGlhbGl6ZSB0aGUgZ3JhcGhpY3MgYmVu Y2htYXJrJ3MgS2FsbWFuIGZpbHRlciB3aXRoIGVzdGltYXRlZCA2MCBGUFMKSW5kZXg6IFBlcmZv cm1hbmNlVGVzdHMvQW5pbW9tZXRlci9yZXNvdXJjZXMvZXh0ZW5zaW9ucy5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBQZXJmb3JtYW5jZVRlc3RzL0FuaW1vbWV0ZXIvcmVzb3VyY2VzL2V4dGVuc2lvbnMuanMJ KHJldmlzaW9uIDE5MjQwMCkKKysrIFBlcmZvcm1hbmNlVGVzdHMvQW5pbW9tZXRlci9yZXNvdXJj ZXMvZXh0ZW5zaW9ucy5qcwkod29ya2luZyBjb3B5KQpAQCAtNjgsNiArNjgsMTYgQEAgZnVuY3Rp b24gSW5zZXRzKHRvcCwgcmlnaHQsIGJvdHRvbSwgbGVmdAogICAgIHRoaXMubGVmdCA9IGxlZnQ7 CiB9CiAKK0luc2V0cy5lbGVtZW50UGFkZGluZyA9IGZ1bmN0aW9uKGVsZW1lbnQpCit7CisgICAg dmFyIHN0eWxlcyA9IHdpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGVsZW1lbnQpOworICAgIHJldHVy biBuZXcgSW5zZXRzKAorICAgICAgICBwYXJzZUZsb2F0KHN0eWxlcy5wYWRkaW5nVG9wKSwKKyAg ICAgICAgcGFyc2VGbG9hdChzdHlsZXMucGFkZGluZ1JpZ2h0KSwKKyAgICAgICAgcGFyc2VGbG9h dChzdHlsZXMucGFkZGluZ0JvdHRvbSksCisgICAgICAgIHBhcnNlRmxvYXQoc3R5bGVzLnBhZGRp bmdUb3ApKTsKK30KKwogSW5zZXRzLnByb3RvdHlwZSA9CiB7CiAgICAgZ2V0IHdpZHRoKCkKSW5k ZXg6IFBlcmZvcm1hbmNlVGVzdHMvQW5pbW9tZXRlci90ZXN0cy9yZXNvdXJjZXMvc3RhZ2UuanMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gUGVyZm9ybWFuY2VUZXN0cy9Bbmltb21ldGVyL3Rlc3RzL3Jlc291cmNl cy9zdGFnZS5qcwkocmV2aXNpb24gMTkyNDAwKQorKysgUGVyZm9ybWFuY2VUZXN0cy9Bbmltb21l dGVyL3Rlc3RzL3Jlc291cmNlcy9zdGFnZS5qcwkod29ya2luZyBjb3B5KQpAQCAtMzUsMTkgKzM1 LDE0IEBAIFJvdGF0ZXIucHJvdG90eXBlID0KIGZ1bmN0aW9uIFN0YWdlKGVsZW1lbnQsIG9wdGlv bnMpCiB7CiAgICAgdGhpcy5lbGVtZW50ID0gZWxlbWVudDsKKyAgICB0aGlzLl9zaXplID0gUG9p bnQuZWxlbWVudENsaWVudFNpemUoZWxlbWVudCkuc3VidHJhY3QoSW5zZXRzLmVsZW1lbnRQYWRk aW5nKGVsZW1lbnQpLnNpemUpOwogfQogCiBTdGFnZS5wcm90b3R5cGUgPQogewogICAgIGdldCBz aXplKCkKICAgICB7Ci0gICAgICAgIHZhciBzdHlsZXMgPSB3aW5kb3cuZ2V0Q29tcHV0ZWRTdHls ZSh0aGlzLmVsZW1lbnQpOwotICAgICAgICB2YXIgcGFkZGluZyA9IG5ldyBJbnNldHMoCi0gICAg ICAgICAgICBwYXJzZUZsb2F0KHN0eWxlcy5wYWRkaW5nVG9wKSwKLSAgICAgICAgICAgIHBhcnNl RmxvYXQoc3R5bGVzLnBhZGRpbmdSaWdodCksCi0gICAgICAgICAgICBwYXJzZUZsb2F0KHN0eWxl cy5wYWRkaW5nQm90dG9tKSwKLSAgICAgICAgICAgIHBhcnNlRmxvYXQoc3R5bGVzLnBhZGRpbmdU b3ApKTsKLSAgICAgICAgcmV0dXJuIG5ldyBQb2ludCh0aGlzLmVsZW1lbnQuY2xpZW50V2lkdGgg LSBwYWRkaW5nLndpZHRoLCB0aGlzLmVsZW1lbnQuY2xpZW50SGVpZ2h0IC0gcGFkZGluZy5oZWln aHQpOworICAgICAgICByZXR1cm4gdGhpcy5fc2l6ZQogICAgIH0sCiAgICAgCiAgICAgcmFuZG9t OiBmdW5jdGlvbihtaW4sIG1heCkK