151280 2015-11-13 16:12:11 -0800 Web Inspector: Dashboard log message count doesn't include console.time messages 2016-01-10 12:24:48 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED EasyFix, GoodFirstBug, InRadar P2 Normal --- 1 mattbaker webkit-unassigned bburg commit-queue graouts jj joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1141972 0 mattbaker 2015-11-13 16:12:11 -0800 * SUMMARY Dashboard log message count doesn't include console.time messages. The Console log filter shows console.time messages when "Logs" is selected, so they should be included in the total. * STEPS TO REPRODUCE 1. Inspector -> Console tab 2. Type "console.log(1)" 3. Dashboard log count is 1. 4. Type "console.time('foo')" 5. Type "console.timeEnd('foo')" => Log count is 1. Expected 2. Filtering the Console log by "Errors" hides the time marker. Filtering by "Logs" shows the time marker. 1141973 1 webkit-bug-importer 2015-11-13 16:12:49 -0800 <rdar://problem/23543063> 1154162 2 jj 2016-01-09 13:00:11 -0800 The problem is in `_incrementConsoleMessageType` in `Source/WebInspectorUI/UserInterface/Models/DefaultDashboard.js`, where it only increments log/issue/error-count if the ConsoleMessage has the levels log, warning, or error respectively. As there also exists MessageLevels info and debug, those are not included in the log-count. Adding two fallthrough cases for info and debug to also increment the log-count would solve the problem. This would make `console.timeEnd()`, `console.debug()`, and `console.info()` increment the log-count in the dashboard. If that sounds like an okay solution, I’d like to submit a patch. 1154202 3 mattbaker 2016-01-09 23:01:58 -0800 (In reply to comment #2) > The problem is in `_incrementConsoleMessageType` in > `Source/WebInspectorUI/UserInterface/Models/DefaultDashboard.js`, where it > only increments log/issue/error-count if the ConsoleMessage has the levels > log, warning, or error respectively. > As there also exists MessageLevels info and debug, those are not included in > the log-count. The Chrome console API reference states that console.info and console.debug are identical to console.log, so it works for me! > Adding two fallthrough cases for info and debug to also increment the > log-count would solve the problem. > This would make `console.timeEnd()`, `console.debug()`, and `console.info()` > increment the log-count in the dashboard. > > If that sounds like an okay solution, I’d like to submit a patch. Sounds good. 1154206 4 268643 jj 2016-01-10 03:42:55 -0800 Created attachment 268643 Patch 1154245 5 268643 bburg 2016-01-10 11:36:56 -0800 Comment on attachment 268643 Patch r=me 1154251 6 268643 commit-queue 2016-01-10 12:24:43 -0800 Comment on attachment 268643 Patch Clearing flags on attachment: 268643 Committed r194828: <http://trac.webkit.org/changeset/194828> 1154252 7 commit-queue 2016-01-10 12:24:48 -0800 All reviewed patches have been landed. Closing bug. 268643 2016-01-10 03:42:55 -0800 2016-01-10 12:24:43 -0800 Patch bug-151280-20160110124223.patch text/plain 1696 jj U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0ODI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAw MTg0ZjI3MDZkMzM1ZDIwNjgwMThiNWJmZjBhNzM0NDNlMzQ3OWZhLi5lYzRlZWFmOGRmMTJhOGY1 N2JiZGZhNjVjY2VkZTNjMGU0ODQ4M2Y2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNi0wMS0xMCAgSm9oYW4gSy4gSmVuc2VuICA8ampAam9oYW5qZW5zZW4u ZGs+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRGFzaGJvYXJkIGxvZyBtZXNzYWdlIGNvdW50 IGRvZXNuJ3QgaW5jbHVkZSBjb25zb2xlLnRpbWUgbWVzc2FnZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTI4MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvRGVm YXVsdERhc2hib2FyZC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EZWZhdWx0RGFzaGJvYXJk LnByb3RvdHlwZS5faW5jcmVtZW50Q29uc29sZU1lc3NhZ2VUeXBlKToKKyAgICAgICAgTWFrZSBJ bmZvIGFuZCBEZWJ1ZyBsZXZlbHMgaW5jcmVtZW50IHRoZSBsb2cgY291bnQuCisKIDIwMTYtMDEt MDkgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBbQ29jb2FdIEFs bG93IG92ZXJyaWRpbmcgdGhlIGZyYW1ld29ya3MgZGlyZWN0b3J5IGluZGVwZW5kZW50bHkgb2Yg dXNpbmcgYSBzdGFnaW5nIGluc3RhbGwgcGF0aApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RlZmF1bHREYXNoYm9hcmQuanMgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRGVmYXVsdERhc2hib2FyZC5qcwpp bmRleCBjNGQ2YmQ3NzE1MDVjMTQ3NDEzMzMwZmI0NThmZWU2NGRjNjljZWRmLi4yODNmNWZmODMw N2RmMWE1ZWIwOThiYTU1MmQ5YTRiM2MxZjU3MTNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRGVmYXVsdERhc2hib2FyZC5qcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRGVmYXVsdERhc2hib2Fy ZC5qcwpAQCAtMjQxLDYgKzI0MSw4IEBAIFdlYkluc3BlY3Rvci5EZWZhdWx0RGFzaGJvYXJkID0g Y2xhc3MgRGVmYXVsdERhc2hib2FyZCBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplCiAgICAgewog ICAgICAgICBzd2l0Y2ggKHR5cGUpIHsKICAgICAgICAgY2FzZSBXZWJJbnNwZWN0b3IuQ29uc29s ZU1lc3NhZ2UuTWVzc2FnZUxldmVsLkxvZzoKKyAgICAgICAgY2FzZSBXZWJJbnNwZWN0b3IuQ29u c29sZU1lc3NhZ2UuTWVzc2FnZUxldmVsLkluZm86CisgICAgICAgIGNhc2UgV2ViSW5zcGVjdG9y LkNvbnNvbGVNZXNzYWdlLk1lc3NhZ2VMZXZlbC5EZWJ1ZzoKICAgICAgICAgICAgIHRoaXMubG9n cyArPSBpbmNyZW1lbnQ7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBXZWJJbnNw ZWN0b3IuQ29uc29sZU1lc3NhZ2UuTWVzc2FnZUxldmVsLldhcm5pbmc6Cg==