151271 2015-11-13 12:06:43 -0800 [WinCairo][MediaFoundation] Video rendered at wrong position. 2015-11-13 13:52:26 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham oldest_to_newest 1141901 0 peavo 2015-11-13 12:06:43 -0800 Watching videos at YouTube shows that we are not rendering them at the correct position. 1141913 1 265491 peavo 2015-11-13 12:58:38 -0800 Created attachment 265491 Patch 1141915 2 265493 peavo 2015-11-13 13:00:37 -0800 Created attachment 265493 Patch 1141917 3 265493 achristensen 2015-11-13 13:03:56 -0800 Comment on attachment 265493 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265493&action=review > Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:2692 > + FloatRect destRect = r; This isn't needed if it's used only once and r is not used anywhere else. Just rename the parameter. 1141932 4 peavo 2015-11-13 13:39:42 -0800 (In reply to comment #3) > Comment on attachment 265493 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=265493&action=review > > > Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:2692 > > + FloatRect destRect = r; > > This isn't needed if it's used only once and r is not used anywhere else. > Just rename the parameter. Thanks for reviewing :) I will rename the parameter. 1141935 5 peavo 2015-11-13 13:52:26 -0800 Committed r192441: <http://trac.webkit.org/changeset/192441>. 265491 2015-11-13 12:58:38 -0800 2015-11-13 13:00:29 -0800 Patch bug-151271-20151113215839.patch text/plain 1978 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MjQzNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTExLTEzICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dW01lZGlh Rm91bmRhdGlvbl0gVmlkZW8gcmVuZGVyZWQgYXQgd3JvbmcgcG9zaXRpb24uCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTEyNzEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgZGVzdGluYXRpb24gcmVj dGFuZ2xlIHVzZWQgd2hlbiBibGl0dGluZyBhIGZyYW1lIHRvIHRoZSBncmFwaGljcyBjb250ZXh0 CisgICAgICAgIHNob3VsZCBoYXZlIG9mZnNldCAoMCwgMCkuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy93aW4vTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6RGlyZWN0 M0RQcmVzZW50ZXI6OnBhaW50Q3VycmVudEZyYW1lKToKKwogMjAxNS0xMS0xMyAgSm9zZXBoIFBl Y29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFBy b3ZpZGUgYSB3YXkgdG8gb3ZlcnJpZGUgdGhlIFdLV2ViVmlldyByZW1vdGUgaW5zcGVjdG9yIG5h bWUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXll clByaXZhdGVNZWRpYUZvdW5kYXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb24u Y3BwCShyZXZpc2lvbiAxOTI0MTUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy93aW4vTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMjY4OCwxMCArMjY4OCw5IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3Vu ZGF0aW9uOjoKICNpZiBVU0UoQ0FJUk8pCiAgICAgICAgIFdlYkNvcmU6OlBsYXRmb3JtQ29udGV4 dENhaXJvKiBjdHh0ID0gY29udGV4dC5wbGF0Zm9ybUNvbnRleHQoKTsKICAgICAgICAgY2Fpcm9f c3VyZmFjZV90KiBpbWFnZSA9IGNhaXJvX2ltYWdlX3N1cmZhY2VfY3JlYXRlX2Zvcl9kYXRhKHN0 YXRpY19jYXN0PHVuc2lnbmVkIGNoYXIqPihkYXRhKSwgQ0FJUk9fRk9STUFUX0FSR0IzMiwgd2lk dGgsIGhlaWdodCwgcGl0Y2gpOwotICAgICAgICBXZWJDb3JlOjpGbG9hdFJlY3QgY2xpcCgwLCAw LCB3aWR0aCwgaGVpZ2h0KTsKLSAgICAgICAgV2ViQ29yZTo6RmxvYXRSZWN0IHJlY3QgPSByOwot ICAgICAgICByZWN0LmludGVyc2VjdChjbGlwKTsKLSAgICAgICAgY3R4dC0+ZHJhd1N1cmZhY2VU b0NvbnRleHQoaW1hZ2UsIHJlY3QsIHJlY3QsIGNvbnRleHQpOworICAgICAgICBGbG9hdFJlY3Qg c3JjUmVjdCgwLCAwLCB3aWR0aCwgaGVpZ2h0KTsKKyAgICAgICAgRmxvYXRSZWN0IGRlc3RSZWN0 ID0gcjsKKyAgICAgICAgY3R4dC0+ZHJhd1N1cmZhY2VUb0NvbnRleHQoaW1hZ2UsIGRlc3RSZWN0 LCBzcmNSZWN0LCBjb250ZXh0KTsKICAgICAgICAgY2Fpcm9fc3VyZmFjZV9kZXN0cm95KGltYWdl KTsKICNlbHNlCiAjZXJyb3IgIlBsYXRmb3JtIG5lZWRzIHRvIGltcGxlbWVudCBkcmF3aW5nIG9m IERpcmVjdDNEIHN1cmZhY2UgdG8gZ3JhcGhpY3MgY29udGV4dCEiCg== 265493 2015-11-13 13:00:37 -0800 2015-11-13 13:03:56 -0800 Patch bug-151271-20151113220037.patch text/plain 1973 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MjQzNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTExLTEzICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dW01lZGlh Rm91bmRhdGlvbl0gVmlkZW8gcmVuZGVyZWQgYXQgd3JvbmcgcG9zaXRpb24uCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTEyNzEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgc291cmNlIHJlY3Rhbmds ZSB1c2VkIHdoZW4gYmxpdHRpbmcgYSBmcmFtZSB0byB0aGUgZ3JhcGhpY3MgY29udGV4dAorICAg ICAgICBzaG91bGQgaGF2ZSBvZmZzZXQgKDAsIDApLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5jcHA6CisgICAgICAg IChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246OkRpcmVjdDNEUHJl c2VudGVyOjpwYWludEN1cnJlbnRGcmFtZSk6CisKIDIwMTUtMTEtMTMgIEpvc2VwaCBQZWNvcmFy byAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBQcm92aWRl IGEgd2F5IHRvIG92ZXJyaWRlIHRoZSBXS1dlYlZpZXcgcmVtb3RlIGluc3BlY3RvciBuYW1lCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vTWVkaWFQbGF5ZXJQcml2 YXRlTWVkaWFGb3VuZGF0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy93aW4vTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uLmNwcAko cmV2aXNpb24gMTkyNDE1KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2lu L01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTI2ODgsMTAgKzI2ODgsOSBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlv bjo6CiAjaWYgVVNFKENBSVJPKQogICAgICAgICBXZWJDb3JlOjpQbGF0Zm9ybUNvbnRleHRDYWly byogY3R4dCA9IGNvbnRleHQucGxhdGZvcm1Db250ZXh0KCk7CiAgICAgICAgIGNhaXJvX3N1cmZh Y2VfdCogaW1hZ2UgPSBjYWlyb19pbWFnZV9zdXJmYWNlX2NyZWF0ZV9mb3JfZGF0YShzdGF0aWNf Y2FzdDx1bnNpZ25lZCBjaGFyKj4oZGF0YSksIENBSVJPX0ZPUk1BVF9BUkdCMzIsIHdpZHRoLCBo ZWlnaHQsIHBpdGNoKTsKLSAgICAgICAgV2ViQ29yZTo6RmxvYXRSZWN0IGNsaXAoMCwgMCwgd2lk dGgsIGhlaWdodCk7Ci0gICAgICAgIFdlYkNvcmU6OkZsb2F0UmVjdCByZWN0ID0gcjsKLSAgICAg ICAgcmVjdC5pbnRlcnNlY3QoY2xpcCk7Ci0gICAgICAgIGN0eHQtPmRyYXdTdXJmYWNlVG9Db250 ZXh0KGltYWdlLCByZWN0LCByZWN0LCBjb250ZXh0KTsKKyAgICAgICAgRmxvYXRSZWN0IHNyY1Jl Y3QoMCwgMCwgd2lkdGgsIGhlaWdodCk7CisgICAgICAgIEZsb2F0UmVjdCBkZXN0UmVjdCA9IHI7 CisgICAgICAgIGN0eHQtPmRyYXdTdXJmYWNlVG9Db250ZXh0KGltYWdlLCBkZXN0UmVjdCwgc3Jj UmVjdCwgY29udGV4dCk7CiAgICAgICAgIGNhaXJvX3N1cmZhY2VfZGVzdHJveShpbWFnZSk7CiAj ZWxzZQogI2Vycm9yICJQbGF0Zm9ybSBuZWVkcyB0byBpbXBsZW1lbnQgZHJhd2luZyBvZiBEaXJl Y3QzRCBzdXJmYWNlIHRvIGdyYXBoaWNzIGNvbnRleHQhIgo=