151248 2015-11-12 23:38:06 -0800 WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction calls an std::function after it's been moved from 2015-11-17 10:35:56 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugzilla.redhat.com/show_bug.cgi?id=1269778 P2 Normal --- 1 ryuan.choi ryuan.choi commit-queue mcatanzaro oldest_to_newest 1141783 0 ryuan.choi 2015-11-12 23:38:06 -0800 Like Bug 147873, it may generate std::bad_function_call 1141789 1 265472 ryuan.choi 2015-11-13 00:08:15 -0800 Created attachment 265472 Patch 1142087 2 265472 darin 2015-11-14 18:53:16 -0800 Comment on attachment 265472 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=265472&action=review > Source/WebKit2/ChangeLog:9 > + Like r188287, calling an empty std::function results in a std::bad_function_call > + exception being thrown when sendSync is failed. Fix looks fine. Why no regression test, though? 1142112 3 ryuan.choi 2015-11-15 04:05:12 -0800 (In reply to comment #2) > Comment on attachment 265472 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=265472&action=review > > > Source/WebKit2/ChangeLog:9 > > + Like r188287, calling an empty std::function results in a std::bad_function_call > > + exception being thrown when sendSync is failed. > > Fix looks fine. Why no regression test, though? I don't have idea to make a test case that sendSync is failed, although EFL test case(test_ewk2_view) sometimes raises this exception. 1142392 4 265472 commit-queue 2015-11-16 16:27:01 -0800 Comment on attachment 265472 Patch Clearing flags on attachment: 265472 Committed r192496: <http://trac.webkit.org/changeset/192496> 1142393 5 commit-queue 2015-11-16 16:27:05 -0800 All reviewed patches have been landed. Closing bug. 265472 2015-11-13 00:08:15 -0800 2015-11-16 16:27:01 -0800 Patch bug-151248-20151113170808.patch text/plain 2300 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNDA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2IxYTczY2FmZDA2NDc1 YmMyOGM2Yjg0NzFjNDU4OGM4ZGI1MTZkMy4uYWU1ZGE1NmQ4MGQ5NjA1NDczYThmYmJlZTg5YmFh OGI3NTM3N2RlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTExLTEzICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFdlYkZyYW1lTG9h ZGVyQ2xpZW50OjpkaXNwYXRjaERlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24gY2FsbHMg YW4gc3RkOjpmdW5jdGlvbiBhZnRlciBpdCdzIGJlZW4gbW92ZWQgZnJvbQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxMjQ4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGlrZSByMTg4Mjg3LCBjYWxsaW5n IGFuIGVtcHR5IHN0ZDo6ZnVuY3Rpb24gcmVzdWx0cyBpbiBhIHN0ZDo6YmFkX2Z1bmN0aW9uX2Nh bGwKKyAgICAgICAgZXhjZXB0aW9uIGJlaW5nIHRocm93biB3aGVuIHNlbmRTeW5jIGlzIGZhaWxl ZC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJD bGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0 Y2hEZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKToKKwogMjAxNS0xMS0xMiAgQW5kZXJz IENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhIGNvbnRleHQg bWVudSBkZWxlZ2F0ZSBtZXRob2QgdGhhdCB0YWtlcyBhIHVzZXJJbmZvIHBhcmFtZXRlcgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFt ZUxvYWRlckNsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBw b3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcAppbmRleCBkNWVkZmIwMWVjZDU3NmYwMGM1MjY3 NzhlZmI4M2Q4ZjE4NzVjMTBjLi42MDU2MWNiZTY4ZjM1N2IzN2E5NWNiMzRhYmM5MzE3YzdmOTMw NTNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0 L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcApAQCAtODA5LDcgKzgwOSw3 IEBAIHZvaWQgV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGVjaWRlUG9saWN5Rm9yTmF2 aWdhdGlvbkFjdGlvbihjb25zdCBOYXZpZ2F0CiAgICAgLy8gTm90aWZ5IHRoZSBVSVByb2Nlc3Mu CiAgICAgV2ViQ29yZTo6RnJhbWUqIG9yaWdpbmF0aW5nQ29yZUZyYW1lID0gb3JpZ2luYXRpbmdG cmFtZSA/IG9yaWdpbmF0aW5nRnJhbWUtPmNvcmVGcmFtZSgpIDogbnVsbHB0cjsKICAgICBpZiAo IXdlYlBhZ2UtPnNlbmRTeW5jKE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OkRlY2lkZVBvbGljeUZv ck5hdmlnYXRpb25BY3Rpb24obV9mcmFtZS0+ZnJhbWVJRCgpLCBTZWN1cml0eU9yaWdpbkRhdGE6 OmZyb21GcmFtZShjb3JlRnJhbWUpLCBkb2N1bWVudExvYWRlci0+bmF2aWdhdGlvbklEKCksIG5h dmlnYXRpb25BY3Rpb25EYXRhLCBvcmlnaW5hdGluZ0ZyYW1lID8gb3JpZ2luYXRpbmdGcmFtZS0+ ZnJhbWVJRCgpIDogMCwgU2VjdXJpdHlPcmlnaW5EYXRhOjpmcm9tRnJhbWUob3JpZ2luYXRpbmdD b3JlRnJhbWUpLCBuYXZpZ2F0aW9uQWN0aW9uLnJlc291cmNlUmVxdWVzdCgpLCByZXF1ZXN0LCBs aXN0ZW5lcklELCBVc2VyRGF0YShXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS50cmFuc2Zvcm1PYmpl Y3RzVG9IYW5kbGVzKHVzZXJEYXRhLmdldCgpKS5nZXQoKSkpLCBNZXNzYWdlczo6V2ViUGFnZVBy b3h5OjpEZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uOjpSZXBseShyZWNlaXZlZFBvbGlj eUFjdGlvbiwgbmV3TmF2aWdhdGlvbklELCBwb2xpY3lBY3Rpb24sIGRvd25sb2FkSUQpKSkgewot ICAgICAgICBmdW5jdGlvbihQb2xpY3lJZ25vcmUpOworICAgICAgICBtX2ZyYW1lLT5kaWRSZWNl aXZlUG9saWN5RGVjaXNpb24obGlzdGVuZXJJRCwgUG9saWN5SWdub3JlLCAwLCAwKTsKICAgICAg ICAgcmV0dXJuOwogICAgIH0KIAo=