151245 2015-11-12 21:08:04 -0800 Web Inspector: Deleting a probe should remove probe breakpoint actions only. 2015-11-12 22:03:25 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1141752 0 mattbaker 2015-11-12 21:08:04 -0800 * SUMMARY Deleting a probe should remove probe breakpoint actions only. * STEPS TO REPRODUCE 1. Open Debugger tab 2. Create a breakpoint, add a non-probe action (log message) and a probe expression 3. Delete the probe (X) from the Probes panel in the right sidebar 4. Edit breakpoint => No breakpoint actions. Expected log message action to still be there 1141753 1 webkit-bug-importer 2015-11-12 21:08:27 -0800 <rdar://problem/23529750> 1141754 2 265466 mattbaker 2015-11-12 21:11:34 -0800 Created attachment 265466 [Patch] Proposed Fix 1141755 3 265466 bburg 2015-11-12 21:13:53 -0800 Comment on attachment 265466 [Patch] Proposed Fix Ugh, this should have had a test initially. I won't burden this fix. r=me 1141761 4 mattbaker 2015-11-12 21:22:15 -0800 *** Bug 151244 has been marked as a duplicate of this bug. *** 1141775 5 265466 commit-queue 2015-11-12 22:03:23 -0800 Comment on attachment 265466 [Patch] Proposed Fix Clearing flags on attachment: 265466 Committed r192408: <http://trac.webkit.org/changeset/192408> 1141776 6 commit-queue 2015-11-12 22:03:25 -0800 All reviewed patches have been landed. Closing bug. 265466 2015-11-12 21:11:34 -0800 2015-11-12 22:03:23 -0800 [Patch] Proposed Fix bug-151245-20151112211128.patch text/plain 1668 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNDA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA0 NGVmN2ViMzFiMThhZTU4M2VjZTI4NDA5N2U3NTZiNjY5MjYzYmQxLi40MzRkMzQxNmI4OTEyZTlh ODg2OGJjMjQxMWE0Y2Y0MzQwMzYwZWEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNS0xMS0xMiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRGVsZXRpbmcgYSBwcm9iZSBzaG91bGQgcmVtb3Zl IHByb2JlIGJyZWFrcG9pbnQgYWN0aW9ucyBvbmx5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUxMjQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZWQgYnJlYWtwb2ludCBhY3Rpb24gZmlsdGVyLgor CisgICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvQnJlYWtwb2ludC5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5CcmVha3BvaW50LnByb3RvdHlwZS5jbGVhckFjdGlvbnMpOgorICAgICAg ICBNaXNzaW5nIHJldHVybiBpbiBuYW1lZCBmdW5jdGlvbiBleHByZXNzaW9uLgorCiAyMDE1LTEx LTEyICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogQXV0by1sb2cgaW5zcGVjdCBub2RlIHNlbGVjdGVkIGVsZW1lbnRzIHRvIHRo ZSBjb25zb2xlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9Nb2RlbHMvQnJlYWtwb2ludC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL01vZGVscy9CcmVha3BvaW50LmpzCmluZGV4IGIwYzhjZTcyZmViYzc3NGJlOWU4YmM4Mzlm ZWFkNTMyODdhNjZkODkuLjIxYjJjOTYxOWRiOWQ5NGQ3NTkzODlhNWVmZjcxYTU1ODE1NzI0ZmYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9C cmVha3BvaW50LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01v ZGVscy9CcmVha3BvaW50LmpzCkBAIC0yOTIsNyArMjkyLDcgQEAgV2ViSW5zcGVjdG9yLkJyZWFr cG9pbnQgPSBjbGFzcyBCcmVha3BvaW50IGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAg ICAgICBpZiAoIXR5cGUpCiAgICAgICAgICAgICB0aGlzLl9hY3Rpb25zID0gW107CiAgICAgICAg IGVsc2UKLSAgICAgICAgICAgIHRoaXMuX2FjdGlvbnMgPSB0aGlzLl9hY3Rpb25zLmZpbHRlcihm dW5jdGlvbihhY3Rpb24pIHsgYWN0aW9uLnR5cGUgIT09IHR5cGU7IH0pOworICAgICAgICAgICAg dGhpcy5fYWN0aW9ucyA9IHRoaXMuX2FjdGlvbnMuZmlsdGVyKGZ1bmN0aW9uKGFjdGlvbikgeyBy ZXR1cm4gYWN0aW9uLnR5cGUgIT09IHR5cGU7IH0pOwogCiAgICAgICAgIHRoaXMuZGlzcGF0Y2hF dmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5CcmVha3BvaW50LkV2ZW50LkFjdGlvbnNEaWRD aGFuZ2UpOwogICAgIH0K