151237 2015-11-12 17:11:27 -0800 Web Inspector: Add a keyboard shortcut to restore the default zoom level 2015-12-01 11:52:25 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 151572 1 nvasilyev bburg bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1141706 0 nvasilyev 2015-11-12 17:11:27 -0800 Command +/- in Safari and WebKit Inspector increases and decreases the zoom level respectively. Command 0 in Safari resets the zoom level. Command 0 in Web Inspector toggles the left sidebar. 1141707 1 webkit-bug-importer 2015-11-12 17:12:00 -0800 <rdar://problem/23527493> 1144095 2 bburg 2015-11-22 14:28:10 -0800 Cmd-0 is bound to show/hide main navigator in Xcode, which is how it got into Inspector. However, I think we should be consistent with Safari and other browsers and use Cmd-0 to reset the zoom level. Safari uses Cmd-Shift-L to toggle the left sidebar, I'm fine with that. Would probably want Cmd-Shift-R for the right sidebar, then. 1144216 3 nvasilyev 2015-11-23 13:39:22 -0800 (In reply to comment #2) > Cmd-0 is bound to show/hide main navigator in Xcode, which is how it got > into Inspector. However, I think we should be consistent with Safari and > other browsers and use Cmd-0 to reset the zoom level. Safari uses > Cmd-Shift-L to toggle the left sidebar, I'm fine with that. Would probably > want Cmd-Shift-R for the right sidebar, then. Cmd-Shift-R already reloads ignoring cache in Web Inspector and Chrome. https://www.webkit.org/blog-files/web-inspector-keyboard-shortcuts/tooltips.gif 1144221 4 266099 bburg 2015-11-23 14:07:37 -0800 Created attachment 266099 Proposed Fix 1144237 5 bburg 2015-11-23 15:40:26 -0800 (In reply to comment #3) > (In reply to comment #2) > > Cmd-0 is bound to show/hide main navigator in Xcode, which is how it got > > into Inspector. However, I think we should be consistent with Safari and > > other browsers and use Cmd-0 to reset the zoom level. Safari uses > > Cmd-Shift-L to toggle the left sidebar, I'm fine with that. Would probably > > want Cmd-Shift-R for the right sidebar, then. > > Cmd-Shift-R already reloads ignoring cache in Web Inspector and Chrome. > https://www.webkit.org/blog-files/web-inspector-keyboard-shortcuts/tooltips. > gif I meant Cmd-Option-{R,L}, sorry. 1144258 6 266099 commit-queue 2015-11-23 18:53:36 -0800 Comment on attachment 266099 Proposed Fix Clearing flags on attachment: 266099 Committed r192757: <http://trac.webkit.org/changeset/192757> 1144259 7 commit-queue 2015-11-23 18:53:39 -0800 All reviewed patches have been landed. Closing bug. 1145318 8 266099 joepeck 2015-12-01 11:52:25 -0800 Comment on attachment 266099 Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=266099&action=review > Source/WebInspectorUI/UserInterface/Base/Main.js:1851 > + event.preventDefault(); Is this needed? I think KeyboardShortcut implicitly prevents default by default. 266099 2015-11-23 14:07:37 -0800 2015-11-23 18:53:36 -0800 Proposed Fix bug-151237-20151123140722.patch text/plain 2598 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTkyNzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAz YzEwODNlMTA2ODJjZDlmOGUxOTA4ZTRiOGI1MzBmODU5ZjhhODY1Li5lYTAxOGEzZTRhNDk4ZGQy ZmNiOWU1YTlhMzAwNjQ4MDIwNDkzYTM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNyBAQAogMjAxNS0xMS0yMyAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQgYSBrZXlib2FyZCBzaG9ydGN1dCB0byByZXN0b3Jl IHRoZSBkZWZhdWx0IHpvb20gbGV2ZWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE1MTIzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoZSBDbWQtMCBzaG9ydGN1dCBtYXRjaGVzIHRoZSBrZXliaW5kaW5n cyBvZiBTYWZhcmkgYW5kIG90aGVyIGJyb3dzZXJzLgorCisgICAgICAgICogVXNlckludGVyZmFj ZS9CYXNlL01haW4uanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuY29udGVudExvYWRlZCk6CisK KzIwMTUtMTEtMjMgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKICAgICAgICAgV2Vi IEluc3BlY3RvcjogdXNlIENtZC1PcHRpb24tTCBhbmQgQ21kLU9wdGlvbi1SIGZvciB0b2dnbGlu ZyBuYXZpZ2F0aW9uIGFuZCBkZXRhaWxzIHNpZGViYXJzCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE1NzIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCmluZGV4IDdlODU3Mzk4MGFhYTAzN2Fl YTNmNzQ1MjNjOTA0ZjgxZTdhNzJlNzYuLjJjOGU2OTI2OTU0YzE1ZDNkZWMyNzc2NjMxOGQ1ZGZi NGJmZTQ4MjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0Jhc2UvTWFpbi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9C YXNlL01haW4uanMKQEAgLTI0OSw2ICsyNDksNyBAQCBXZWJJbnNwZWN0b3IuY29udGVudExvYWRl ZCA9IGZ1bmN0aW9uKCkKIAogICAgIHRoaXMuX2luY3JlYXNlWm9vbUtleWJvYXJkU2hvcnRjdXQg PSBuZXcgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQoV2ViSW5zcGVjdG9yLktleWJvYXJk U2hvcnRjdXQuTW9kaWZpZXIuQ29tbWFuZE9yQ29udHJvbCwgV2ViSW5zcGVjdG9yLktleWJvYXJk U2hvcnRjdXQuS2V5LlBsdXMsIHRoaXMuX2luY3JlYXNlWm9vbS5iaW5kKHRoaXMpKTsKICAgICB0 aGlzLl9kZWNyZWFzZVpvb21LZXlib2FyZFNob3J0Y3V0ID0gbmV3IFdlYkluc3BlY3Rvci5LZXli b2FyZFNob3J0Y3V0KFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1h bmRPckNvbnRyb2wsIFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0LktleS5NaW51cywgdGhp cy5fZGVjcmVhc2Vab29tLmJpbmQodGhpcykpOworICAgIHRoaXMuX3Jlc2V0Wm9vbUtleWJvYXJk U2hvcnRjdXQgPSBuZXcgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQoV2ViSW5zcGVjdG9y LktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuQ29tbWFuZE9yQ29udHJvbCwgIjAiLCB0aGlzLl9y ZXNldFpvb20uYmluZCh0aGlzKSk7CiAKICAgICB0aGlzLnRhYkJyb3dzZXIgPSBuZXcgV2ViSW5z cGVjdG9yLlRhYkJyb3dzZXIoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRhYi1icm93c2VyIiks IHRoaXMudGFiQmFyLCB0aGlzLm5hdmlnYXRpb25TaWRlYmFyLCB0aGlzLmRldGFpbHNTaWRlYmFy KTsKICAgICB0aGlzLnRhYkJyb3dzZXIuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuVGFi QnJvd3Nlci5FdmVudC5TZWxlY3RlZFRhYkNvbnRlbnRWaWV3RGlkQ2hhbmdlLCB0aGlzLl90YWJC cm93c2VyU2VsZWN0ZWRUYWJDb250ZW50Vmlld0RpZENoYW5nZSwgdGhpcyk7CkBAIC0xODQ1LDYg KzE4NDYsMTEgQEAgV2ViSW5zcGVjdG9yLl9kZWNyZWFzZVpvb20gPSBmdW5jdGlvbihldmVudCkg ewogICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CiB9OwogCitXZWJJbnNwZWN0b3IuX3Jlc2V0 Wm9vbSA9IGZ1bmN0aW9uKGV2ZW50KSB7CisgICAgSW5zcGVjdG9yRnJvbnRlbmRIb3N0LnNldFpv b21GYWN0b3IoMSk7CisgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKK307CisKIFdlYkluc3Bl Y3Rvci5lbGVtZW50RHJhZ1N0YXJ0ID0gZnVuY3Rpb24oZWxlbWVudCwgZGl2aWRlckRyYWcsIGVs ZW1lbnREcmFnRW5kLCBldmVudCwgY3Vyc29yLCBldmVudFRhcmdldCkKIHsKICAgICBpZiAoV2Vi SW5zcGVjdG9yLl9lbGVtZW50RHJhZ2dpbmdFdmVudExpc3RlbmVyIHx8IFdlYkluc3BlY3Rvci5f ZWxlbWVudEVuZERyYWdnaW5nRXZlbnRMaXN0ZW5lcikK